Commit Graph

18959 Commits

Author SHA1 Message Date
Andy Wickham
96adbcb2a8 Merge "Remove unused AssistStateManager methods." into main 2024-05-07 01:43:46 +00:00
Andy Wickham
17526db32a Merge "Implement animateNavBarLongPress for stashed taskbar." into main 2024-05-06 23:12:32 +00:00
Tracy Zhou
b297d4fb83 Update SUW swipe home logic for taskbar stashing
- Reverted the previous change. It doesn't fix the issue when launching setup mode with command line. The fact that it looked as if it's fixed from factory reset might be a fluke
- Found out that we unstash the task bar to home from setup somewhere in TaskbarStashController. This is related to stashed alpha only.

Fixes: 337738795
Test: Finish setup, swipe home in folded, and observe home handle is visible.
Change-Id: I04daf41ae9a1c3b7e6e4962dd4a8c62b708e0a54
2024-05-06 13:05:41 -07:00
Tracy Zhou
74ed411d07 Merge "Fix 3-button showing up briefly on the AllSet page in setup" into main 2024-05-06 19:06:07 +00:00
Liran Binyamin
b4b5e79ffe Merge "Interrupt bubble animation on stash change" into main 2024-05-06 16:06:55 +00:00
Liran Binyamin
209c764175 Interrupt bubble animation on stash change
This change handles cancelling the currently running bubble animation when the stash state is changing.

Demo - http://recall/-/bJtug1HhvXkkeA4MQvIaiP/4jnBgnFaIPez6m7fVLSlf

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605846
Test: atest BubbleBarViewAnimatorTest
Change-Id: I34628f8ad741228dd21285ad66e45ef2909fbdab
2024-05-06 09:55:34 -04:00
Tracy Zhou
cb8eb189f1 Fix 3-button showing up briefly on the AllSet page in setup
Fixes: 338883705
Test: Go through setup. Make sure the 3-button doesn't show up anytime during setup
Change-Id: Idd62486465d608235abe61b994718311c72cb20c
2024-05-05 21:39:54 -07:00
Andy Wickham
3a7a76f88e Implement animateNavBarLongPress for stashed taskbar.
I think ideally we would tie this into the taskbar's outline
provider, but it seemed more complicated to deal with existing
stashing animations.

Instead I've just animated the stashed taskbar scale to 0.85 or
1.18, depending on the SHRINK_NAV_HANDLE_ON_PRESS flag. These
are based on the existing navbar shrink/expand animations.

Demo (the flickering doesn't happen on-device):
https://drive.google.com/file/d/1CWCPRsuD3kjtOUbwXspkQ_ZJ6Ln7FnUo/view?usp=sharing&resourcekey=0-kJjfgnuEca1de4u8mbHrig

Bug: 308693847
Test: Manual
Flag: LEGACY SHRINK_NAV_HANDLE_ON_PRESS DISABLED
Flag: LEGACY ANIMATE_LPNH DISABLED
Change-Id: I6ecbc849ac1c066a4c018325f0237a61641d99aa
2024-05-03 17:53:34 -07:00
Federico Baron
aed966daae Merge "Add screenrecord and demote TaplTestsTrackpad#switchToOverview" into main 2024-05-03 23:54:32 +00:00
Bill Yi
60829aa8a2 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-05-03 23:19:17 +00:00
fbaron
afe67917d1 Add screenrecord and demote TaplTestsTrackpad#switchToOverview
Flag: NONE
Test: TaplTestsTrackpad#switchToOverview
Bug: 336606166
Change-Id: Id0e55f20db2a3cfcdb3e16909f76f3b902b5eeaf
2024-05-03 13:51:39 -07:00
Treehugger Robot
7cc2ab636f Merge "Determine split leash position by taskId instead of bounds" into main 2024-05-03 19:56:54 +00:00
Ats Jenk
b67d07912c Merge "Drag bubble in bubble bar to other side" into main 2024-05-03 16:41:55 +00:00
Bill Yi
1d754e69ad Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I85e4106f6ac809bffdab9d91ef8700211d940c28
2024-05-03 01:48:12 -07:00
Vinit Nayak
070c3661d5 Determine split leash position by taskId instead of bounds
* Previously we were comparing bounds of the leash to determine
which leash was leftTop vs bottomRight
* That didn't work when we were translating the split apps when
IME is showing in portrait split screen
* Transitions between IME showing to recents animation could
probably use some work, but that itself is not a regression.

Bug: 330714602
Test: Tested on large and small screen with IME up on both apps
No more empty hole

Change-Id: Ie08ac644e5d1bcc48ba57e05e25bbee66afa3d37
2024-05-02 15:45:23 -07:00
Tracy Zhou
c9b5b0a3dd Merge "Add ime back button logic to the init block of NavbarButtonsViewController" into main 2024-05-02 21:16:54 +00:00
Fengjiang Li
c2ef74306b Merge "[Launcher Jank] Pass single threaded Executor to RotationButtonController so that binder calls are ordered." into main 2024-05-02 20:08:50 +00:00
Treehugger Robot
a3009176a9 Merge "Give bubble team owners on the correct launcher bubble dirs" into main 2024-05-02 19:47:20 +00:00
Liran Binyamin
841411d122 Give bubble team owners on the correct launcher bubble dirs
Whoops.

Flag: N/A
Test: treehugger
Bug: none
Change-Id: I25df1a161d94bd1acac976bc61217a59b3657074
2024-05-02 15:33:16 -04:00
Treehugger Robot
f7ed35fc87 Merge "Locking the All Apps view before asserting PS components." into main 2024-05-02 19:02:42 +00:00
Treehugger Robot
03cd176277 Merge "Add support for animating non-running tasks" into main 2024-05-02 18:24:56 +00:00
Sunny Goyal
93221e00a5 Merge "Converting ModelTask to an interface instead of an abstract class" into main 2024-05-02 17:41:09 +00:00
Tony Wickham
ee77e8483a Merge "Remove obsolete binder calls to TaskTransitionSpec" into main 2024-05-02 15:28:04 +00:00
Tracy Zhou
4b43cfbc04 Add ime back button logic to the init block of NavbarButtonsViewController
Fixes: 338320015
Test: Run adb shell am start -a android.intent.action.MAIN -n com.google.android.setupwizard/.SetupWizardTestActivity. Make sure the back key shows by default but hides when IME renders back arrow.
Change-Id: I8baeb10d3f5b13c3bac084872d77d881c1513733
2024-05-01 23:18:29 -07:00
Jagrut Desai
0fd34b783c Merge "Taskbar in Desktop Windowing Mode" into main 2024-05-01 22:49:48 +00:00
Sunny Goyal
993893895c Converting ModelTask to an interface instead of an abstract class
This allows extensibility and better use of lambdas

Bug: 338282246
Test: Presubmit
Flag: None

Change-Id: Ia41067f0068b3b631eeb4faf877dc77f8587e1f6
2024-05-01 15:43:26 -07:00
Helen Cheuk
e07207678b Merge "Fix performance issue caused by triggering hover focus animation accidentally" into main 2024-05-01 21:56:26 +00:00
Ats Jenk
363a841a04 Drag bubble in bubble bar to other side
Adds support to pin bubble bar to other side of the screen by dragging
from one bubble. The entire bubble bar will move to the other side.
Implements the BaseBubbleBarPinController to handle dragging an
individual BubbleView.
Updates how translation and alpha get applied during BubbleBarView
location animation when a bubble is being dragged.
Dragged bubble is part of the BubbleBarView and when it is being
dragged, and we animate the bubble bar to the other side, we need to
ensure that the animation does not affect the dragged bubble.
Updating the translation and alpha for the BubbleBarView ViewGroup will
affect the dragged bubble as well. Updating how translation and alpha
gets applied to BubbleBarView so that it gets applied to individual
child views and then we can skip applying it to the dragged view.

Bug: 330585402
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: drag bubble from expanded bubble bar to left and right

Change-Id: I1fe2ba9fd466ff97d3b3af763bdcce30c3f98606
2024-05-01 14:53:14 -07:00
Schneider Victor-tulias
65ae550a92 Add support for animating non-running tasks
It is possible to animate a non-running task to home mid-quick switch, which was not properly supported, causing a janky animation. Added custom animations to handle this more smoothly.

Flag:  ACONFIG com.android.launcher3.enable_additional_home_animations DISABLED
Fixes: 237638627
Test: swipe to home mid-quick switch on handheld/large screen in portrait/landscape from an app present/missing on the workscape in RTL/LTR
Change-Id: I89c9cf1ed1c0b88ff6c3ce71a663cb16e69d5843
2024-05-01 20:06:34 +00:00
Holly Jiuyu Sun
2692954360 Merge "[omni] Let parent to allow intercept when it's in the 2nd stage." into main 2024-05-01 18:48:52 +00:00
Vinit Nayak
4cb712b8d6 Merge "Allow single root candidate for app pair launch for pip edge case" into main 2024-05-01 18:43:59 +00:00
Himanshu Gupta
3a0f024044 Locking the All Apps view before asserting PS components.
Bug: 334946529
Test: NA
Flag: NA
Change-Id: Id8895a993f61ee22fcef1ba562aaa8baf156d6d7
2024-05-01 18:52:32 +01:00
Holly Sun
1d90321484 [omni] Let parent to allow intercept when it's in the 2nd stage.
Discussed with Andy for ideas - instead of passing the outer touch slop out, it might be easier to let parent to allow intercept when it's in the 2nd stage (e.g., OverviewInputConsumer doesn't have touch slop handling logic). So we can go through this if: https://source.corp.google.com/h/googleplex-android/platform/superproject/main/+/main:packages/apps/Launcher3/quickstep/src/com/android/quickstep/inputconsumers/NavHandleLongPressInputConsumer.java;l=105;drc=deee0d06f624223b808593997cf22042c9aa5142
`mDelegate` can be `OverviewInputConsumer` or `OtherActivityInputConsumer` or `TaskbarUnstashInputConsumer`.

Bug: 330446193
Flag: legacy ENABLE_LPNH_TWO_STAGES disabled
Test: manual
Change-Id: I1f33172f1614a750a01632c8c945ee5e5cbd7adc
2024-05-01 10:02:40 -07:00
Jagrut Desai
2e8ca87c21 Taskbar in Desktop Windowing Mode
Test: presubmit
Bug: 330146462
Flag: NONE
Change-Id: Ib33f90704c3010df6a52e2a1c420960b11dbd0d4
2024-05-01 09:29:24 -07:00
helencheuk
ef31d0a35e Fix performance issue caused by triggering hover focus animation accidentally
HoverAnimator and FocusAnimator are triggered unexpectedly on state transition. When it is already disabled, it is disabled again when user swipes to All Apps and triggers animators. Add checking to not trigger animator when the new enable status is the same as the current one.

Bug: 333688227
Test: Ran v2/android-crystalball-eng/health/microbench/systemui/main/systemui-misc-1-jank-suite in ab/
Flag: N/A
Change-Id: I090490f1c78a3427225c24bc536e1767700ec6c3
2024-05-01 17:15:12 +01:00
Tony Wickham
a179a77e09 Remove obsolete binder calls to TaskTransitionSpec
Fixes: 334312256
Flag: none
Test: manual (no visual regression)
Change-Id: Ie20dc8d4bb0c85a8a256b001fbb92405679618a8
2024-05-01 15:15:18 +00:00
Alex Chau
e14ee6f914 Merge "Improve taskId logging for Overview" into main 2024-05-01 13:49:18 +00:00
Alex Chau
2daa3eba99 Merge "Refactor TaskView.getTaskIds and its attribute container to support any number of tasks" into main 2024-05-01 13:49:02 +00:00
Gustav Sennton
19f8002e30 Merge "Pass OverviewComponentObserver as a parameter." into main 2024-05-01 07:06:40 +00:00
Tracy Zhou
d0d94922fe Merge "Do not hide nav bar on the homescreen from setup" into main 2024-05-01 00:08:35 +00:00
Fengjiang Li
08af8696ff [Launcher Jank] Pass single threaded Executor to RotationButtonController so that binder calls are ordered.
Bug: 338036218
Test: presubmit
Flag: NONE
Change-Id: Ic398bf4be53c6b2cc5f4fa11aea5c3b451d5ddf8
2024-04-30 22:41:01 +00:00
Ats Jenk
af0ba3e8cf Merge "Implement API to animate bubble bar position" into main 2024-04-30 22:20:05 +00:00
Tracy Zhou
ee67a48d60 Do not hide nav bar on the homescreen from setup
FLAG_STASHED_SMALL_SCREEN is not updated after setup UI finishes.

Fixes: 337738795
Test: Finish setup, swipe home in folded, and observe home handle is visible.
Change-Id: I297e3b44f49f94ab5a1b9fe5ff16ff64c6cf2c0a
2024-04-30 15:01:38 -07:00
Ats Jenk
d7fe32ab8e Implement API to animate bubble bar position
Create a new API to animate bubble bar position.
Animating it will not update its laid out location.
To update bubble bar laid out location, BubbleBarUpdate can be used.
Applying a location change from BubbleBarUpdate no longer animates the
change.

Bug: 330585402
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: long press bubble bar and drag it to left and right
Change-Id: I2572da4c063fc8e07cf07c4303778d343baa4ec4
2024-04-30 13:12:56 -07:00
Treehugger Robot
7f26505f04 Merge "Re-fetch DesktopVisibilityController when needed instead of just once" into main 2024-04-30 17:50:17 +00:00
Alex Chau
0a81d07234 Improve taskId logging for Overview
Fix: 338034523
Test: manual
Flag: NONE
Change-Id: I0ba84047a83bd9bdbd891bddf86f6cbe36bca572
2024-04-30 17:22:43 +01:00
Gustav Sennton
f74d8b7264 Re-fetch DesktopVisibilityController when needed instead of just once
When creating DesktopTaskbarRunningAppsController the Quickstep Launcher
might not be available, meaning we pass a null
DesktopVisibilityController to DesktopTaskbarRunningAppsController.
With this CL we refetch DesktopVisibilityController whenever needed.

Bug: 338035946
Test: manual, and DesktopTaskbarRunningAppsControllerTest
Flag: ACONFIG com.android.window.flags.Flags.enableDesktopWindowingTaskbarRunningApps DEVELOPMENT
Change-Id: I8b806e2d0addbf8fb5ab6a3d419a4691c445f223
2024-04-30 16:07:13 +00:00
Treehugger Robot
5a8e719b4c Merge "Remove references to FEATURE_PC and related Desktop classes in Launcher" into main 2024-04-30 15:33:30 +00:00
Liran Binyamin
85c50adb91 Merge "Animate the bubble bar to show new bubble" into main 2024-04-30 14:01:09 +00:00
Gustav Sennton
0eaf9ebdaa Remove references to FEATURE_PC and related Desktop classes in Launcher
Also clean up TaskbarRecentAppsController APIs

Flag: NA
Test: DesktopTaskbarRunningAppsControllerTest
Bug: 330551930
Change-Id: Ibd9c3d6aa1d5423b51a48ed0a972196752d5199a
2024-04-30 13:15:28 +00:00