Since developers have been relying on detecting leaks from studio build
and this exception can cause rest of on destroy to not run, to avoid
false positives, we could just rely on Log.e instead.
See bug for more details.
Bug: 400793700
Flag: EXEMPT BUGFIX
Test: Leak canary and studio heap dump
Change-Id: Ieea35ecfcc4b0f048b47c204809bbbf39e367b06
* changes:
[Part 3] Clean up references for flags from past release.
[Part 2] Clean up references for flags from past release.
[Part 1] Clean up references to flags from past release.
- Fix some mockito issue by using a fake implementation rather
than a mock.
- Return early in the bubble bar animation if there's no animating
bubble. The issue here is that the scaleY property of the bubble
bar is set to 1 when the animation is interrupted. However, in
the test environment, the cancellation of the animator is posted
to a different thread, and another animation frame is running
after the scaleY was already reset to 1.
Flag: EXEMPT test only
Test: atest BubbleBarViewAnimatorTest
Bug: 399934422
Bug: 399720438
Change-Id: I271f670c50168237aeaf867c8171ae3023ee09ff
Adjust the max height calculation logic in on measure to use a different translationY for the bottom row menus. The bottom row menu animates translating up to show more items. Thus, we use the min translationY accepted for the menu to calculate its max height size.
Fix: 326952853
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewMenuImageTest
Change-Id: I0b32c16e020033feccbfeef8f96c196d193ac0cb
Changed the gravity of the task menu layout parameters from `START` to `LEFT` because `sTempRect.left` measures left distance, not start distance. This ensures correct positioning, particularly in Right-to-Left (RTL) layouts where `START` may align to the left instead of right, according to search result.
Fix: 400867857
Flag: EXEMPT BUG_FIX
Test: Manual. Using RTL and app chip, expands the app chip menu.
Change-Id: Ia3165563c2f87cf7f2d17eee554386d96f30860b
exploded animation
Following CLs will support launching individual task window in the
desktop task view.
Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug: 353948437
Change-Id: I5d084a7d8b231522bf5db1704cee1d6124affc22
Hide screenshot and select from menu if thumbnail is null
Bug: 383662632
Flag: com.android.launcher3.enable_show_enabled_shortcuts_in_accessibility_menu
Test: OverviewMenuImageTest & manual. See bug.
Change-Id: Idf41de7e36b63f7bcc8639f5f3932a61e56ebfcd
This includes:
1) updating the color token used in dark mode,
2) adjusting sizes of individual app icons and their strokes.
See screenshots in http://b/383556682#comment7.
Bug: 383556682, 380386440
Flag: com.android.launcher3.taskbar_overflow
Test: manual
Change-Id: Ia05d803c5602552ce4f3e4675411b281107ac843
Adjusts the positioning logic for the task menu when displayed for tasks on the bottom row of the grid. The changes ensure the menu is visible and does not overlap with other UI elements, such as the taskbar. It defines min and max bounds of the menu when it's opened on bottom row. It also moves the menu on top of the taskbar.
A follow-up CL will manage the max height to make the bottom row menu scrollable.
Fix: 322953749
Bug: 326952853
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewMenuImageTest
Change-Id: I44fb70d8537c0b52af4314e818d02ccfcd35d8d3
Noticed that predictor holds the registered callback and caused leak.
Using named listener classes for better stacks and also unregisters them
Bug: N/A
Flag: EXEMPT BUGFIX
Test: WidgetPredictionsRequesterTest
Change-Id: I94211ddbc77077c98b804827bb1cecdefe57703b
The button is shown when "hidden" non-desktop mode apps are open, and
KQS gets shown in desktop mode. Per UX, the button should be removed
when KQS is shown from taskbar, as taskbar overflow bubble.
Bug: 399860396
Test: Open apps in fullscreen, switch to desktop mode, open enough apps
for taskbar to enter overflow, tap taskbar overflow icon, verify
that the overflow bubble does not show "X more apps" button.
Separately, press Alt+Tab, and verify the button gets shown.
Flag: com.android.launcher3.taskbar_overflow
Change-Id: Ic4050b1b29fe22a1e0d2be661acfca18561b4ed1
The problem: with taskbar animation for Desktop mode we were checking, if we are already in DW then don't recreate taskbar. This was put in as condition so where DisplayController Info change we don't recreate twice. first being from transilition listerners and second being form info change in display controller.
The solution: Ignore the info change listener when there is already ongoing recreation is in progress.
Test: Presubmit
Bug: 399826787
Flag: EXEMPT bugfix
Change-Id: Ib86e79b3b4c86e515e44d1d1dd7ca98ed694c365
This model will be used to drive Growth Framework nudge rendering and
behavior in follow up CL.
More details at: go/al-growth-framework-nudge
Test: Manual
Bug: 398026145
Flag: EXEMPT add separately
Change-Id: Icfd53f2587fe7b184f21f7e180c795bd6f586040
This change wires bubble bar dragging as well as bubble dragging to
full screen behind a flag. Note that when the bubble is dragged to
full screen we remove the bubble from the bubble bar and notify
sysui but on the sysui side the bubble doesn't yet get converted.
Flag: com.android.wm.shell.enable_bubble_to_fullscreen
Bug: 388858013
Test: manual
- with flag off
- verify existing dragging works
- with flag on
- verify bubble bar can be dragged across
- verify bubble is removed when bubble dragged to full screen zone
Change-Id: I9e4d8ee3d2ba9dffff3dd4ba91dfce1a5c723d68
Add freeform check and update logs
Return early instead of crashing if a launch change is not available
Bug: 395495925
Flag: NONE only adding logs, not change of actual code
Test: DesktopAppLaunchAnimatorHelperTest
Change-Id: I0d51c563a26e7d6020222cb84757e0ea8d561d69