Commit Graph

13868 Commits

Author SHA1 Message Date
Shamali P
8f126e8e66 Change the studio build specific onEndCallback exception to a log.e
Since developers have been relying on detecting leaks from studio build
and this exception can cause rest of on destroy to not run, to avoid
false positives, we could just rely on Log.e instead.

See bug for more details.

Bug: 400793700
Flag: EXEMPT BUGFIX
Test: Leak canary and studio heap dump
Change-Id: Ieea35ecfcc4b0f048b47c204809bbbf39e367b06
2025-03-12 23:00:40 +00:00
Shamali Patwa
af883adedc Merge changes from topic "flags-cleanup" into main
* changes:
  [Part 3] Clean up references for flags from past release.
  [Part 2] Clean up references for flags from past release.
  [Part 1] Clean up references to flags from past release.
2025-03-10 10:54:42 -07:00
Sebastián Franco
0d8df93275 Merge "Sync landscape rotation with Overview rotation" into main 2025-03-10 09:30:11 -07:00
Alex Chau
2642bfb210 Merge "Check before casting to TaskMenuView on rotation" into main 2025-03-10 06:57:59 -07:00
Uwais Ashraf
6b44fe4432 Merge "Move overlay setup functionality to TaskView/Container" into main 2025-03-08 15:55:41 -08:00
Uwais Ashraf
33c6559d41 Move overlay setup functionality to TaskView/Container
Bug: 395294954
Bug: 396064850
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Perfetto trace comparison
Test: OverviewDesktopTaskImageTest
Change-Id: I69ac43350b261532a47f7989848a650ae8a70e9a
2025-03-08 13:49:23 +00:00
Treehugger Robot
6721777d9d Merge "Fix task menu height calculation for bottom row handling." into main 2025-03-08 05:13:19 -08:00
Liran Binyamin
a5c9d86e1d Merge "Address flakes in BubbleBarViewAnimatorTest" into main 2025-03-07 18:17:59 -08:00
Treehugger Robot
9a993d2b9d Merge "pin-shortcut: Implements the actual pinning functionality" into main 2025-03-07 18:09:10 -08:00
Artsiom Mitrokhin
b673fbf897 Merge "Update taskbar overflow view to match the spec" into main 2025-03-07 18:06:50 -08:00
Brian Isganitis
0dc5fac084 Merge "Animate changes in Taskbar recents indicators." into main 2025-03-07 14:47:08 -08:00
Liran Binyamin
c2edd1c79a Address flakes in BubbleBarViewAnimatorTest
- Fix some mockito issue by using a fake implementation rather
   than a mock.
 - Return early in the bubble bar animation if there's no animating
   bubble. The issue here is that the scaleY property of the bubble
   bar is set to 1 when the animation is interrupted. However, in
   the test environment, the cancellation of the animator is posted
   to a different thread, and another animation frame is running
   after the scaleY was already reset to 1.

Flag: EXEMPT test only
Test: atest BubbleBarViewAnimatorTest
Bug: 399934422
Bug: 399720438
Change-Id: I271f670c50168237aeaf867c8171ae3023ee09ff
2025-03-07 14:13:31 -08:00
Jordan Silva
aacd9295fd Fix task menu height calculation for bottom row handling.
Adjust the max height calculation logic in on measure to use a different translationY for the bottom row menus. The bottom row menu animates translating up to show more items. Thus, we use the min translationY accepted for the menu to calculate its max height size.

Fix: 326952853
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewMenuImageTest
Change-Id: I0b32c16e020033feccbfeef8f96c196d193ac0cb
2025-03-07 14:06:57 -08:00
Brian Isganitis
26f9468db1 Animate changes in Taskbar recents indicators.
Flag: com.android.window.flags.enable_taskbar_recents_layout_transition
Fix: 356394053
Test: go/testedequals
Change-Id: Ic018695254bbfea11469c3579e242089b00b90f5
2025-03-07 15:47:48 -05:00
Treehugger Robot
522a869e01 Merge "Show screenshot and select in task menu" into main 2025-03-07 12:28:33 -08:00
Treehugger Robot
8800f6d068 Merge "Fix RTL menu position for icon app chip." into main 2025-03-07 11:52:17 -08:00
Sebastian Franco
0e0fffd81c Sync landscape rotation with Overview rotation
Bug: 390487996
Test: NA
Flag: com.android.launcher3.one_grid_specs
Change-Id: Ib564c21befd06edd5c720fe33f36780761035fee
2025-03-07 11:48:43 -08:00
Treehugger Robot
b6001773da Merge "desktop-exploded-view: Launch desktop task view should reverse its exploded animation" into main 2025-03-07 11:45:18 -08:00
Treehugger Robot
9cc284aa17 Merge "Don't show more apps button in KQS opened from taskbar" into main 2025-03-07 10:39:05 -08:00
Jordan Silva
cccec098e8 Merge "Fix split screen app chip position in portrait mode" into main 2025-03-07 09:50:52 -08:00
Jordan Silva
59e6fd541a Fix RTL menu position for icon app chip.
Changed the gravity of the task menu layout parameters from `START` to `LEFT` because `sTempRect.left` measures left distance, not start distance. This ensures correct positioning, particularly in Right-to-Left (RTL) layouts where `START` may align to the left instead of right, according to search result.

Fix: 400867857
Flag: EXEMPT BUG_FIX
Test: Manual. Using RTL and app chip, expands the app chip menu.
Change-Id: Ia3165563c2f87cf7f2d17eee554386d96f30860b
2025-03-07 09:45:40 -08:00
Xiaoqian Dai
3dfd8bb2b5 desktop-exploded-view: Launch desktop task view should reverse its
exploded animation

Following CLs will support launching individual task window in the
desktop task view.

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug: 353948437
Change-Id: I5d084a7d8b231522bf5db1704cee1d6124affc22
2025-03-07 17:40:14 +00:00
Alex Chau
df7bb7966c Check before casting to TaskMenuView on rotation
- Added a instanceof check to avoid ClassCastException

Fix: 400957867
Flag: EXEMPT BUG_FIX
Test: manual testing rotation on phone and tablet
Change-Id: I2b094fdca4f380128b50d5086548cbac3ef09bf4
2025-03-07 16:55:06 +00:00
samcackett
0946c8c123 Show screenshot and select in task menu
Hide screenshot and select from menu if thumbnail is null

Bug: 383662632
Flag: com.android.launcher3.enable_show_enabled_shortcuts_in_accessibility_menu
Test: OverviewMenuImageTest & manual. See bug.
Change-Id: Idf41de7e36b63f7bcc8639f5f3932a61e56ebfcd
2025-03-07 08:41:41 -08:00
Liran Binyamin
fd1cb45975 Merge "Handle bubble bar drag and bubble drag to fullscreen" into main 2025-03-07 08:11:24 -08:00
Artsiom Mitrokhin
dcf37ce078 Update taskbar overflow view to match the spec
This includes:
1) updating the color token used in dark mode,
2) adjusting sizes of individual app icons and their strokes.

See screenshots in http://b/383556682#comment7.

Bug: 383556682, 380386440
Flag: com.android.launcher3.taskbar_overflow
Test: manual
Change-Id: Ia05d803c5602552ce4f3e4675411b281107ac843
2025-03-07 10:38:37 -05:00
Jordan Silva
75395e3425 Merge "Fix TaskMenuView bottom row divider and translation." into main 2025-03-07 06:12:57 -08:00
Jordan Silva
97b3389cd7 Fix split screen app chip position in portrait mode
Adjusted the secondary app chip's split translation in portrait mode to account for the divider size, ensuring correct positioning in split screen.

Fix: 314326993
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Change-Id: I39eae8b5f1ac8cff6b466cff5b6fb16f0a6e9647
2025-03-07 11:40:12 +00:00
Jordan Silva
65aff4c6bb Fix TaskMenuView bottom row divider and translation.
Adjusts the positioning logic for the task menu when displayed for tasks on the bottom row of the grid. The changes ensure the menu is visible and does not overlap with other UI elements, such as the taskbar. It defines min and max bounds of the menu when it's opened on bottom row. It also moves the menu on top of the taskbar.

A follow-up CL will manage the max height to make the bottom row menu scrollable.

Fix: 322953749
Bug: 326952853
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewMenuImageTest
Change-Id: I44fb70d8537c0b52af4314e818d02ccfcd35d8d3
2025-03-07 11:31:20 +00:00
Jordan Silva
fd066b2d7a Merge "Add app chip flag to prevent skipping settledProgress and fullscreenProgress for the current IconView." into main 2025-03-07 02:04:12 -08:00
Treehugger Robot
80ffe676d1 Merge "[CD Taskbar] Remove External Taskbar's Rounded Corners" into main 2025-03-06 17:58:42 -08:00
Li Lin
6be6102a44 Merge "Add Growth Framework nudge payload model." into main 2025-03-06 17:03:21 -08:00
Shamali P
992facdff3 Unregister widget prediction callback on clear
Noticed that predictor holds the registered callback and caused leak.
Using named listener classes for better stacks and also unregisters them

Bug: N/A
Flag: EXEMPT BUGFIX
Test: WidgetPredictionsRequesterTest
Change-Id: I94211ddbc77077c98b804827bb1cecdefe57703b
2025-03-06 14:25:13 -08:00
Jagrut Desai
d5e5fca0dc Merge "Fix Taskbar not present in Desktop Mode after unlocking" into main 2025-03-06 13:18:33 -08:00
Jordan Silva
02a0119032 Add app chip flag to prevent skipping settledProgress and fullscreenProgress for the current IconView.
Bug: 398318613 
Flag: com.android.launcher3.enable_overview_icon_menu
Test: Manual
Test: systemui-thermal-throttling-3-suite
Change-Id: I96d8889752287510e760d4367b2ef981689e106d
2025-03-06 12:31:54 -08:00
Toni Barzic
200c5ee980 Don't show more apps button in KQS opened from taskbar
The button is shown when "hidden" non-desktop mode apps are open, and
KQS gets shown in desktop mode. Per UX, the button should be removed
when KQS is shown from taskbar, as taskbar overflow bubble.

Bug: 399860396
Test: Open apps in fullscreen, switch to desktop mode, open enough apps
     for taskbar to enter overflow, tap taskbar overflow icon, verify
     that the overflow bubble does not show "X more apps" button.
     Separately, press Alt+Tab, and verify the button gets shown.
Flag: com.android.launcher3.taskbar_overflow
Change-Id: Ic4050b1b29fe22a1e0d2be661acfca18561b4ed1
2025-03-06 17:16:10 +00:00
Will Osborn
787dcec135 DeviceProfile refactoring for connected displays
Test: locally tested on Tangor
Flag: com.android.launcher3.enable_overview_on_connected_displays
Bug: 392858637
Change-Id: I0f45710eb60c7ea3359153c7961461532fec8e97
2025-03-06 14:33:00 +00:00
Treehugger Robot
872ef49247 Merge "Add TaskContentView parent to TaskThumbnailViewHeader and TTV" into main 2025-03-06 03:37:25 -08:00
Alex Chau
d81a7835ac Merge "Update live tile's pivot when ReccentsView's pivot is updated" into main 2025-03-06 03:29:39 -08:00
Sergey Pinkevich
f3ea2ed42c Merge "Change launch change requirement within DesktopAppLaunchAnimatorHelper" into main 2025-03-05 23:55:30 -08:00
Jagrut Desai
bf0727b60d Fix Taskbar not present in Desktop Mode after unlocking
The problem: with taskbar animation for Desktop mode we were checking, if we are already in DW then don't recreate taskbar. This was put in as condition so where DisplayController Info change we don't recreate twice. first being from transilition listerners and second being form info change in display controller.

The solution: Ignore the info change listener when there is already ongoing recreation is in progress.

Test: Presubmit
Bug: 399826787
Flag: EXEMPT bugfix

Change-Id: Ib86e79b3b4c86e515e44d1d1dd7ca98ed694c365
2025-03-05 18:58:38 -08:00
Sukesh Ram
850179005f [CD Taskbar] Remove External Taskbar's Rounded Corners
Remove Taskbar's Rounded Corners for External Display.

Flag: com.android.window.flags.enable_taskbar_connected_displays
Bug: 400799093
Test: Manual
Change-Id: I6808850647cd4136aae23de13fa54ecaba3c1025
2025-03-05 15:14:56 -08:00
Li Lin
ebb8fe35bb Add Growth Framework nudge payload model.
This model will be used to drive Growth Framework nudge rendering and
behavior in follow up CL.

More details at: go/al-growth-framework-nudge

Test: Manual
Bug: 398026145
Flag: EXEMPT add separately
Change-Id: Icfd53f2587fe7b184f21f7e180c795bd6f586040
2025-03-05 15:14:54 -08:00
Treehugger Robot
7a7a92999c Merge "Making ActivityContext extend SavedStateRegistryOwner" into main 2025-03-05 11:44:19 -08:00
Liran Binyamin
6b18e3811d Handle bubble bar drag and bubble drag to fullscreen
This change wires bubble bar dragging as well as bubble dragging to
full screen behind a flag. Note that when the bubble is dragged to
full screen we remove the bubble from the bubble bar and notify
sysui but on the sysui side the bubble doesn't yet get converted.

Flag: com.android.wm.shell.enable_bubble_to_fullscreen
Bug: 388858013
Test: manual
       - with flag off
         - verify existing dragging works
       - with flag on
         - verify bubble bar can be dragged across
         - verify bubble is removed when bubble dragged to full screen zone
Change-Id: I9e4d8ee3d2ba9dffff3dd4ba91dfce1a5c723d68
2025-03-05 10:04:58 -08:00
Mykola Podolian
e5c9aadf2c Merge "Added logic to show the shell drop target and update the bubble location" into main 2025-03-05 09:24:38 -08:00
Sunny Goyal
84e0e6a188 Making ActivityContext extend SavedStateRegistryOwner
Bug: 390572144
Test: Presubmit
Flag: EXEMPT refactor

Change-Id: I8272e95a8d2da95b3c93ec616fdf877b89db5b26
2025-03-05 09:22:47 -08:00
Sergey Pinkevich
fe17dd475b Change launch change requirement within DesktopAppLaunchAnimatorHelper
Add freeform check and update logs

Return early instead of crashing if a launch change is not available

Bug: 395495925
Flag: NONE only adding logs, not change of actual code
Test: DesktopAppLaunchAnimatorHelperTest

Change-Id: I0d51c563a26e7d6020222cb84757e0ea8d561d69
2025-03-05 16:23:18 +00:00
Will Osborn
19bdf47a31 Merge "Make separate dependency scopes and graphs for different RecentsViews" into main 2025-03-05 07:29:04 -08:00
Treehugger Robot
806a9f1368 Merge "Use the safe getDisplayId() API when building the recents desktop task list." into main 2025-03-05 05:30:51 -08:00