Commit Graph

17066 Commits

Author SHA1 Message Date
Federico Baron
099f7f936e Merge "Ensure PauseUIUpdate always ends up getting set to false" into udc-qpr-dev am: 15b81093d7 am: f3a2082285
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24749997

Change-Id: I8183be8017e43d588b5baed2b80bed70aca7a728
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-14 16:53:40 +00:00
Becky Qiu
543dbad157 Merge "Print out debug logging in bug report if not running test." into udc-qpr-dev am: d1d73e05ce am: 09b354b232
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24737823

Change-Id: Icd77d37a3e009bb54044fcd501bc7ea5fc659e0a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-14 16:52:54 +00:00
Tracy Zhou
bcbb5745b8 Merge "Fix wrong insets in phone mode with FLAG_HIDE_NAVBAR_WINDOW on" into main 2023-09-14 16:51:26 +00:00
Federico Baron
f3a2082285 Merge "Ensure PauseUIUpdate always ends up getting set to false" into udc-qpr-dev am: 15b81093d7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24749997

Change-Id: I06df48dda4c77024b9b35127a8eeda9b42080607
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-14 16:51:15 +00:00
Federico Baron
15b81093d7 Merge "Ensure PauseUIUpdate always ends up getting set to false" into udc-qpr-dev 2023-09-14 16:26:34 +00:00
Jagrut Desai
a144105c12 Merge "Fix TaplTestsNexus#testSearchForApp" into main 2023-09-14 16:08:35 +00:00
Becky Qiu
09b354b232 Merge "Print out debug logging in bug report if not running test." into udc-qpr-dev am: d1d73e05ce
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24737823

Change-Id: I628cb28daa134c58b10a8db6f84f4004ed1ddbf4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-14 16:00:42 +00:00
Wei Sheng Shih
64116af237 Merge "Transfer the animation bounds to another coordinate if needed." into main 2023-09-14 10:02:28 +00:00
wilsonshih
3228322d49 Transfer the animation bounds to another coordinate if needed.
For a remote close animation target, because the orientation can be
different from launcher, so when launcher applying surface animation
to it, there should do another coordinate transfer based on it's
coordinate.
Also for closing animation, there shouldn't use #getWindowTargetBounds
because it only search for opening target.
There is no change when launcher's orientation matches animation target.

Bug: 254805643
Bug: 298318284
Test: close activity in each oritation, verify the position of remote
animaiton target is aligned with the floating view.

Change-Id: I7799357695a467f1bfc653e4f058a5e646ea2405
2023-09-14 02:41:21 +00:00
Bill Yi
b87805f3c7 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2023-09-14 02:08:56 +00:00
Becky Qiu
28498d5f6f Print out debug logging in bug report if not running test.
Bug: 300101221
Test: local
Flag: not needed, logging only.
Change-Id: If016d6fe35a1c43e1a1f311d696b9f2ca0f36f6a
2023-09-13 17:24:51 -07:00
fbaron
a101ac696f Ensure PauseUIUpdate always ends up getting set to false
when result was null but getTaskbarUIController() is not null, we don't setPauseUIUpdate to false. This CL ensure we always end up setting pauseUIUpdate to false so that the hotseat suggested apps show up.

Fix: 295892343
Flag: no flag
Test: verify hotseat icons don't disappear
Change-Id: Id872f3174df276cb7a4ed7f6672523d0851a11dd
2023-09-13 16:56:02 -07:00
Brian Isganitis
4e5202867b Merge "Have backup TouchController of Taskbar All Apps AFV." into main 2023-09-13 22:29:54 +00:00
Alex Chau
2ddd019a4c Merge "Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig" into main 2023-09-13 20:57:51 +00:00
Mady Mellor
d56ec1ad5e Merge "Use the scrim value from bubble constants in launcher" into main 2023-09-13 20:28:27 +00:00
Brian Isganitis
91a4aca5a5 Have backup TouchController of Taskbar All Apps AFV.
BaseDragLayer only lets the top AFV intercpet touch events, otherwise it
moves onto its TouchController instances. Taskbar AllApps still needs to
intercept touch events sometimes when an AFV above it cannot (e.g. a
snackbar). This CL adds a TouchController to TaskbarOverlayDragLayer
that delegates to TaskbarAllAppsSlideInView if it is open.

Test: Manual
Fix: 299165179
Flag: No
Change-Id: I9b73c55f698de5b60b463f91140a6717a7053cd3
2023-09-13 18:47:43 +00:00
Brian Isganitis
793a9d9905 Merge "Focus Taskbar search EditText and show IME on meta key toggle." into main 2023-09-13 18:13:50 +00:00
Jagrut Desai
311d519292 Fix TaplTestsNexus#testSearchForApp
This cl is 1/2 part change

We are currently getting StaleObjectException when running this test.
We want to implment a synchoronized event beetween test and launcher,
so we know that search result adapter is done updating and page will
get no more updates of search results.

Test: Presubmit
Bug: 232008758
Flag: not needed
Change-Id: I40cf9b83d231a2487220aabc8f8e8c3ca71f255c
2023-09-13 11:09:05 -07:00
Alex Chau
e1955fe4b9 Migrate ENABLE_GRID_ONLY_OVERVIEW to aconfig
- Keeping FeatureFlags.ENABLE_GRID_ONLY_OVERVIEW for local testing until aconfig is available in FlagFlipper
- Still reference ENABLE_GRID_ONLY_OVERVIEW in tests as aconfig still can't be mocked

Bug: 270397206
Test: manual
Change-Id: I799e05311adc21184a6ad7ce92a3abdab3f25c25
2023-09-13 15:59:01 +01:00
Bill Yi
91869bb5fc Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: If357cbbd2d233f466c706a21e45e829bffe95633
2023-09-12 21:18:29 -07:00
Mady Mellor
cf50be2c80 Use the scrim value from bubble constants in launcher
Test: manual - enable persistent taskbar (light theme shows it best)
             - expand bubbles
             => observe that the scrim on taskbar matches the rest of
                scrim
Bug: 294396107

Change-Id: I6fc516f3d57a3e8de4d80c079f3543874f289ad7
2023-09-12 16:17:39 -07:00
Winson Chung
b0f5838214 Merge "Revert "Reset the frozen recents list state when switching to bu..."" into main 2023-09-12 22:32:10 +00:00
Brian Isganitis
a46e03ad90 Merge "Stash transient Taskbar on overlay task stack changes." into main 2023-09-12 22:20:24 +00:00
Ats Jenk
d4d114f9cd Merge "Fix flicker when swiping from desktop to home" into main 2023-09-12 20:44:20 +00:00
Brian Isganitis
3c0303b6ac Focus Taskbar search EditText and show IME on meta key toggle.
Test: adb shell input keyevent 117
Fix: 300116542
Flag: ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
Change-Id: Iaf15240f49e978078cd586169be1665e1a86eda5
2023-09-12 20:23:47 +00:00
Tracy Zhou
a53f14d15a Fix wrong insets in phone mode with FLAG_HIDE_NAVBAR_WINDOW on
Can't reuse the same insets object for both providedInsets and paramsForRotation. They can override each other.

Bug: 274517647
Test: turn on FLAG_HIDE_NAVBAR_WINDOW and ENABLE_TASKBAR_NO_RECREATION. Make sure the insets are correct
Change-Id: I8a4ab93e17bf5f4c7949678b087261344cccb1f9
2023-09-12 13:04:13 -07:00
Federico Baron
092064e1d0 Merge "Add smartspace custom widget" into main 2023-09-12 18:43:58 +00:00
Winson Chung
9c51128ebe Revert "Reset the frozen recents list state when switching to bu..."
Revert submission 24683011-extend_recents_freeze_duration

Reason for revert: b/298544839

Reverted changes: /q/submissionid:24683011-extend_recents_freeze_duration

Change-Id: I7e881baf200981bddee39336fc3573dce0dc148f
2023-09-12 17:01:47 +00:00
Tracy Zhou
ca9b884118 Merge "Always recreate TaskbarActivityContext" into main 2023-09-12 02:24:45 +00:00
Jagrut Desai
fb4694d51e Merge "Apply ForciblyShown WindowLayoutParam flags for Transient Taskbar" into udc-qpr-dev am: 733d440ac1 am: a1e8f327ff
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24709295

Change-Id: Id84c65adba08bae631cccfd6792c6a90b6992637
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-11 23:47:46 +00:00
Mady Mellor
3edb22bd09 Merge "Stash taskbar when bubbles is expanded in overview" into main 2023-09-11 23:14:40 +00:00
Jagrut Desai
a1e8f327ff Merge "Apply ForciblyShown WindowLayoutParam flags for Transient Taskbar" into udc-qpr-dev am: 733d440ac1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24709295

Change-Id: I0066e91a986878debb75663fa68d4f5408af8898
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-11 22:57:58 +00:00
Jagrut Desai
733d440ac1 Merge "Apply ForciblyShown WindowLayoutParam flags for Transient Taskbar" into udc-qpr-dev 2023-09-11 21:52:08 +00:00
Ats Jenk
521a7e428c Fix flicker when swiping from desktop to home
When swiping up from desktop, we need to temporarily show launcher views
when user may go to overview. Hide them again when user just swiped up for
taskbar. But not hide them user is swiping home.
Previously we were always hiding launcher views when user swiped up from
desktop and that led to home or transient taskbar.
This change ensures that we only change the visibility of launcher views
when overview ui is hidden, freeform tasks are still visible, and
gesture has ended.
Otherwise there were flickers when, after swiping home, we were hiding
launcher views and then showing them again shortly after as the freeform
tasks were now hidden.

Bug: 297562634
Test: be on desktop with some open apps
      - swipe up to go home, observe that there are no flickers from
        home screen icons, widgets or hotseat
      - swipe up for transient taskbar, observe desktop apps remain
        visible
      - swipe up to go to overview, observe the other fullscreen apps
        flow in from the side

Change-Id: I14f9f95a3a22fbca6878ecea24848f271dc951d7
2023-09-11 21:43:02 +00:00
Brian Isganitis
3cfc2a338d Stash transient Taskbar on overlay task stack changes.
Test: Manual
Fix: 299515360
Flag: No
Change-Id: I3c182fa51bcb7af908aebf168f017923aff8c789
2023-09-11 20:32:44 +00:00
Winson Chung
0940399f72 Merge "Reset the frozen recents list state when switching to button navigation" into main 2023-09-11 20:23:16 +00:00
Ivan Tkachenko
068d1ea839 Merge "Bubble bar user education" into main 2023-09-11 17:59:08 +00:00
Brian Isganitis
cbaf0a7f70 Merge "Close overlay onTaskStackChanged when All Apps is visible." into main 2023-09-11 17:46:16 +00:00
Mady Mellor
2da9c114c4 Stash taskbar when bubbles is expanded in overview
Test: manual - have transient taskbar
             - have a bubble
             - go to overview
             - expand bubbles
             => observe that transient taskbar stashes
             - collapse bubbles
             => observe that transient taskbar unstashes

             - verify that expanding bubbles in app and on launcher
               home behaves as expected (stashes taskbar in app and
               don't see taskbar or stashed handle on home)
Bug: 284104811

Change-Id: I3d7057ed651e66ab2a0292725f30153ee4d6d51e
2023-09-11 09:41:14 -07:00
Jagrut Desai
6472119d4b Apply ForciblyShown WindowLayoutParam flags for Transient Taskbar
Test: Manual
Bug: 278078311
Flag: Not needed
Change-Id: Ia963e45b3b4e6d928b6292b80b73394e76fe2325
2023-09-11 09:39:23 -07:00
Schneider Victor-tulias
ad147bbc0d Merge "Add error handling to prevent IllegalArgumentException" into udc-qpr-dev am: 9e6a845ca4
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24622404

Change-Id: I543b44b24c93508776bcc4a7c24a8142a70d698c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-11 16:29:01 +00:00
Schneider Victor-tulias
9e6a845ca4 Merge "Add error handling to prevent IllegalArgumentException" into udc-qpr-dev 2023-09-11 15:30:05 +00:00
Tracy Zhou
01cc856157 Always recreate TaskbarActivityContext
- Add ENABLE_TASKBAR_NO_RECREATION flag
  When the flag is turned on,
  * Always destroy and recreate
  * Move task bar drag layer lifecycle from TaskbarActivityContext to TaskbarManager
  * Wrap the drag layer into a fullscreen root view

Note that in order to preserve the window across multiple TaskbarActivityContext creations, the inset types and ids must stay the same, so it's extracted out.

Bug: 274517647
Test: Fold and unfold a few times. Use a few applications. Make sure the task bar is visible and in the right place (tested with ENABLE_TASKBAR_NO_RECREATION and FLAG_HIDE_NAVBAR_WINDOW both on, both off, and one on and one off)
Change-Id: Ic3f0aa3d056fe178a53b76b2ad6cc6b9bffd5898
2023-09-10 22:43:47 -07:00
Winson Chung
8bbfc2b667 Reset the frozen recents list state when switching to button navigation
- A quickswitch will freeze the spatial order of the recents list
  (to allow quickswitching back), but if a nav mode change happens
  immediately after, then the recents list will continue to be
  frozen leaving the list in the wrong order (which can cause a
  flake or failure)

Bug: 298544839
Test: atest NexusLauncherTests:com.android.quickstep.TaplTestsQuickstep
Change-Id: Iabac305ea12cf4a2eb704802a315b6feba49f88a
2023-09-09 16:44:42 +00:00
Jagrut Desai
2a0d7b5a11 Merge "Add haptic feeback for Transient Taskbar" into main 2023-09-09 02:54:02 +00:00
Andy Wickham
43da2dc409 Merge "Add tests for LPH override for 3 button mode Taskbar." into udc-qpr-dev am: 3289e4fa35 am: 294a40b1be
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24607784

Change-Id: Id8ba2e642aad256612f21e6026adbf5c2e756123
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-08 23:49:12 +00:00
Brian Isganitis
648d917a29 Merge "Add All Apps search icon variant behind flag." into main 2023-09-08 23:39:23 +00:00
Vinit Nayak
7f184f82ac Merge "Ignore non-running app-pair tests" into main 2023-09-08 22:42:49 +00:00
Jagrut Desai
54677143b1 Add haptic feeback for Transient Taskbar
Bug: 264851582
Test: Manual
Flag: Not needed
Change-Id: Id5f0e386968291f4c4a897bebf40c59aba33c3d4
2023-09-08 15:39:12 -07:00
Brian Isganitis
8215d8be32 Close overlay onTaskStackChanged when All Apps is visible.
We have too many cases where All Apps can relaunch the current task
behind it to the point where it will not be sustainable to manually
close AFVs in all of these cases.

Test: Manual
Fix: 299169192
Fix: 299169075
Fix: 299169073
Flag: No
Change-Id: If3d9aa756ff5e5d6fbaf5f91d2ccc0c5c11a5c23
2023-09-08 20:51:58 +00:00