Commit Graph

312 Commits

Author SHA1 Message Date
Brandon Dayauon
157f2d8c1f Change inactive button to surfaceBright and headerProtection to scHighest on LT and scLow on DT
bug:294291021
bug:275087095
flag: n/a
test: Manual photos:
before: https://screenshot.googleplex.com/5sDvwGUebY3BtLo
before: https://screenshot.googleplex.com/BSmjETXYbBqXXxG
after: https://screenshot.googleplex.com/8nGCqHEuxQKKpiQ
after: https://screenshot.googleplex.com/AWALHXZAsuLq8b6

Change-Id: I2dd8eff2c56618a143c10fa4e7533265dde3f0b8
2023-08-17 15:09:42 -07:00
Pat Manning
da69661add Show tooltips on cursor hover of taskbar icons.
Fix: 250092437
Test: TaskbarHoverToolTipControllerTest
Flag: ENABLE_CURSOR_HOVER_STATES
Change-Id: Ia0463518d13b313b354328078685930215fb7636
2023-07-14 13:42:30 +01:00
Marcelo Arteiro
d7d49ad4b3 Merge "Fixing color mismatch for Launcher3/NexusLauncher" into udc-dev am: d469ce2460 am: e3f46ba90b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/23102625

Change-Id: Iab06fa739fb16e399931ca90ebb2cfdf7afdd738
Merged-In: Iab06fa739fb16e399931ca90ebb2cfdf7afdd738
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-06-14 22:25:51 +00:00
Marcelo Arteiro
ecff4b59c0 Fixing color mismatch for Launcher3/NexusLauncher
https://screenshot.googleplex.com/7hpgPtjSdjzYFYh

Bug: 268682423
Bug: 277728851
Test: Manual
Change-Id: I7b92ca18721624ef5ecd4b69ca4158ad2dc600f3
2023-06-08 19:01:29 +00:00
Pat Manning
58b6145feb Refactor ArrowTipView so it can be customized and used in any drag layer.
Allows use in TaskbarDragLayer.

Allows customization of properties like text color, background color, and open/close animations.

Bug: 250092437
Test: manual. (Will test with TaplTestsTaskbar in follow up CL when implemented.)
Change-Id: I056395322e5fef7aa4d9fd7e4c2d73c050eff759
2023-06-06 13:46:31 +01:00
Sunny Goyal
3e596d3aa4 Updating the top scrim to also use dynamicaly generated bitmap
Bug: 237818532
Test: Verified on device
Flag: N/A
Change-Id: I22ceb470677ab9df53e40fb78f0292b7fd5e2241
2023-06-01 19:20:04 +00:00
Federico Baron
4b43200910 Merge "Update colors for edit state" into udc-dev 2023-05-18 21:03:19 +00:00
Federico Baron
3eba77ca4b Merge "Update colors for popup menus" into udc-dev 2023-05-18 21:03:19 +00:00
fbaron
e8efdc4bd9 Update colors for edit state
Bug: 268521231
Test: Verify that edit state colors match the figma attached in the bug
Flag: no flag
Change-Id: I72e5ffde48ca2e53b876b2c86ac5d92c8ddf79c0
2023-05-17 09:27:08 -07:00
fbaron
1a76d5c72d Update colors for popup menus
Bug: 268521231
Test: Verify that popup menu colors match the figma attached in the bug
Change-Id: I24025576a789775dfcf17694d16c0d5f6ee844fd
2023-05-16 15:07:30 -07:00
fbaron
8463f6a771 Update folder preview and folder colors
Bug: 268521231
Test: Verify that folder preview and folder colors match the figma attached in the bug
Flag: no flag
Change-Id: Ica75cace98fc2643d59ad0c28cbad736b578c51d
2023-05-16 09:34:37 -07:00
fbaron
1406a0f606 Update notification dot color
Bug: 268521231
Test: Verify that notification dot colors match the figma attached in the bug
Change-Id: Id0cbf9f2447819ae3e6e00e880eca1be3f189826
2023-05-15 11:06:46 -07:00
Jordan Silva
567372fbda Fix text sizes and alignment in drop target
Drop target button texts are being resized incorrectly.
When both buttons are visible, the text is considerably smaller compared
to only one visible button. This happens even for the default display and font scale 1.

Fix: 271279172
Test: manual. test all combinations of display size and font size.
Test: HomeScreenEditStateImageTest
Change-Id: Ib001dcf8b096c65b138946bdad49cf8199fb5b1d
2023-05-02 14:57:49 +02:00
Jagrut Desai
64b79a9fad Merge "Exposing functionality to pin Taskbar from TaskbarDividerPopupView." into udc-dev 2023-04-21 16:15:07 +00:00
Jagrut Desai
c6d625b8db Exposing functionality to pin Taskbar from TaskbarDividerPopupView.
This CL allows user to long press on Taskbar divider view to bring up divider popup view. It also included functionality of allowing user to turn on always show taskbar from the divider popup view.

Test: Manual
Bug: 265436055
Bug: 265434718
Bug: 265434902
Bug: 265434705
Flag: ENABLE_TASKBAR_PINNING

Change-Id: Ied54d718483a9b06b053d68988e5c294a786002a
2023-04-20 22:04:21 -07:00
fbaron
328ca3811c Update colors for widget picker
Bug: 278157622
Test: Look at widget picker on tablet and verify that the colors match the new spec, and verify the portrait mode looks good also.
Change-Id: I634d876dfafc086806b233c500f7d8daddfe7b0b
2023-04-18 16:17:24 -07:00
Sunny Goyal
7b74a5c53f Merge "Revert "Revert "Revert "Simplifying some page indicator dots attributes so that it can"""" into udc-dev 2023-04-07 01:02:09 +00:00
Sunny Goyal
5cd1b198b0 Revert "Revert "Revert "Simplifying some page indicator dots attributes so that it can"""
This reverts commit 7025765c72.

Reason for revert: 274169859

Change-Id: I86a114bf2c713fea6ec7095f68816820ba5f7495
2023-04-06 22:33:11 +00:00
TreeHugger Robot
331ab34a2a Merge "Revert "Revert "Simplifying some page indicator dots attributes so that it can""" into udc-dev 2023-03-31 20:10:37 +00:00
Sunny Goyal
7025765c72 Revert "Revert "Simplifying some page indicator dots attributes so that it can""
This reverts commit 0263a679f2.

Reason for revert: Trying again to confirm if this was the actual cause of regression

Change-Id: I2a663015d7ecdcf315634d8a976bf8294b58981d
2023-03-31 17:10:15 +00:00
Sunny Goyal
1fc1cd002f Merge "Revert "Simplifying some page indicator dots attributes so that it can"" into udc-dev 2023-03-29 21:22:10 +00:00
Sunny Goyal
0263a679f2 Revert "Simplifying some page indicator dots attributes so that it can"
This reverts commit a5ead45967.

Reason for revert: b/274169859

Change-Id: Id214694ae4f61cd70796c6f7e932c1fdef82d746
2023-03-29 19:11:03 +00:00
Sunny Goyal
feca2d8700 Merge "Simplifying some page indicator dots attributes so that it can be easily modularized" into udc-dev 2023-03-17 19:02:01 +00:00
Sunny Goyal
a5ead45967 Simplifying some page indicator dots attributes so that it can
be easily modularized

> Moving the color configuration to xml
> Moving auto-hide logic to a subclass as it doesn't
  need to be in the main library

Bug: 274011949
Test: Verified on device
Change-Id: Icf7bd5d1cbde3daa9441f2af51f98a931bcd6ee2
2023-03-16 15:57:06 -07:00
Charlie Anderson
63be5b53db polish for the app shortcut popup, fixing padding on several elements.
Bug: 269343928
Test: manually verify against spec
Change-Id: Ib8dd7ab2778644e2220622d43f9774c1de6357e9
2023-03-14 11:33:38 -04:00
Brandon Dayauon
ffc7084b37 Correctly make to spec the color for "Turn on work apps" button and add stroke
- define color in base and quickstep

bug: 267975252
test: Manual - video: lightTheme: https://drive.google.com/file/d/1noY5Grq4jOxFIheL91KB_sOYRwp8XIyD/view?usp=sharing
test: darkTheme: https://drive.google.com/file/d/1o1uaTedAKbPy3BTG1GKJ0ldyHFs0-jGN/view?usp=sharing
Change-Id: I266b6624aa6f045c1f30c0db984fa9e1c5f6fe7e
2023-03-03 15:42:13 -08:00
Federico Baron
e8217b3c1b Add ripple effect when a header in widget picker is selected.
We need to use setSelected in order to add a ripple effect when a header is selected in tablet landscape mode, and to set the style through XML rather than programmatically the way it was done before in the method `setLargeScreenTheme`.

Fix: 268558453
Test: Turn on LARGE_SCREEN_WIDGET_PICKER and verify that when selecting a header there's a ripple effect on that header
Change-Id: I6cab920258a57118430d1e07416508ef36faa56d
2023-02-21 16:33:18 -08:00
Thales Lima
e9273ea743 Improvements for All Apps on different display sizes
Bug: 262912817
Test: DeviceProfileAlternativeDisplaysDumpTest
Change-Id: I50e980183b4d5c1a46cca8f1c867b866b9eae4b5
2023-02-01 11:34:12 +00:00
TreeHugger Robot
3467c51780 Merge "Change folder text color to match spec" into tm-qpr-dev 2023-01-30 21:45:13 +00:00
Thales Lima
d852d65693 Create attr for padding between icon and text in cells
Bug: 265210314
Test: DeviceProfileDumpTest
Change-Id: I00af790d0c21c35f1cbce1362e63d3ab8259244a
Merged-In: I00af790d0c21c35f1cbce1362e63d3ab8259244a
2023-01-26 22:50:18 +00:00
Federico Baron
79a9bfed79 Change folder text color to match spec
We needed folder text color to use textColorPrimary. With this CL we update it to be that.

Test: Look at folder text color
Fix: 262450499
Change-Id: Icd540c7d3ff4431b4edc72f04ce7f8f14787aa5b
2023-01-26 20:26:29 +00:00
Sunny Goyal
adb364a104 Unifying multiple all-apps implementations
> Using a single layout for the all-apps content
> Removing some unnecessary themes
> Fixing search chashes in SecondaryDisplayLauncher

Bug: 259733681
Test: Existing TAPL tests verify that Launcher/AllApps work properly
Change-Id: Icd5310316499cd421bc039cdbd4d398b813cd477
2022-12-14 11:27:12 -08:00
Thales Lima
b35faed6e7 Improve spaces for folders
Bug: 214582832
Test: DeviceProfileTest
Change-Id: I7c5cae0792d51baf111d0aec46be302ac6ca9994
2022-11-07 18:23:48 +00:00
Sunny Goyal
fc1928e324 Optimizing some icon generation code:
1) Fixing missing shadow from shortcut icons
2) Chaning all-apps icon rendering to draw background/foreground separately
   This allows us to reuse the bitmap generated for themed icons, instead of
   creating a new everytime

Bug: 248308987
Test: Verified on device
Change-Id: Ia3cbefb21a2ce676d6bb2df3d9375d61b5bed61b
2022-10-20 10:40:54 -07:00
Sunny Goyal
af95ddbadc Fixing search behavior in Launcher3
> Showing no-result found only when there are no results
> Removing unnecessary view inflation in RecyclerViewPool for
  various search vide types
> Removing unused market-search link and no-empty-result illustration

Bug: 240343082
Bug: 207573083
Test: Verified Launcher3
Change-Id: Ia44799cd2385ea5dc837ef25732ca237975abde7
2022-07-28 22:05:30 -07:00
Pat Manning
0b16bba93a Set drop target font weight to medium.
Bug: 235886741
Test: manual.
Change-Id: Ie5b3f4159dee7e2eb8e614a15b57a0929f8eae71
2022-07-20 11:28:36 +01:00
Brian Isganitis
cd7cc294b8 Update download app icon treatment to latest mocks.
Demo: https://screenshot.googleplex.com/BfTvY2EaByJXwdw.png
Test: Manually using "start install session helper" in SupportApp.
Fix: 205714358
Change-Id: I3ec2fb776cbad974ae36f34b29f3081b3d073c83
2022-06-02 11:53:47 -07:00
James O'Leary
202ac414bf Merge "Revert "Update app icon shadows"" into tm-dev 2022-06-01 01:29:34 +00:00
James O'Leary
dac75aef3b Revert "Update app icon shadows"
Revert submission 17935777-lightDarkDetection

Reason for revert: Talked with Adam Cohen, white shadows are controverstial and we'd need to escalate to senior UX if we want to ship. James would rather do it in U timeframe, will flag to UXers we work with that the opportunity to escalate is available if needed.
Reverted Changes:
Ia91221427:Update light/dark detection.
Ie12d3d054:Update app icon shadows
Icc88c3496:Update smartspace shadow

Change-Id: I8bc90e79073b8e088f2912fef2af4c6c99a33553
2022-05-31 21:12:38 +00:00
James O'Leary
2b6700a94c Merge "Update app icon shadows" into tm-dev 2022-05-27 19:44:39 +00:00
James O'Leary
fe435ad44e Update app icon shadows
Allow use of white shadow, set radius to 1.0 and offset to 0.
Use 100% and 20% alpha, instead of 70% and 50%.
(nets out to same effect)
Make ambient and key shadows equivalent: there are deterministic
formulas for what contrast a shadow will create, and those formulas
were used for the spec. Ad-hoc attempts to try to increase visibility
are no longer needed and don't align with design intent

Bug: 213314628
Test: Manual inspection at runtime
Change-Id: Ie12d3d05488e16fea94e91be16c25448f450a44d
2022-05-12 18:28:39 +00:00
Sunny Goyal
d333091d79 Fixing wrong alpha for disbled icon
Bug: 230852221
Test: Verified manually
Change-Id: I73fb1ac73ff374cd67b3f26367814ea5b0b49a3b
2022-05-09 16:12:06 -07:00
Jon Miranda
48a2f7a0ac Use color tokens for all apps entry buttons.
Bug: 220356537
Bug: 205803230
Test: manual, dark mode, light mode
Change-Id: I0973d5aa9ab1ccbdcc78c1e411cbbf63953f2f94
2022-02-23 19:47:33 +00:00
Jon Miranda
b77878ebe3 Update folder preview and folder background colors.
Bug: 201332301
Test: light theme / dark theme
      open and close folder, ensure colors are accurate

Change-Id: I49198eb2faee03111be33051fd1cb08094844c77
2021-10-06 16:57:33 -07:00
Brian Isganitis
cbaf149f87 Update folder pagination dot color to match mocks.
Test: Folder page dot color matches mocks in light and dark mode.
Fix: 195045519
Change-Id: Ib485e51fbb903b1345ee865ddd8614f280e7608a
2021-08-09 16:03:54 -04:00
Steven Ng
a1dcbce15a Remove drop target button drawable padding if text isn't hidden
Test: manual
Fix: 194320733
Change-Id: I12adeaf37cee5a0fcf383641f24b7750f14daf27
2021-07-26 17:10:56 +01:00
Yogisha Dixit
2046730771 Update widget manipulation colors to match AOD.
This CL makes two changes:
1. Changes the colors we use from system_accent1_50 ->
system_accent1_100 (light wallpapers) and system_accent2_700 ->
system_accent2_600 (dark wallpapers).
2. Changes when we use the light/dark colors. Before: light accent color
when wallpaper luminosity < 0.3. After: light accent color when wallpaper luminosity < 0.7.

Bug: 192359286
Test: manual on light/dark wallpapers with light/dark theme
Change-Id: I28abfd77439a16b4bb637376fd88180d536364cf
2021-07-16 16:43:18 +01:00
Alina Zaidi
f03b1aeeb6 Merge "Reduce margin for DropTargetBar to avoid buttons to be truncated." into sc-dev am: eefccccb19
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15155531

Change-Id: I92c997fbd0d0f47e78e5169e8cad9938bd2af0a0
2021-07-01 11:52:05 +00:00
Alina Zaidi
1b5efa3216 Reduce margin for DropTargetBar to avoid buttons to be truncated.
Bug: 187036287
Test: Tested manually by QA testing team on 4X5 grid size
Change-Id: Iaa4cd3e464ccf50427a5aa96d97093601e1d2948
2021-07-01 09:50:46 +01:00
Jonathan Miranda
9f113f76fa Merge "Update colors for non-v31 devices." into sc-dev am: 7a582f2d7d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15096360

Change-Id: Ib926073532c53a4db19e9930ade8c9efd776796d
2021-06-26 15:10:27 +00:00