Commit Graph

400 Commits

Author SHA1 Message Date
Brandon Dayauon
f61fb2717b Merge "Change inactive button to surfaceBright and headerProtection to scHighest on LT and scLow on DT" into udc-qpr-dev am: 7f347e93d2 am: d2d331f128
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24472448

Change-Id: I3efae71036af16990d5fd162e2be79a266e6cf9c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-21 17:11:43 +00:00
Jagrut Desai
8923830f74 Remove Change Navigation Mode option for Taskbar Divider Popup Menu
- Breakout CL part 3
- This is a breakout cl from ag/24272821 to make it more readable and atomic.
- This cl consist removal of an option from taskbar divider popup meu which is no longer required and other changes regarding the removal like ripple.

Test: Manual, Visual
Bug: 265170176
Flag: ENABLE_TASKBAR_PINNING
Change-Id: I3664df7a134cc0eb5b4ed856c7e0730ef1b75dea
2023-08-17 22:13:49 +00:00
Brandon Dayauon
157f2d8c1f Change inactive button to surfaceBright and headerProtection to scHighest on LT and scLow on DT
bug:294291021
bug:275087095
flag: n/a
test: Manual photos:
before: https://screenshot.googleplex.com/5sDvwGUebY3BtLo
before: https://screenshot.googleplex.com/BSmjETXYbBqXXxG
after: https://screenshot.googleplex.com/8nGCqHEuxQKKpiQ
after: https://screenshot.googleplex.com/AWALHXZAsuLq8b6

Change-Id: I2dd8eff2c56618a143c10fa4e7533265dde3f0b8
2023-08-17 15:09:42 -07:00
Andy Wickham
bc3bac4113 Revert^3 "Change Overview Actions to round buttons."
Awaiting UX alignment.

Test: N/A
Flag: N/A
Change-Id: I05e9627d8b44ea16d29445e005534af2a1abd439
2023-08-08 12:09:59 -07:00
Andy Wickham
be8981442a Revert^2 "Change Overview Actions to round buttons."
f849f2856f

Fix: 293081298

Change-Id: Iaf1553770329ec3a6c6d8a2d9d81b60203e79ed8
2023-07-26 20:56:05 +00:00
Greg Kaiser
f849f2856f Revert "Change Overview Actions to round buttons."
Revert submission 23784078-overview-actions

Reason for revert: b/293081298

Reverted changes: /q/submissionid:23784078-overview-actions

Change-Id: I185cfc6baf8dd2243f6fb5a585c926f9df3b3934
2023-07-25 14:27:28 +00:00
Andy Wickham
f98949cac3 Change Overview Actions to round buttons.
If floating search is active in Overview (flag enabled and we are
the active Launcher), these buttons will be aligned to the search
bar relative to the bottom of the screen. Otherwise, the buttons
will be aligned below the active task like before.

Demo for Launcher3 build:
https://drive.google.com/file/d/1fVzRRnW5AFDMPkW-E8_w4BOCzTAOURQ_/view?usp=drive_link&resourcekey=0-6-EbFZXkBqcu0rw7uuEzjw

Bug: 292000892
Test: Manual with floating enabled/disabled and
SEPARATE_RECENTS_ACTIVITY enabled/disabled (simulating not being
the active Launcher). Also tested with a 3P Launcher, Nova.
Flag: N/A; this change is enabled by default, but also verified
UI looks correct with ENABLE_FLOATING_SEARCH_BAR.

Change-Id: Ia45f88d2c691c4525b1e73cca4707498d058a917
2023-07-22 07:43:17 +00:00
Vinit Nayak
306c6e843f Merge "Change split toast exit asset to "X"" into udc-qpr-dev 2023-07-20 22:58:17 +00:00
Vinit Nayak
78207fd80b Change split toast exit asset to "X"
* TODO: Probably need to change tint based on theme

Bug: 276361926
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE
Test: Shows up as expected
Change-Id: I28a2eefa115cb15aab560d750103c7946639c18b
2023-07-17 20:19:16 -07:00
Pat Manning
da69661add Show tooltips on cursor hover of taskbar icons.
Fix: 250092437
Test: TaskbarHoverToolTipControllerTest
Flag: ENABLE_CURSOR_HOVER_STATES
Change-Id: Ia0463518d13b313b354328078685930215fb7636
2023-07-14 13:42:30 +01:00
Andrew Cole
fe0a3b41d8 Updating materialColorSurfaceContainerHighest color access
For any view files applying the WidgetConatinerTheme via widgetsTheme they were incorrectly inheriting themes and skipping the AppTheme provided but only in light mode. In dark mode the WidgetContainerTheme.Dark was correctly inheriting the theme.

To avoid a risky theme update for all widgetsThemes we just modify the color accessor to use @color instead of ?attr as these colors should not be attributes AFAIKT

Bug: b/289305591
Test: Follow repro steps on the bug for smartspace
Change-Id: I26cc3239763f8eac3dfe5f094c6757692f46d1bc
2023-07-06 12:21:21 -07:00
Treehugger Robot
936722a71f Merge "Adds an overflow bubble to the bubble bar." into udc-qpr-dev 2023-06-07 22:09:31 +00:00
Sunny Goyal
6773667e34 Revert "Revert "Adding main thread binder tracing in development..."
Revert submission 23522417-revert-23482347-launcher-binder-tracing-RBUMTFPXQG

Reason for revert: Fixed broken build
Reverted changes: /q/submissionid:23522417-revert-23482347-launcher-binder-tracing-RBUMTFPXQG

Change-Id: I3e130a780b8641c4a17a5cdf799513f2ba08b16e
2023-06-02 18:14:35 -07:00
Santiago Aboy Solanes
ee846feb80 Revert "Adding main thread binder tracing in development build."
Revert submission 23482347-launcher-binder-tracing

Reason for revert: Broken Build 10242119 on git_master on errorprone b/285434612

Reverted changes: /q/submissionid:23482347-launcher-binder-tracing

Change-Id: Id9726474265e839a59d6eb34822e7a86d40f0fc9
2023-06-02 08:59:28 +00:00
Sunny Goyal
3db98b1152 Adding main thread binder tracing in development build.
> Unifying multiple binder tracing implementations
> Removing wallpaper customization check as it has been rolled out
  few years ago, this avoids additional RPC to check for wallpaper
> Removing RaceConditionReproducer as it is not used anywhere and
  is not integrated with this tracing anymore

Bug: 273718665
Test: Presubmit
Flag: N/A
Change-Id: I801af5d039a9d38d5d39e803723ec6da50a9d59f
2023-06-01 09:39:50 -07:00
Brandon Dayauon
fe3d513650 Merge "Update work tab colors and fab background color" into udc-dev 2023-05-25 03:07:59 +00:00
Brandon Dayauon
adcc16cf56 Update work tab colors and fab background color
Spec: https://screenshot.googleplex.com/6mKVuFNNNQfXpbD

bug: 283120562
test:
manually Launcher3 build var:
worktab lt: https://screenshot.googleplex.com/B8v44jm77o5Jyc7
widgetpicker tab lt: https://screenshot.googleplex.com/48WjAB8fKpZSEQ7
sharesheet tab lt: https://screenshot.googleplex.com/9rfSBeNALXbG7NL
worktab dt: https://screenshot.googleplex.com/332jCxde9vDW7hd
widgetpicker tab dt: https://screenshot.googleplex.com/3PGtrvQ2jLhQD4k
sharesheet tab dt: https://screenshot.googleplex.com/3jr4GPzRc3rzMA6

NexusLauncher:
worktab lt: https://screenshot.googleplex.com/BH2SFMXfQ4dtBeh
sharesheet lt: https://screenshot.googleplex.com/5axg34QgTt87iSL
widget picker tab lt: https://screenshot.googleplex.com/928kWFJ5mTun9py
worktab dt: https://screenshot.googleplex.com/7KWKLH4kt6nJpXT
sharesheet dt: https://screenshot.googleplex.com/778UoyhYrhimSAz
widgetpicker tab dt: https://screenshot.googleplex.com/FFFxBLqsATNXj8v

Change-Id: I78f20b2863a04d23e8a8880fc1d6a3ac0cfeb82a
2023-05-24 09:10:03 -07:00
Federico Baron
4b43200910 Merge "Update colors for edit state" into udc-dev 2023-05-18 21:03:19 +00:00
Federico Baron
3eba77ca4b Merge "Update colors for popup menus" into udc-dev 2023-05-18 21:03:19 +00:00
Jagrut Desai
062f93517d Adding all apps icon for transient taskbar to default config
Test: Pre-submit
Bug: 278130502
Flag: not needed
Change-Id: Iea4c7717cf669c60b71a55d53d67ee5502006541
2023-05-17 10:57:51 -07:00
Liran Binyamin
f78d55ba76 Adds an overflow bubble to the bubble bar.
Bug: 271468319
Test: Tested on a physical device
Change-Id: Ib4ad62779173ab8010e5e5d25bf5415fee1b1d41
2023-05-17 16:37:48 +00:00
fbaron
e8efdc4bd9 Update colors for edit state
Bug: 268521231
Test: Verify that edit state colors match the figma attached in the bug
Flag: no flag
Change-Id: I72e5ffde48ca2e53b876b2c86ac5d92c8ddf79c0
2023-05-17 09:27:08 -07:00
fbaron
1a76d5c72d Update colors for popup menus
Bug: 268521231
Test: Verify that popup menu colors match the figma attached in the bug
Change-Id: I24025576a789775dfcf17694d16c0d5f6ee844fd
2023-05-16 15:07:30 -07:00
Jagrut Desai
5dbfe1f238 Merge "Design review updates for Taskbar Pinning" into udc-dev 2023-05-03 18:24:07 +00:00
Jagrut Desai
1c9c6d0ea9 Design review updates for Taskbar Pinning
Changes:

- icon allignment animation for taskbar diviver view
- taskbar divider background color according to spec.

Test: Manual
Bug: 265170176
Flag: ENABLE_TASKBAR_PINNING
Change-Id: Ief45e48f4fc9f9b4cc30124c4c93cd3c5a880a33
2023-05-01 14:57:54 -07:00
Marcello Galhardo
b771653919 Remove white boarders from Shortcut Category icon
* The icon works with light mode, but breaks the UI with dark mode on.
* Previously, the icon would be show as a white square in dark mode.
* The new version shows it correctly, as a circle.

Test: manual
Flag: not needed

Change-Id: I61838266494a9a2c3048030ff3c95ced3db6347c
Fixes: 280069069
2023-04-28 17:10:31 +00:00
Marcello Galhardo
0745f507a4 Merge "Add custom widget category for Note Taking" into udc-dev 2023-04-26 14:25:33 +00:00
Marcello Galhardo
4b7b7f1cfa Add custom widget category for Note Taking
Test: manual
Flag: not needed

Fixes: b/261853771
Change-Id: I493fd782cf8569ee9efca5134eefb5652a2bf972
2023-04-24 17:09:31 +00:00
Jagrut Desai
64b79a9fad Merge "Exposing functionality to pin Taskbar from TaskbarDividerPopupView." into udc-dev 2023-04-21 16:15:07 +00:00
Jagrut Desai
c6d625b8db Exposing functionality to pin Taskbar from TaskbarDividerPopupView.
This CL allows user to long press on Taskbar divider view to bring up divider popup view. It also included functionality of allowing user to turn on always show taskbar from the divider popup view.

Test: Manual
Bug: 265436055
Bug: 265434718
Bug: 265434902
Bug: 265434705
Flag: ENABLE_TASKBAR_PINNING

Change-Id: Ied54d718483a9b06b053d68988e5c294a786002a
2023-04-20 22:04:21 -07:00
fbaron
328ca3811c Update colors for widget picker
Bug: 278157622
Test: Look at widget picker on tablet and verify that the colors match the new spec, and verify the portrait mode looks good also.
Change-Id: I634d876dfafc086806b233c500f7d8daddfe7b0b
2023-04-18 16:17:24 -07:00
Federico Baron
cc79886814 Merge "Fix droptarget button wrong radius on hover" into udc-dev 2023-04-13 23:50:12 +00:00
fbaron
84e19a9bea Fix droptarget button wrong radius on hover
Fix: 277470359
Test: drag app to uninstall or remove on tablet, verify the button shape doesn't change when hovered over
Change-Id: I6b8b2de7357f8d19cdee7632a9957624a3f242a1
2023-04-13 19:27:00 +00:00
fbaron
6847c9f113 Add entry point for home gardening
Bug: 277817921
Test: Turn on flag MULTI_SELECT_EDIT_MODE and verify that a new button shows up that says "Edit Home Screen"
Change-Id: Ic8027ab80604faf5bdc63a44319ecffc047a495c
2023-04-12 09:31:28 -07:00
Sunny Goyal
7b74a5c53f Merge "Revert "Revert "Revert "Simplifying some page indicator dots attributes so that it can"""" into udc-dev 2023-04-07 01:02:09 +00:00
Sunny Goyal
5cd1b198b0 Revert "Revert "Revert "Simplifying some page indicator dots attributes so that it can"""
This reverts commit 7025765c72.

Reason for revert: 274169859

Change-Id: I86a114bf2c713fea6ec7095f68816820ba5f7495
2023-04-06 22:33:11 +00:00
fbaron
55fed64ced Rename widgets two pane sheet layout files and spec files to more fitting name
Currently the names used for widgets two pane sheet files are similar to full sheet files, just with "_large_screen" added to it. This is not a good name as it can cause confusion. The new name includes "_two_pane" which is more indicative of the actual functionality of these files.

Fix: 276917926
Test: verify widget picker two pane still works
Change-Id: I23cf2a20fc137cc3e99c5fdc90100648a0926368
2023-04-04 09:55:31 -07:00
Sunny Goyal
7025765c72 Revert "Revert "Simplifying some page indicator dots attributes so that it can""
This reverts commit 0263a679f2.

Reason for revert: Trying again to confirm if this was the actual cause of regression

Change-Id: I2a663015d7ecdcf315634d8a976bf8294b58981d
2023-03-31 17:10:15 +00:00
Sunny Goyal
0263a679f2 Revert "Simplifying some page indicator dots attributes so that it can"
This reverts commit a5ead45967.

Reason for revert: b/274169859

Change-Id: Id214694ae4f61cd70796c6f7e932c1fdef82d746
2023-03-29 19:11:03 +00:00
Sunny Goyal
a5ead45967 Simplifying some page indicator dots attributes so that it can
be easily modularized

> Moving the color configuration to xml
> Moving auto-hide logic to a subclass as it doesn't
  need to be in the main library

Bug: 274011949
Test: Verified on device
Change-Id: Icf7bd5d1cbde3daa9441f2af51f98a931bcd6ee2
2023-03-16 15:57:06 -07:00
Charlie Anderson
3b072b9a07 Merge "Fixes several Visual issues with the app shortcut popup" into tm-qpr-dev 2023-03-08 14:15:17 +00:00
Charlie Anderson
52caf63404 Fixes several Visual issues with the app shortcut popup
- Fix system shortcut alignment and ordering.
- Replace horizontal split icon with correct size drawable.
- Remove popup shortcut reversing logic, and instead show same order of shortcuts regardless of orientation.

Test: tested manually on tablet and phone
Bug:269343928
Change-Id: I1700ad1ee04abf0820c87d89e1dc07d6880fd519
2023-03-06 16:40:51 -05:00
Brandon Dayauon
ffc7084b37 Correctly make to spec the color for "Turn on work apps" button and add stroke
- define color in base and quickstep

bug: 267975252
test: Manual - video: lightTheme: https://drive.google.com/file/d/1noY5Grq4jOxFIheL91KB_sOYRwp8XIyD/view?usp=sharing
test: darkTheme: https://drive.google.com/file/d/1o1uaTedAKbPy3BTG1GKJ0ldyHFs0-jGN/view?usp=sharing
Change-Id: I266b6624aa6f045c1f30c0db984fa9e1c5f6fe7e
2023-03-03 15:42:13 -08:00
Jagrut Desai
3addf0b66d Merge "Implement All Apps Icon upto the visual Specs." into tm-qpr-dev 2023-02-25 01:49:59 +00:00
Jagrut Desai
560b0eac62 Implement All Apps Icon upto the visual Specs.
Test: Visual
Bug: 267382941

Change-Id: If675c2f4767014598b23d8a2c2e684f5a8fb4f19
2023-02-24 15:41:06 -08:00
Federico Baron
4ee5c429fe Merge changes I6c89c639,I6cab9202 into tm-qpr-dev
* changes:
  Move 'no widgets found' to right pane and add rounded edges to right pane.
  Add ripple effect when a header in widget picker is selected.
2023-02-22 23:24:10 +00:00
Ats Jenk
431c0c05fd Merge "Add empty view to desktop tile in overview" into tm-qpr-dev 2023-02-22 19:30:55 +00:00
Federico Baron
8f6523a3d6 Move 'no widgets found' to right pane and add rounded edges to right pane.
Previously 'no widgets found' appeared on the left pane, but in large screen landscape we want it to appear on the right pane. Additionally, we added rounded edges to the right pane that turn into sharp edges when we scroll.

Fix: 268558448
Fix: 268557435
Test: Turn on LARGE_SCREEN_WIDGET_PICKER and on tablet landscape mode go to the widget picker and search for a widget that doesn't exist, verify that 'no widgets found' appears on the right pane. Also verify that right pane has rounded corner that turn into sharp corners as we scroll
Change-Id: I6c89c63941e3b0680836828d0c7849d789cbce61
2023-02-22 00:34:10 +00:00
Federico Baron
e8217b3c1b Add ripple effect when a header in widget picker is selected.
We need to use setSelected in order to add a ripple effect when a header is selected in tablet landscape mode, and to set the style through XML rather than programmatically the way it was done before in the method `setLargeScreenTheme`.

Fix: 268558453
Test: Turn on LARGE_SCREEN_WIDGET_PICKER and verify that when selecting a header there's a ripple effect on that header
Change-Id: I6cab920258a57118430d1e07416508ef36faa56d
2023-02-21 16:33:18 -08:00
Ats Jenk
4d397e2ebb Add empty view to desktop tile in overview
Show an empty view when there are no tasks on the desktop.

Bug: 267326725
Test: have a fullscreen task, open overview, observe empty view for
  desktop tile
Test: have a desktop task, open overview, observe desktop task thumbnail
  is shown in overview and empty view is hidden

Change-Id: Ifb6d96d42bf602e9cc9e397efc0e07e2accdf16b
2023-02-17 16:48:47 -08:00