Commit Graph

602 Commits

Author SHA1 Message Date
Vadim Tryshev
b5057c496a Revert "Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test"
This reverts commit 1a2462914d.

Reason for revert: Likely culprit for b/286115393

Change-Id: I613ca9f62c5b9f43f2e3cd240e45bc1a0db0e661
2023-06-12 17:40:22 +00:00
Fengjiang Li
1a2462914d Fix NPE of handling ACTION_MOVE in StatusBarTouchController and added unit test
Fix: 282945183
Test: N/A
Change-Id: I96680f04a6946129b14c365e2300f408dfe8f0c3
2023-06-05 09:19:07 -07:00
Jagrut Desai
ce8dd7884a Fixing TaplTestsQuickstep#testQuickSwitchToPreviousAppForTablet()
Currently, test asssumes that we are in persistent taskbar mode and assumes that taskbar is visible after switching to non ime activity.

We need overall strategy to how we migrate currentl TaplTestQuickstep to test for transient taskbar mode also. But, this will fix the current flakiness.

Test: Pre-submit
Flag: not needed
Bug: 281772186
Change-Id: Ie7e3364febd38ce489c3d3c881b94b8b308d3cb5
2023-05-31 15:05:35 -07:00
Stefan Andonian
57eaf86f8d Merge "Revert "Keep ViewCaptureRule logic self-contained."" into udc-dev 2023-05-30 17:49:54 +00:00
Stefan Andonian
0a8fab01da Revert "Keep ViewCaptureRule logic self-contained."
This reverts commit eec7a9d90f.

Reason for revert: Failing tests.

Change-Id: Idf16453bbd7f0ace17d8e80d3303fae26b50333b
2023-05-26 21:11:41 +00:00
Stefan Andonian
9678d9470c Merge "Keep ViewCaptureRule logic self-contained." into udc-dev 2023-05-25 22:53:28 +00:00
Stefan Andonian
eec7a9d90f Keep ViewCaptureRule logic self-contained.
This will make it easier for other apps / processes to integrate the
ViewCapture logic into their integrated testing frameworks.

Bug: 270158224
Test: Verified that a zip file was generated properly and was able to be
loaded into go/web-hv properly.

Change-Id: Ib3e4a0b60497937b750126590071884882b22917
2023-05-25 17:59:46 +00:00
Hui Kang
879d746de7 Merge changes from topic "Annotate Platinum Test" into udc-dev
* changes:
  [3/7]Add PlatinumTest annotation to tests
  [4/7]Add PlatinumTest annotation to tests
2023-05-25 16:04:10 +00:00
Hui Kang
5bde3f8573 [4/7]Add PlatinumTest annotation to tests
These tests are in the audited platinum suite (go/platinum-audit-flake)

Test: make
Bug: 283409062
Change-Id: Id438fde00b2a6e31694bef125d20637af514b9da
2023-05-24 01:17:18 +00:00
Thales Lima
ac206e1daf Merge "Create TAPL test for taskbar in overview" into udc-dev 2023-05-23 18:32:34 +00:00
Thales Lima
1f10e53ba2 Create TAPL test for taskbar in overview
Fix: 269985301
Test: TaplTestsQuickstep
Flag: none
Change-Id: Iea0311bcba54882f7f2cf5d35cd98a538ae85855
2023-05-23 13:22:10 +00:00
Vadim Tryshev
807d9c2c30 Merge "Revert "Re-enabling a couple of tests"" into udc-dev 2023-05-22 20:28:07 +00:00
Vadim Tryshev
8d1de90744 Revert "Re-enabling a couple of tests"
This reverts commit 81b228a5fb.

Reason for revert: b/283523638

Change-Id: I2787b34e369ed2c879d80806bc30cab3dbb10c69
2023-05-19 21:17:55 +00:00
Vadim Tryshev
bc4813afb2 Merge "Re-enabling a couple of tests" into udc-dev 2023-05-19 17:37:16 +00:00
Jagrut Desai
20c26a4a6c Merge "Fix TaplTestsTaskbar" into udc-dev 2023-05-18 20:11:59 +00:00
Treehugger Robot
4b941231ce Merge "Re-enable testOverviewForTablet for persistent taskbar." into udc-dev 2023-05-17 23:33:59 +00:00
Jagrut Desai
23d752779b Fix TaplTestsTaskbar
we were going to overview and clearing tasks before splitscren test are broken because of it.

Test: Presubmit
Bug: 281772186
Flag: not needed
Change-Id: I79addec3cfa0adf41581be72fed2ca3cd024a904
2023-05-17 11:51:41 -07:00
Jon Miranda
479b247372 Re-enable testOverviewForTablet for persistent taskbar.
Will enable for transient taskbar separately.

Bug: 281812199
Test: verified passes locally
Change-Id: I25ddc8bd80b8e06e983d0add0d1b354083d1870a
2023-05-16 16:13:09 -07:00
Stefan Andonian
fa8091661a Added ViewCapture to all tests which implement AbstractLauncherUiTest.
This enables developers to watch failed tests in classes like
TaplTestsQuickstep in the go/web-hv tool.

Bug: 242867462
Test: Failed a test and verified that the TimeLapse bugreport entry
showed up properly in the go/web-hv tool.

Change-Id: Ic89af2a0e7102db52c52ddc668607a81c4809ed6
2023-05-12 21:15:14 +00:00
Jagrut Desai
c875f27912 Fixing TaplTests
Test: Pre-Submit
Fixes: 281772186
Flag: not needed
Change-Id: Ibe2987a69c9ca393ed267e755a3b99826164fee4
2023-05-10 10:47:45 -07:00
Jagrut Desai
53b4435b7e Merge "Un-Split TaplTestsTaskbar" into udc-dev 2023-05-09 20:43:01 +00:00
Jagrut Desai
9569ce86a2 Un-Split TaplTestsTaskbar
Before we use TaskbarModeSwitch but had a drawback where we would not know which variant of taskbar the test failed for. So, we split the taskbar tests into transient and persistent for better error logs and debugging.
But, now we can use Parameterized Test Runner to achieve the same and do not have to duplicate test code for testing two different variants of Taskbar.

There can be instances where we only want to test certain taskbar variant only, we have separated files for that.

Test: Presubmit
Bug: 267648422
Flag: not needed
Change-Id: I4322498f13d257a5f1793b008f45b09ac9b9f3ff
2023-05-09 09:36:09 -07:00
Vinit Nayak
b33a2e0762 Enable flag ENABLE_SPLIT_LAUNCH_DATA_REFACTOR
Flag: ENABLE_SPLIT_LAUNCH_DATA_REFACTOR
Bug: 279494325
Change-Id: I9c58ba50f0269c69a12f548a1873c2d8251f6243
2023-05-08 17:27:03 -07:00
Mady Mellor
c37bf46381 Adds BubbleControllers to TaskbarControllers
* BubbleControllers is optionally available (gated behind a flag).
* The bubble bar controllers follow init & onDestroy after the taskbar
  controllers.
* Adds the relevant views used by the bubble controllers to the
  transient taskbar layout.

Bug: 253318833
Test: manual, with other CLs, see go/bubble-bar-tests
Flag: WM_BUBBLE_BAR
Change-Id: I685163cdcc912768b1a720952762f4cbc602b14b
2023-05-05 17:02:38 -07:00
Qiao Yang
1aee68df56 Merge "Revert "Revert "Listen for hover events over stashed taskbar.""" into udc-dev 2023-05-05 19:09:44 +00:00
Qiao Yang
2482c8dcd4 Revert "Revert "Listen for hover events over stashed taskbar.""
This reverts commit c27605099c.

Reason for revert: DroidMonitor-triggered revert due to breakage <https://android-build.googleplex.com/builds/quarterdeck?branch=git_udc-dev&target=cf_x86_64_phone-userdebug&lkgb=10076607&lkbb=10076982&fkbb=10076788>, bug <281093059>

Change-Id: I71e7fd07232c27a004243df0ffb0457fe53fe13b
2023-05-05 19:07:17 +00:00
Qiao Yang
51669b612f Merge "Revert "Listen for hover events over stashed taskbar."" into udc-dev 2023-05-05 18:05:16 +00:00
Pat Manning
c27605099c Revert "Listen for hover events over stashed taskbar."
This reverts commit c5882bcdfc.

Reason for revert: b/281068877

Change-Id: I431678658fc464c995df0df5e3cac5491d91b052
2023-05-05 17:22:21 +00:00
Treehugger Robot
b6f64a4465 Merge "Listen for hover events over stashed taskbar." into udc-dev 2023-05-04 23:15:44 +00:00
Pat Manning
c5882bcdfc Listen for hover events over stashed taskbar.
Bug: 243191650
Test: TaplTestsTaskbar
Flag: ENABLE_CURSOR_HOVER_STATES
Change-Id: Ia189ac6a6097d073c40c69ead6ecaf398d22eba8
2023-05-04 20:35:44 +01:00
Schneider Victor-tulias
d1054fd86b Merge "Revert "Fix broken TaplTestsTaskbar splitscreen test cases"" into udc-dev 2023-05-04 16:55:21 +00:00
Nick Chameyev
1aa2383d26 Merge "[Unfold animation] Start Launcher animation preemptively to synchronize the first frame" into udc-dev 2023-05-04 09:36:04 +00:00
Jeremy Sim
8ecacd3624 Merge "Move test to presubmit" into udc-dev 2023-05-03 17:39:35 +00:00
Nick Chameyev
705c665c06 [Unfold animation] Start Launcher animation preemptively to synchronize the first frame
Starts unfold animation in Launcher right after receiving
configuration change for the unfolded screen.
This makes sure that before we unblock the screen we
have the first frame of the unfold animation ready
in Launcher (transformations are applied).

Bug: 271099882
Test: atest com.android.systemui.unfold.util.PreemptiveUnfoldTransitionProgressProviderTest
Test: manual testing fold/unfold, checking perfetto traces
Test: test with flag enabled/disabled
Change-Id: Icb8f91f9264248600d4bed14811445f50aac99c7
2023-05-03 11:35:03 +01:00
Jeremy Sim
deda0d0c05 Move test to presubmit
testSplitAppFromHomeWithItself() has been in postsubmit for approx. 4 months with no major flakes, moving to presubmit

Fixes: 270201357
Test: Android Test Investigate reports 2/45 test failure rate
Change-Id: I13cd5bc9e0ba376ffe97e8e61ed577a51b59bdb4
2023-05-02 18:25:39 +00:00
Schneider Victor-tulias
ccddd71c88 Revert "Fix broken TaplTestsTaskbar splitscreen test cases"
This reverts commit ccc10128f1.

Reason for revert: the underlying issue will be fixed in b/279873859

Change-Id: I37d4c16bc907fd31ef983d3c6974b3376543c3ce
2023-04-27 22:48:15 +00:00
Schneider Victor-tulias
a314b0375e Merge "Fix broken TaplTestsTaskbar splitscreen test cases" into udc-dev 2023-04-26 21:33:38 +00:00
Schneider Victor-tulias
ccc10128f1 Fix broken TaplTestsTaskbar splitscreen test cases
The split tasks no longer close between test orientation changes. Updating tests to close all tasks after TaplTestsTaskbar test cases

Flag: not needed
Fixes: 279063348
Test: TaplTestsTaskbar
Change-Id: Ie654aae0a16ff495555b48f85a8dec8537086649
2023-04-26 10:15:27 -07:00
Vinit Nayak
955555a314 Merge "Support splitting from workspace with Widgets" into udc-dev 2023-04-22 03:55:23 +00:00
Vinit Nayak
fd46900b96 Support splitting from workspace with Widgets
* Need to insert widget's icon in animation
* Launching w/ same package app + widget is
broken

Test: Launched apps from predicted apps + widget,
hotseat apps + widget
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE
Bug: 276361926

Change-Id: I3e30189e56536371ebd0acfbdd2c073a882cc731
2023-04-21 14:05:12 -07:00
Jagrut Desai
c6d625b8db Exposing functionality to pin Taskbar from TaskbarDividerPopupView.
This CL allows user to long press on Taskbar divider view to bring up divider popup view. It also included functionality of allowing user to turn on always show taskbar from the divider popup view.

Test: Manual
Bug: 265436055
Bug: 265434718
Bug: 265434902
Bug: 265434705
Flag: ENABLE_TASKBAR_PINNING

Change-Id: Ied54d718483a9b06b053d68988e5c294a786002a
2023-04-20 22:04:21 -07:00
Sunny Goyal
ab2f808196 Using a runtime generated layout for tests instead of defining xml
This allows support for easily setting up default layouts

Bug: 277345535
Test: Presubmit
Flag: N/A
Change-Id: I1c089d60ac3f8add8d7e1060d343e04d30afe094
2023-04-12 22:54:14 +00:00
Brian Isganitis
3ef917a4e3 Cleanup ENABLE_TASKBAR_EDU_TOOLTIP: remove EDU sheet.
Test: Manual
Fix: 270396268
Change-Id: I3cebdb6646060cf6793e5ffc638213dde41338c0
2023-04-10 12:55:18 -04:00
vadimt
81b228a5fb Re-enabling a couple of tests
Now we have test investigators team, so we can keep the tests in the running state.
I'll monitor these tests for some time to see whether they need immediate attention.

Test: presubmit, abtd
Bug: 187761685
Change-Id: I783f6551fafb4a9f0a2c81541cb0c2a70d22ab58
2023-04-04 16:09:26 -07:00
Vinit Nayak
02f20dddb0 Merge "Default to using SplitSelectSource drawable if TaskView icon drawable is null" into tm-qpr-dev am: 8e307ba50a am: 3e5b212204
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22347415

Change-Id: I2f3da1c74ed5ae04ff9cbc4bc06e280da5390b4d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-04-03 15:54:11 +00:00
Jeremy Sim
9f0a6b8e82 App Pairs (behind flag): Add Overview menu item, icon, tests
This is the first of several patches implementing the App Pairs feature behind a flag.

This patch includes:
- The icon asset for the "Save app pair" menu option
- The menu option, which will appear in the Overview drop-down menu for split pairs
- Some tests ensuring that the menu item appears when appropriate

Flag: ENABLE_APP_PAIRS (set to false)
Bug: 274189428
Test: 2 tests in TaplTestsSplitscreen.java
Change-Id: I174f2c66e7eb6d83ff7fe501eb82cc48e727022c
2023-03-31 17:16:56 -07:00
Vinit Nayak
ecca8eacbc Default to using SplitSelectSource drawable if TaskView icon drawable is null
* Alternative solution could be to set
onTaskViewVisibilityChanged(true) for the taskView that is about
to be dismissed so it loads it's taskIcon/thumbnail back from the cache
* However, that does still leave us open to race conditions (even though
we can be reasonably confident the icon is probably in the cache)
* Also made other changes to allow already public fields on some classes
to be mockable for unit testing

Fixes: 275267738
Test: Tested with fullscreen task at end of overview,
GroupedTaskView at end of overview,
Initiating split from home,
Initiating split from overview actions,
Initiating split from overview app icon

Change-Id: Ic9059c93c07b90f61c9f418d5d36d6ba201ff96a
2023-03-30 15:26:57 -07:00
Jon Miranda
a97dc04478 Merge "Add taskbarIconSize to GridOption/DisplayOptions" into tm-qpr-dev am: 085c53869f am: 3cd39729dc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22228076

Change-Id: I3cb2d462cef1df514c87418ed70ac624899c21fd
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-24 23:02:51 +00:00
Jon Miranda
9c478b6c29 Add taskbarIconSize to GridOption/DisplayOptions
- Renamed variables to make it more clear what they represent
- DeviceProfile will be source of truth for taskbar
  sizes

Bug: 265144213
Test: phone, multi-display, tablet
Change-Id: Id9c19d15a65894fd7645e0f876a4b6527b713c34
Flag: ENABLE_TRANSIENT_TASKBAR=true
2023-03-24 12:29:11 -07:00
Jon Miranda
7953f25c3c Merge "Add spring animation when stashing transient taskbar." into tm-qpr-dev am: ba85154590 am: 9c0ad5f746
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/22178236

Change-Id: Ibec649f0c7d6181ac52e2067898fe4b0b82f01a2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-03-22 03:46:12 +00:00