Migrating the remaining `getTaskViewAt(0)` to `getFirstTaskView()`.
Flag: EXEMPT as no functionality changes
Bug: 379942019
Test: Manual
Change-Id: I083626b0ca62b88d06f508dfc15d9f64112f1a6a
- This function is going to replace all the call sites that compares
`getTaskVieCount()` and `0`.
- This is based on the fact that this count can not be a negative
number.
- Introduce `getLastTaskView()` to get the last TaskView inside the
RecentsView.
Flag: EXEMPT as no functionality changes
Bug: 379942019
Test: Manual
Change-Id: Iefb107d1aba61549a870f14c18e025c34b19a1b5
- Create TaskViewsIterator to iterate all the current TaskViews inside
RecentsView.
- Create TaskViewsIterable with TaskViewsIterator as its iterator.
- Create `mTaskViewsIterable`, an instance of TaskViewsIterable that
used to make the TaskViews iterable.
- Current `getTaskViews()` return `mTaskViewsIterable` directly.
- Change `getTaskViews()` to be a public function, thus it can be
used outside of the RecentsView.
Some follow-up work includes:
- Replace all the call sites of `getTaskViewAt(0)` with
`getFirstTaskView()`
- Replace `0` as the index of the first TaskView with
`getFirstTaskViewIndex()`
- Audit all the call sites of iterating the TaskViews, let them use
`getTaskViews()` or IterableTaskViews.iterator() if index is needed.
Flag: EXEMPT as no functionality changes
Bug: 379942019
Test: Ensure the TaskViews required are correct in the following
scrnarios:
1. Swiping up from home screen to enter overview with empty or
multiple tasks
2. Swiping up from a fullscreen app to enter overview with
one or multiple tasks
3. Dimissing one or multiple tasks, exit and enter overview w/o
newly opened tasks
4. Remvoing all the tasks, reenter overview w/o newly opened
tasks
Change-Id: I930ce92b7e0bc37005af74a58fd4c0ce3013e5cb
Add a member property `mTaskViewCount` inside the RecentsView to track
the number of TaskView inside it. Its value will be increased
`onViewAdded` and decreased `onViewRemoved`.
- Then `getTaskViewCount()` can just return this variable directly.
- Invalidate the `PagedView.mPageScrolls` on a view addition and
removal util they have been updated on next `onLayout`. This is done
to guarantee that `mOnPageScrollsInitializedCallbacks` is run with
up to date `mPageScrolls`.
Flag: EXEMPT as no functionality changes
Bug: 379942019
Test: Tested on Tangor, ensure `mTaskViewCount` is correct in the
following scenarios:
1. Adding more tasks and enter overview
2. Dismissing one and more tasks
3. Dismissing all tasks
Change-Id: I32407e77dd2a9b3d8200efc334c1eadea1336b31
While splitting focus task, there is a timing issue of focus task being animated first and then small tiles.
This CL fixes that makes animation smooth i.e. animate stage task(focus task) and other small tiles together.
Also refactored animationStartProgress and animationEndProgress initialisation by adding "if/else" for readability.
Test: Manual.Split focus task.(RTL as well)
Fix: 383417963
Flag: com.android.launcher3.enable_large_desktop_windowing_tile
Change-Id: I7b8c651d91168802b930fdeac62e762a2be9dbe9
This reverts commit 09603bfb39.
Reason for revert: Launcher icons are sometimes not visible during the back-to-home animation when immediately swiping back after opening the app.
Change-Id: I13869cf755160986e323365a460f6ebe128008a9
* changes:
Update LauncherSwipeUpHandlerV2Test setup to account for RecentsWindowFactory
Update TaplTestsQuickstep to expect recents window states when enabled
Test: manual. Verified haptics play when MSDL flag is on.
Test: manual. Verified haptics played from the history of the
MSDLWrapper via adb dumpsys
Flag: com.android.launcher3.msdl_feedback
Bug: 376283547
Change-Id: I66c9c712141a7b618cc8b4ca995e1475e21b377b
Remove and merge the usage of the enableBubbleBarInPersistentTaskBar
flag to the enableBubbleBar flag.
Bug: 383181643
Flag: com.android.wm.shell.enable_bubble_bar
Test: NONE - removed and merged flag usage.
Change-Id: I4f131e1ddf8367425b91c8fb597857ee222b75d8
Bug: 381054861
Test: Manual, i.e. verify that tapping the taskbar while predictive back is in progress does not cancel or commit it
Flag: com.android.window.flags.predictive_back_three_button_nav
Change-Id: I4117aca74216849519a0cabcbd3cb14f7fc5b38f
Bug: 382453424
Test: Manual, i.e. tested back-to-home and back-to-allapps animation on phones, tablets and foldables, including interruptions.
Flag: EXEMPT bugfix
Change-Id: Iece001b6b9edd9ca7a909e3ccbe8ebdff2e71d9f
Bug: 381317629
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Performance tests
Test: Open single, split and desktop tasks with flag combinations for TTV refactor and app chip.
Change-Id: Ie43955ddf6c9fac162974077a37e8448c5ef1781
* changes:
Move recents divider if hotseat is set after recents.
Animate out/in the correct task view when recents change.
Implement initial LayoutTransition for Taskbar recents.
Changes saveAppPair to take a general number of apps, rather than just 2. At the moment, this will not change anything, since GroupedTaskViews are still hard coded to contain 2 apps.
Bug: 349828130
Flag: com.android.wm.shell.enable_flexible_split
Test: No effect on behavior, just a small refactor.
Change-Id: I6f86210ab4662f0d3a8fba1f6bb6fd78391e7fa2
- Introduce a function `getFirstTaskView()` in RecentsView to get the
first TaskView inside RecentsView.
- Replace `getTaskViewAt(0)` with this newly introduced function.
- Let `RecentsView.isTaskInExpectedScrollPosition()` accept a TaskView
instead of index of the TaskView. This can avoid using the index at
the callsites of this function.
- Change `getTaskViews()` to be a public function, thus it can be
used outside of the RecentsView.
Flag: EXEMPT as no functionality changes
Bug: 379942019
Test: Ensure the TaskViews required are correct in the following
scrnarios:
1. Swiping up from home screen to enter overview with empty or
multiple tasks
2. Swiping up from a fullscreen app to enter overview with
one or multiple tasks
3. Dimissing one or multiple tasks, exit and re-enter overview
w/o newly opened tasks
4. Remvoing all the tasks, re-enter overview w/o newly opened
tasks
Change-Id: If63ad6dc9f5106be08d867090fdaf616117dcd82
Fixes a bug where updateItems is first called with recents and then with hotseat. This causes the Taskbar to first be All Apps, Divider, and then Recents. The layout transition path assumes though that the Divider after All Apps is not for recents in this case, which is wrong. Due to this assumption, it skips over the divider and then adds the hotseat items after it (should be added before). Added a test for this case.
Flag: com.android.launcher3.taskbar_recents_layout_transition
Bug: 343521765
Test: go/testedequals
Change-Id: Ia690c71fe482709e35ab302a7b497bf547eb4478
The animations mostly match the spec, though the recents indicators scale/fade with icon currently.
The change transitions need to incorporate translateX since that changes based on the number of icons in Taskbar. We need the translateX for pinning update to happen before TaskbarView lays out its children so that the animator computes the correct start and end values.
Flag: com.android.launcher3.taskbar_recents_layout_transition
Bug: 343521765
Test: go/testedequals
Change-Id: I13aa49abf80ddc09fab890f78bde924a8f7f1d6e
Adds a step to verify that TaskbarOverflowView items get set to the list
of the least recent tasks. Adds test cases for an edge case where
taskbar hits max number of items event without recent tasks
(b/379774843).
Has a fix for a further edge case where taskbar overflow view could be
created with a single item (in which case we can just show that item
directly).
Bug: 379774843
Flag: com.android.launcher3.taskbar_overflow
Test: atest TaskbarOverflowTest
Change-Id: I004676da3e17f26b8110d14d39589c84a9f384d8
Test: Built and ran locally
Flag: com.android.launcher3.enable_fallback_overview_in_window
Bug: 379746094
Change-Id: Ic48b4ef2471a3d6d5eb2e9bacdf00e7d71a87778
