Commit Graph

4112 Commits

Author SHA1 Message Date
Alex Chau
6d00b4b014 Read task size info from RecentsView directly
- Automatically determine the Overivew component to use the correct RecentsViewContainer
- Also added log on both pre-computed taskSize and newly calculated task size

Bug: 336660988
Test: presubmit
Flag: TEST_ONLY
Change-Id: Ic0adfba35af513e731007241416fc85760135f07
2024-08-20 10:56:52 +01:00
Alex Chau
d326e17fe2 Add logs for getFocusedTaskHeightForTablet
Bug: 336660988
Bug: 360724626
Test: presubmit
Flag: TEST_ONLY
Change-Id: I67d4fc8211f24b77566bd24525d23054dfdded6e
2024-08-19 20:39:41 +01:00
Shamali Patwa
accd0f68c8 Merge "Update the scale on corner radii on scaled image drawable." into main 2024-08-16 20:37:57 +00:00
Treehugger Robot
a21058eb88 Merge "Move TouchEventGenerator to multivalent" into main 2024-08-16 06:04:22 +00:00
Shamali P
c7e1b5c975 Update the scale on corner radii on scaled image drawable.
The RoundedDrawableWrapper applies rounded corners on each draw, so,
on scaling, the corners look odd for small widgets.

This change, applies the same scale to corner radius as well.
There are some widgets whose preview images have embedded transparency,
but we don't do much for such previews.

Bug: 359860747
Test: Manual
Flag: EXEMPT bugfix
Change-Id: I5e58e29765503454f286d99050b13b497531d306
2024-08-15 02:54:17 +00:00
Andrew Cole
d61fbd4140 IconCacheUpdateHandlerTest
This is the unit testing for the updates to IconCacheUpdateHandler

Bug: 357725795
Test: SELF
Flag: TEST_ONLY
Change-Id: I159f5ef70fcc9a5aae7bb319f06a3ff935f28246
2024-08-14 15:57:42 -07:00
Sihua Ma
97ed80634d Move TouchEventGenerator to multivalent
Test: atest NexusLauncherRoboTests
Flag: TEST_ONLY
Change-Id: I6603b4764de6708cb0c3d7c2a52c0ffb81607771
2024-08-14 21:17:44 +00:00
Treehugger Robot
28cbc13413 Merge "Ensure that inactive archived icons in the folder preview are not shown as grey pending icons" into main 2024-08-13 22:19:44 +00:00
Charlie Anderson
08a0a65fca Ensure that inactive archived icons in the folder preview are not shown as grey pending icons
Bug: 350758155
Test: manually verified + PreviewItemManagerTest
Flag: com.android.launcher3.use_new_icon_for_archived_apps
Change-Id: Ic378c4f840ce05ecbcbbc3f4f57087c9acd7c1f5
2024-08-13 13:01:18 -04:00
Uwais Ashraf
d39bc803c7 Merge "Improve performance of thumbnail retrieval - hot taskData flow" into main 2024-08-13 10:59:32 +00:00
Uwais Ashraf
60b62d734d Improve performance of thumbnail retrieval - hot taskData flow
Bug: 357542209
Test: TasksRepositoryTest, manual with reduced speed video
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: Ie94daf61d8e41c4b9c12d67f5f45166104879325
2024-08-12 16:49:24 +00:00
Treehugger Robot
50051adcc1 Merge "Revert AllAppsRecyclerViewPoolTest.kt" into main 2024-08-09 23:01:49 +00:00
Fengjiang Li
6554ab99e3 Revert AllAppsRecyclerViewPoolTest.kt
Manual revert of ag/28323761, will add it back after confirming preformance test regression has been resolved.

Fix: 354560500
Test: Revert of test
Flag: NONE
Change-Id: Ibc9ec7a641c7df80ac5a7f08933dadfdf0b8d1e6
2024-08-09 13:06:52 -07:00
Anushree Ganjam
3f6412e50d Merge "Remove debug logs" into main 2024-08-08 23:19:39 +00:00
Charlie Anderson
72c5d8ffde Merge "Use DoubleShadowIconDrawable to draw shadow behind archived cloud icon" into main 2024-08-08 17:38:51 +00:00
Treehugger Robot
3307f87b82 Merge "Implement e2e test for desktop windowing" into main 2024-08-08 11:32:10 +00:00
Alex Chau
1ceac5ddfe Implement e2e test for desktop windowing
Code changes:
- TaskView, GroupedTaskView and DesktopTaskView now uses different resId, so it can be differentiated by TAPL
- Extracted result handling of icon loading, so we can override in DesktopTaskView
- DesktopTaskView now load icons, so titleDescription can be loaded. When icons are loaded, contentDescription are applied to respective snapshotViews; icon unloading is ignored
- Track launchDesktopFromRecents and composeRecentsLaunchAnimator in TAPL events so we can test if the TaskView launch path is correct

Test changes:
- Added TaplTestsOverviewDesktop that move 2 TestActivities into Desktop, and launch the DesktopTaskView as static and live tile
- TaplTestsOverviewDesktop is limited to Tangor/cf_tablet only, and added LimitDeviceRule to AbstractLauncherUiTest to enable @AllowedDevices and @IgnoreLimit

TAPL changes (2 APIs added/modified):
- Changed TaskView matcher to use id/task_view_* to match all TaskView types
- When Overview is launcehd from Background, mark the currentTask after the launch as liveTile. When an OverviewTask has the same accessibility node as the liveTile, it'll expect different event when launching.
- [API change] BaseOverview.getTestActivityTask can now matches mutiple test activiites, useful for matching GroupedTaskView and DesktopTaskView; Fix a bug that getTestActivityTask wrongly use `getParent()` which is RecentsView to match activityName.
- In OverviewTask.open, we'll expect different events based on TaskView types and whether it's a live tile. Launching DesktopTaskView will in additional verify Desktop header is present on screen.
- [API change] In OverviewTaskMenu, support tapping Desktop menu and verify Desktop header is present on screen.
- Removed unused OverviewTaskMenuItem

Fix: 320313527
Test: TaplTestsOverviewDesktop
Flag: com.android.window.flags.enable_desktop_windowing_mode
Change-Id: I89261c787364901320f3acb18f01ddad5f62d17c
2024-08-08 10:37:40 +01:00
Anushree Ganjam
5c4ea5b0ca Remove debug logs
Bug: 339737008
Test: Manual
Flag: TEST_ONLY
Change-Id: I8177fc721f330267bc20abf6e7d587289e45477b
2024-08-07 14:08:10 -07:00
Jordan Silva
3645e88ae5 Merge "Add Jetpack Compose for Launcher3 and Quickstep behind a build flag (2/3)" into main 2024-08-07 17:08:39 +00:00
Charlie Anderson
99147f53e0 Use DoubleShadowIconDrawable to draw shadow behind archived cloud icon
- Refactor Launcher3 ShadowInfo out of DoubleShadowBubbleTextView

Bug: 350758155
Test: locally verified + screenshot test
Flag: com.android.launcher3.use_new_icon_for_archived_apps
Change-Id: I8e5e5936296fafbfbf3caf80a936ca1038c125e3
2024-08-07 11:56:33 -04:00
Jordan Silva
4afa195b5b Add Jetpack Compose for Launcher3 and Quickstep behind a build flag (2/3)
This CL adds a Soong build flag in Android.bp files to enable Compose code when building Launcher.
The flag is disabled by default, and it will be enabled once agreed with the System Health team. More details in go/launcher-enabling-compose-next-steps.

To turn this flag on, one simply has to `build-flag set RELEASE_ENABLE_COMPOSE_IN_LAUNCHER true` before compiling.

- When the flag is enabled, Launcher3 will use a ComposeFacade object that provides features implemented using Compose. This Facade also provides a function to check whether Compose is enabled or not.
- When the flag is disabled, Launcher3 will implement a ComposeFacade object that throws an exception if a feature using Compose is requested. Thus, it is important to always check isComposableAvailable function before requesting a Compose feature.

Bug: 346288480
Test: Builds
Flag: EXEMPT Build flag: RELEASE_ENABLE_COMPOSE_IN_LAUNCHER
Change-Id: I5f2703f74960aeb104d0386ed3ef49784ed85234
2024-08-06 18:47:22 +01:00
Sebastián Franco
99a76f1f64 Merge "Convert testing classest to Kotlin" into main 2024-08-06 00:21:18 +00:00
Fengjiang Li
77be7410c3 Merge "Fix jank regression from AllAppsRecyclerViewPoolTest" into main 2024-08-05 23:17:22 +00:00
Fengjiang Li
ce638d69b7 Fix jank regression from AllAppsRecyclerViewPoolTest
Unit test ag/28323761 delays the preInflationCount check after creating ActivityContext on main thread, thus causing jank regression. This CL is a forward fix.

Fix: 354560500
Flag: NONE - jank fix
Test: Presubmit
Change-Id: I0e91dd765f1805b98895ce90804ec187e50285b4
2024-08-05 09:39:05 -07:00
Charlie Anderson
6b8e362247 Adds new bugfix flag for using new app archiving icon
Flag: com.android.launcher3.use_new_icon_for_archived_apps
Bug: 350758155
Test: locally
Change-Id: I7bacbacd85a8216e7975665e6d3c1ab98ed23235
2024-08-05 00:37:28 -04:00
Charlie Anderson
e5ace06d81 Merge "Reapply "Handles Bold Text setting for inline icon by providing bolded cloud icon"" into main 2024-08-05 04:24:32 +00:00
Sebastian Franco
ce4446c469 Convert testing classest to Kotlin
Bug: 324261526
Test: ImageTest
Test: FolderTest
Test: IntegrationReorderWidgets
Flag: TEST_ONLY
Change-Id: Ieb4e451cc44656fc98d87163203eaae379ec0512
2024-08-02 12:53:14 -07:00
Charlie Anderson
fe23e711fd Reapply "Handles Bold Text setting for inline icon by providing bolded cloud icon"
This reverts commit 00fb1adab4.
Also fixes test applyIconAndLabel_setsImageSpan_whenInactiveArchivedApp.

Bug: 350758155
Fixes: 356166053
Test: unit test
Flag: com.android.launcher3.enable_new_archiving_icon

Change-Id: I93f2ac47dc3a8fa81d59e0f089385d2b3fe93306
2024-08-02 17:26:02 +00:00
Shamali Patwa
b74b05336c Merge "Fix the getWidgetsByPackageItem method to return a copy" into main 2024-08-01 21:59:28 +00:00
Sihua Ma
7eaf24840d Merge "Add unit test for LauncherAppWidgetHost" into main 2024-08-01 20:26:40 +00:00
Shamali P
74862f990b Fix the getWidgetsByPackageItem method to return a copy
Bug: 356545910
Fix: 356545910
Test: Unit test
Flag: EXEMPT BUGFIX
Change-Id: I90429983733eb5f2bb2d6df00799d2445eaeea31
2024-08-01 18:56:41 +00:00
Vadim Tryshev
37538d64e5 Merge "Clearing package data as recommended by owners of the "pm clear" command" into main 2024-08-01 17:22:46 +00:00
Treehugger Robot
01a1169d57 Merge "Revert "Handles Bold Text setting for inline icon by providing bolded cloud icon"" into main 2024-07-31 16:47:15 +00:00
Charlie Anderson
00fb1adab4 Revert "Handles Bold Text setting for inline icon by providing bolded cloud icon"
This reverts commit 114e84908f.

Reason for revert: b/356166053

Change-Id: I30dfbc5da1caecd89b4b23aafe4de8e9efede6a0
2024-07-31 14:08:16 +00:00
Vadim Tryshev
9fc3734030 Clearing package data as recommended by owners of the "pm clear" command
Bug: 353541583
Test: running on abtd
Flag: NONE test change
Change-Id: I227eb145f5c2fa5c07972bae15fb66e69e623dd8
2024-07-31 00:50:00 +00:00
Treehugger Robot
779c79129b Merge "Fix grid migration item copy bug" into main 2024-07-30 20:19:19 +00:00
Brandon Dayauon
dfb1722afc Merge "Make a dummy view at the bottom of all apps" into main 2024-07-30 20:15:26 +00:00
fbaron
5ff84328f0 Fix grid migration item copy bug
When migrating from a grid with 2+ copies of the same item to a grid that has less copies of that item, but more than 0, the extra copies don't migrate to the new grid.

Bug: 354946925
Test: ValidGridMigrationUnitTest
Flag: EXEMPT bugfix
Change-Id: I76ad0cb0f5abe9b5bf895c07467fc05986e9fea4
2024-07-30 10:11:58 -07:00
Treehugger Robot
6a8f5ecced Merge "Revert "Add debug logs to BaseOverview#isActionsViewVisible"" into main 2024-07-30 17:07:14 +00:00
Tracy Zhou
06483e97fd Merge "Fix tapl test failures from enabling task bar on the phones" into main 2024-07-30 16:36:03 +00:00
Schneider Victor-tulias
533e1d2753 Revert "Add debug logs to BaseOverview#isActionsViewVisible"
This reverts commit 11eaec69f4.

Reason for revert: debug logs no longer needed

Change-Id: If0b2f33c63c86483e4d28df79086e80103fdb001
2024-07-30 14:44:46 +00:00
Brandon Dayauon
4a024c0834 Make a dummy view at the bottom of all apps
This is so that user can scroll all the way to bottom of all apps.
- updated tests to account for this new view

bug:340936636
Test manually:
before:https://drive.google.com/file/d/18mKMAedQh2uUOR2G4U_ZORIKP2tkRmEk/view?usp=sharing
after:https://drive.google.com/file/d/1UEl3kBfeInqxsgF2HwCfzOBEcsEqdbJ4/view?usp=sharing
Flag: NONE addingViewToBottomOfAllApps

Change-Id: Ib4b67a66cfc7ec2ba0dbbe211a241f244d204aaf
2024-07-29 14:58:25 -07:00
Tracy Zhou
8a4213b786 Fix tapl test failures from enabling task bar on the phones
https://android-build.corp.google.com/test_investigate/?invocationId=I33800010300127205&testResultId=TR49729385401905444

Bug: 355971327
Test: run tapl tests
Flag: com.android.wm.shell.enable_taskbar_on_phones
Change-Id: Iab463b0a439efd3e707384ca4c6588a1de28d7b9
2024-07-28 10:18:19 -07:00
Charlie Anderson
114e84908f Handles Bold Text setting for inline icon by providing bolded cloud icon
Bug: 350758155
Test: locally tested + unit tests
Flag: com.android.launcher3.enable_new_archiving_icon

Change-Id: I6e1fccbb7c8cb87a7e2675a60b05bf0cb402acf2
2024-07-26 11:17:39 -04:00
Brandon Dayauon
0ffb2d5530 Merge "Create floatingMaskViewTest and make FloatingMaskView testable." into main 2024-07-25 05:00:46 +00:00
Brandon Dayauon
a616e79764 Create floatingMaskViewTest and make FloatingMaskView testable.
bug: 354209068
Test: presubmit locally
Flag: NONE writing test for floatingmaskview
Change-Id: I90cbed18a908279365af185330fb2dc1e747ebff
2024-07-24 15:32:36 -07:00
Shamali Patwa
b4d185e3cc Merge changes from topic "popup-refactor" into main
* changes:
  Delete the unused code from popup provider
  Update references that read popup data provider to use picker provider
  Update references that wrote widget data to popup data provider
  Move widget related listeners to widget picker data provider
  Define widget picker data provider separate from popup provider
  Create a separate class for widget related methods from popup provider
2024-07-24 18:46:35 +00:00
Kevin Lim
5ca6219003 Merge "[UniversalSearchInput] Support search box dynamic height adjustment in ActivityAllAppsContainerView" into main 2024-07-24 16:10:16 +00:00
Sebastián Franco
0c852e6bdd Merge "Ignoring flaky tests" into main 2024-07-24 06:31:35 +00:00
Sebastian Franco
6d1728bbdd Ignoring flaky tests
Bug: 353965234
Test: CellLayoutMethodsTest
Flag: TEST_ONLY
Change-Id: I831861febe78f5eda873cc924d2dde8a09e49518
2024-07-24 02:46:29 +00:00