Commit Graph

17895 Commits

Author SHA1 Message Date
Charlie Anderson
6c4dde2c4d Merge "Adds a legacy flag to enable Launcher BR metrics." into main 2024-01-05 01:32:11 +00:00
Sunny Goyal
1a8f804195 Merge "Removing ENABLE_CACHED_WIDGET since we now have always listenign widget" into main 2024-01-05 00:02:54 +00:00
Charlie Anderson
a4240c72c0 Adds a legacy flag to enable Launcher BR metrics.
This is necessary because the aconfig flag requires reboot to enable, however backup/restore happens on the first load so the flag will not be ready.

Flag: LEGACY ENABLE_LAUNCHER_BR_METRICS TEAMFOOD
Test: compilation / presubmit
Bug: 305984208
Change-Id: Ida90b1bd485fb037ebf3dde7ad17bf4e462661e6
2024-01-04 17:40:51 -05:00
Johannes Gallmann
852a70f994 Merge "Hide app icon during predictive back to home" into main 2024-01-04 19:39:05 +00:00
Tony Wickham
97e6c9c214 Merge "Fix KI in test and re-enable for postsubmit." into main 2024-01-04 17:50:35 +00:00
Sunny Goyal
4df719a1e6 Removing ENABLE_CACHED_WIDGET since we now have always listenign widget
> Also using PendingWidgetView for deferred widget view

Bug: 270395008
Flag: LEGACY ENABLE_CACHED_WIDGET enabled
Test: Exising widgets tests pass.
      Verified UI by forcefully rendering deferred widget

Change-Id: Id34f89d778f9f993c1b7ad13f66e57fda9843417
2024-01-04 09:26:10 -08:00
Jordan Silva
873d49937c Merge "Add ESCAPE key to dismiss Overview" into main 2024-01-04 14:12:28 +00:00
Jordan Silva
9878a7206e Add ESCAPE key to dismiss Overview
This CL adds the functionality of escape key to Overview. It dismisses Overview when the esc key is pressed.
When Overview is showing a Modal Task, it will return to Overview state instead of the Normal state.

Fix: 315283507
Flag: N/A
Test: TaplTestsQuickstep
Change-Id: I02e02f623d9a4aad1c2d6188fdea4e3fc4f96d64
2024-01-04 09:08:44 -03:00
Vinit Nayak
e4b5ab6523 Merge "Null out launcher reference to prevent leak" into main 2024-01-04 00:59:28 +00:00
Tony Wickham
c5d4e4dcf5 Fix KI in test and re-enable for postsubmit.
- The taskbar stashing logic with hardware keyboards was different
  between tests and user experience; aligned the test to be the
  same.
- There is still a previous test failure that only occurred in
  post submit, so also add ScreenRecord to diagnose it
- Once that is resolved, can promote the test to PRESUBMIT.

Test: testQuickSwitchToPreviousAppForTablet
Flag: NA
Fixes: 318544733
Bug: 314873201
Change-Id: Ia813eb0294d759c40d90cec7a8e9a7e0aea2d917
2024-01-03 23:27:18 +00:00
Vinit Nayak
e363a611d2 Null out launcher reference to prevent leak
Bug: 314806687
Flag: None
Test: Enabled flag and played with taskbar/home transitions,
seemed fine

Change-Id: I86ab417eccf1fd6255195025890a1b93bf5d3bb4
2024-01-03 15:08:47 -08:00
Tracy Zhou
e1c3332532 Merge "Correct contextual button width, height and touch area" into main 2024-01-03 21:11:24 +00:00
Vadim Tryshev
6741d1affc Ignoring testQuickSwitchToPreviousAppForTablet
It fails on some targets

Test: presubmit
Flag: N/A
Bug: 318544733
Change-Id: Ia6e34f81942b3e911b637cd66eae4362e633eee5
2024-01-03 12:58:57 -08:00
Helen Cheuk
df20ea0ed4 Merge "Update BubbleTextView height to match parent so focus outline drawn could be fully displayed" into main 2024-01-03 18:38:29 +00:00
Vadim Tryshev
943843a239 Merge "Re-promoting some tests to postsubmit" into main 2024-01-03 18:25:59 +00:00
Sunny Goyal
05dc6db762 Merge "Fix launcher holds a surfaceController" into main am: 4b48398352 am: 507cccdb17 am: cb1fc471bb
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2891611

Change-Id: Ib1b0eae5c1664f202312109da2391a250607108b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-03 17:59:03 +00:00
Sunny Goyal
cb1fc471bb Merge "Fix launcher holds a surfaceController" into main am: 4b48398352 am: 507cccdb17
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/2891611

Change-Id: I5a9c74659439b1dd04e124f9191796bc348d97f6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-01-03 17:25:19 +00:00
Jagrut Desai
39e4b611b5 Merge "Refactor TaskbarDividerPopup Open/close animation" into main 2024-01-03 17:00:52 +00:00
Johannes Gallmann
436b9939e3 Hide app icon during predictive back to home
Bug: 311337169
Flag: ACONFIG com.android.systemui.predictive_back_qs_dialog_anim DEVELOPMENT
Test: Manual, i.e. testing predictive back to home on device and verifying visually that app icon behaves correctly
Change-Id: I91491d91d004d81f4abc67c361c8824eba8dfdcd
2024-01-03 16:45:16 +01:00
Sergey Pinkevich
638ee17821 Select task is broken on display large size
The update of the focus task overlay should be at last, cause otherwise the first time the "Select" button doesn't work - the text is not highlighted.

Also, we need to update pivot of the selected task only if there is a grid overview enabled. Otherwise the bug is still reproducible on Felix.

Bug: 305125147
Flag: NONE
Test: Manual (both on Tangor and Felix in Portrait/Landscape mode with small/medium/large Display size)
Change-Id: Id928cee0949b9124aeb27cc8210a53993e72ba19
2024-01-03 14:44:12 +00:00
helencheuk
2174b0ad2e Update BubbleTextView height to match parent so focus outline drawn could be fully displayed
Design doc: go/launcher-focus-outline
Before: BubbleTextView height is larger than its parent, outline is cropped
https://screenshot.googleplex.com/dYXjWAHS4VzPQdJ
After: BubbleTextView has the same height as its parent Prediction Row, outline is fully shown
https://screenshot.googleplex.com/3eMxPwxiHs9JTTq

Bug: 310953377
Test: Manual
Flag: ACONFIG com.android.launcher3.enable_focus_outline Development
Change-Id: I7bfa4da3b67b4a4abc4dfe9df560dda8d7e9b1bd
2024-01-03 12:14:25 +00:00
Tracy Zhou
650000f68f Correct contextual button width, height and touch area
Side note: this is unrelated to NearestTouchFrame

Bug: 313371759
Bug: 230395757
Test: https://screenshot.googleplex.com/6mF4ZPSob6z55Nh
Change-Id: I7e5217bef4b2cfb6d14d62d107e75b1267ffd2f4
2024-01-02 23:05:53 -08:00
Riddle Hsu
78611ea4ca Merge "Reduce redundant IPC when switching app by navigation bar" into main 2024-01-03 06:30:44 +00:00
Tracy Zhou
9742e603b5 Merge "Adjust the layout of nav buttons in 3 button mode with task bar / nav bar unification" into main 2024-01-03 00:12:56 +00:00
Jagrut Desai
25cb918a37 Refactor TaskbarDividerPopup Open/close animation
Test: Manual
Bug: 315848479
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED
Change-Id: I3c43bd718cef24ec334f7f4884167ecb2ce0cfd5
2024-01-02 15:25:42 -08:00
Tracy Zhou
5ad10ff6f6 Adjust the layout of nav buttons in 3 button mode with task bar / nav bar unification
In nav bar, we assign layout weight 0.25:0.5:1(for home but the content width of home is set to 80dp):0.5:0.25 with a LinearLayout. Since we use a FrameLayout for taskbar (to support both folded and unfolded task bar), in this change we are matching the layout by manually calculating the width of each section (since we are already manipulating like so in different layoutters)

Bug: 230395757
Test: https://screenshot.googleplex.com/3P6vDrgb6geqTUm
Change-Id: I6ba201477621f173e42c5211fcc68b24e3022122
2024-01-02 14:34:51 -08:00
Vadim Tryshev
5cc6b2ba52 Re-promoting some tests to postsubmit
Excluding TaplDragTest#testDragToFolder, which is failing on some devices

Will watch their stability; may further promote to presubmit

Bug: 187761685
Test: presubmit, abtd
Flag: N/A
Change-Id: I6fd9a6fb315dc9ab7bcac788edfac95cc3e9b93f
2024-01-02 13:14:08 -08:00
Hyunyoung Song
0c2204dcbe Merge "Fixing UserHandle for AppTarget Event from Launcher." into main 2024-01-02 18:22:18 +00:00
Yunfan Chen
2c385bec7b Merge "Do not recreate taskbar due to unestimated bounds" into main 2023-12-28 11:09:16 +00:00
Bill Yi
f68aedbd86 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2023-12-27 22:16:51 +00:00
Saumya Prakash
664375d43a Merge "Ensure the back gesture tutorial icon renders correctly for RTL" into main 2023-12-27 21:35:13 +00:00
Bill Yi
78941bd1a9 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Iee5a6456177dc64115c3de5d651b7a9aca0ff36d
2023-12-26 17:27:33 -08:00
Riddle Hsu
894c17c87b Reduce redundant IPC when switching app by navigation bar
In SplitScreenController#onStartingSplitLegacy, it also ignores:
if (ENABLE_SHELL_TRANSITIONS) return null;

This avoids a latency from the 2-way IPC in
RecentsAnimationListener#onTasksAppeared.

Bug: 275508603
Test: Capture trace when switching app by quickstep.

Change-Id: Ia11cbca0d38cdc2bfd676dfa3d59a5c8931a2d6e
2023-12-22 20:14:31 +08:00
chuanghua.zhao
5a6161d928 Fix launcher holds a surfaceController
When the dark night mode switch is triggered,systemui calls binder
to the onNavigationBarSurface method in the launcher and applies the
surfaceController.
Keep switching,you will keep applying,resulting in more surface
objects. The behaviour would cause that SurfaceFlinger couldn't
remove the unnecessary navigationbar layers timely and the
navigationbar layer would leak in SF.

Actively release the SC after using the SC in the launcher.

Bug: 317336417
Test: 1.Launch the settings app
      2.Click Display menu
      3.click the dark theme menu multiple times
      4.Check whether the surfaceController is released
      adb shell "ls -l/proc/904/fd|wc -l"

Change-Id: Ic449de9dbe0c52e0053be91e67ee9081a574581b
2023-12-22 13:04:41 +08:00
Tony Wickham
2ad9d442a4 Merge "Update live tile during dismiss anim even if disabled at start" into main 2023-12-21 22:58:02 +00:00
Saumya Prakash
4f0c2ec9b7 Ensure the back gesture tutorial icon renders correctly for RTL
This change adds RTL support for the back gesture icon on the main menu
of the gesture tutorial menu. In RTL mode, it was previously rendering
in the middle of the screen.

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fix: 309564541
Test: ran the tutorial in RTL mode in different form factors.
Change-Id: I24def01ed205355ced23060068ddd74af61134ab
2023-12-21 21:33:53 +00:00
Liran Binyamin
0d09a45e40 Merge "Handle recreate_taskbar in QuickstepTestInformationHandler" into main 2023-12-21 15:40:03 +00:00
Johannes Gallmann
5714801784 Merge "Fix statusbar appearance during predictive back to home by fling" into main 2023-12-21 08:05:21 +00:00
Johannes Gallmann
ccff1b84ea Merge "Fix NullPointerException in LauncherBackAnimationController" into main 2023-12-21 08:04:42 +00:00
Jeremy Sim
227d3b79f3 Merge "Ignore taskbar launch request if app(s) are already running" into main 2023-12-21 07:00:27 +00:00
Yunfan Chen
f00adbeb68 Do not recreate taskbar due to unestimated bounds
The change around configuration and display cutout to support flexible
display setup is making the received display info is not calculated as
the hard-coded way in taskbar. It will cause the taskbar recreated when
the device reaches a given rotation for the first time.

The recreation is not necessary as it is only a hint of taskbar's
estimation doesn't match the result. Block the recreation in that case
to avoid user visible animation issue.

Bug: 302387383
Test: Rotate a device with movable cutout and no recreation happens
Flag: ACONFIG com.android.window.flags.allows_screen_size_decoupled_from_status_bar_and_cutout TRUNKFOOD
Flag: ACONFIG com.android.window.flags.movable_cutout_configuration DEVELOPMENT
Change-Id: I1aa6add57ec49a49cc7473bfaada6d9212c1fc4b
2023-12-21 14:35:20 +09:00
Jeremy Sim
9a7b6f972b Ignore taskbar launch request if app(s) are already running
This CL fixes several issues:
- When launching an app pair on top of the exact same app pair, Overview no longer enters a broken state
- When launching another app quickly after launching an app pair, splitscreen no longer breaks

Fixes: 315190686
Test: Launch app pair and then launch same app pair again from Taskbar -- Overview does not break
Flag: ACONFIG com.android.wm.shell.enable_app_pairs DEVELOPMENT
Change-Id: I0d474dd89359e1a10a881c5cf8deee64754219c3
2023-12-21 10:13:20 +09:00
Shamali Patwa
716f982d44 Merge "Add long click listener to the widget picker activity" into main 2023-12-20 22:39:57 +00:00
Brian Isganitis
4227a72c94 Merge "Have meta key toggle Taskbar All Apps in freeform mode." into main 2023-12-20 21:00:01 +00:00
Pat Manning
d842f5e573 Merge "Hide taskbar icons for IME when virtual keyboard is present." into main 2023-12-20 20:11:43 +00:00
Tony Wickham
bd29dde623 Update live tile during dismiss anim even if disabled at start
Before we only checked if live tile drawing was enabled at the
start of the dismiss animation, and didn't add the frame callback
listener at all if not. Now we always add the frame callback
listener when dismissing the running task, and check if live tile
drawing is enabled within the listener in case there is a race.

Fixes: 312261719
Test: Swipe up to Overview from an app, immediately swipe up to
dismiss the app; ensure it always follows your finger
Flag: None

Change-Id: Ia12b02d5989c09d2104edd202f8c016f202f76b8
2023-12-20 19:58:28 +00:00
Brian Isganitis
588b78e174 Have meta key toggle Taskbar All Apps in freeform mode.
Test: Manual
Fix: 315245851
Flag: NA
Change-Id: Ie72f2f48ed21e85fc3b3f707cfd91023ebe79a7c
2023-12-20 19:42:19 +00:00
Pat Manning
559434af5a Hide taskbar icons for IME when virtual keyboard is present.
Unless hardware keyboard is attached and taskbar is pinned.

Fix: 316270741
Bug: 255818649
Test: Manual. Using combinations of transient taskbar, virtual and hardware keyboards.
Flag: NONE
Change-Id: I1fae1655fc16b9fa951510cf834d2a33cb8956d8
2023-12-20 18:55:09 +00:00
Federico Baron
1abb9a47b4 Merge "Align QSB with hotseat and workspace icons" into main 2023-12-20 17:36:12 +00:00
Johannes Gallmann
9d446d1842 Fix statusbar appearance during predictive back to home by fling
Bug: 317218355
Flag: ACONFIG com.android.window.flags.predictive_back_system_animations DISABLED
Test: Manual, i.e. verifying statusbar appearance during back to home
Change-Id: I158d4d26bd262337eb3dd09e56c1999935e9788b
2023-12-20 17:37:02 +01:00