Let `isGestureBlockedTask` return false directly if
`mGestureBlockingTaskId` is not valid. This can avoid
the caller go to create incorrect InputConsumer when
the chekcing `taskId` is also invalid.
Bug: 402218420
Flag: EXEMPT bug fix
Test: m
Change-Id: Ia0cde8ee2b97fc92028458d01487d958f2e87a80
This shows up if the launcher is in a sw600dp-or-greater configuration.
Test: AspectRatioSystemShortcutTests
Test: OverviewMenuImageTest
Test: Manual check on phone, tablet, and inner/outer fold screens.
Flag: com.android.window.flags.universal_resizable_by_default
Bug: 357141415
Change-Id: I1bcbf9299d28ce68cccd636d92ed7195d64736eb
This test is flaky in robolectric but does not repro locally.
Looking at the test it verifies that the animation doesn't get
canceled immediately after it starts. So the scenario here is an
edge case for something that shouldn't happen generally because
the animation is controlled in this class, although theoretically
other classes could obtain a reference to the physics animator and
cancel it directly. But since the test flakes badly, we're better
off without it until it can be fixed.
Bug: 404773413
Flag: EXEMPT test only
Test: atest BubbleBarViewAnimatorTest
Change-Id: I24493b71842a2fe859ffe40b6f375ade7ee8535d
- isHomeAndOverviewSame now returns true for launcher in window
- added isHomeAndOverviewSameActivity to differentiate specifically
when Overview is hosted in the Launcher activity (currently only
used for launcherChildTask handling, which we can clean up in a
follow up change)
- overviewIntent now equals homeIntent for launcher in window
- fixed containerInterface to always use FallbackoverviewInWindow
when overview-in-window is enabled; this means TaskbarManager
gets the proper RecentsViewContainer for creating the correct
TaskbarUIController
- updated getSwipeUpHandlerFactory based on isHomeAndOverviewSame
change above
Fixes: 401382430
Test: InputConsumerUtilsTest, manual
Flag: com.android.launcher3.enable_fallback_overview_in_window
Flag: com.android.launcher3.enable_launcher_overview_in_window
Change-Id: Ie8edd55b47d6438af36b9d2a788d72d69afa02f3
This test is the leading cause of flakiness for the entire suite.
Bug: 404773413
Flag: EXEMPT test-only
Test: BubbleBarViewAnimatorTest
Change-Id: I7c5658ad55aa0e959e068e5979325d1c41d18310
This means we are now testing real objects instead of mocks
Test: TaskbarHoverToolTipControllerTest
Fixes: 346394827
Flag: EXEMPT bugfix
Change-Id: Ib2e7f859432e84eb18c985dd71adaaaf9a513620
The SetFlagsRule was missing in tests.
Flag: EXEMPT Test fix
Fix: 402452969
Test: atest NexusLauncherTests:com.android.quickstep.DesktopSystemShortcutTest
Change-Id: I80e4fc311b173e32e2d85849656b837deb903aeb
All input consumers should be associated with display IDs, especially since these are used by TouchInteractionService.onConsumerInactive and they will be using per-display objects.
Flag: com.android.launcher3.enable_gesture_nav_on_connected_displays
Bug: 382130680
Test: InputConsumerUtilsTest
Change-Id: Ic14121db2361da1f0a819221b85256b1b3926774
Fixing NPW caused by ag/31415696. The recents view container can be null in tearDown
Flag: EXEMPT test fix
Fixes: 399657343
Test: TaplTestsQuickstep
Change-Id: I3665fc4bc131b90b22f43282f0c4e9e1188d0eb4
Add freeform check and update logs
Return early instead of crashing if a launch change is not available
Bug: 395495925
Flag: NONE only adding logs, not change of actual code
Test: DesktopAppLaunchAnimatorHelperTest
Change-Id: I0d51c563a26e7d6020222cb84757e0ea8d561d69
Moving widget filtering to UI layer as it changes with surface
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: I9d9377540ca36873659cea4ecc91fb162d82cd44
Flag: com.android.launcher3.enable_gesture_nav_on_connected_displays
Bug: 382130680
Bug: 398881237
Test: connected an external display and attempted touch gestures. checked logs to ensure motion events are separated by display id
Change-Id: I45356fd7f1926685093833990d39c85a4a074c58
Adds TAPL test that verifies users are able to drag app items from all
apps to workspace when all apps is opened on from a pinned taskbar shown
on the home screen, as may be the case when a desktop mode taskbar is
shown on home screen.
Adapts LauncherInstrumentation to handle the case where taskbar is shown
on home - when verifying launcher states, it sets taskbar visibility
expectations to account for a posibility that taskbar is visible in
home, or workspace states. Adds a request to the test protocol to
determine whether taskbar should be visible on home.
Bug: 392118517
Flag: com.android.window.flags.enter_desktop_by_default_on_freeform_displays
Test: Ran TaplTestLockedTaskbar tests
Change-Id: I40b06da70aaa49b0a3e0673797e6c18773a72238
- Add TaskContentView parent view
- Extract TaskThumbnailViewHeader logic and any related state out of
TaskThumbnailView and move to TaskContentView
- Use vertical LinearLayoutManager to hold the TaskThumbnailViewHeader
and TaskThumbnailView
- Rename TaskThumbnailViewHeader to TaskHeaderView. Rename xml and state
similarly
Bug: 397889146
Flag: EXEMPT. Refactor
Test: Refactoring CL. Existing unit tests still pass.
Change-Id: Ie31f35c6617aab272f984a6beb3e4cb8f58e3ce9
- The block of code is no longer failing
Fix: 308841019
Test: testOverviewForTablet
Flag: EXEMPT TEST_ONLY
Change-Id: Ibf2bd7b5ff8c0814d803bc519814072fe1421540
Earlier wallpaper preview was reading widgets that were eligible for
displaying in picker, which means widgets that are marked as hidden in
picker wouldn't show up in wallpaper preview.
This fix updates widgets model to maintain map of all widgets (instead of just pickable widgets like before), so that the existing `getWidgetsByComponentKey` function used by wallpaper preview can see all widgets. And, updates picker specific methods to use separate functions (suffixed `forPicker` that filter out picker ineligible widgets when read by picker code).
Bug: 385695615
Test: WidgetsModelTest, WidgetsPredictionUpdateTaskTest and demo
Flag: EXEMPT BUGFIX
Change-Id: I59efe38be0ce1f8a956ba4be42fb6e8b48b5d323
Instead of requiring that a valid display ID is given to
the APIs in `DesktopVisibilityController` and crashing the Launcher,
this CL lets the code handle invalid IDs gracefully, and adds a test
that fails without the fix.
Bug: 392986431
Test: atest NexusLauncherTests:com.android.launcher3.statehandlers.DesktopVisibilityControllerTest
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Change-Id: Id1bc7876ce654b96191c85089557b9279963acd8
Bug: 378096575
Flag: NONE test fix, not actual code editing
Test: DesktopAppLaunchTransitionManagerTest
Change-Id: I6dc335fea156f4e830e9c2cadf3c98ff01fb7c4f
Moving most of the logic from DesktopAppLaunchTransition to DesktopAppLaunchAnimatorHelper to make it more testable
Bug: 391548553
Flag: com.android.window.flags.enable_desktop_trampoline_close_animation_bugfix
Test: DesktopAppLaunchAnimatorHelperTest
Change-Id: I606fc3fc25250ea4128f3089b701a1ae153dc47a
And make DisplayController display id aware
Test: locally tested on Tangor
Flag: EXEMPT refactor
Bug: 392858637
Change-Id: I805cd7323c48a2988c95b9fda7f6cfe4c153860c
