Commit Graph

513 Commits

Author SHA1 Message Date
TreeHugger Robot
d0aba60767 Merge "Introduce KeyboardStateManager to maintain keyboardstate as show or hide." into tm-qpr-dev 2022-09-09 20:10:37 +00:00
Anushree Ganjam
a461660fa8 Introduce KeyboardStateManager to maintain keyboardstate as show or hide.
- Add a feature flag for IME Latency logging.

- Removed mShowImeAfterFirstLayout from ExtendedEditText.

   http://ag/1414509 added `mShowImeAfterFirstLayout`and cl description
   says "Show IME when search query != null after rotation".

   I verified the behavior by turning on "Allow home screen rotation".
   Keyboard is not getting dismissed on rotation in AA+ screen in a-z list
   or even in the search screen.
   Video : https://drive.google.com/file/d/1BWUTrW9OSEo6ojErj8INMwjFCPArVD4B/view?usp=sharing&resourcekey=0-SXTcKyUw1wCSi8Bm37ktow

Bug: 240192346
Test: Manual.

Verified by setting `ENABLE_KEYBOARD_TRANSITION_SYNC` to false and for
following usecases.

- All apps entry with ime enabled, scrolling a-z list to hide keyboard
- Folder name change - showing and dismissing keyboard
- Toast entry from Allapps and QSB - showing and dismissing keyboard

Change-Id: I1a6b5759b8e71e77744f58677b6d1b73e2f633e8
2022-09-09 04:32:33 +00:00
Schneider Victor-tulias
f0ff290103 Merge "Enable input consumer selection reason logging and gesture navigation error detection." into tm-qpr-dev am: 82e112c2a4 am: 45140c5372
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19819335

Change-Id: Id27a35b7425000ee7e5e8d735718bf025bb62839
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-08 18:48:54 +00:00
Schneider Victor-tulias
82e112c2a4 Merge "Enable input consumer selection reason logging and gesture navigation error detection." into tm-qpr-dev 2022-09-08 17:53:26 +00:00
Anushree Ganjam
a4f15a1a95 Merge "Add a feature flag for showing Search Educard in QSB" into tm-qpr-dev am: 94a54203f3 am: 8538ea530c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19887643

Change-Id: Ie24f43eedd5851693d6c02505e4827bd4d9c0ee6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-07 23:03:31 +00:00
Anushree Ganjam
c74ef95d50 Add a feature flag for showing Search Educard in QSB
Bug: 243680092
Test: Manual
Change-Id: I3ba1f577df2a5cfb2eb5f7acad20b47980c20916
2022-09-07 19:14:35 +00:00
Schneider Victor-tulias
119ae79e3c Enable input consumer selection reason logging and gesture navigation error detection.
Bug: 227514916
Test: ran locally, tested multiple gestures and checked logs
Change-Id: Iab0c9a21ee0141744cf82afd16ee941f2b49a9cc
2022-09-01 15:59:07 -07:00
TreeHugger Robot
4563f5cb6e Merge "[Toast] Add a feature flag for using app search for web zero-state." into tm-qpr-dev am: a29868e30c am: b73f762e28
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19747910

Change-Id: Idcbe944619afb89f9aea16fbb15db14bc69eaa7a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-01 03:35:32 +00:00
TreeHugger Robot
a29868e30c Merge "[Toast] Add a feature flag for using app search for web zero-state." into tm-qpr-dev 2022-09-01 01:54:18 +00:00
Schneider Victor-tulias
7ba044f10b Merge "Add gesture nav error state tracking and logging" into tm-qpr-dev am: ff5ad47a06 am: 520bf2e892
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19300928

Change-Id: I7830f925e70d89f84fce7da317403e03dacbb419
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-30 23:55:39 +00:00
Schneider Victor-tulias
038922a653 Add gesture nav error state tracking and logging
- Added ActiveGestureErrorDetector
- Removed startQuickstep logs; these were confusing and not helpful in ActiveGestureLogs

Test: printed logs after several gestures
Bug: 227514916
Design: go/gesture-nav-logging
Change-Id: Ia2a7e4f90a3a371d9a92190aa66eb07acd061d6c
2022-08-30 12:18:29 -07:00
Sebastian Franco
47558a6201 Adding flag to improve the icons reordering on foldables
Test: compiles
Bug: 188081026
Change-Id: Ifa30bbc9ff38f2cc0f9530f3e075b5eb662f63eb
Merged-In: Ifa30bbc9ff38f2cc0f9530f3e075b5eb662f63eb
2022-08-29 22:08:20 +00:00
Sebastián Franco
b35a9e51fc Merge "[Merge conflict tmp-qpr] Adding flag to improve the icons reordering on foldables" 2022-08-29 22:03:29 +00:00
Becky Qiu
edea2575e6 [Toast] Add a feature flag for using app search for web zero-state.
Bug: 241001264
Test: local
Change-Id: Id4af1664253182217014a43d8f8025f1a00da291
2022-08-26 16:41:05 -07:00
Sebastian Franco
ffae7d256c [Merge conflict tmp-qpr] Adding flag to improve the icons reordering on foldables
Test: compiles
Bug: 188081026
Change-Id: Ifa30bbc9ff38f2cc0f9530f3e075b5eb662f63eb
2022-08-26 00:05:27 +00:00
Schneider Victor-tulias
305a1df9d9 Merge changes I562abc6c,I7a48d960,I0916f969 into tm-qpr-dev am: 7fb96a5305 am: 2ed4c84e68
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19517498

Change-Id: If267d42f6d15fef03373ffe0c77fc1ebb1a7dd3a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-25 21:31:02 +00:00
Schneider Victor-tulias
7fb96a5305 Merge changes I562abc6c,I7a48d960,I0916f969 into tm-qpr-dev
* changes:
  Update ActiveGestureLog to store n-gestures rather than n-events.
  Add input consumer selection reason to active gesture logs
  Collapse EventLogArray into ActiveGesture log.
2022-08-25 20:42:13 +00:00
Schneider Victor-tulias
24637f50c5 Add input consumer selection reason to active gesture logs
Test: manually tried gestures in 3 button and gesture nav and checked logs
Bug: 227514916
Change-Id: I7a48d960ef5a41ddee95153fa08a2345f00cbef7
2022-08-25 10:03:30 -07:00
Sunny Goyal
ca5761d21f Merge "Removing some obsolete features" into tm-qpr-dev am: 211496e3d8 am: a3dacac8b9
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19505122

Change-Id: I8a0157caa803b2edcef458895d7e9ded06ea5fe0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-22 21:07:20 +00:00
Sunny Goyal
211496e3d8 Merge "Removing some obsolete features" into tm-qpr-dev 2022-08-22 20:27:45 +00:00
Luca Zuccarini
c97195c1fc Merge "Set the default for keyboard sync to IS_STUDIO_BUILD." into tm-qpr-dev am: ee29b830b4 am: c905fd544a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19668493

Change-Id: Id3cad76e985f7b8da0f586b3b515b55b1d3b1a6e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-22 09:52:24 +00:00
Luca Zuccarini
ee29b830b4 Merge "Set the default for keyboard sync to IS_STUDIO_BUILD." into tm-qpr-dev 2022-08-22 09:12:01 +00:00
Sukesh Ram
b6d673ad40 Merge "Enable Pinning Deep Shortcuts in Secondary Display" 2022-08-19 23:18:52 +00:00
Sukesh Ram
353b0a914f Enable Pinning Deep Shortcuts in Secondary Display
Currently, deep shortcuts can be pinned to the workspace grid (home screen) upon long click of the icon. However, a challenge in doing so has been persistence of these shortcuts because whenever a new secondary display activity gets started, these pinned shortcut icons vanish. To address this, we store pinned shortcut data in memory which is done here via SharedPreferences.

Retrieval of this data still needs to be done as outlined here: https://docs.google.com/document/d/1wLb2h8qCPGur-VsufCH4mLnnuLDLcmMq0FrCo7ichu8/edit#heading=h.44bkbp2hiok0.

Bug: 241843710
Test: Manual
Change-Id: I709f046fac79fdfd47c3c84054173992d81757ae
2022-08-19 16:18:04 -07:00
Luca Zuccarini
78c6e3f2a4 Set the default for keyboard sync to IS_STUDIO_BUILD.
As discussed offline, I will send out an announcement in the Sysui-studio and #sysui-debug Chat Spaces to solicit bug reports.

Bug: 234812580
Test: manual
Change-Id: Id693e8ebd990b804da247d4639a2dd2d6fbdd01f
2022-08-19 19:09:15 +00:00
Grace Han
c9225b74d4 Merge "Create Flag for Region Sampling in Smartspace" into tm-qpr-dev am: 4fb9dbb9f5 am: ae351cd134
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19397546

Change-Id: I203497b28f995f4660718c85ce1e132bcd982e86
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-19 16:39:22 +00:00
Grace Han
4fb9dbb9f5 Merge "Create Flag for Region Sampling in Smartspace" into tm-qpr-dev 2022-08-19 15:59:35 +00:00
Luca Zuccarini
a5722fa5f0 Merge "Introduce a new flag to guard keyboard synchronization." into tm-qpr-dev am: 2e126f985e am: 4728814a0f
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/19117747

Change-Id: Ia57d8df450a9cf6922ca19327ea55bfa6fdc8d63
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-10 18:15:54 +00:00
Luca Zuccarini
7e02d6845e Introduce a new flag to guard keyboard synchronization.
Bug: 234812580
Test: manual
Change-Id: I1c8714fa68cde06b95f6a7822075188c7dc2f71f
2022-08-05 12:20:14 +00:00
Sunny Goyal
c5c7da9a8b Removing some obsolete features
PROMISE_APPS_NEW_INSTALLS = true
ENABLE_QUICKSTEP_WIDGET_APP_START = true
FOLDER_NAME_SUGGEST = true
ENABLE_PREDICTION_DISMISS = true
HOTSEAT_MIGRATE_TO_FOLDER = false
ENABLE_DEEP_SHORTCUT_ICON_CACHE = true
ENABLE_THEMED_ICONS = true
ENABLE_ALL_APPS_EDU = true
EXPANDED_SMARTSPACE = false

Bug: 241141733
Test: Presubmit
Change-Id: I72c0c20ab7e214994dc3c3665c90e85d45991a7a
2022-08-02 13:38:38 -07:00
Sukesh Ram
189554616c Drag from appDrawer & pin onto secondary display homescreen
Bug: 239246505
Test: Manual

Change-Id: I817d8ef700f2d7caec6fa63123935502f17f2d2f
2022-07-25 21:04:25 +00:00
Grace
170911d823 Create Flag for Region Sampling in Smartspace
This change adds a feature flag to control region sampling for
the homescreen smartspace. The flag helps developers toggle the
feature on and off during debugging.

Bug: 202758428
Test: N/A
Change-Id: I99e795408f5550b4a535ef181744f029e09c4436
2022-07-22 19:58:00 +00:00
Sunny Goyal
25972b1f2f Adding support for continously capturing view hierarcy in Launcher
Bug: 238243939
Test: Verified data being captured and dumped
Change-Id: Ibe069d39ccf728f7b953f85085e58976be6e05ac
2022-07-11 15:43:54 -07:00
Becky Qiu
da6a8fab1b [Toast] Add a feature flag to use local overrides for search timeout.
Bug: 229038631
Test: manual
Change-Id: I131ee7fc9bd7d09d7a4d4ee3f4577110ed75c0d4
2022-07-06 11:16:00 -07:00
Pinyao Ting
6c7361fb46 Merge "Cache and reuses LauncherAppWidgetHostView when launcher resumes" into tm-qpr-dev 2022-06-27 20:51:22 +00:00
Pinyao Ting
e5dbb75acd Cache and reuses LauncherAppWidgetHostView when launcher resumes
Currently by design when launcher enters the background, it stops
listening to updates in widgets. This eventually causes the dilemma
for launcher when it resumes, before the update can be returned from
the system process via IPC, launcher could do one of the following
to fill the gap:
1. show a deferred widget view -- a placeholder that renders the shape
   of the widget -- to let the user know widget is being reloaded.
2. show whichever widget view that was previously displayed to the
   user that may now contain stale content.

There is a descrepancy here since in some edge cases we are showing the
former while in most other cases we are showing the later. This CL added
a short-term fix to address the descrepancy and favors the later where
possible.

Bug: 218067434
Test: manual
Change-Id: I6cd2cd704186267227e2ec47f2581843fd526fa0
2022-06-15 13:23:31 -07:00
Brandon Dayauon
452ee1e45a ENABLE_HIDEHEADER_PRIVATE_IME
Add featureflag to have the hide header feature
Bug: 222862488
Test: Manual

Change-Id: I5e0cd0e5d40e0eb2d70e95b4981e6b2c7835cf0d
2022-06-13 14:29:17 -07:00
Andy Wickham
b17399e54c Updates keyboard option feature flag name. am: 918ba0c9f2 am: 845d34d210
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18818901

Change-Id: I0ec4213c3716e7b47ea1529e82bfbf7e1a9ae0ac
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-09 22:07:37 +00:00
Andy Wickham
918ba0c9f2 Updates keyboard option feature flag name.
This should ignore any value previously stored for the old flag.

Fix: 235440407
Test: Manual
Change-Id: Ib0b21442443575e88153f5a13ea945bfad3fa9f0
2022-06-09 11:02:39 -07:00
Andy Wickham
36f3ed631f Merge "Enables keyboard option by default." into tm-dev am: 2d5bda75fc am: b8dd99d01e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/18687151

Change-Id: I7634a2fcaf0f70ea0f91f2edc576ba78683911cf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-06 22:36:18 +00:00
Andy Wickham
9899468884 Enables keyboard option by default.
This just enables the setting for this feature. The default
value of the setting itself is still false.

Bug: 231433168
Test: Manually verified the option worked as expected, including
showing the user education when typing directly in All Apps
without tapping the QSB. Also verified previous features like
the snackbar to enable keyboard by default worked as before.

Change-Id: If423ae49436d1bf71579d52a99aea5ca3f2407dc
2022-06-02 16:51:01 -07:00
Vinit Nayak
28036435b6 Refactor TaskShortcutFactory to return List of SystemShortcuts
* Remove ENABLE_SPLIT_SELECT feature flag
* Remove unused SystemUiProxy methods

Bug: 233006032
Test: Options show up as expected
Change-Id: I9b98d962db79363a20ad41faa15404f1c156b9ec
2022-06-01 16:27:04 -07:00
Schneider Victor-tulias
766f2fc346 Coordinate the SUW All Set page first reveal with the taskbar unstash to hotseat animation.
Bug: 220096988
Test: manual
Change-Id: I1f517b322e5c18f825be8b51ebb560a4a195b666
2022-05-13 11:17:10 -07:00
Sunny Goyal
2a84e378b7 Adding feature to automatically show keyboard in all-apps
Bug: 227659010
Test: Manual
Change-Id: Id0a295d343aa895a2f672319ae1ccb3a975d41ce
2022-05-06 15:16:08 -07:00
Stefan Andonian
510a818521 Show an 'Undo' snackbar when users dismiss a predicted hotseat item.
Bug: 200841778
Test: Hard-coded the flag to be true, and verified that the snack bar
is shown with the correct text. Also verified that talkback announces
"Item Removed" properly and that the correct log event is produced by
the AppEventProducer which AiAi needs to process the user action.

Change-Id: Ifbb9cf7aecf26cd4bcebf48d4fb07fb3d5af46bb
2022-04-06 17:22:40 +00:00
Sunny Goyal
59c535bb71 Merge "Adding a feature flag to disable icon overrides" into tm-dev 2022-04-01 17:26:09 +00:00
Sunny Goyal
eeca859bc9 Adding a feature flag to disable icon overrides
Bug: 226388663
Test: Verified locally by disabling the feature
Change-Id: Icfbe790046209b15dbdc0e44dcf1a14f1f50de62
2022-03-23 15:31:38 -07:00
Luca Zuccarini
b21fd239a9 [Toast] Flip the QSB motion flag to true by default.
Bug:225749858
Test: manual with soong build as well as server build image with this
change

Change-Id: I5658bae753a7112a64fc89ae54c10c5af3a09654
2022-03-22 15:45:07 +00:00
Luca Zuccarini
24fab62d35 [OneSearch] Add a flag to guard QSB animations.
Bug: 225749858
Test: manual
Change-Id: Ib725b9bcec235d2e23cf93b2f86d0dc9cd0600cb
2022-03-21 19:00:23 +00:00
Becky Qiu
85025d248d [Avocado] Use device config for arm2 flags instead.
Bug: 224861508
Test: manual
Change-Id: Ib42ddb3808cf84ed1511754bf3f8bbcf5d100894
2022-03-15 17:13:56 -07:00