aixan/lawnchair
1
0
Fork 0
mirror of https://github.com/LawnchairLauncher/lawnchair.git synced 2026-02-20 11:18:21 +00:00
Code Issues Packages Projects Releases Wiki Activity
58,436 Commits 37 Branches 1,369 Tags
67fa00189dcafe5df7ebc08c3dd1e6ccc2a7e276
Commit Graph

8114 Commits

Author SHA1 Message Date
Jeremy Sim
c779ae54ce Fix bug with trying to split an app with itself 
This patch fixes the following user flow:
1) App is already running
2) User initiates splitscreen from Home with that app
3) User selects the same app from Taskbar or AllApps

Previously, this caused a crash because the split-from-home initiation removed the corresponding app tile, causing a null pointer exception when the same task ID was used as a split target.

Fixed by adding a null check: if the target TaskView can't be found for any reason, fall back to launching the second app via Intent instead. If the app doesn't support multi-instance, the UI will now show an attempted split, followed by the message "This app can only be opened in 1 window."

Fixes: 263041522
Fixes: 266218404
Test: Manual
Change-Id: I39ed60c9ac758ac215391f0618f44f7fcee4f32c
 2023-01-31 17:58:12 +08:00
Tony Huang
36baf82028 Fix divider hidden delay if quick swipe to home 
We didn't handle such case if transient bar enable and divider is
hidden by split side so it will have a delay.
Catch up it on handleNormalGestureEnd if end target is home.

Fix: 265755388
Test: manual
Test: pass existing tests
Change-Id: I09ac2a3a57c51473daf2b6887cd23bca505378f7
 2023-01-31 09:03:09 +00:00
Tony Wickham
c3963a7ff4 Fixes to VoiceInteractionWindowController 
- Make temporary taskbar background behind assistant non-touchable
  (fail-safe in case the window isn't removed for some reason)
- Give temporary taskbar background a different window title and
  add a couple more dump statements to help debugging
- Only show the taskbar background for persistent taskbar; transient
  taskbar can skip most of the special casing and just hide it
- Fix bug where we weren't drawing the separate taskbar background in 3
  button mode
- Fix bug where we weren't actually synchronizing
  separateWindowForTaskbarBackground with TaskbarDragLayer, since the
  former wasn't attached to the window yet; now we wait until it is
  attached before calling synchronizeNextDraw()
- Also added dump logs for TaskbarDragLayerController alpha channels

Test: manual in 3 button and gesture nav (with and without
FORCE_PERSISTENT_TASKBAR enabled)
Fixes: 243652789
Bug: 262664266

Change-Id: I865871e57dd4cb255a916317a7e5d35cfde97df5
 2023-01-31 00:58:22 +00:00
TreeHugger Robot
757df72fe3 Merge "Revert "Revert "Add debug logs for hotseat disapperaed bug""" into tm-qpr-dev am: ba73400fe1 am: ac906553d9 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21147358

Change-Id: I426dd331bf34f8e62deb35ca256fd9f4f026f926
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-31 00:08:46 +00:00
TreeHugger Robot
ac906553d9 Merge "Revert "Revert "Add debug logs for hotseat disapperaed bug""" into tm-qpr-dev am: ba73400fe1 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21147358

Change-Id: Ideccac6c81d2021b4b8fd4f5672c3e2bbe5ac191
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-30 23:16:40 +00:00
Stefan Andonian
526e168906 Move ViewCapture On/Off controls to QuickSettings Tile. 
Rather than use a feature flag for this feature, the on/off state will
be stored as a system setting and will be changed via a QuickSettings
tile.

Bug: b/264452057
Test: Verified that the new QuickSettings tile doesn't crash via normal
interactions (pressing, long-pressing, etc.). Also verified that
ViewCapture is turned on when the QuickSettings tile is in the enabled
state and is turned off when it is in the disabled state.

Change-Id: I90551511ac2766dc30c51a25aec2c96e3e552ce9
 2023-01-30 22:51:26 +00:00
Schneider Victor-tulias
949ddaed15 Merge "Update the gesture nav tutorial to use a mock transient taskbar" into tm-qpr-dev am: 2980adb209 am: e6068a501e 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21062344

Change-Id: Iad595f6ee0f5e4bdb61cbcde28ae3dda4bbc1f6a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-30 22:47:23 +00:00
Schneider Victor-tulias
360f6d0130 Merge "Revert "Revert^2 "Cancel gestures on launcher destroy""" into tm-qpr-dev am: 7d346bf90b am: 030ba11d8c 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21100567

Change-Id: Ib3d7981a93d9647a3599df12e8093d31941550fa
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-30 22:45:51 +00:00
TreeHugger Robot
6f73f537d4 Merge "Let createSetStateAnimator return null when needed" into tm-qpr-dev am: b42c293a82 am: 90c8076e28 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21136525

Change-Id: Id7bb242670bf2a2450409893c73ae3109a1ba13c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-30 22:44:51 +00:00
TreeHugger Robot
ba73400fe1 Merge "Revert "Revert "Add debug logs for hotseat disapperaed bug""" into tm-qpr-dev 2023-01-30 22:41:41 +00:00
Tony Wickham
ad79986f6b Merge "Remove ALPHA_INDEX_IME_BUTTON_NAV" into tm-qpr-dev am: d9dd02b451 am: f37c33cd50 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21122190

Change-Id: I2a98a1588adc0bab25bff44b1ac16a76bf9eff94
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-30 22:40:48 +00:00
Schneider Victor-tulias
e6068a501e Merge "Update the gesture nav tutorial to use a mock transient taskbar" into tm-qpr-dev am: 2980adb209 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21062344

Change-Id: I390f2562dbed33d85d479fb76ae268774a54868d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-30 21:56:12 +00:00
Schneider Victor-tulias
030ba11d8c Merge "Revert "Revert^2 "Cancel gestures on launcher destroy""" into tm-qpr-dev am: 7d346bf90b 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21100567

Change-Id: I813c4ccadb4bb063a844229004c2fdab4a4f9784
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-30 21:55:56 +00:00
Schneider Victor-tulias
2980adb209 Merge "Update the gesture nav tutorial to use a mock transient taskbar" into tm-qpr-dev 2023-01-30 21:40:44 +00:00
Schneider Victor-tulias
7d346bf90b Merge "Revert "Revert^2 "Cancel gestures on launcher destroy""" into tm-qpr-dev 2023-01-30 21:39:50 +00:00
TreeHugger Robot
90c8076e28 Merge "Let createSetStateAnimator return null when needed" into tm-qpr-dev am: b42c293a82 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21136525

Change-Id: I512e0ee056a57a91f781ed022f0ca6f37472800e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-30 21:38:33 +00:00
Tony Wickham
f37c33cd50 Merge "Remove ALPHA_INDEX_IME_BUTTON_NAV" into tm-qpr-dev am: d9dd02b451 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21122190

Change-Id: I0a5c3b86d81dd17258913895b34b63fe6c7a3028
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-30 21:37:14 +00:00
TreeHugger Robot
b42c293a82 Merge "Let createSetStateAnimator return null when needed" into tm-qpr-dev 2023-01-30 21:19:10 +00:00
Sunny Goyal
669b71f5b3 Introducing CellPosMapper which allows mapping between UI position 
and model position

Test: atest CellPosMapperTest
Bug: 188081026
Change-Id: If5c6b3df5ad240317bb535c675f6ead94084238e
 2023-01-30 12:17:09 -08:00
Alex Chau
84ba9fb5fe Revert "Revert "Add debug logs for hotseat disapperaed bug"" 
This reverts commit f4269f01d7.

Reason for revert: bug re-opened
Bug: 260135164

Change-Id: I818cc3f66c55148a4fbd19714adb25d7d4a0d39e
 2023-01-30 19:29:45 +00:00
Tony Wickham
d9dd02b451 Merge "Remove ALPHA_INDEX_IME_BUTTON_NAV" into tm-qpr-dev 2023-01-30 19:11:47 +00:00
Winson Chung
6fd2d639ce Merge "Fix issue with floating rotation button being in the wrong corner (launcher)" into tm-qpr-dev am: 0cf4c14fe0 am: c41fba5541 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21118628

Change-Id: I9308412c7172adbce16ac639d120e9aced53555e
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-30 18:57:26 +00:00
Hongwei Wang
f3ca8dda8b Merge "Refactor to use the PipContentOverlay" into tm-qpr-dev am: 7bf3a9bffc am: 3e25594560 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21118637

Change-Id: I47507b96eaa41cbad21b9509bf1624dc033ebffb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-30 18:46:37 +00:00
Winson Chung
c41fba5541 Merge "Fix issue with floating rotation button being in the wrong corner (launcher)" into tm-qpr-dev am: 0cf4c14fe0 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21118628

Change-Id: I70d1c6aeafe79ae26fae148becb5455d9d7c68fe
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-30 18:42:12 +00:00
Hongwei Wang
3e25594560 Merge "Refactor to use the PipContentOverlay" into tm-qpr-dev am: 7bf3a9bffc 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21118637

Change-Id: I6e38c8f8c308d95e655de177e6c65a70e9c799f4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-30 18:06:52 +00:00
Tracy Zhou
31b50aa743 Merge "Disable quickswitch for trackpad gestures" 2023-01-30 18:00:47 +00:00
Winson Chung
0cf4c14fe0 Merge "Fix issue with floating rotation button being in the wrong corner (launcher)" into tm-qpr-dev 2023-01-30 17:54:14 +00:00
Hongwei Wang
7bf3a9bffc Merge "Refactor to use the PipContentOverlay" into tm-qpr-dev 2023-01-30 17:43:45 +00:00
Alex Chau
f6c231d575 Let createSetStateAnimator return null when needed 
- This is to fix a regression from http://ag/20968628. Instead of returning null and change the behavior, return null and do null checks on callers

Fix: 266109700
Test: Swipe AllApps from home on tablets, no flicker on taskbar, for gesture and 3-button
Change-Id: Ic1900ef396b00187ce9eced906c4628436481213
 2023-01-30 16:59:43 +00:00
Chavi Weingarten
0aa21b3918 Merge "Updated SurfaceSyncGroup API definition." 2023-01-30 16:35:54 +00:00
Luca Zuccarini
8e1818e789 Merge "[Toast] Introduce SysUI's animation library to the transition manager." into tm-qpr-dev am: f70e2f0a95 am: 20650ab555 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20836638

Change-Id: I73f3653bd7777df7d5454add3ebc5c7b5663d088
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-30 15:38:17 +00:00
Luca Zuccarini
20650ab555 Merge "[Toast] Introduce SysUI's animation library to the transition manager." into tm-qpr-dev am: f70e2f0a95 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20836638

Change-Id: Ic4f5610fe4c04a5b876356d9912bf8f9eabc35b2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-30 14:51:12 +00:00
Luca Zuccarini
f70e2f0a95 Merge "[Toast] Introduce SysUI's animation library to the transition manager." into tm-qpr-dev 2023-01-30 14:25:48 +00:00
Tracy Zhou
6692653328 Disable quickswitch for trackpad gestures 
Bug: 261815244
Test: make sure (1) if user starts by swiping up, disable quickswitch (they will land either in overview, home, or the current app) (2) if user starts by quick switching, cancel the gesture

Change-Id: I6b59cec0089d5e6f22eee3241c6336345dd15dce
 2023-01-29 23:56:00 -08:00
Winson Chung
4bfef12fdd Merge "Include SysUI state in stashing check" into tm-qpr-dev am: 0a381d4115 am: 3b67bcd0f9 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21120299

Change-Id: I89158bb65c5db395dac6b9e9bde58e65b9f547c6
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-29 07:07:30 +00:00
Winson Chung
3b67bcd0f9 Merge "Include SysUI state in stashing check" into tm-qpr-dev am: 0a381d4115 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21120299

Change-Id: Ie35303e08e9658497be60b193fd405ddcea89c63
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-29 06:24:23 +00:00
Winson Chung
0a381d4115 Merge "Include SysUI state in stashing check" into tm-qpr-dev 2023-01-29 05:57:50 +00:00
Winson Chung
62c74f9633 Include SysUI state in stashing check 
Fixes: 266890635
Test: Open home controls over lockscreen, go back
Change-Id: Ic486ccdc4698f53507bc56875ccebef06826a6a4
 2023-01-29 05:57:39 +00:00
Vinit Nayak
7ffc338a42 Merge "Launch initial split from taskbar in overview app menu" into tm-qpr-dev am: d710773889 am: fd185e6402 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20956773

Change-Id: I78f6b8fee567230a59d533ca17bebc3c578e9040
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-28 07:08:17 +00:00
Vinit Nayak
fd185e6402 Merge "Launch initial split from taskbar in overview app menu" into tm-qpr-dev am: d710773889 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20956773

Change-Id: I65ec9dbc148013ed6143f868398078e4f32bf4a7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-28 06:26:13 +00:00
Vinit Nayak
d710773889 Merge "Launch initial split from taskbar in overview app menu" into tm-qpr-dev 2023-01-28 05:25:12 +00:00
Jagrut Desai
e42feb4db5 Merge "Add divider line into taskbar." into tm-qpr-dev am: 307b6e2475 am: 617cb7c4e1 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20968623

Change-Id: I0e60024a0c3ef3df5d5eb3994cf705a3b8d4ca4f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-28 02:21:47 +00:00
Jagrut Desai
617cb7c4e1 Merge "Add divider line into taskbar." into tm-qpr-dev am: 307b6e2475 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/20968623

Change-Id: Iebee8c1a98ff8f5ee1bc60cd72921fe417878dd5
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-28 01:54:25 +00:00
Jagrut Desai
307b6e2475 Merge "Add divider line into taskbar." into tm-qpr-dev 2023-01-28 01:22:03 +00:00
Vinit Nayak
49dc6d2712 Launch initial split from taskbar in overview app menu 
* Consolidated init calls in SplitSelectStateController
* Also add support to launch from taskbar all apps
* Add logic in SplitSelectStateController to know whether
or not we need to dismiss existing TaskView vs relying
on mSplitHiddenTaskView null check
* Default click handling for SplitShortcut is to start
split selection mode

Bug: 251747761
Test: Initiated split from smart actions, thumbnail app
icon, home, taskbar in overview, all apps. Saw it choose
the latest thumbnail

Change-Id: Ib4f64e619c97615af458a19a9c0efd86c92979d9
 2023-01-27 16:46:14 -08:00
Schneider Victor-tulias
ece659d11a Revert "Revert^2 "Cancel gestures on launcher destroy"" 
This reverts commit 377eb40985.

Reason for revert: failing tests
Fixes: 266606727
Fixes: 266621449

Change-Id: I61094be02fb73c5ad65ee65be5ed93a3364f37ef
 2023-01-27 14:38:19 -08:00
Stefan Andonian
59d78bea68 Merge "Load home properly even if AllSetActivity fails Go To Home Swipe." into tm-qpr-dev am: d01497d714 am: 8e97128a7e 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21048063

Change-Id: I172bb350e7ccb70ae60f17f4b579a8b0eb49a0ef
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-27 20:14:43 +00:00
Stefan Andonian
8e97128a7e Merge "Load home properly even if AllSetActivity fails Go To Home Swipe." into tm-qpr-dev am: d01497d714 
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/21048063

Change-Id: Ia04f38a55b7ac76f895719878ea5cafc7e22e1a1
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
 2023-01-27 19:25:27 +00:00
Tony Wickham
602f3074f9 Remove ALPHA_INDEX_IME_BUTTON_NAV 
Taskbar already stashes when IME is showing, which hides the taskbar
icons in 3 button mode. Hence this extra flag seems redundant and breaks
Transient Taskbar, which allows unstashing taskbar over IME

Test: Install 3P keyboard, swiping taskbar up over IME still shows icons
Test: Connect physical keyboard, icons still hide in 3 button nav when
the IME switcher is showing
Fixes: 264723145

Change-Id: Iafb89e765668d70a1bfad2e136957a2ef8924514
 2023-01-27 17:24:46 +00:00
Luca Zuccarini
2098381808 [Toast] Introduce SysUI's animation library to the transition manager. 
Bug: 250588519
Test: manual, see videos in bug
Change-Id: Iccc440c95ecc14d39e35d911798e239b698b950a
 2023-01-27 13:49:40 +00:00