Commit Graph

9015 Commits

Author SHA1 Message Date
Stefan Andonian
672fa7a9a9 Enforce setting up SystemUIProxy on the main thread.
Bug: 280086782
Test: Added annotations and device did not crash under normal usage.
Change-Id: Ie587aafaaa018a3e6a5c33ca238e204f5cc0ea4e
2023-05-04 22:28:26 +00:00
Brian Isganitis
0c7f244f18 Merge "Better handle large display and text scaling on EDU tooltip." into udc-dev 2023-05-04 16:30:07 +00:00
Tony Huang
2725473272 Merge "Send divider change to launcher to animate" into udc-dev 2023-05-04 13:02:53 +00:00
Nick Chameyev
1aa2383d26 Merge "[Unfold animation] Start Launcher animation preemptively to synchronize the first frame" into udc-dev 2023-05-04 09:36:04 +00:00
Wei Sheng Shih
37d8c93893 Merge "Fix pauseBlur make launcher become opaque" into udc-dev 2023-05-04 07:29:50 +00:00
wilsonshih
8bf6c9edda Fix pauseBlur make launcher become opaque
...so reveal animation can blend with the launching target.

Bug: 279785569
Test: manual, rotate device, launch app from quick switch.
Verify launcher surface isn't opaque so app window can blend with
reveal animation.

Change-Id: I46b0652fd14ff66b681a9212608c13fe4ec50eb3
2023-05-04 03:02:45 +00:00
Brian Isganitis
58f079b134 Better handle large display and text scaling on EDU tooltip.
For large scaling configurations, the tooltip height can exceed the
available space, which can truncate important content such as the "Done"
button. To mitigate this issue, we should attempt to increase the width
of the tooltip to hopefully free up some height due to the text taking
up fewer lines.

To support dynamic width, each EDU column gets an equal weight in the
ConstraintLayout, but the lottie animations are still constrained to
their original dimensions. If they fill the width, their aspect ratio
will be maintained and we will still have height issues.

Demo: https://screenshot.googleplex.com/6jV6geJFzCYtQ6v.png

Test: Manual (transient and persistent)
Fix: 278761297
Change-Id: I8cc0c4260caef747378954225d8635b2fb8eef52
2023-05-03 18:46:47 +00:00
Jagrut Desai
5dbfe1f238 Merge "Design review updates for Taskbar Pinning" into udc-dev 2023-05-03 18:24:07 +00:00
Saumya Prakash
32a38c9ff1 Merge "Remove unused Assistant gesture tutorial and add error checking" into udc-dev 2023-05-03 17:37:52 +00:00
Nick Chameyev
705c665c06 [Unfold animation] Start Launcher animation preemptively to synchronize the first frame
Starts unfold animation in Launcher right after receiving
configuration change for the unfolded screen.
This makes sure that before we unblock the screen we
have the first frame of the unfold animation ready
in Launcher (transformations are applied).

Bug: 271099882
Test: atest com.android.systemui.unfold.util.PreemptiveUnfoldTransitionProgressProviderTest
Test: manual testing fold/unfold, checking perfetto traces
Test: test with flag enabled/disabled
Change-Id: Icb8f91f9264248600d4bed14811445f50aac99c7
2023-05-03 11:35:03 +01:00
Kateryna Ivanova
46b73c2338 Merge "Revert^2 "Introduce library for public animation APIs"" into udc-dev 2023-05-03 08:41:31 +00:00
Fengjiang Li
c15679d512 Merge "[1/n] Launcher Startup Latency: add StartupLatencyLogger to launcher3 and log startup latency" into udc-dev 2023-05-03 03:18:46 +00:00
Tracy Zhou
41bfd86c1e Merge "Revert "Fix touch focus not updated correctly after launching overview with live tile."" into udc-dev 2023-05-03 00:41:34 +00:00
Fengjiang Li
5a36c17a32 [1/n] Launcher Startup Latency: add StartupLatencyLogger to launcher3 and log startup latency
More details at "Log Startup Latency" section in go/launcher-startup-latency

Test: tested on phone, foldable and tablet, print latency logs in logcat
Bug: 278092752
Change-Id: Ibf269b0ecd6007d29b95e36f65ab6f02c45deb3a
2023-05-02 17:08:05 -07:00
Tracy Zhou
3ec15b04f5 Revert "Fix touch focus not updated correctly after launching overview with live tile."
This reverts commit 8899f3a387.

Reason for revert: Regression b/280167174, b/280240591

Change-Id: Id82ab1dafb8c939b0e073ad4978d2782e3d953d8
2023-05-02 21:40:13 +00:00
Sihua Ma
8f85ad38ba Merge "Fix ConcurrentModificationException in QuickstepWidgetHolder" into udc-dev 2023-05-02 21:26:53 +00:00
Schneider Victor-tulias
db07d2223e Merge "Add null checks for mRecentsView" into udc-dev 2023-05-02 18:15:47 +00:00
Winson Chung
52cc03e42c Merge "Wait for shell drop target to be ready for handling drags in tests" into udc-dev 2023-05-02 16:46:24 +00:00
Winson Chung
c8ad4f7f43 Wait for shell drop target to be ready for handling drags in tests
- Wait for the shell drop target to be made visible and drawn before
  attempting to continue with the drag gesture

Bug: 234653212
Test: atest NexusLauncherTests

Change-Id: Ida851343873b51288460f25bba062f29019005d4
2023-05-02 05:29:36 +00:00
Tony Wickham
5e43031ed0 Merge "Simplify/correct Taskbar insetsRoundedCornerFrame calculation" into udc-dev 2023-05-02 00:56:38 +00:00
Jagrut Desai
1c9c6d0ea9 Design review updates for Taskbar Pinning
Changes:

- icon allignment animation for taskbar diviver view
- taskbar divider background color according to spec.

Test: Manual
Bug: 265170176
Flag: ENABLE_TASKBAR_PINNING
Change-Id: Ief45e48f4fc9f9b4cc30124c4c93cd3c5a880a33
2023-05-01 14:57:54 -07:00
Schneider Victor-tulias
f77d2086c4 Add null checks for mRecentsView
Fixed a NPE and added some null checks for mRecentsView. These NPEs can happen if the launcher is destroyed unexpectedly.

Flag: not needed
Fixes: 279738827
Test: ran launcher and tested some gestures
Change-Id: I9c32e22a13d950346ce705ba3a6f11dd3f1da87f
2023-05-01 13:51:02 -07:00
Saumya Prakash
94c8cf49cf Remove unused Assistant gesture tutorial and add error checking
The Assistant gesture tutorial is unused in both the current and
redesigned gesture nav tutorials and can be removed. Left in, its
detections of gestures are leading to bugs with the tutorial.

Additionally, this change adds in error checking for side swipes in the
overview tutorial.

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fix: 280115831
Fix: 261239858
Fix: 278926113
Test: Manually went through both versions of gesture tutorial on
handheld, foldable, and tablet devices

Change-Id: Ie481d92ede2c2ab16ce2b3d1f729f6cb88f1b4c0
2023-05-01 17:58:54 +00:00
Vinit Nayak
2a014d4c0d Refactor handling data launching split screen to separate class
* SplitSelectDataHolder contains logic for knowing how
to launch split, separate from the actual API calls to launch split

Flag: ENABLE_SPLIT_LAUNCH_DATA_REFACTOR
Bug: 279494325
Test: Tested w/ all 6 types of launches noted in
SplitSelectDataHolder#@SplitLaunchType.
Also checked to make sure most-recent running tasks are
still being used where applicable.

Change-Id: I8114f87e9956b100622c80f578e291937ed4eeac
2023-04-28 18:00:22 -07:00
Tony Wickham
3cfada0a00 Simplify/correct Taskbar insetsRoundedCornerFrame calculation
Now we base it on the current tappableElement insets, which will only be
> 0 for the unstashed, persistent taskbar which draws rounded corners.
This inset also stays stable during temporary stash transitions such as
when the IME is showing.

Flag: ENABLE_TRANSIENT_TASKBAR=true, ENABLE_TASKBAR_PINNING=true
Test: in split screen for both transient and pinned (persistent)
taskbar, ensure split screen divider bottom is drawn appropriately
Fixes: 278028503

Change-Id: Iab56c5dc8f9fc81c34aa01f41b5212dd5c6fd7f0
2023-04-28 23:51:41 +00:00
Sihua Ma
d72ce23707 Fix ConcurrentModificationException in QuickstepWidgetHolder
If the listeners would modify the listener list in the widget holder, this would cause a ConcurrentModificationException.

Fix: 275100497
Test: N/A
Change-Id: I3ae0e92db71f1c21d35dbf391dfcb92b46dd30f1
2023-04-28 14:21:24 -07:00
Saumya Prakash
71d05f963f Merge "Update the colors for gesture navigation tutorial." into udc-dev 2023-04-28 17:03:31 +00:00
Kateryna Ivanova
c0a003ed77 Revert^2 "Introduce library for public animation APIs"
af289a1cd1

Bug: 271850966
Change-Id: Iddc1790fc3704ce20fde4377d05360a77b6c146c
2023-04-28 08:38:26 +00:00
Saumya Prakash
796ebc6006 Update the colors for gesture navigation tutorial.
This change introduces tokens for the lottie animations so that the
colors can be changed. In this change, the home gesture tutorial colors have
been updated to match the updated design at http://shortn/_VvbigpP0ys

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Bug: 279823249
Test: Manually went through the tutorial on handheld, foldable, and tablet
Change-Id: Id2270cea41345e8f4d330097e10a7dae2b00032a
2023-04-27 22:06:17 +00:00
Ats Jenk
0e068b1213 Pass in display when using DesktopMode APIs
Pass in the display id when asking wmshell to show desktop apps or when
querying the number of visible desktop tasks.

Bug: 278084491
Test: open some apps on the desktop, swipe up to recents, tap the
  desktop tile to open desktop again
Change-Id: Ia7328613244a1aa401e0e4792bc747a4b99b412d
2023-04-27 11:50:49 -07:00
Schneider Victor-tulias
8c1bffb24f Merge "Remove unused debug logs" into udc-dev 2023-04-27 17:44:42 +00:00
Tracy Zhou
07b5cb3351 Merge "Fix touch focus not updated correctly after launching overview with live tile." into udc-dev 2023-04-27 04:31:49 +00:00
Tracy Zhou
8899f3a387 Fix touch focus not updated correctly after launching overview with live tile.
Similar to ag/19938037

Fixes: 277625965
Test: Meta+Tab to launch overview from app, or swipe from app, then use DPAD_LEFT and DPAD_RIGHT to go through overview. Make sure the selected task is highlighted
Change-Id: Id0138878d32e4d37f30cef51ddb9ddb9df85fd65
2023-04-27 03:14:40 +00:00
Treehugger Robot
a9a2ec9b55 Merge "Move setCurrentPlayTime before starting animation." into udc-dev 2023-04-27 01:00:56 +00:00
Jagrut Desai
0e5f1af6cb Merge "Adding Support for Change Navigation Mode Taskbar Divider Menu Option" into udc-dev 2023-04-26 22:12:08 +00:00
Andy Wickham
a4627d2235 Merge "Add long swipe from app to overview gesture (with flag)." into udc-dev 2023-04-26 21:30:53 +00:00
Jon Miranda
77b17547c3 Move setCurrentPlayTime before starting animation.
Otherwise when animations are turned off, the animation will start/end
and then gets stuck to the first frame of the animation.

Fixes: 278046913
Change-Id: I5f0ed4b99ab4737b5371d65754d1acb4fdb8edb0
Flag: none
Test: swipe to go home
2023-04-26 12:05:04 -07:00
Andy Wickham
830e4b7ce0 Add long swipe from app to overview gesture (with flag).
High level:
 - As you swipe up from an app (OtherActivityInputConsumer),
   a state transition animation to All Apps is created in
   AnimatorControllerWithResistance. The animation is played
   alongside the Recents resistance animation (i.e. past the
   settling point of Overview, which is at mCurrentShift 1).
 - The actual state transition to All Apps only happens if you
   release your finger in the "all apps region." This is set to
   mCurrentShift 2, so double the distance that Overview rests.
 - A haptic plays whenever you enter or exit this region, and
   the all apps animation is set to 0 until the region is
   active. This is so it's clear that something different is
   happening.
 - The panel that was previously used for tablets is now used
   for phones during this transition. It comes in at full
   opacity when you enter the region, and the contents (apps
   and search suggestions) fade in as you continue swiping.
 - The only gesture that is recognized in the all apps region
   is a fling downwards, which will return you to the previous
   app. Otherwise a left/right/up fling or slow release will
   finish the all apps transition.
 - The threshold is ignored if the flag is disabled (default)
   or if FallbackActivityInterface is active.

Flag:
The threshold is ignored if ENABLE_ALL_APPS_FROM_OVERVIEW is
disabled (default).

Bug: 259619990
Bug: 275132633
Test: Manual with and without the flag enabled
Change-Id: Ie311b77252416d97677b2c56fad61dfd392b6fe8
2023-04-26 10:52:04 -07:00
Jordan Silva
a68cd72a3c Merge "Fix digital wellbeing toast being initialized multiple times" into udc-dev 2023-04-26 17:15:09 +00:00
Sebastián Franco
3538deee10 Merge "Prevent null pointer exception by return from setBackToLauncherCallback when mBackToLauncherCallback is null" into udc-dev 2023-04-26 16:06:35 +00:00
Jordan Silva
f03e5f3778 Fix digital wellbeing toast being initialized multiple times
Digital Wellbeing toast state was being updated several times together with the app icon unnecessarily. This was causing a recreation of the Digital Wellbeing and replacing the banner attached to the TaskView multiple times, leading to heavy UI thread work and jumpy animations in some cases.

Bug: 271428408
Test: manual
Change-Id: I1a2a1423924efb0fb3c1e66826e3ab11211dcfb7
2023-04-26 11:40:47 +01:00
Tracy Zhou
c8f0ac0cd8 Merge "Commit to OtherActivityInputConsumer when swiping up in app" into udc-dev 2023-04-26 06:22:50 +00:00
Fengjiang Li
216ae0f7ec Merge "Fix NPE of predictive back in TaskbarAllAppsSlideInView" into udc-dev 2023-04-26 05:15:33 +00:00
Vinit Nayak
80a3213d6b Merge "Route PredictedAppIcon clicks through launcher" into udc-dev 2023-04-25 23:20:41 +00:00
Saumya Prakash
773c5c1760 Merge "Update the mock hotseat for the Gesture Navigation tutorial" into udc-dev 2023-04-25 20:14:32 +00:00
Tracy Zhou
33bcdbbb9d Commit to OtherActivityInputConsumer when swiping up in app
Fixes: 279634432
Test: swipe up and then immediately down, making sure that the notification shade is not brought down
Change-Id: I5ffdab6cef8162d0f0783c5d4a761197952209dd
2023-04-25 13:10:47 -07:00
Vinit Nayak
1bb594c72b Route PredictedAppIcon clicks through launcher
* This allows us to intercept launching predicted apps for
split-screen if user is in split selection flow
* Defaults to existing behavior of ItemClickHandler.INSTANCE
if we do not need to intercept the click

Bug: 276361926
Flag: ENABLE_SPLIT_FROM_WORKSPACE_TO_WORKSPACE
Test: Launches as expected when not in split, launches in
split when selected as second app to initiate split with

Change-Id: Ieb45137ae89da340d314e995f4f6eb1f8b49a42f
2023-04-25 12:31:56 -07:00
Tracy Zhou
eb55f83d88 Merge "Support 4-finger gesture to quick switch" into udc-dev 2023-04-25 18:21:37 +00:00
Schneider Victor-tulias
fff7cef9f1 Remove unused debug logs
Removing debug logs for bugs that have already been closed. These logs are filling up the logcat buffer and impeding in other test investigations.

Flag: not needed
Test: Tapl tests
Bug: 260260325
Change-Id: I4d69b904f2ea79d758cf6bef7d90d172f2eb2a91
2023-04-25 11:00:37 -07:00
Robin Lee
52b4c77770 Merge "Remove keyguard state from onAnimationCancelled" into udc-dev 2023-04-25 17:35:59 +00:00