Commit Graph

11645 Commits

Author SHA1 Message Date
Treehugger Robot
671d4e5384 Merge "Ensure starting position rect isn't empty in FloatingTaskView" into main 2024-06-07 00:28:31 +00:00
Shamali Patwa
fc4ff35e68 Merge "Ensure widgets from WidgetSections.xml are included in suggestions" into main 2024-06-07 00:00:03 +00:00
Treehugger Robot
c09cb9e345 Merge "Fix bubble visibility issue when collapsed" into main 2024-06-06 22:42:05 +00:00
Vinit Nayak
410681a955 Ensure starting position rect isn't empty in FloatingTaskView
* on rotation taskbar re-inflates it's hotseat views.
If we're already in split, then FloatingTaskView tries to do calculations
on the view's position in the window, but has a reference to the
old, pre-rotated view which is no longer in any window.
* This sets startingPosition to be an empty rect, which is used to
set LayoutParam values, which are used downstream in update() to calculate
scale, and thus we end up dividing by 0.
* TODO(b/345556328) figure out a better solution than checking for an
empty rect

Fixes: 342606096
Test: Repro steps don't cause crash
Flag: EXEMPT bugfix
Change-Id: Icb546a05d383d1997a92471fc1de3ffc37d06eca
2024-06-06 15:32:33 -07:00
Shamali P
d69e21f8fe Ensure widgets from WidgetSections.xml are included in suggestions
Additionally, let only prediction system provide suggestions, since the
UI surface has been there for a while, adding locally filtered widgets
from app package isn't required.

Bug: 345520128
Test: Unit tests
Flag: EXEMPT bugfix
Change-Id: Ia97f0743fefeae750e07a694bb19d24a5cc11ffe
2024-06-06 22:23:35 +00:00
Liran Binyamin
87e579ea2d Fix bubble visibility issue when collapsed
When the bubble bar collapses, explicitly set the alpha to 1
for bubbles that should not be hidden.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 345283193
Test: manual
       - create 3 bubbles in the bar
       - tap to expand
       - select the last bubble
       - tap it again to collapse
       - observe it is visible
Change-Id: I1aed310b66433b88b08ccaf760fc8e82923b1b64
2024-06-06 16:35:22 -04:00
Winson Chung
533893e898 Merge "Always report mandatory insets for button nav" into main 2024-06-06 04:28:38 +00:00
Winson Chung
762b3b4685 Always report mandatory insets for button nav
Fixes: 340134342
Fixes: 343817842
Test: atest android.systemui.cts.WindowInsetsBehaviorTests
Test: Verify mandatory insets vs window bounds in various
      orientations when folded/unfolded
Change-Id: I18d4f5d212d16c62d15d84b4842b3d20c0d8c5ae
2024-06-06 04:26:48 +00:00
Hongwei Wang
7584e28833 Merge "Crop the center when no source rect hint" into main 2024-06-06 00:15:05 +00:00
Ats Jenk
765cc415a3 Merge changes from topic "bubblebar-a11y" into main
* changes:
  Move bubble bar strings
  Add content description to bubble bar and bubbles
2024-06-05 19:04:22 +00:00
Ats Jenk
cd4c9d153d Add content description to bubble bar and bubbles
Set content description on the bubble bar when it is collapsed. Only
allow focus on the bar itself. In collapsed mode, bubbles in the bar
can't be focused.
Content description for the bar matches what we have in floating mode.
We include the text for the first bubble and then how many bubbles are
there more.

Set content description on bubbles in bubble bar. When bubble bar is
expanded, only the bubbles are focusable.
Bubble content description matches the floating bubbles content
description. Includes the notification title and app name.

Bug: 344670947
Flag: com.android.wm.shell.enable_bubble_bar
Test: enable talkback, focus on bubble bar when it is collapsed, check
  that only bubble bar receives focus
Test: enable talkback and expand bubble bar, check that only the bubbles
  receive focus
Change-Id: Id931f0360b9ebadd01dd16b05b75546fcc4df803
2024-06-05 10:13:22 -07:00
Treehugger Robot
6a69160999 Merge "Add debug logs to TopTaskTracker" into main 2024-06-05 16:17:19 +00:00
Treehugger Robot
02a187e84e Merge "Miscellaneous polish for new home animation." into main 2024-06-05 15:00:35 +00:00
Alex Chau
7779855ab4 Merge "Fix icon and DWB toast focus transition" into main 2024-06-05 14:58:52 +00:00
Schneider Victor-tulias
86b9ad4ff7 Add debug logs to TopTaskTracker
Flag: NONE debug logs
Bug: 342247547
Test: checked TIS logs
Change-Id: I6c8440af122a0376ffd77df6c8c9b9aeb742d447
2024-06-05 10:34:15 -04:00
Luca Zuccarini
0f6668d011 Miscellaneous polish for new home animation.
1. Update the starting window velocity when coming from 3-button nav or
   predictive back

Before we used an arbitrary fixed velocity which goes down to basically
0 with the old implementation, but caused a noticeable jump up in the
new one when using predictive back. Now we just pass 0, since the
predictive back framework doesn't give us the actual velocity.

2. Add the scaling home reveal to the targetless (not going back to a
   specific app icon or widget) animation and 3-button nav

Bug: 298089923
Fix: 343143876
Flag: com.android.launcher3.enable_scaling_reveal_home_animation
Test: manually tested with flag on and off
Change-Id: Ied3630a51862731fad044b68f76a45dc87f2e17b
2024-06-05 13:21:46 +00:00
Alex Chau
481e3ae079 Fix icon and DWB toast focus transition
- icon and DWB toast now transition in with animation when swipe up from apps to Overview
- Refacotred focusTransition into MultiProperty, with separate control from fullScreenProgress and scaleAndDim, and get rid of "invert" parameter and iconScaleAnimStartProgress variable which is very confusing
- Added a SCALE_AND_DIM_OUT property for use with PendingAnmation during dismiss, as PendingAnimation does not support per animator interpolator
- Use height from resource in DWB toast when calcualting translation, so translation can be properly set before view is measured
- Always set bannerOffsetPercentage regardless if banner is added

Fix: 344786723
Fix: 315972057
Fix: 313644427
Flag: EXEMPT bugfix
Test: Quick switch from home, icon and DWB toast don't transition in until gesture release
Test: Quick switch from app, icon and DWB toast don't transition in until gesture release to Overview
Test: Dismiss focus task, icon and DWB toast transition in after transition settle
Test: Swipe down task, icon and DWB toast transition out with finger
Test: Launcher central task, icon and DWB toast transition out
Change-Id: Ie16a2ceff10967de38b5f66c52f4be00d0051c5f
2024-06-05 12:33:25 +01:00
Jordan Silva
b620e432c3 Merge "Fix split snapshot broken after rotating in fake orientation" into main 2024-06-04 22:00:10 +00:00
Treehugger Robot
2e80918e75 Merge "Animate RecentsView when rotating in fake orientations" into main 2024-06-04 19:05:05 +00:00
Uwais Ashraf
5580144d6b Animate RecentsView when rotating in fake orientations
Test: Manual - animations
Bug: 336704871
Flag: EXEMPT bugfix
Change-Id: I80629128a0730ca85d0313d15af806ddf840e82b
2024-06-04 17:27:59 +00:00
Jagrut Desai
e263730c1e Merge "Make Taskbar Divider PopUp Menu Width Dynamic" into main 2024-06-04 17:13:36 +00:00
Alina Zaidi
c40cf8674b Merge "Add transition source for DesktopMode enter transition event originating from AppIcon press in overview" into main 2024-06-04 17:09:01 +00:00
Jordan Silva
a3b66f59c2 Fix split snapshot broken after rotating in fake orientation
This CL replaces the live tile with the snapshot after rotating in fake orientation. The animateRotation function was created to extract the rotation logic to guarantee that switchToScreenshot call will only happen when there is a running task.

Fix: 326410493
Flag: EXEMPT bug fix
Test: Manual. Instructions in the bug description.
Change-Id: I9d5e1b5ca803f8f8072702b37206a73b8d8a10ed
2024-06-04 17:48:07 +01:00
Alina Zaidi
f895a7b0bd Add transition source for DesktopMode enter transition event originating
from AppIcon press in overview

Test: Updated unit tests
Flag: EXEMPT not a major feature/ user visible change
Bug: b/326231756

Change-Id: I9e53cd3ec41dd2475ba90ea8fab2fb7a90f5e158
2024-06-04 13:12:04 +00:00
Jordan Silva
bf5e19fcb1 Merge "Adding logs to monitor OverviewCommandHelper" into main 2024-06-04 12:49:12 +00:00
Jordan Silva
11afae1bc9 Adding logs to monitor OverviewCommandHelper
This CL adds some logs to help analyzing why recents button with 3 button navigation sometimes don't open Overview.

Bug: 337954957
Test: NONE
Flag: EXEMPT Adding logs to debug issue
Change-Id: I44a799319eca667b04d4e78a38ade796fc3b69fb
2024-06-04 11:16:01 +01:00
Fengjiang Li
018074351c Animate -1 to recents
Fix: 343770316
Test: manual - record a video
Flag: com.android.launcher3.use_activity_overlay
Change-Id: I74346f060ea93dbc8fc0a1c3290d4996d89ec062
2024-06-03 12:59:48 -07:00
Liran Binyamin
ba732a77a1 Merge "Fix bubble bar and handle visibility on first bubble" into main 2024-06-03 19:49:26 +00:00
Ats Jenk
1507a2c59e Merge "Fix bubble position when dragged to dismiss view" into main 2024-06-03 18:30:59 +00:00
Liran Binyamin
273f9ec487 Fix bubble bar and handle visibility on first bubble
When the animation of the first bubble is suppressed, immediately
stash or show the bubble bar to make sure it has been initialized
correctly.

Also we no longer automatically update the bubble bar visibility
based on its alpha value, since we're managing alpha and visibility
ourselves.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 343505267
Fixes: 343502240
Test: manually verified state for the following scenarios for the first bubble
       - in app when keyboard is open
       - in app -> open shade
       - in app -> lock device
       - on home -> open shade
       - on home -> lock device
       - in overview -> open shade
Test: manually sanity tested to make sure animations for more bubbles still work
Test: manual
       - Open test bubble app
       - Open keyboard and send a bubble
       - The bubble should animate using a HUN since the keyboard is open
       - Swipe back to hide the keyboard
       - Observe that the bubble bar no longer shows to stash into the handle
Change-Id: I754a5a9c8e961af0cdd5ccadf83d3081d4414c7e
2024-06-03 13:27:48 -04:00
Jagrut Desai
38478e74f9 Make Taskbar Divider PopUp Menu Width Dynamic
Test: Manual
Bug: 327647761
Flag: com.android.launcher3.enable_taskbar_pinning
Change-Id: Ib5c13324afee46b45b2c71e3af86c15a6384a278
2024-06-03 10:26:41 -07:00
Hongwei Wang
282cdebd0c Crop the center when no source rect hint
When there is no source rect hint, forge a crop that matches the given
aspect ratio and centered, therefore we can use a consolidated animation
path and fix the issue with the round corner, which was inproperly
scaled in the past.

Flag: NONE bug fix
Bug: 298409662
Test: Test the overlay in both gesture and button navigation mode,\
      with both YouTube and Google Maps,\
      in both folded and unfolded mode.
Change-Id: I8ae48b999159a51eda2ff41c49cdb3c4e1541176
2024-06-02 19:36:38 -07:00
Jeremy Sim
9715761427 Merge "Add logging for actions view" into main 2024-06-01 00:40:22 +00:00
Jeremy Sim
bcaceda41a Merge "Save app pair with 50-50 snap target if snap position is SNAP_TO_NONE" into main 2024-06-01 00:39:00 +00:00
Jeremy Sim
2d107d8d4d Add logging for actions view
Bug: 340935208
Test: N/A
Flag: EXEMPT bugfix
Change-Id: Idb1ed848f01fc8378ae54f89ecf37cd14300ed79
2024-05-31 23:03:43 +00:00
Isak Lilja
29322e82fe Save app pair with 50-50 snap target if snap position is SNAP_TO_NONE
It was not possible to save an app pair if free snap mode was enabled
and the snap position was SNAP_TO_NONE. Just default to 50-50 split if
the current divider snap position is SNAP_TO_NONE.

Cherrypicked from isak.lilja@sony.com's CL at https://partner-android-review.git.corp.google.com/c/platform/packages/apps/Launcher3/+/2835425.

Bug: 343219704
Test: N/A
Flag: EXEMPT bugfix
Change-Id: I62347ac13440f714a493366ac66e893578a2d8d9
2024-05-31 21:52:15 +00:00
Ats Jenk
af5a393f88 Fix bubble position when dragged to dismiss view
When moving a bubble to dismiss view, use the drag translation x methods
to set the translation x values.
When bubble is moved to the dismiss view, the container will animate
back to the initial position. And we need to account for this while
bubble is in the dismiss view.

Bug: 339659499
Flag: com.android.wm.shell.enable_bubble_bar
Test: manual, drag bubble to other side and then to dismiss view,
  observe that bar moves back to original side and bubble is at the
  center of the dismiss view
Change-Id: I4c6e1be2dcd1180d985ceafccfc0f18466549347
2024-05-31 14:21:40 -07:00
Brian Isganitis
8aad11912d Merge "Only stash for IME when in-app and in overview." into main 2024-05-31 19:25:31 +00:00
Ats Jenk
348ac13cfe Merge "Notify pin controller about stuck to dismiss" into main 2024-05-31 16:46:54 +00:00
Jordan Silva
a74d1e419b Merge "Add Accessibility Menu support for multiple DWB banners" into main 2024-05-31 11:15:00 +00:00
Jagrut Desai
4c6913395c Merge "Accessibility Annoucement for the always show taskbar switch" into main 2024-05-31 05:33:15 +00:00
Jagrut Desai
7570f36e28 Accessibility Annoucement for the always show taskbar switch
Test: Manual
Bug: 326012899
Flag: com.android.launcher3.enable_taskbar_pinning

Change-Id: Idad1c6349d14153468e0c660703f5ff1808ab8e5
2024-05-30 14:50:53 -07:00
Brian Isganitis
d4d6388c8a Only stash for IME when in-app and in overview.
Making it a force stashed flag does not work because we do not stashing
to occur in Launcher non-overview states.

Flag: EXEMPT bugfix
Fix: 343756969
Test: Manual
Change-Id: Ib9c9e6fd1213777e66e8b48a20a2bbeb210ded8a
2024-05-30 16:02:06 -04:00
Priyanka Advani
34459f0210 Merge "Revert "Always report mandatory insets for button nav"" into 24D1-dev am: 8ec05c628b
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/27593486

Change-Id: I6242e741fba0b4b95be4b7e47a44ad515faf64b9
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2024-05-30 18:57:33 +00:00
Priyanka Advani
8ec05c628b Merge "Revert "Always report mandatory insets for button nav"" into 24D1-dev 2024-05-30 18:50:44 +00:00
Tracy Zhou
55308cadcf Merge "Support trackpad tapl tests in 3-button mode" into main 2024-05-30 17:59:13 +00:00
Jordan Silva
1b487619a0 Add Accessibility Menu support for multiple DWB banners
Fix: 341672022
Flag: EXEMPT Bug fix
Test: Manual. With Talkback on, open two apps in split screen and both with DWB enabled, go to Overview, access the Accessibility Menu > Actions.
Change-Id: Iff6adf8d549aa00ea42598cbfbdaf8c7a4164b29
2024-05-30 18:22:38 +01:00
Jordan Silva
8181dfdf92 Fix Talkback wrong label announced going from App to Overview
To fix the incorrect title information being spoken after a transition state ends, a new function named getTitle is introduced in the LauncherState. This function provides the correct title for the transition state. The default accessibility label is set to R.string.home_screen. All Apps and Overview states override the getTitle function to ensure the correct accessibility label for their respective states.

Fix: 265892510
Flag: EXEMPT bugfix
Test: Manual with Talkback. With Talkback enabled, navigate from App to Overview.
Change-Id: I96b820f310f8b778a149709bca687a5912386246
2024-05-30 14:01:32 +00:00
Chaitanya Cheemala
1773b06050 Revert "Always report mandatory insets for button nav"
This reverts commit 4304a14206.

Reason for revert: Likely culprit for b/343564388  - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Change-Id: Ibc6fae27f31bcb54406da013babc76b2d5fc7f10
2024-05-30 11:44:57 +00:00
Treehugger Robot
1d9f23b1ad Merge "Fix DWB banner not showing up for split tasks" into main 2024-05-30 11:04:37 +00:00