Commit Graph

17329 Commits

Author SHA1 Message Date
Schneider Victor-tulias
d58c0dbdca Merge "Clean up NPEs in AbsSwipeUpHandler" into main 2023-11-14 18:49:50 +00:00
Himanshu Gupta
775f5ca9c6 Merge "Adding Private Space views to Launcher." into main 2023-11-14 18:33:42 +00:00
Schneider Victor-tulias
3b9d80d2d8 Clean up NPEs in AbsSwipeUpHandler
AbsSwipeUphandler has many potential and common NPEs. Added more null checks to AbsSwipeUpHandler

Flag: N/A
Fixes: 295905702
Fixes: 309535060
Test: StartLauncherViaGestureTests, quick switched and launched app from recents
Change-Id: I11f62eac423ae3c5792ce97ca49963f1e005b289
2023-11-14 10:48:10 -05:00
Jordan Silva
646c95e643 Merge "Fix wrong number of columns for AllApps calculation" into main 2023-11-14 14:35:00 +00:00
Himanshu Gupta
08badb3f6f Adding Private Space views to Launcher.
This CL adds the following:
* Static View Elements to be added to AllApps recycler View
* View Controller to load the above elements dynamically
* Private Space Section Decorator
* PrivateProfile Manager containing the logic related to Private Space
* Abstract UserProfileManager as the super class of Work/Private
ProfileManager

Private Space Views Figma
[link](https://www.figma.com/file/K6bIIcG882EiJNjxvSWsFT/V%E2%80%A2-Private-Space?type=design&node-id=14535-111985&mode=design&t=JLz9W0O551TpzQYH-0)

Flag: ACONFIG com.android.launcher3.Flags.enable_private_space DEVELOPMENT
Bug: 289223923
Test: Ran Launcher3 tests
Change-Id: I8aa4247c78064a551e5e0d0b46d3fc033873f99d
2023-11-14 11:58:16 +00:00
Jordan Silva
8b3fa14ef9 Fix wrong number of columns for AllApps calculation
Fix: 310657769
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: DeviceProfileDumpTest
Test: DeviceProfileResponsiveDumpTest
Change-Id: Id46c9e4529176b68f6d92d31a71016ed4f8134d1
2023-11-14 10:37:32 +00:00
Luca Zuccarini
a3b8854951 Merge "Refine way to trigger the keyboard for a controlled insets animation." into main 2023-11-14 08:23:22 +00:00
Luca Zuccarini
6ab61069f3 Refine way to trigger the keyboard for a controlled insets animation.
Before we did it as normal just without requesting focus. However, we
also need to not log the new state, as this must happen only after the
controlled animation has completed (or been cancelled).

Bug: 309756056
Flag: NA
Test: manual
Change-Id: I7f1564d2b29d91c9fdb0afce586fe5cc1148bac0
2023-11-14 08:20:40 +00:00
Tracy Zhou
859edd00e9 Migrate ENABLE_SPLIT_FROM_FULLSCREEN_WITH_KEYBOARD_SHORTCUTS to aconfig
Bug: 270394122
Test: N/A
Change-Id: I9bacd906099518b4a4c43a9f80ab0c753beac89a
2023-11-13 13:12:09 -08:00
Jagrut Desai
bd997801e9 Merge "Migrate ENABLE_TASKBAR_PINNING to aconfig flag" into main 2023-11-13 20:13:15 +00:00
Jordan Silva
1fb00ea561 Merge "Responsive grid cleanup" into main 2023-11-13 15:03:29 +00:00
Pat Manning
da5baa981a Merge "Fix focus nav of AllApps when Searching." into main 2023-11-10 18:20:01 +00:00
Pat Manning
e7cb65009e Fix focus nav of AllApps when Searching.
- Do not focus the Icon in Small Icon Result Rows
- Use FocusIndicatorHelper when focusing search result icons

Flag: NONE
Bug: 296844600
Fix: 310173226
Test: Test: TaplKeyboardFocusTest
Change-Id: Icfc82ae41ffc8ef7c7ad42950f98f3d2dc805795
2023-11-10 16:48:21 +00:00
Jagrut Desai
90dd098c85 Migrate ENABLE_TASKBAR_PINNING to aconfig flag
Test: Manual, Presubmit
Bug: 265437087
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED

Change-Id: I4800230c04feceefa2398e189c493c8c4a7b2fe5
2023-11-09 23:20:03 +00:00
Anushree Ganjam
af4f41b9dc Merge "Hide overlay if the overlay was shown when Meta key is tapped." into main 2023-11-09 22:14:41 +00:00
Jordan Silva
8f7986abae Responsive grid cleanup
This CL renames some of the variables to keep it consistent across the code. It removes workarounds that were made to facilitate easy code reviews without breaking the tests.
It is a cleanup of the responsive grid feature.

Bug: 299889733
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: CalculatedAllAppsSpecTest
Test: CalculatedFolderSpecTest
Test: CalculatedHotseatSpecTest
Test: CalculatedWorkspaceSpecTest
Test: AllAppsSpecsTest
Test: FolderSpecTest
Test: HotseatSpecsTest
Test: WorkspaceSpecsTest
Change-Id: I198fadfbcfc0d1b32a62a3076949b42ee1fbcf33
2023-11-09 22:06:03 +00:00
Jordan Silva
767d484b27 Merge "Resize icon and text size for AllApps when it doesn't fit the cell" into main 2023-11-09 20:24:38 +00:00
Tracy Zhou
d66d114944 Merge "Make enableTaskbarNoRecreate() depend on ENABLE_TASKBAR_PINNING and ENABLE_TASKBAR_NAVBAR_UNIFICATION" into main 2023-11-09 18:47:59 +00:00
Federico Baron
b2cb1f87b7 Merge "Folder preview work badge theming fix" into main 2023-11-09 17:35:48 +00:00
Vadim Tryshev
572b5b09fd Merge "Allowing ACTION_CANCEL events to come from device 0" into main 2023-11-09 01:42:16 +00:00
Anushree Ganjam
b736982bab Hide overlay if the overlay was shown when Meta key is tapped.
Before fix : https://b.corp.google.com/issues/300492676#comment13
When Meta key is tapped in -1 screen, the toggleAllAppsFromIntent is called and
AllApps Drawer is shown in home screen. But the user is still in -1 screen.

After fix: https://b.corp.google.com/issues/300492676#comment15
When meta key is tapped in -1 screen, we hide -1 screen and transition
to 0 screen and then show AllAppsDrawer.

Bug: 300492676
Test: Manual, https://b.corp.google.com/issues/300492676#comment15
Flag: NA

Change-Id: I1234e4defdd0b53be35271b9f7567b0719eec7ac
2023-11-08 17:08:57 -08:00
Tracy Zhou
f2d7be1cec Make enableTaskbarNoRecreate() depend on ENABLE_TASKBAR_PINNING and ENABLE_TASKBAR_NAVBAR_UNIFICATION
We want to turn on the flag when either of the dependent features is on

Bug: 299193589
Test: N/A
Change-Id: I7b48ff2be0cf9da3b6bc00d75370fa585ce4140d
2023-11-08 14:52:58 -08:00
Vadim Tryshev
7a1beb559f Allowing ACTION_CANCEL events to come from device 0
Tests assert that input events come to Launcher only from tests, which
sets deviceId to 0. This way, we spot when a cable touches a lab device
and breaks the tests, in which case deviceId will be != -1.

But CANCEL event, which is programmatic, now can legitimately come from
device 0.

Bug: 308489875
Test: presubmit
Flag: N/A
Change-Id: I84ee9ed8e008043f83e82d57b17b64a10677ee8d
2023-11-08 13:20:57 -08:00
fbaron
1e360c1a92 Folder preview work badge theming fix
Currently the preview apps in a folder icon have the work badge with theming even when themed icons is off

Fix: 306665193
Test: Verify that folder with work icons has non-themed work badge when themed icons is off
Flag: NONE
Change-Id: I78ca7cb2361f6e590742fa64c88397d1ea80be68
2023-11-08 12:30:58 -08:00
Charlie Anderson
ee78d44eb2 Merge "Fixing polish issues with the U app shortcut popup design" into main 2023-11-08 18:08:30 +00:00
Jordan Silva
376036a36e Resize icon and text size for AllApps when it doesn't fit the cell
Bug: 287975993
Fix: 309489796
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: DeviceProfileDumpTest
Test: DeviceProfileResponsiveDumpTest
Test: ResponsiveHomeScreenImageTest
Test: ResponsiveFolderImageTest
Test: ResponsiveAllAppsImageTest
Change-Id: I1dda073b558a7f4540d5fe5c438fa796a70b6ddd
2023-11-08 18:05:59 +00:00
Thales Lima
55fcfacd1a Merge "Center AllApps on the screen" into main 2023-11-08 18:02:16 +00:00
Thales Lima
d94993ed9e Merge "Use new icon stepping logic for Folders" into main 2023-11-08 15:50:41 +00:00
Thales Lima
a25cd90b5e Center AllApps on the screen
AllApps used workspace paddings which are unbalanced in verticalBar. This changes it to always be centered. In dynamic grid AllApps now uses the whole width for the layout. In responsive grid it keeps the cell width and center the layout.

Note that this is centered on the screen but nothing could be done regarding the camera inset at this time, as it would need a refactor of how AllApps QSB is layout as well.

Bug: 269632571
Test: NexusLauncherTest
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Change-Id: I326d041bcef211d398d1a5c3210958b689414d49
2023-11-08 14:39:52 +00:00
Jordan Silva
72bc6f53f7 Merge changes from topic "comet-landscape" into main
* changes:
  Update Responsive Grid tests with aspect ratio group
  Refactoring Responsive Grid XML specs for more flexibility
2023-11-08 11:16:21 +00:00
Sebastián Franco
5054899552 Merge "Moving some constants in Launcher.java to a separate file for ease of readability" into main 2023-11-07 21:22:11 +00:00
Federico Baron
8bd0aac27f Merge "Remove white background from shortcuts in widget picker" into main 2023-11-07 16:53:53 +00:00
Sebastian Franco
974cc94839 Moving some constants in Launcher.java to a separate file for ease of readability
Part of  go/launcher_SoR

Flag: N/A
Bug: 306465626
Test: compiling, no-op change
Change-Id: I5ea40acb2ba1ea5840021e297516a511b032a043
2023-11-07 10:12:26 -06:00
Jordan Silva
f2402e25f1 Refactoring Responsive Grid XML specs for more flexibility
It merges portrait and landscape XML specs for responsive grid. This update allows the responsive grid to rely on other properties like aspect ratio and not solely the orientation from resource qualifiers.

Bug: 299889733
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Test: CalculatedAllAppsSpecTest
Test: CalculatedFolderSpecTest
Test: CalculatedHotseatSpecTest
Test: CalculatedWorkspaceSpecTest
Test: AllAppsSpecsTest
Test: FolderSpecTest
Test: HotseatSpecsTest
Test: WorkspaceSpecsTest
Change-Id: I39ee54d49c9d2a54fcbe91c8a1327a21a8126032
2023-11-07 11:51:28 +00:00
Himanshu Gupta
7d56e6ea23 Merge "Adding Prework for Private Space integration in Launcher" into main 2023-11-07 08:45:41 +00:00
Catherine Liang
7059799ac6 Merge "Update launcher preview icons on themed icon update" into main 2023-11-06 19:08:10 +00:00
Andreas Agvard
d103d230a9 Merge "Enabled haptics during long press nav handle" into main 2023-11-06 08:40:58 +00:00
Himanshu Gupta
9aab4d4603 Adding Prework for Private Space integration in Launcher
This Cl adds the following:
1. Fixes for Quite Mode check maintained by Launcher
2. Addition of new Quite Mode broadcasts
3. Fixes for determining work profile user correctly.

Flag: ACONFIG com.android.launcher3.Flags.enable_private_space DEVELOPMENT
Bug: 289223923
Test: Ran Launcher3 tests
Change-Id: I5f6158b213723339e70ff99e66c5f439f5879e12
2023-11-05 12:31:10 +00:00
Andy Wickham
402ca3e3e5 Merge "Add animateNavBarLongPress to SystemUiProxy and ANIMATE_LPNH flag" into main 2023-11-04 19:57:39 +00:00
Thales Lima
e9b5e14a2b Use new icon stepping logic for Folders
Bug: 307694237
Test: DeviceProfileResponsiveDumpTest
Test: DeviceProfileResponsiveAlternativeDisplaysDumpTest
Test: ResponsiveFolderImageTest
Flag: ACONFIG com.android.launcher3.enable_responsive_workspace TEAMFOOD
Change-Id: Ifbfb714e48c2e0851ef55ac60cadafbb6358d074
2023-11-04 17:10:13 +00:00
Andreas Agvard
cb016243c7 Enabled haptics during long press nav handle
Flag: LEGACY ENABLE_SEARCH_HAPTIC_HINT ENABLED
Test: Manual
Bug: 303023676
Change-Id: Ia792fc6d00bf06320f51d56c43ed59c6dd23d456
2023-11-03 23:44:13 +01:00
Andreas Agvard
15ddc16b53 Merge "Tweak lpnh haptics based on UX input" into main 2023-11-03 22:41:02 +00:00
Priyanka Advani
ebc9a3b5e1 Merge "Revert "Change TAPL to swipe to stash taskbar (instead of deprec..."" into main 2023-11-03 22:10:27 +00:00
Priyanka Advani
9aed56096c Revert "Change TAPL to swipe to stash taskbar (instead of deprec..."
Revert submission 24877128-cherrypick-tapl-transient-swipe-owubvwrsw6i

Reason for revert: Likely culprit for b/309158105

Reverted changes: /q/submissionid:24877128-cherrypick-tapl-transient-swipe-owubvwrsw6i

Change-Id: I8ee560f7e599bcfde09eff53f049309ba25ce77f
2023-11-03 21:31:45 +00:00
Pat Manning
89bd90927d Merge "Fix focus navigation of All Apps when using external keyboard." into main 2023-11-03 18:42:37 +00:00
Tony Wickham
075a67da15 Merge "Change TAPL to swipe to stash taskbar (instead of deprecated long press)" into main 2023-11-03 18:35:54 +00:00
Kevin Lim
ab242020a2 Merge "[Settings] Remove logic to restore highlight to 0th item in SettingsActivity." into main 2023-11-03 18:12:09 +00:00
Charlie Anderson
a2d85dec47 Fixing polish issues with the U app shortcut popup design
Test: locally verified against design
Flag: NONE
Bug: 304807548

Change-Id: Iff22b3515b638700fb66e856944ec4aa1287e401
2023-11-03 11:46:44 -04:00
Andreas Agvard
3221a9235f Tweak lpnh haptics based on UX input
Flag: LEGACY ENABLE_SEARCH_HAPTIC_HINT DISABLED
Test: Manual
Bug: 303023676
Change-Id: I7c96ac82358059418665dfe569705e745da7b1d8
2023-11-03 14:11:41 +01:00
Michael Stokes
f5a83e56e0 Merge "Revert "Fix the badge in badge (triple badging), by simply remov..."" into main 2023-11-03 12:36:10 +00:00