Commit Graph

10360 Commits

Author SHA1 Message Date
Johannes Gallmann
661f96066e Fix predictive back to home with pinned taskbar
Bug: 309969400
Flag: ACONFIG com.android.window.flags.predictive_back_system_animations DISABLED
Test: Manual, i.e. testing predictive back with pinned taskbar
Change-Id: Ic6f747e87f8ebb2bed58f4783736ed4dca43fb7e
2023-12-07 15:51:46 +01:00
Andreas Agvard
52b5113e8d Merge "Adds supportsCommitHaptic" into main 2023-12-05 12:48:15 +00:00
Johannes Gallmann
e8575dfbe9 Merge "Fix delayed taskbar animation for predictive back" into main 2023-12-05 12:37:30 +00:00
Satish Yalla
b85266aef2 Merge "Revert "Change TAPL to swipe to stash taskbar (instead of deprec..."" into main 2023-12-05 10:21:18 +00:00
Satish Yalla
de82f8f44f Revert "Change TAPL to swipe to stash taskbar (instead of deprec..."
Revert submission 25532044-tapl-transient-taskbar-default

Reason for revert: <test revert (b/314873201)>

Reverted changes: /q/submissionid:25532044-tapl-transient-taskbar-default

Change-Id: I51e78699f588a8fe8506c96398de921448e0ab6a
2023-12-05 06:48:25 +00:00
Schneider Victor-tulias
dc4b61be59 Merge "Fix Keyboard quick switch screenshots and spliscreen launch" into main 2023-12-05 04:10:13 +00:00
Tony Wickham
2f334e9ca7 Merge "Change TAPL to swipe to stash taskbar (instead of deprecated long press)" into main 2023-12-05 02:40:02 +00:00
Vadim Tryshev
dc7de0d9fb Merge "Waiting for Launcher activity to stop when starting an overview task" into main 2023-12-04 21:47:09 +00:00
Sunny Goyal
b1e430bcb9 Revert^2 "Changing SystemUiProxy to kotlin"
49997a7cf9

Change-Id: Ieed3f7ad7c9d36ee1c2fc53e0c03df34698c256d
2023-12-04 17:21:22 +00:00
Andreas Agvard
973c049fe0 Adds supportsCommitHaptic
Test: Manual
Bug: 314408519
Flag: LEGACY ENABLE_SEARCH_HAPTIC_COMMIT ENABLED
Change-Id: Ia8f90489c2b8d82f6c63b4b363f9be5de6b2598b
2023-12-02 11:04:51 +01:00
Vadim Tryshev
caf5958e57 Waiting for Launcher activity to stop when starting an overview task
This will help to ensure that Launcher state has settled before continuing the test.

Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: Ie72853a9d289b2688fdfbdf5220ce86808ac2da1
2023-12-01 16:15:45 -08:00
Andreas Agvard
23de925836 Increase slider for haptic hint iterations
The haptic hint can now be made up to 200 itertions long (2.4 seconds)

Test: Manual
Flag: LEGACY ENABLE_SEARCH_HAPTIC_HINT DISABLED
Change-Id: I9c92d3cb24fabfa3b0d318a77d312423501737a6
2023-12-01 21:16:14 +01:00
Andreas Agvard
ffa44902d4 Merge "Adds support for shrinking nav handle on press" into main 2023-12-01 20:14:03 +00:00
Vinit Nayak
717c4f51ff Merge "Remove unused animation of splitInstructionsView text" into main 2023-12-01 20:00:27 +00:00
Andreas Agvard
1ea0746e1c Adds support for shrinking nav handle on press
Fix: 314158312
Flag: LEGACY SHRINK_NAV_HANDLE_ON_PRESS DISABLED
Test: Manual

Change-Id: Icd46467939ae9a38592ee67ee0d2a521eb8e0b6c
2023-12-01 17:54:41 +01:00
Pat Manning
bf6905c069 Merge "Navigate grid overview via arrows and tab properly." into main 2023-12-01 12:23:21 +00:00
Serdar Kocdemir
063858b510 Merge "Revert "Changing SystemUiProxy to kotlin"" into main 2023-12-01 12:04:59 +00:00
Pat Manning
e683c4c549 Navigate grid overview via arrows and tab properly.
Fix: 311646336
Fix: 281021558
Test: TaskGridNavHelperTest
Flag: N/A
Change-Id: Iad5a2eec22f8fa4519a6a1f7bcde097e00d6b142
2023-12-01 11:06:41 +00:00
Surajit Chandra
49997a7cf9 Revert "Changing SystemUiProxy to kotlin"
Revert submission 25509210-proxy-kotlin

Reason for revert: test revert b/314219394
Reverted changes: /q/submissionid:25509210-proxy-kotlin

Change-Id: I3ada33461886ba2428b6b768cacc0d5454d543a3
2023-12-01 08:27:16 +00:00
Sunny Goyal
6f04a32b21 Merge "Revert "Removing unnecessary iconFactory class when generating b..."" into main 2023-11-30 23:55:59 +00:00
Sunny Goyal
01f8bc59c6 Merge "Changing SystemUiProxy to kotlin" into main 2023-11-30 23:55:15 +00:00
Schneider Victor-tulias
55bdb474c2 Merge "Fix ANR in TouchInteractionService" into main 2023-11-30 23:27:39 +00:00
Saumya Prakash
89b93d4bbd Merge "Add taskbar pinning education for new users and update other steps" into main 2023-11-30 20:08:13 +00:00
Sunny Goyal
b18392cbe9 Changing SystemUiProxy to kotlin
> Simplifying some try-catch stamtements
> Removing unnecessary interface implementation
> Using kotlin native null check, which also prevents NullpointExeception
  when using calling methods from a non-main thread

Bug: 314010650
Flag: N/A
Test: Presubmit
Change-Id: I435ace5df8d7a19a8bba4099408f6cc7257d1f1f
2023-11-30 12:05:28 -08:00
Jagrut Desai
7736ec8968 Merge "Decreasing the intensity of haptic feedback for taskbar invocation" into main 2023-11-30 19:29:45 +00:00
Tracy Zhou
aa759645cf Merge "Use enableSplitContextually() to guard split keyboard shortcut feature" into main 2023-11-30 18:43:13 +00:00
Schneider Victor-tulias
b9341d1878 Fix ANR in TouchInteractionService
AccessibilityManager.registerSystemAction is a binder call that should be run on the ui helper thread. It is only used for the taskbar and likely ran slowly ON THE UI thread, causing an ANR.

Flag: N/A
Fixes: 313923168
Test: ran launcher
Change-Id: Icf8d7282df5bffd4aae2f4ec94f997b555c3b8c1
2023-11-30 13:05:37 -05:00
Sunny Goyal
dad66f4188 Revert "Removing unnecessary iconFactory class when generating b..."
Revert submission 25483550-themed-badge

Reason for revert: b/314097390

Reverted changes: /q/submissionid:25483550-themed-badge

Change-Id: I7ad16d7c5d5457d350ac6cff86d512c2f57dbcbf
2023-11-30 17:09:41 +00:00
Johannes Gallmann
b1f522d1a7 Fix delayed taskbar animation for predictive back
Bug: 311613831
Flag: NONE
Test: Manual, i.e. testing predictive back to home and analysing taskbar animation
Change-Id: I87d9ba065a43ee99ff1c7b35478b2828a482bd7b
2023-11-30 15:40:23 +01:00
Andreas Agvard
711f104409 Merge "Use NavHandleLongPressInputConsumer regardless of flags." into main 2023-11-30 13:32:00 +00:00
Pat Manning
2a350af739 Merge "Show taskbar pinning dialog on right-click." into main 2023-11-30 10:57:41 +00:00
Pat Manning
001d1cda52 Merge "Allow right-click of taskbar icons to launch long-click menu." into main 2023-11-30 10:56:46 +00:00
Anna Zhuravleva
94228b18db Merge "Add user_type field and log it in Launcher" into main 2023-11-30 10:28:45 +00:00
Johannes Gallmann
0c3b20b585 Merge "Use Decelerate Interpolator for predictive back to home window scaling" into main 2023-11-30 08:10:04 +00:00
Johannes Gallmann
c07b1c92b0 Merge "Prevent scaled window from leaving screen bounds for back to home" into main 2023-11-30 08:09:39 +00:00
Tracy Zhou
6209f34b02 Use enableSplitContextually() to guard split keyboard shortcut feature
enableSplitFromFullscreenWithKeyboardShortcuts() depends on enableSplitContextually() from the product perspective, hence merging these two flags

Bug: 270394122
Test: N/A
Change-Id: Iecf46a62bfa21ed0c3bad9ca8c9e2646b3aebc78
2023-11-29 22:20:42 -08:00
Winson Chung
abb4483f6f Merge "Add Launcher support for left-right splits on portrait foldables" into main 2023-11-30 05:52:57 +00:00
Jagrut Desai
a5ad8bed64 Decreasing the intensity of haptic feedback for taskbar invocation
Test: Presubmit, Manual
Bug: 308496668
Flag: NONE
Change-Id: Ic8c28b8e84bf9f388a73c518c91840d958287546
2023-11-29 19:03:33 -08:00
Jon @
95306b1502 Merge "Allow initial call to onLauncherVisibilityChanged when using home transition listener." into main 2023-11-30 01:15:26 +00:00
Jon Miranda
bd53046738 Allow initial call to onLauncherVisibilityChanged when using home transition listener.
Fixes: 308632502
Flag: ACONFIG ENABLE_HOME_TRANSITION_LISTENER TEAMFOOD
Test: HomeTransitionObserverTest
Change-Id: I8992f8f74cbfa7e98a79a136265ee6c4ad784c2c
2023-11-29 13:35:03 -08:00
Andy Wickham
3523154b07 Use NavHandleLongPressInputConsumer regardless of flags.
This way we can still log long press attempts even when the
feature flags or settings are disabled.

We always log LAUNCHER_LONG_PRESS_NAVBAR when a long press is
detected, even if nothing else happens.

Additionally, we log LAUNCHER_DEEP_PRESS_NAVBAR if the long
press was short-circuited by a deep press. In this case both
logs will appear.

If ENABLE_LPNH_DEEP_PRESS is false, it's possible that
LAUNCHER_DEEP_PRESS_NAVBAR will be logged without
LAUNCHER_LONG_PRESS_NAVBAR. This is because we log deep press
even if the feature is disabled, but it won't cause long press to
trigger immediately, so the user may release their finger before
the normal long press triggers.

Note: getLongPressRunnable will still return null if the flags or
other checks fail, so nothing will happen beyond logging.

Fix: 313477667
Fix: 310955078
Test: Manual with wwlogcat with flags in various states
Flag: NA
Change-Id: I40ceb5a22b364c2d5d6e4fdabb546b81c84354eb
2023-11-29 13:02:27 -08:00
Schneider Victor-tulias
f67c54b48f Fix Keyboard quick switch screenshots and spliscreen launch
Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 312449590
Fixes: 292182490
Test: TaplTestsKeyboardQuickSwitch, keyboard quick switched with split app pairs
Change-Id: I0faf2f7d58b39270ad6e5a065cf59f48e0dd23f0
2023-11-29 15:59:04 -05:00
Winson Chung
104a4c8b69 Add Launcher support for left-right splits on portrait foldables
Bug: 291018646
Test: Manual
Flag: enable_left_right_split_in_portrait

Change-Id: I92af7ffd83770f7e942c3892a12b1611ff5b50f4
Signed-off-by: Winson Chung <winsonc@google.com>
2023-11-29 20:20:14 +00:00
Alex Chau
4745e95ea7 Merge "Adjust app chip menu top margin." into main 2023-11-29 14:40:12 +00:00
Anna Zhuravleva
9c20381231 Add user_type field and log it in Launcher
Add new field user_type to decouple
work_profile and private_space users.
Deprecate is_work boolean field.

Bug: 312200869
Test: statsd_testdrive 19, output: https://paste.googleplex.com/5912695996416000
Flag: NA
Change-Id: Idc25f341b4353a85b8a93eab97c88195895baedc
2023-11-29 10:26:53 +00:00
Vinit Nayak
eabb37822f Merge "Change SplitInstructionsView cancel from X to "Cancel"" into main 2023-11-29 00:18:42 +00:00
Vinit Nayak
e5277ab8e7 Remove unused animation of splitInstructionsView text
* The animation of the overall view is
sufficient and we don't need this separate one

Flag: None
Bug: 295983387
Test: Visually appears the same
Change-Id: I6e3fe7191df8af869a50abab820d30e95e23696c
2023-11-28 14:39:18 -08:00
Pat Manning
ad6b044412 Adjust app chip menu top margin.
Include adjusting gap of menu when expanding app chip.

Fix: 313648444
Test: OverviewImageTest
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Change-Id: Iea8ea76873ac008b90b6a8f183dc99cba9237041
2023-11-28 22:38:22 +00:00
Vinit Nayak
d6efde5cbb Change SplitInstructionsView cancel from X to "Cancel"
* Styling (accent color) is still a TODO,
just made it bold for now.

Flag: ACONFIG com.android.wm.shell.enable_split_contextual DEVELOPMENT
Bug: 295983387
Test: Tested w/ flag on and off, cancel doesn't show
with flag off

Change-Id: Id5214a86abbe0cf095e32f6f75522ea51d6b1f3c
2023-11-28 14:34:12 -08:00
Johannes Gallmann
8c197b9328 Merge "Fix task window losing scale when going back to home" into main 2023-11-28 20:35:13 +00:00