Commit Graph

22274 Commits

Author SHA1 Message Date
Jordan Silva
612aac88cb Update marquee to show only when chip is expanded
- Introduced title and titleCollapsed to change the text when expanded and collapsed using only 2 dots for truncate the text, similar to ellipsize="marquee".

- Removed ellipsize="marquee" from the XML to prevent chip relayout when entering in Overview. See b/406969521.

Fix: 406969521
Fix: 403193877
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Change-Id: Ia95eb8b7ec6d22b9d576defe7c66a4950ee1dca3
2025-03-28 14:28:54 -07:00
Jordan Silva
12a154e1e2 Merge "Skips same drawable for app chip to improve performance" into main 2025-03-28 11:27:22 -07:00
Ats Jenk
6965cc0d25 Merge "Control stash handle visibility directly" into main 2025-03-28 10:01:02 -07:00
Jordan Silva
eefc673796 Skips same drawable for app chip to improve performance
`IconView` creates a new drawable and makes it mutate for scaling it during some animations. The `setDrawable` function there also performs more logic and invalidate the view. Thus, every time `setDrawable` is called in the `IconAppChipView`, even if the same drawable is provided, it will unnecessarily create a copy of the drawable, invalidate and redraw the whole view.

To prevent this inefficient behavior, a hash check has been introduced in `IconAppChipView`. This hash check skips the redundant logic if the same drawable is provided to `setDrawable`.

Bug: 402613435
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Change-Id: I3d20fa6bfc7aaf79222469ad88080985d4c1d1a0
2025-03-28 09:14:39 -07:00
Treehugger Robot
b9fd24446b Merge "Reland "Reduce calls to surface reparenting and set relative layer"" into main 2025-03-28 08:17:47 -07:00
Min Chen
3ce268355d Merge "Get DesktopTaskView from deskId" into main 2025-03-28 07:32:14 -07:00
Alex Chau
cb2b925a50 Reland "Reduce calls to surface reparenting and set relative layer"
Surface reparenting was happening on every frame since we call
applyDepthAndBlur on each frame during animation. Instead we can do it
only when base surface is set. mBlurSurface should always be parented to
mBaseSurface so no point in calling it again and again.

Relative layer changes only when we either draw above or recents. While
drawing above recents, mBaseSurface relative layer should be used.
mBaseSurfaceOverride otherwise. No point to call this during animation.

Added perfetto traces comparison home->all apps, alongwith all other
generic overview scenarios which possibly could have caused jank is
added here:

https://drive.google.com/drive/folders/146K_4WLaOGQcZ1gsuhCFlOCzfZ-mJBw8?resourcekey=0-r1-NnNtYGH88d8DGEvnXZg&usp=sharing

Bug: 404647629
Test: Manual. Enter overview from Desktop tile / home.
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I567d6b8615685e5c50ef7b7b15787fa56cb2da79
2025-03-28 13:01:22 +00:00
Will Osborn
fbfb7bf8b3 Merge "Fix launcher immutable list UnsupportedOperationException on swipe up" into main 2025-03-28 02:37:13 -07:00
Treehugger Robot
530ccf25a5 Merge "Forcefully finish recents animations when launcher is detroyed" into main 2025-03-28 01:55:03 -07:00
Johannes Gallmann
2fb39cf4f2 Merge "Play haptic on ACTION_DOWN for 3-button-nav buttons" into main 2025-03-27 23:48:51 -07:00
Eric Sum
0f02613b08 Merge "Add ACTION_DESKTOP_MODE_EXIT_MODE_ON_LAST_WINDOW_CLOSE latency (launcher)." into main 2025-03-27 22:19:21 -07:00
Schneider Victor-Tulias
8d72503263 Forcefully finish recents animations when launcher is detroyed
If launcher is destroyed while the recents animation start is pending, then the taskanimationmanager and absswipeuphandler states are not properly cleaned up. Adding a new cleanup flow to handle this case.

Flag: EXEMPT bug fix
Fixes: 405642423
Test: adb shell cmd uimode night yes/no while TaskAnimationManager.mRecentsAnimationStartPending == true
Change-Id: I7bf1fc4fc07859f92d7aec6cd78deafa1214dd17
2025-03-27 23:03:40 -04:00
Treehugger Robot
de9976afa5 Merge "Create RemoteTargetHandler based on GroupedTaskInfo" into main 2025-03-27 16:50:20 -07:00
minch
1f1f4a6267 Get DesktopTaskView from deskId
Fix the bug introduced by ag/32547343.
Getting the corresponding `DesktopTaskView` from the `deskId`
instead of `deskDisplayId`.

Bug: 406340124
Test: m
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Change-Id: Ifaa9a9602cb95c871dee16f874c2b4a51404aad1
2025-03-27 23:46:27 +00:00
Treehugger Robot
d1b30baedb Merge "Update SplitSelectDataHolderTest for HSUM" into main 2025-03-27 16:31:45 -07:00
Shamali Patwa
f216f3d2ce Merge "Delete the filter code as it will be provided differently in refactor" into main 2025-03-27 16:19:36 -07:00
Ats Jenk
f46ebe0378 Control stash handle visibility directly
Stash handle alpha animator was set to control the visibility of the
view. This caused issues with the state as sometimes the alpha animation
conflicted with the state of the bubble bar. And caused the handle to be
visible when the bubble bar (or handle) should not be.

Remove the ability for the handle alpha animator to manage the
visibility. We already have logic in place to ensure that the stash
handle is visible or invisible based on the state. And it is not needed
for the animator to manage it.

Bug: 392121302
Flag: com.android.wm.shell.enable_bubble_bar
Test: atest NexusLauncherRoboTests
Test: move an app to bubble, move it back to fullscreen, check that
  handle is hidden
Test: check that handle is hidden and shown when in app and opening
  notif shade
Test: check that handle is hidden and shown when in app and locking and
  unlocking device
Test: check that handle is shown when receiving bubbles in app and the
  bar stashes after showing new bubbles
Change-Id: I4af8b4fa38f63b3cbc01f9cf59e66d7fc651ab13
2025-03-27 15:23:38 -07:00
Treehugger Robot
39e6b8c4f6 Merge "[CD][Alt+Tab] Flatten Alt + Tab structure" into main 2025-03-27 14:49:55 -07:00
Treehugger Robot
d81b43802a Merge "Add showPinningView to TaskbarPinningControllerTest." into main 2025-03-27 14:45:20 -07:00
minch
8fbd61aca7 Create RemoteTargetHandler based on GroupedTaskInfo
Inside `RemoteTargetGluer`, create the `RemoteTargetHandle`
based on `GroupedTaskInfo`.

Bug: 406340124
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Test: m
Change-Id: I0603d0b05fbc4fa8042ef1da27b2cf95226969d9
2025-03-27 21:39:30 +00:00
Vinit Nayak
b988ca81b0 Update SplitSelectDataHolderTest for HSUM
Test: atest NexusLauncherTests:com.android.quickstep.util.SplitSelectDataHolderTest
Flag: EXEMPT test
Fixes: 398855338
Change-Id: Ia224be5291d9aa37f76ec0e1ac3d8096ec73d7c0
2025-03-27 17:20:44 -04:00
Shamali P
472709d9ca Delete the filter code as it will be provided differently in refactor
With the dagger update the initialization happens in constructor which
we would avoid once we work on refactor and move it into a repository
class. The list will also be fetched from a different data source, so,
makes sense to delete it at the moment.

Bug: 406324964
Flag: EXEMPT BUGFIX
Test: Not applicable as code is removed
Change-Id: Iab8bb1e94677abf9b5b882f4d3485b002faf3e0f
2025-03-27 14:15:05 -07:00
Alex Chau
e01a996b58 Merge changes I3c43ab80,Ib19011cd into main
* changes:
  Revert "Reduce calls to surface reparenting and set relative layer."
  Revert "Add logs for debugging to overview blur"
2025-03-27 13:48:52 -07:00
Jon Miranda
3e0f782663 Merge "Only sync app launch and taskbar when in Normal state." into main 2025-03-27 13:43:15 -07:00
Treehugger Robot
706a5e0626 Merge "Fix missing icon menu content for desk" into main 2025-03-27 12:25:18 -07:00
Charlie Anderson
4be299ec97 Merge "Make sure predicted app ring path gets updated with latest shape" into main 2025-03-27 11:45:10 -07:00
Jon Miranda
e5f04cdde0 Only sync app launch and taskbar when in Normal state.
Bug: 319162553
Test: Launch app from overview
Flag: com.android.launcher3.sync_app_launch_with_taskbar_stash
Change-Id: Ibb0849b251d5fa2f85c61946d1834fec78ef2e6a
2025-03-27 11:36:07 -07:00
Jordan Silva
cecaee661a Revert "Reduce calls to surface reparenting and set relative layer."
This reverts commit 1653a5082d.

Reason for revert: b/406789714

Change-Id: I3c43ab802d327e030b0e9473cd81e52ee2d7e028
2025-03-27 10:11:41 -07:00
Treehugger Robot
b3a5b7c8e4 Merge "Revert^2 "Simplifying model testing rules"" into main 2025-03-27 10:11:38 -07:00
Jordan Silva
4da65e47e4 Revert "Add logs for debugging to overview blur"
This reverts commit af83003826.

Reason for revert: b/406789714

Change-Id: Ib19011cdff3406bb7cf02c0ecbcef81ae0fa6036
2025-03-27 10:11:05 -07:00
Suhua Lei
0e7b86dbe3 Fix missing icon menu content for desk
Bug: 406073558
Flag: com.android.launcher3.enable_overview_icon_menu
Test: manully create desks

Change-Id: I852042db1fce5996717f6bce796d44fd4b1af42c
2025-03-27 16:59:54 +00:00
Winson Chung
cfe7494b67 Merge "Extend logic to clear visibility of occluded tasks in top task tracker" into main 2025-03-27 08:59:52 -07:00
Will Osborn
ba8a3ff176 Fix launcher immutable list UnsupportedOperationException on swipe up
Bug: 406740276
Flag: EXEMPT bugfix
Test: locally tested

Change-Id: I4dfd0434e9537103144d08fa4db96f43ee5b59a8
2025-03-27 15:54:58 +00:00
Pat Manning
9e8341ac2c Run expressive dismiss on closing task from menu.
Add default spring methods for running dismiss on a task.

Fix: 404206966
Test: Manual.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: Ic7c5b82d6b504a31193ba85b0c79dd89be344c22
2025-03-27 08:33:28 -07:00
Bill Yi
322c5f9e37 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2025-03-27 07:52:07 -07:00
Treehugger Robot
1431d1a211 Merge "Prevent initializing DWB Toast if it's already destroyed" into main 2025-03-27 07:05:18 -07:00
Charlie Anderson
91f881ed7b Merge "Add metrics logging for selected icon shape" into main 2025-03-27 06:35:40 -07:00
Jordan Silva
8356752a67 Prevent initializing DWB Toast if it's already destroyed
Fix: 406168165
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Change-Id: I66328917a9b75cd54549616e547acca698015ae4
2025-03-27 05:01:23 -07:00
Will Osborn
58dd096ce4 Merge "Fix for applyLoadPlan being called after RecentsView is destroyed." into main 2025-03-27 04:46:40 -07:00
Treehugger Robot
749927c88e Merge "Move querying focus display to TIS" into main 2025-03-27 04:14:02 -07:00
Ajinkya Chalke
552831ed28 [CD][Alt+Tab] Flatten Alt + Tab structure
Next:
- Look into sorting tasks based on last active time.
- Will update task thumbnails as per latest UX.
- Need to ensure the logic that determines which task has focus when overview is launched.

Bug: 382769617
Test: manually run CUJs
Flag: com.android.launcher3.enable_alt_tab_kqs_flatenning
Change-Id: Ic1ab8a3a30af3d941e26439507e5a583540759e5
2025-03-27 08:52:37 +00:00
Sunny Goyal
3b307455a0 Revert^2 "Simplifying model testing rules"
35b6d322ab

Change-Id: I3ed574a517dbe350b6dfe5b1d3ed198203d22f44
2025-03-26 23:08:55 -07:00
Treehugger Robot
b932dea54e Merge "Implement spring animations for running state changes." into main 2025-03-26 21:06:14 -07:00
Charlie Anderson
9a92108984 Make sure predicted app ring path gets updated with latest shape
- fixes issue where transient taskbar uses wrong predicted app shape

Bug: 388255881
Test: changing shapes and unstashing taskbar
Flag: com.android.launcher3.enable_launcher_icon_shapes
Change-Id: Ibdc54e4df5fd4f85ed62b5a8179dba044850cbbc
2025-03-26 23:54:55 -04:00
Treehugger Robot
d46249c412 Merge "Update Launcher UI when model changes are made outside of Launcher UI" into main 2025-03-26 20:35:30 -07:00
Charlie Anderson
a8b5c62382 Add metrics logging for selected icon shape
Bug: 400696362
Test: N/A
Flag: com.android.launcher3.enable_launcher_icon_shapes
Change-Id: Ibe85fad20ec35bc49dc8e76e3dbf402d31810d21
2025-03-26 20:08:48 -07:00
Jon Miranda
e6d41c9b2f Add showPinningView to TaskbarPinningControllerTest.
Simple test that checks long pressing on the divider icon shows the
pinning view.

Bug: 402671805
Bug: 346394250
Test: TaskbarPinningControllerTest
Flag: TEST_ONLY
Change-Id: I435be4d7a12b0a92432cba49e57b6cef46e9679d
2025-03-26 19:05:03 -07:00
Sunny Goyal
6e12b811a0 Merge "Revert "Simplifying model testing rules"" into main 2025-03-26 16:37:45 -07:00
Priyanka Advani (xWF)
35b6d322ab Revert "Simplifying model testing rules"
Revert submission 32704934-model-test-cleanup

Reason for revert: Droidmonitor created revert due to b/406588406. Will be verifying through ABTD before submission.

Reverted changes: /q/submissionid:32704934-model-test-cleanup

Change-Id: Ieeb7f5b5699afeae27f946f060147bb68afc36e5
2025-03-26 16:12:16 -07:00
Treehugger Robot
0219df0770 Merge "Simplifying model testing rules" into main 2025-03-26 15:10:44 -07:00