Commit Graph

46 Commits

Author SHA1 Message Date
Pat Manning
5aa23d41dd Focus a task by default when using keyboard to go to overview.
Fix: 322898816
Test: TaplTestsQuickstep.java
Flag: None.
Change-Id: I6d4b0ca6593ed2ac7c7d8793954c36e55b5978de
2024-02-23 12:22:06 +00:00
Federico Baron
cda8adfad3 Merge "Fix testDragToFolder()" into main 2024-02-23 00:41:55 +00:00
fbaron
d0f392db6e Fix testDragToFolder()
The issue here was that we were dragging to the folder icon when it was already a folder. We need to drag to the folder icon, wait for the folder to open, and then drag into the middle of the opened folder.

Fix: 320742556
Flag: NONE
Test: TaplDragTest#testDragToFolder
Change-Id: I82816f8e249cbe55fb4eef79c27e19b6fe00318e
2024-02-22 13:21:18 -08:00
Treehugger Robot
a5e8751f0d Merge "Merging multiple implementations of CancellableTask" into main 2024-02-22 02:54:30 +00:00
Tracy Zhou
0c801cbd20 Merge "Guard taskbar / navbar unification logic with whether the device is a phone on top of the flag" into main 2024-02-16 17:51:03 +00:00
Tracy Zhou
89f72882ce Guard taskbar / navbar unification logic with whether the device is a phone on top of the flag
Test: Rerun the tapl tests
Bug: 325162802
Change-Id: Iffeeb0a60b634e66bc80e4ba45db816cdc8ba564
2024-02-15 22:06:33 -08:00
Sunny Goyal
cc1dad0cae Merging multiple implementations of CancellableTask
Bug: 318539160
Flag: None
Test: Manual
Change-Id: Ie855427c2676e0ce76655e4dd67472c0b5e435d8
2024-02-15 13:01:10 -08:00
Vadim Tryshev
451eebd450 Adding logging for for the case whe Launcher activity is not resumed after Back
Bug: 322823209
Test: presubmit
Flag: N/A
Change-Id: I4e9b26ab142f4d69f906eeb6d5ab487babbcbca1
2024-02-15 12:39:27 -08:00
Vinit Nayak
574551e2a2 Add logs for uninstallWorkspaceIcon() test
Bug: 319501259
Change-Id: I2ac5c849e4551527eaf7f09a202f00a414d9d980
2024-02-14 23:29:04 +00:00
Vadim Tryshev
cb5d2ab72f Merge "Doubling the wait time for activity creation in PortraitLandscapeRunner" into main 2024-02-14 19:54:39 +00:00
Alex Chau
76502e84f2 Merge "Refactored StateManager logs" into main 2024-02-14 17:40:08 +00:00
Vadim Tryshev
dbaa758854 Doubling the wait time for activity creation in PortraitLandscapeRunner
Apparently, 10 sec is not sufficient, let's try 20.

Bug: 321772674
Test: presubmit
Flag: N/A
Change-Id: Iec67e4d0cf782d7d966566c305e8b73ee67d0f67
2024-02-13 13:50:15 -08:00
Vadim Tryshev
00538c2a5a Merge "Allowing the test to set additional anomaly checker for TAPL" into main 2024-02-13 21:16:41 +00:00
Alex Chau
4e6e1555c4 Refactored StateManager logs
- Make the log permanaent behind a DEBUG flag
- Logs are currently enabled with b/279059025 marked as the related bug

Bug: 279059025
Flag: None
Test: Manual
Change-Id: I60a75d73d40d00e7d42292f3d42cc9dd8c9b0825
2024-02-13 15:35:15 +00:00
Vadim Tryshev
09c5398533 Allowing the test to set additional anomaly checker for TAPL
This way, we can unify the messages from the test and the messages fom TAPL for TaplTests

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I9360e5d4ef47021d2dd7e01c859181bbc417a67d
2024-02-08 16:46:37 -08:00
Sebastián Franco
e6bab556a1 Merge "Remove unnecesary AbstractLauncherUiTest.initialize whit two arguments" into main 2024-02-08 19:33:13 +00:00
Vadim Tryshev
e2c07182ed Merge "Removing FilteredLogcat files" into main 2024-02-08 02:16:23 +00:00
Sebastián Franco
458de20538 Remove unnecesary AbstractLauncherUiTest.initialize whit two arguments
Bug: 324261526
Test: atest TaplDragTest
Flag: NA
Change-Id: I0802d725eea222d19c8d8e60878c2f88be854ddc
2024-02-07 22:48:26 +00:00
Anushree Ganjam
faa35a81bb Merge "Add Unit tests for System Shortcut." into main 2024-02-07 19:38:32 +00:00
Vinit Nayak
44911450c6 Merge "Update test infra to allow split placeholder view in all apps" into main 2024-02-07 14:57:19 +00:00
Vinit Nayak
fad0709510 Update test infra to allow split placeholder view in all apps
* Previously we assume the split placeholder view shouldn't be
present in any states except launcher split selection, however
with contextual that changes.
* Now we only ensure that view isn't there in all apps when
we are not in split selection.

Test: Test runs and passes locally
Fixes: 323418145
Change-Id: Ida92030f9b139532ebb09c1d2646795bbb940bfc
2024-02-07 03:32:02 +00:00
Vadim Tryshev
1e038e4c16 Removing FilteredLogcat files
We don't use them

Bug: 187761685
Flag: N/A
Test: presubmit
Change-Id: I236f3c8e8cc7372e371d9a5bc1ff37889e1ab87b
2024-02-06 18:47:36 -08:00
Jordan Silva
d5df5b3e11 Merge "Refactoring TAPL functions for OverviewTask" into main 2024-02-05 23:03:49 +00:00
Anushree Ganjam
9858a3e0f4 Add Unit tests for System Shortcut.
Update SystemShortcut<T extends ActivityContext> and remove dependency on Launcher so we can write unit tests.

Introduce TestSandboxModelContextWrapper , wrapper around SandboxModelContext and ActivityContext.

Use SandboxModelContext for testing since we need UserCache, AllAppsContainerView, AllAppsStore to be spied and verified for function calls.

StatsLogManager is not verified in this cl, We can do as follow up.

Bug: 319250810
Test: Manual.
Flag: aconfig com.android.launcher3.enable_private_space TEAMFOOD

Change-Id: If767128a502e40d2016a331db4a342f20f24c588
2024-02-05 10:59:52 -08:00
Jordan Silva
ebd71c6cc9 Refactoring TAPL functions for OverviewTask
This CL refactors some methods in OverviewTask to rely on OverviewSplitTask. It also changes the BaseOverview getTasks function to retrieve the parent task and support cases where only the bottomright_snapshot is available in the recent tasks.

Bug: 320633351
Test: TaplTestsSplitscreen
Flag: N/A
Change-Id: I226f895810ce3b46cc107f76cd85e2918abf7088
2024-02-05 13:50:23 +00:00
Cliff Wang
dd2222749b Merge "Revert "Make sure TAPL waits for Launcher activity to stop each time it stops"" into main 2024-02-05 08:21:54 +00:00
Cliff Wang
ac82e995ca Revert "Make sure TAPL waits for Launcher activity to stop each time it stops"
This reverts commit dd33b64a64.

Reason for revert: “DroidMonitor: Potential culprit for Bug b/323619378 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.”.

Bug:323619378
Change-Id: Iadaa80f2cc51f39ae3ab73cdd49a98d05835506e
2024-02-05 04:46:17 +00:00
Vadim Tryshev
f9eced5768 Merge "Make sure TAPL waits for Launcher activity to stop each time it stops" into main 2024-02-03 02:33:53 +00:00
Vadim Tryshev
dd33b64a64 Make sure TAPL waits for Launcher activity to stop each time it stops
This helps to ensure that the test doesn't proceed while the activity is
still stopping and it's state hasn't settled.

We introduce a count of STOP events and make sure it's 0 except for
cases where stops are safe to ignore or we have waited for them.

Bug: 313926097
Flag: N/A
Test: presubmit
Change-Id: I51c73c89854fcaa390d47a57389da18b2ce0ee6c
2024-02-02 15:21:20 -08:00
Sebastián Franco
fe5c308a11 Merge "Adding unit test to makeSpaceForHotseatMigration" into main 2024-02-02 17:52:52 +00:00
Fengjiang Li
2aaccefecb Merge changes I471c27b8,I602cf29b into main
* changes:
  Fix small gap between widget resize frame and widget background.
  Update TaplAddWidgetTest#testResizeWidget() and WidgetResizeFrame#resize() API to pass launcher's cellBoarderSpace and use its height to expand widget
2024-02-02 03:31:13 +00:00
Fengjiang Li
387fea9731 Update TaplAddWidgetTest#testResizeWidget() and WidgetResizeFrame#resize() API to pass launcher's cellBoarderSpace and use its height to expand widget
To expand widget vertically, the drag distance has to be >= 0.66 * (cellHeight + cellBoarderSpace.y). The TAPL test should add cellBoarderSpace.y onto the vertical drag distance to make test less flaky.

Bug: 291104076
Test: Postsubmit passed https://android-build.corp.google.com/builds/abtd/run/L49100030001703948
Flag: NA
Change-Id: I602cf29b83df6875abd8eadfe255a2adb13f03cb
2024-02-01 16:24:14 -08:00
Sebastian Franco
2d8be10856 Adding unit test to makeSpaceForHotseatMigration
Flag: NA
Bug: 318417510
Test: atest HotseatReorderUnitTest
Change-Id: If4fe388d00138b2d43693df0cf79abb16f354291
2024-02-01 17:08:52 +00:00
Schneider Victor-tulias
1ca66992c1 Update KQS overview launch animation
Updated the KQS overview launch animation to match the spec: open overview and scroll to the focused task in one fluid motion

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 313608085
Test: Opened KQS from home and overview
Change-Id: I2d617db29ff46e89fab50bb6f8aee900b6fe649f
2024-02-01 14:49:29 +00:00
David Saff
1121f8b5b9 Assert keyguard gone at beginning and end of PortraitLandscapeRunner
Should help distinguish if we have tests leaving things in a bad state,
or the intervening infrastructure.

Bug: 285935417
Change-Id: I5569472a9804cb21ee0646c72decb5f51be9ab01
2024-01-31 19:35:40 +00:00
Vadim Tryshev
a41fc4e4ad Merge "Verifying that keyguard is invisible before pressing Home in PortraitLandscapeRunner" into main 2024-01-30 20:47:27 +00:00
Sebastián Franco
ea73bf5d77 Merge "Removing the Worskapce as a dependency of CellLayout" into main 2024-01-30 02:19:19 +00:00
Federico Baron
8960937d47 Merge "Fix testDragToFolder test" into main 2024-01-29 19:27:24 +00:00
Vadim Tryshev
9a94452dbc Verifying that keyguard is invisible before pressing Home in PortraitLandscapeRunner
Bug: 285935417
Test: presubmit
Flag: N/A
Change-Id: I8c525b99e7dc434f0b68aad59a18908f4253b29b
2024-01-29 11:00:55 -08:00
Sebastian Franco
2986e0b4d1 Removing the Worskapce as a dependency of CellLayout
This will make it easier to test CellLayout, also we should avoid
circular dependencies as much as poisble.

This also allows the CellLayout to be created in other containers
that are not workspace.

Bug: 318417510
Test: creating HotseatReorderUnitTest in follow up cl
Test: TaplReorderWidgets
Test: ReorderAlgorithmUnitTest
Flag: NA
Change-Id: Ic45029a244cb11f8d6775c50b90af9c56f01eaa3
2024-01-26 09:28:57 -08:00
Rohit Goyal
9977121e8e Test Fix: Move UnarchiveBroadcastReceiver to AndroidManifest-common to also support NexusLauncher tests.
* Currently unarchival tests only pass for Launcher3. We extend the broadcast receiver to AndroidManifest-common to also support NexusLauncher tests.

Test: atest TaplPromiseIconUiTest.java
Bug: 319240622
Flag: ACONFIG com.android.launcher3.enable_support_for_archiving DEVELOPMENT
Change-Id: I9be459a2a0648063d62538eed20c0a6e7644ad44
2024-01-26 00:40:17 +05:30
fbaron
9a16ca5215 Fix testDragToFolder test
The issue seems to be that when we begin drag we enter spring loaded mode which triggers the 'app swap' interaction, leading us to getting the wrong position for the app icon we're trying to drag into. Using photos app instead of gmail should make it so that we don't enter the app swap operation with playstore, meaning we would get the correct position for play store and we will drag the app there

Fix: 320484402
Flag: NONE
Test: TaplDragTest#testDragToFolder
Change-Id: Id6f09be997046e7c450a2760ee95cc5735ad5673
2024-01-25 10:55:27 -08:00
Sebastián Franco
4d4c7e06eb Merge "Send ACTION_UP if there is an exception" into main 2024-01-23 18:40:53 +00:00
Vadim Tryshev
6be6906321 Send ACTION_UP if there is an exception
Test: presubmit
Flag: N/A
Bug: 187761685
Change-Id: I22fa5a9da7384a44b35bdd3b21c79837dbbd11d2
2024-01-22 16:24:31 -08:00
Vadim Tryshev
d1108f24e5 Send ACTION_POINTER_UP if there is an exception
Test: presubmit
Flag: N/A
Bug: 187761685
Change-Id: Ica5fec6e5732383aed764682619453b2b3fac113
2024-01-22 16:14:10 -08:00
Uwais Ashraf
77b97c0729 Replace existing Robolectric test task with functioning one.
This CL does the following:
- Creates a dir for multivalentTests
- Creates symlinks for the dir to keep Android Studio happy
- Moves many files to the multivalentTests dir
- Adjusts gradle and soong build files to use the new dir as part of
their source sets.

Test: ./gradlew :NexusLauncher:testGoogleWithQuickstepDebugUnitTest
Test: atest Launcher3RoboTests
Fix: 316553886
Bug: 316553889
Flag: NA
Change-Id: Iae28fd0c0191b3ecf9bd2950800875950cca2622
2024-01-19 21:39:23 +00:00