Commit Graph

9827 Commits

Author SHA1 Message Date
Tony Wickham
4fda59a0cc No longer stash taskbar when swiping up all apps
Instead, scale down hotseat behind all apps alongside workspace.

Test: Swipe up to all apps from home; all apps button in an app works as before
Fixes: 221094533
Change-Id: Ia6f1e7bac86849018dc8d0b1d95f0bab963835a8
2022-02-23 22:04:35 +00:00
TreeHugger Robot
c089baa668 Merge "Remove Taskbar and Taskbar EDU flags." into tm-dev 2022-02-23 20:10:02 +00:00
Vinit Nayak
58c27cce73 Remove Taskbar and Taskbar EDU flags.
Bug: 219035565
Change-Id: I643b5d006b5759723418901ffeb463fa04a82cbc
(cherry picked from commit ec4adc1d5a)
2022-02-23 18:14:28 +00:00
Alex Chau
b8c22e1155 Tune AllApps bottom sheet VisD and motion
- Make AllApps bottom sheet solid and appears from bottom
- Teleport AllApps bottom sheet as user drag to reduce drag range
  - Consider teleport interpolation for state transition sdetection
- Tuned workspace motions for AllApps bottom sheet (no translate, shrink)
- Add portrait vertical translate for tablet portrait including taskbar AllApps
- Updated bottom sheet handle and created common variables for other bottom sheets

Bug: 208599118
Test: manual on tablet AllApps, taskbar Allapps and handheld AllApps
Change-Id: I69dba5f155914cd012cc8ef3be1ef71fb2be5a40
2022-02-23 17:08:06 +00:00
Brian Isganitis
a1370bfc5f Put taskbar all apps in separate overlay window and stash taskbar.
All apps should display below system UI components such as the
notification tray and power menu, so an overlay window is more
appropriate. As a result, all apps has a separate window activity
context, but some properties are delegated to the taskbar activity
context. Taskbar should also be stashed while all apps is open.

Change-Id: I593457708779d84a0ab8b949a966d247d0a2e1b7
Test: Manual
Bug: 216843189
Fix: 217383817
(cherry picked from commit 473b980bf9)
2022-02-23 15:06:56 +00:00
TreeHugger Robot
0f3b6511aa Merge "Fix Launcher icons not animated during unfold" into tm-dev 2022-02-23 14:03:39 +00:00
Alex Chau
82166fa6d8 Merge "Disable flakey fallback recents test" into tm-dev 2022-02-23 10:58:26 +00:00
Winson Chung
4c2e3310e6 Disable flakey fallback recents test
- Seems to be an existing failure in the recents animation not
  finishing, should disable to unblock folks

Bug: 218403080
Test: Presubmit
Change-Id: Ia42009666c67c29c1a78a2fe197bdce53dcb2ec8
2022-02-23 06:44:55 +00:00
TreeHugger Robot
49cb99a420 Merge "Fix jump in animation for hotseat while re-arranging icons" into tm-dev 2022-02-23 02:40:11 +00:00
Nicolo' Mazzucato
5765d42ada Fix jump in animation for hotseat while re-arranging icons
While re-arranging icons the hotseat remains in scale 1.0f, while the workspace reduces it's scale (as defined by SpringLoadedState.java). Previously, the code to aggregate animations was assuming hotseat and workspace always had the same scale.

MultiScaleProperty.get() was being used to set the starting value of the animation. Previously, it was returning the last aggregated value. However, this value was correct only for the workspace, but not for the hotseat. Returning the current view scale makes it always correct.

Bug: 220271046
Test: Dragged icons from hotseat to workspace, and verified animation didn't jump
Change-Id: Ic01776c1d8e3967624626ed7c44d194a06295790
2022-02-22 18:27:26 +01:00
Nicolo' Mazzucato
d4a5bb244a Fix Launcher icons not animated during unfold
If icons are re-bound during the animation, they were not moved. I was able to reproduce this case 100% of times by folding, restarting launcher and unfolding. From a perfetto trace it seems that in this case `finishBindingItems` was called after the animation already started, therefore not registering any view.

With this cl, items are animated also after they are rebound.

Bug: 197834977
Test: folded -> restarted launcher -> unfolded -> verified icons are now moving towards the center
Change-Id: I5b001c502860c17d6ea5d54d099f04b2ddf1820a
2022-02-22 13:48:35 +01:00
Jordan Demeulenaere
78ef3a5348 Enable back gesture when a SyUI dialog is showing (2/2)
Test: Manual
Bug: 210270549
Change-Id: I8fbf9a90287cbd8d9ddad354e24bbc4d074bd0ef
2022-02-22 11:09:03 +01:00
Winson Chung
3516ecc534 Allow split with an existing split task
- Determine the task in the group being clicked in split-select mode
  and launch split using that selected task
- Also make sure we don't handle drag cancel twice when we are animating
  the return of the drag surface

Bug: 219060441
Test: Split from home/overview with fullscreen+fullscreen task, and with
      fullscreen+split task

Change-Id: I48ec0a82812197803ff4b3698830a9cb705719e3
2022-02-18 17:49:59 +00:00
Vinit Nayak
afd9bfebe1 Merge changes from topic "presubmit-am-a8c798abe8b24577a107553295b8cd0f" into sc-v2-dev-plus-aosp am: 0dffbfcba6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16828919

Change-Id: I0e30b14ef15fde94a27369f3c76f975c8272736f
2022-02-16 21:43:27 +00:00
Vinit Nayak
0dffbfcba6 Merge changes from topic "presubmit-am-a8c798abe8b24577a107553295b8cd0f" into sc-v2-dev-plus-aosp
* changes:
  [automerge] Add null check for null task in getItemInfo() 2p: 73c6288038
  Add null check for null task in getItemInfo()
2022-02-16 21:23:47 +00:00
Vinit Nayak
95686cd9be Merge "Ensure starting split animation scale is always 1" 2022-02-16 18:49:40 +00:00
TreeHugger Robot
64162f1e05 Merge "Update TAPL object hierarchy in preparation for Taskbar TAPL tests" 2022-02-16 18:20:06 +00:00
Presubmit Automerger Backend
21e44c56bb [automerge] Prevent lingering divider animators in AbsSwipeUpHandler 2p: 7faaffa56a
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16693066

Bug: 213403679
Change-Id: I628b14fb01461a103dd0cdd7168835197a28f1c5
Merged-In: I078a7d0f22c2ef2ba847796ec79e740c789ce1ae
2022-02-16 17:13:58 +00:00
Winson Chung
7faaffa56a Prevent lingering divider animators in AbsSwipeUpHandler
- Refactor the util method to create the animator and track the existing
  animation in AbsSwipeUpHandler to be able to cancel it if another call
  to change the visbility comes in.  Note that this doesn't address
  the case where the launch animation overlaps with swipe up (though that
  hopefully shouldn't happen in normal usage)

Bug: 213403679
Test: Tap in the gesture space while split
Change-Id: I078a7d0f22c2ef2ba847796ec79e740c789ce1ae
Merged-In: I078a7d0f22c2ef2ba847796ec79e740c789ce1ae
2022-02-16 17:13:48 +00:00
Tony Huang
b39ef58493 Merge "Refactor startIntentAndTaskWithLegacyTransition" 2022-02-16 03:45:02 +00:00
TreeHugger Robot
940e5c7328 Merge "Cover thumbnail view instead of TaskView for split animation" 2022-02-15 23:22:32 +00:00
Evan Rosky
0a2f5b0baa Merge "Switch pip to fixed-rotation in shell transitions" 2022-02-15 22:34:34 +00:00
TreeHugger Robot
451e468678 Merge changes from topic "presubmit-am-cc24ad26c93446a690f8a34ffde58aa3" into sc-v2-dev-plus-aosp am: 3a6a78f7b0
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/16828915

Change-Id: Icfc37fdb5858352e77628959ed7e627712620cdd
2022-02-15 22:32:43 +00:00
Schneider Victor-tulias
d6279ae641 Update TAPL object hierarchy in preparation for Taskbar TAPL tests
See design at: go/taskbar-tapl-tests

Test: Ran tests remotely
Bug: 215218813
Change-Id: I1c2ceac8954973ea3ae5b2f797fdfb96ba7a6ec4
2022-02-15 13:33:26 -08:00
Vinit Nayak
12a24dca8d Cover thumbnail view instead of TaskView for split animation
Fixes: 219622592
Test: Slowed down animation and verified same as before
refactor was done.

Change-Id: Iec8dc9ea1d7925575c3a3b84e12653829a00d8dd
2022-02-15 12:41:11 -08:00
Vinit Nayak
181f4b2c40 Ensure starting split animation scale is always 1
Bug: 194414938
Test: After second app selected, first split placeholder
view doesn't jumpcut to arbitrary Y bounds.

Change-Id: Ic8b809f147bf38f78198ef4224d810faf5e3c5ba
2022-02-15 12:01:37 -08:00
Brian Isganitis
7b046e7e27 Merge "Add predictions row to taskbar all apps." 2022-02-15 19:24:53 +00:00
TreeHugger Robot
fccae60a24 Merge "Add Z scaling during unfold to launcher" 2022-02-15 17:49:11 +00:00
Nicolo' Mazzucato
12131a40fe Add Z scaling during unfold to launcher
The unfold progresses are mapped to 0.85 - 1 range and set as a scale for launcher.

In case of multiple scale animations for workspace and hotseat, they are combined using MultiScaleProperty (e.g. opening an app while unfolding/going to all apps while unfolding). Note that this is a pretty difficult scenario to be in. If that happens, we multiply all values and bound the result between the max and min values.

Bug: 217368525
Test: atest MultiScalePropertyTest and manually
Change-Id: I6131c39f36deade0b7280c72edda2d72045344e9
2022-02-15 17:02:36 +01:00
Tony Huang
3a2d621429 Refactor startIntentAndTaskWithLegacyTransition
Param intentFirst is not necessary because we could use stagePosition
to ensure intent side is left or right.
Remove it and ensure start task on main stage at split side.

Bug: 218613028
Test: pass existing tests
Test: manual
Change-Id: I3b8fc74b18c4d48fe73b501be696c3d59677183b
2022-02-15 15:57:02 +08:00
TreeHugger Robot
b70131e1dd Merge "Use config_imeDrawsImeNavBar in Launcher" 2022-02-15 02:50:21 +00:00
Benno Lin
978d646864 Merge "Implemnet methods to drag a icon to given Workspace cell" 2022-02-15 01:49:21 +00:00
Benno Lin
7738cac424 Implemnet methods to drag a icon to given Workspace cell
The CL implements public methods to drag an Icon from AllApps to a
given cell in the workspace.

Bug: 199120092
Test: Launcher3Tests:com.android.launcher3.ui.TaplTestsLauncher3#testDragAppIconToWorkspaceCell
Test: https://android-build.googleplex.com/builds/abtd/run/L89300000953052361
Test: https://android-build.googleplex.com/builds/abtd/run/L44500000953013792
Change-Id: Ife16d1f1b55b809763dd40f5afee6711049a4729
2022-02-15 01:48:45 +00:00
Brian Isganitis
099945b075 Add predictions row to taskbar all apps.
- We need to listen to DeviceProfile changes in case the number of
  columns changes in the grid. I made an interface/mixin separate from
  ActivityContext to avoid polutting the latter with too many things. I
  also applied this change to existing taskbar A-Z grid.
- Added all apps visited count to onboarding preferences for only
  showing "All Apps" label in place of divider 20 times. Label is also
  tracked on taskbar side and should be kept in sync.

Test: Manual
Fix: 216843395
Bug: 174174514
Change-Id: I97aa91397c334123626caf18251f19e17c7104fb
2022-02-14 11:24:16 -08:00
TreeHugger Robot
bf96683e46 Merge "Fix taskbar hotseat alignment" 2022-02-14 13:03:46 +00:00
Tom Natan
7823e8b5b6 Merge "[11/n] Letterbox Education: set LAUNCHER_TASKBAR_EDUCATION_SHOWING." 2022-02-13 12:20:57 +00:00
Tony Wickham
1c51edcef3 Merge "Only show unstash feedforward hint when long press will unstash" 2022-02-12 20:22:38 +00:00
Tony Wickham
9b2b607a09 Fix taskbar hotseat alignment
- Use hotseatBorderSpace instead of cellLayoutBorderSpace
- Also divide by 2f instead of 2 because AS was complaining. May or may not potentially address off by 1 pixel issues.

Test: locally set alignment = 1, ensure perfectly aligned
Fixes: 218880076
Change-Id: Ifec30e6727f62985427b65b6c0b0810e7f7cd695
2022-02-12 19:23:23 +00:00
Thiru Ramasamy
5ed87e4c96 Populate search attributes only if the atom's has DeviceSearchResultContainer.
Bug: 199495917, 218973952
Test: https://android-build.googleplex.com/builds/abtd/run/L37100000953023420
Change-Id: I355b4ec0806755f6c72d59b04555b970ca1578f5
2022-02-12 00:57:33 +00:00
Thiru Ramasamy
84a7fee8af Reverting the change that causes test breakage
Bug: 218973952
Test: wwdebug && wwlogcat
Change-Id: I494608ba3df31e9129dc47fc016a7e077e506165
2022-02-11 11:03:09 -08:00
Alex Chau
bf57c15750 Merge "Avoid AllApps bottom sheet from being and add collapse handle" 2022-02-11 11:07:25 +00:00
tomnatan
9f12373bdd [11/n] Letterbox Education: set LAUNCHER_TASKBAR_EDUCATION_SHOWING.
The setting is set to 1 if the taskbar education should be shown as soon as the animation for opening an app starts and is set back to 0 when the taskbar education window is detached from the window.

Bug: 214590804
Test: N/A
Change-Id: Id26e3051a6e0ef1f9c2dcbeef98710efbb4df54f
2022-02-11 10:28:51 +00:00
Riddle Hsu
adfdfd8868 Merge "Set launch source info for shell recents animation" 2022-02-11 06:33:18 +00:00
Jeremy Sim
b84462a6b4 Merge "Fix DWB placement in grouped task view" 2022-02-11 06:22:40 +00:00
Tony Wickham
31a4c539d0 Only show unstash feedforward hint when long press will unstash
Test: Long press to unstash while in an app still works and shows feedforward; long pressing handle while in overview, all apps, or when IME is showing doesn't show anything.
Fixes: 218902248
Change-Id: I2c96570cab018c0e63c446793b84b210964bdb94
2022-02-11 00:29:56 +00:00
Evan Rosky
693f4e78bb Switch pip to fixed-rotation in shell transitions
Pip fixed-rotation should also be active when shell-transitions
is using fixed-rotation.

Bug: 217560545
Test: enter landscape pippable, enter pip (eg. via swipe-to-home)
Change-Id: I9bfbc1efc230a94dd9a480195e3a6ddf712ab353
2022-02-10 16:16:12 -08:00
Jeremy Sim
c78ac6277c Fix DWB placement in grouped task view
In grouped task view, DWB banners will now rotate properly when phone is
in landscape or seascape orientation. Also fixes a couple of minor
existing issues with the bottom task not displaying correctly in the
first place.

Fixes: 208357326
Fixes: 216218406

Test: Tested locally on Pixel 6, using landscape, seascape, and
portrait. Double-checked with task proportions changed, RtL/LtR, and
split top/split left/split right initialization.

Change-Id: I945f9937d2d4d784c0c74a006c7d0680daf628c2
2022-02-11 00:13:13 +00:00
Thiru Ramasamy
70f3f86702 Merge "Populate LauncherUiChanged.search_attributes field." 2022-02-10 23:35:49 +00:00
Alex Chau
fb54cf54e3 Avoid AllApps bottom sheet from being and add collapse handle
- Instead of using top margin, use top padding instead
- Add a separate LinearView for the bottom sheet background
- Added a handle to bottom sheet background that handle touches

Bug: 208599118
Test: phone, tablet and taskbar
Change-Id: Id8d3cb5ee6c58193926e2cf5ea7b0cb2280098be
2022-02-10 20:03:56 +00:00
Evan Rosky
19f7d988d1 Merge "Use fixed-rotation by default for shell transitions" 2022-02-10 19:51:45 +00:00