Commit Graph

11203 Commits

Author SHA1 Message Date
Schneider Victor-tulias
a9721fd344 Merge "Add debug logs to AbsSwipeUpHandler" into main 2024-04-12 20:39:51 +00:00
Sunny Goyal
4396a935c2 Merge "Using resource overrides for PluginManager instead of code-swap" into main 2024-04-12 20:29:36 +00:00
Sunny Goyal
4a22ed81ea Using resource overrides for PluginManager instead of code-swap
Bug: 330920490
Test: Presubmit
Flag: None
Change-Id: Ib1cd50f95873928b9ce104e8e95d21f1dca9c6e3
2024-04-12 11:38:32 -07:00
Schneider Victor-tulias
9622927c8d Add debug logs to AbsSwipeUpHandler
Investigating b/332386996

Flag: N/A
Bug: 332386996
Test: TaplTestsQuickstep#testQuickSwitchFromApp
Change-Id: Ic5245416df624b722819a3dcf1008ca0196d3161
2024-04-12 13:34:31 -04:00
Saumya Prakash
5bb103246b Merge "Adjust where the back button is rendered for new SUW requirements." into main 2024-04-11 19:05:52 +00:00
Saumya Prakash
da26e19dd8 Adjust where the back button is rendered for new SUW requirements.
Large screen devices in landscape mode and devices that have mostly a
square aspect ratio are undergoing a redesign in Setup wizard that makes
most screens two-pane. As part of this redesign, the back button is
aligned in this change. This change doesn't use a flag because the Setup
Wizard change is not flagged.

Fixes: 323778778
Fixes: 328017929
Test: Run Setup Wizard and see if the back button aligns with the Skip
button in two pane screens.
Flag: N/A

Change-Id: I22680f40c0ddf7cd03ab1da69406eb14184b0174
2024-04-11 16:53:41 +00:00
Randy Pfohl
819b835519 Revert "Revert "abtracting Activity from recentsView through rec..."
Revert submission 26911513-revert-26414135-RecentsViewContainer-MEROZZOKJQ

Reason for revert: Fix for issue has been found and will be included in this revert.

Reverted changes: /q/submissionid:26911513-revert-26414135-RecentsViewContainer-MEROZZOKJQ

Change-Id: I517e7d2fc0d82d250a6ed40862dd31c194d0a302
2024-04-11 08:58:08 -07:00
Luca Zuccarini
926a10a3b0 Create a stubbed IRemoteTransition implementation.
Bug: 323863002
Flag: NA
Test: NA, new method is unused (still builds)
Change-Id: Ibc4187f469e41b2db91bef368c710ffbdcd33faf
2024-04-11 09:15:41 +00:00
Vinit Nayak
20c0b2f647 Merge "Add placeholder divider view when starting split tasks" into main 2024-04-11 05:10:35 +00:00
Vinit Nayak
cdaabc6199 Add placeholder divider view when starting split tasks
* This prevents launcher underneath from peaking through
while the split apps are loading

Bug: 299640096
Test: Launched from recents, home and all apps
Doesn't seem to affect small screen since recents scrolls
away and the scrim is only left

Change-Id: I32e394a0bc361489473ee657161c8f3bcbf1e422
2024-04-11 05:09:49 +00:00
Tracy Zhou
f5299f3168 Merge "Move AbstractFloatingView for stage split layering above all apps" into main 2024-04-11 05:05:01 +00:00
Tracy Zhou
3158bf7e43 Move AbstractFloatingView for stage split layering above all apps
- We don't need to worry about if it's in Overview. Only overview has task menus, so if there is no task menu, we place it at the top.

Fixes: 332465429
Test: Launch stage split using keyboard shortcuts with all apps open. Make sure it's above all apps.
Change-Id: Ic950d2897fe80ef407038dd840b86fc92d6d6287
2024-04-10 19:42:50 -07:00
Priyanka Advani
1d6851083b Merge changes from topic "revert-26414135-RecentsViewContainer-MEROZZOKJQ" into main
* changes:
  Revert "abtracting Activity from recentsView through recentsview..."
  Revert "fixing tests to match new abstraction"
2024-04-10 23:58:09 +00:00
Sunny Goyal
63bf93cf65 Merge "Freezing legacy feature flags" into main 2024-04-10 22:29:24 +00:00
Priyanka Advani
3c71346147 Revert "abtracting Activity from recentsView through recentsview..."
Revert submission 26414135-RecentsViewContainer

Reason for revert: Probable culprit for b/333767026. Will be verifying through ABTD for confirmation and before submitting the revert.

Reverted changes: /q/submissionid:26414135-RecentsViewContainer

Change-Id: I25775cd6531355f1dc042ddb7a8d442ee0b36e58
2024-04-10 21:31:07 +00:00
Vinit Nayak
24f88860de Merge "Launch split tasks at beginning of animation instead of the end" into main 2024-04-10 20:16:08 +00:00
randypfohl
547d6fc472 abtracting Activity from recentsView through recentsviewcontainer and basecontainerinterface interfaces
This change will let us move from activity to other parent views for recent views.

Summary: In prep for new recentsview containers outside of activity we needed to decouple recentsview from activity and state.
This change will let us move from activity to other parent views for recent views.

Test: Built and tested locally for 1p and 3p launchers on tablet, and portrait modes. Verified working functionality.

Bug: 292269949

Flag: NONE

Change-Id: I5c72745f438d466362ece988c35a97d829e9c1b4
2024-04-10 09:14:28 -07:00
Holly Jiuyu Sun
c2ee3f5001 Merge "[omni] Implement 2-stage for LPNH." into main 2024-04-10 15:35:54 +00:00
Jeremy Sim
4eac54565e Merge "Prevent menu items from showing on split tasks" into main 2024-04-10 15:25:27 +00:00
Alina Zaidi
0580379e30 Rename freeform tasks to desktop tasks
Bug: b/332878426
Test: refactoring CL. Existing unit tests still pass.
Flag: NONE

Change-Id: I24ad9699223dd383ff794ef3b028bf32beca96d7
2024-04-10 12:30:50 +00:00
Brian Isganitis
3f4e5812ce Merge "Prevent meta shortcut from cancelling split select state." into main 2024-04-10 07:34:47 +00:00
Holly Sun
deee0d06f6 [omni] Implement 2-stage for LPNH.
Use existing override duration and touch slop multiplier values for the 1st stage. Times `TWO_STAGE_MULTIPLIER` for the 2nd stage.
See http://shortn/_WqYj0buH7R

Bug: 330446193
Test: manual
Flag: legacy ENABLE_LPNH_TWO_STAGES disabled
Change-Id: Ic200f431524578d17fd98ebfbc65e44e0971e31c
2024-04-09 17:00:15 -07:00
Holly Jiuyu Sun
c072d44b4e Merge "[omni] Log LP duration & slop's data source and value." into main 2024-04-09 23:52:39 +00:00
Anushree Ganjam
586eb65c0d Merge "Fill CellX , CellY and Rank for predictionRowView iteminfo." into main 2024-04-09 23:26:58 +00:00
Brian Isganitis
84fbec0b16 Prevent meta shortcut from cancelling split select state.
There are two things that need to be changed for this to work:

1. Make the isInOverview condition check for any Overview UI (including
   the split select state, modal, etc.)
2. Toggle Home All Apps directly, because firing the intent will cause
   Launcher to pause and resume before the intent is handled. We
misinterpret the pause as a request to cancel split screen. Since
TaskbarManager has a reference to Launcher, we might as well call the
method directly.

Test: Manual
Fix: 319076403
Flag: N/A
Change-Id: Ib8899188f593a168a054a16717df4a95be098557
2024-04-09 16:10:56 -07:00
Sunny Goyal
8049369af8 Freezing legacy feature flags
Legacy feature flags will be locked to their current values in code.
All new feature development should use aconfig flags

Bug: 332588958
Flag: None
Test: Presubmit
Change-Id: Ie72dd8276b7135620de279835d6721a34f82ede4
2024-04-09 15:26:07 -07:00
Treehugger Robot
b155421ada Merge "Add debug log for RecentsView touch down" into main 2024-04-09 21:32:52 +00:00
Sunny Goyal
3b00e7909a Merge "Using resource override instead of code-swap for ApiWrapper" into main 2024-04-09 20:33:20 +00:00
Alex Chau
8ddacf2185 Merge "Add more logs tracking gesture and recents animation in RecentsView" into main 2024-04-09 20:32:19 +00:00
Alex Chau
55ef24c229 Merge "Add task menu item to move task to Desktop" into main 2024-04-09 20:31:47 +00:00
Holly Sun
6d8b85e83a [omni] Log LP duration & slop's data source and value.
For duration, the data source and value should be the same for LPNH and LPH. E.g., if AGSA overrides duration, it applies for both LPNH and LPH. When there is no AGSA override, there are cases that one of our feature flag is enabled and the other one is disabled. We just simply rely on LPNH's feature flag in this case. This should be fine because the purpose is to cross check the data source and its value.

Bug: 332722082
Test: manual
Flag: legacy CUSTOM_LPNH_THRESHOLDS enabled
Change-Id: I3f10b944257e7021ae7c930b782f1d963c0e505b
2024-04-09 13:27:41 -07:00
Holly Jiuyu Sun
887a88f149 Merge "[omni] Read and use touch slop multiplier for LPNH." into main 2024-04-09 20:17:51 +00:00
Treehugger Robot
cb8ad6edde Merge "Add debug log for TaskView.onClick" into main 2024-04-09 19:54:11 +00:00
Treehugger Robot
58d913d996 Merge "Fix BinderTests#testSwitchToOverview" into main 2024-04-09 19:41:29 +00:00
Anushree Ganjam
59ab86218b Fill CellX , CellY and Rank for predictionRowView iteminfo.
HotseatPreditionController already does this: https://source.corp.google.com/h/googleplex-android/platform/superproject/main/+/main:packages/apps/Launcher3/quickstep/src/com/android/launcher3/hybridhotseat/HotseatPredictionController.java;l=239;drc=fe3f542e614df52cdcfa761074dd52957788a670;bpv=0;bpt=0

PreparePredictionInfo: https://source.corp.google.com/h/googleplex-android/platform/superproject/main/+/main:packages/apps/Launcher3/quickstep/src/com/android/launcher3/hybridhotseat/HotseatPredictionController.java;l=413-419;drc=6cdf7ce91a2643e02156d5ab8fb0f1c416f80c29;bpv=0;bpt=0

adb shell dumpsys activity NexusLauncherActivity

Before: https://paste.googleplex.com/4907497231482880

After: https://paste.googleplex.com/5157313861648384

Test: Manual
Flag: NA
Bug: 332171918

Change-Id: Ic9522238b2df06eb7c96b7f8961bc174fae17c9c
2024-04-09 11:57:13 -07:00
Sunny Goyal
11117d9b2a Using resource override instead of code-swap for ApiWrapper
Bug: 330920490
Flag: None
Test: Presubmit
Change-Id: Iac19f32e64d2c76ed5b4f8592943ee4ae7af51b5
2024-04-09 11:14:44 -07:00
Schneider Victor-tulias
2dee591601 Fix BinderTests#testSwitchToOverview
This test has been failing because the "unexpected" Binder call is actually expected. Updated the test to account for this.

Flag: N/A
Fixes: 315075477
Test: BinderTests#testSwitchToOverview
Change-Id: I2f5d3d07f6ec373f394e7a6f3887000af5f63c7e
2024-04-09 14:04:34 -04:00
Holly Sun
9b11c40b01 [omni] Read and use touch slop multiplier for LPNH.
1) This part is missing from the previous set of CLs. `getLPNHCustomSlopMultiplier` is defined but unused. Similar as reading LPNHDuration, we should also read the touch slot multiplier in Launcher for LPNH.
2) Also, change type to float, which is consistent with our existing implementation and the definition in OverviewProxyService.
3) Slop value is in percentage and Launcher divide it by 100. We haven't got AGSA implementation yet so we can predefine this part.

Bug: 330444720
Bug: 330446188
Test: manual
Flag: legacy CUSTOM_LPNH_THRESHOLDS disabled
Change-Id: Id606a4bc765fe01464ef36a2806c280ee42d30cd
2024-04-09 10:10:10 -07:00
Alex Chau
45162f9cf0 Add debug log for RecentsView touch down
Bug: 318590728
Test: manual
Flag: None
Change-Id: I591ed74af748f0fe424e1b58b4f610a21a106124
2024-04-09 17:46:38 +01:00
Alex Chau
34bfc7a80b Add debug log for TaskView.onClick
Bug: 310064698
Test: manual
Flag: None
Change-Id: Ib772dd8995442d3b1af84aec0668b11828ab62e6
2024-04-09 17:45:30 +01:00
Helen Cheuk
a0dc66c206 Merge "Add focus outline to overview clear all button" into main 2024-04-09 16:27:27 +00:00
Brian Isganitis
093b432985 Merge "Reset allAppsVisible if folding to phone upon recreateTaskbar." into main 2024-04-09 16:22:16 +00:00
Brian Isganitis
4ba8346a34 Merge "Use translation shift setter when showing AllApps without animation." into main 2024-04-09 16:21:54 +00:00
Alex Chau
3c0729c462 Add task menu item to move task to Desktop
- Call SystemUiProxy.moveToDesktop to move existing Overview tasks to desktop
- Animation polish will be handled separately
- Refactored AbstractFloatingView method into a helper to allow testing

Fix: 320310347
Test: DesktopSystemShortcutTest, AbstractFloatingViewHelperTest
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Change-Id: I2e4e04182e46ba4750e0683ee1789ba8fada06ea
2024-04-09 16:35:55 +01:00
Liran Binyamin
60d4e8d3b8 Merge "Fix NPE when setting bubble bar bounds" into main 2024-04-09 14:04:19 +00:00
Sunny Goyal
8ecbaa422f Merge "Moving various nav-bar configs out of feature flags" into main 2024-04-09 05:45:21 +00:00
Vinit Nayak
26c11f2c49 Launch split tasks at beginning of animation instead of the end
* Ideally we animate the live leashes from the placeholder tasks,
that's a lot more changes at this moment so we don't do that
* Instead we just hold off fading in the leashes until the very
end of the animation
* This way taskbar can scale down correctly in both contextual and
app pair launch cases since now launcher visibility will be changed
at the same time

Bug: 308851855
Test: Launches are a bit snappier from workspace/all apps compared
to overview, but in a good way!(?)

Change-Id: I73a9284a2b1a993c5a020396e2aca8499fc5eb09
2024-04-08 22:28:01 -07:00
Jeremy Sim
6a60c3b113 Prevent menu items from showing on split tasks
This CL changes the TaskShortcutFactory for SCREENSHOT and MODAL so that the associated menu options ("Screenshot" and "Select") don't show up on split tasks. These actions are not fully supported on splitscreen tiles (they will only work on one of the two apps), so we disable them.

Bug: 327434215
Flag: N/A
Test: Manual
Change-Id: I121a9c28fa7570f10e13be2de6489182e3362cfc
2024-04-08 17:56:29 -07:00
Jeremy Sim
fa3eae99a5 Merge "Fix bug where app pair title was not updating with language" into main 2024-04-09 00:22:19 +00:00
Sunny Goyal
89931316a2 Moving various nav-bar configs out of feature flags
Bug: 332588958
Test: Presubmit
Flag: None
Change-Id: Ia4dc5b69bcf4d461e3444b9e37bb7334bb74aae4
2024-04-08 16:54:04 -07:00