There are two things that need to be changed for this to work:
1. Make the isInOverview condition check for any Overview UI (including
the split select state, modal, etc.)
2. Toggle Home All Apps directly, because firing the intent will cause
Launcher to pause and resume before the intent is handled. We
misinterpret the pause as a request to cancel split screen. Since
TaskbarManager has a reference to Launcher, we might as well call the
method directly.
Test: Manual
Fix: 319076403
Flag: N/A
Change-Id: Ib8899188f593a168a054a16717df4a95be098557
For duration, the data source and value should be the same for LPNH and LPH. E.g., if AGSA overrides duration, it applies for both LPNH and LPH. When there is no AGSA override, there are cases that one of our feature flag is enabled and the other one is disabled. We just simply rely on LPNH's feature flag in this case. This should be fine because the purpose is to cross check the data source and its value.
Bug: 332722082
Test: manual
Flag: legacy CUSTOM_LPNH_THRESHOLDS enabled
Change-Id: I3f10b944257e7021ae7c930b782f1d963c0e505b
This test has been failing because the "unexpected" Binder call is actually expected. Updated the test to account for this.
Flag: N/A
Fixes: 315075477
Test: BinderTests#testSwitchToOverview
Change-Id: I2f5d3d07f6ec373f394e7a6f3887000af5f63c7e
1) This part is missing from the previous set of CLs. `getLPNHCustomSlopMultiplier` is defined but unused. Similar as reading LPNHDuration, we should also read the touch slot multiplier in Launcher for LPNH.
2) Also, change type to float, which is consistent with our existing implementation and the definition in OverviewProxyService.
3) Slop value is in percentage and Launcher divide it by 100. We haven't got AGSA implementation yet so we can predefine this part.
Bug: 330444720
Bug: 330446188
Test: manual
Flag: legacy CUSTOM_LPNH_THRESHOLDS disabled
Change-Id: Id606a4bc765fe01464ef36a2806c280ee42d30cd
- Call SystemUiProxy.moveToDesktop to move existing Overview tasks to desktop
- Animation polish will be handled separately
- Refactored AbstractFloatingView method into a helper to allow testing
Fix: 320310347
Test: DesktopSystemShortcutTest, AbstractFloatingViewHelperTest
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Change-Id: I2e4e04182e46ba4750e0683ee1789ba8fada06ea
This CL changes the TaskShortcutFactory for SCREENSHOT and MODAL so that the associated menu options ("Screenshot" and "Select") don't show up on split tasks. These actions are not fully supported on splitscreen tiles (they will only work on one of the two apps), so we disable them.
Bug: 327434215
Flag: N/A
Test: Manual
Change-Id: I121a9c28fa7570f10e13be2de6489182e3362cfc
For taskbar unification, we should reset this bit to false when folding
into phone orientation. Otherwise, we will reinit Taskbar AllApps over
the phone UI which is unexpected behavior.
Test: Manual
Flag: N/A
Fix: 293379641
Change-Id: I53c38c8b4df477191be3c21b7750c55a71c7336f
The no-animation case used to be handled immediately upon inflating the
view, so we got away with reassigning the field to
TRANSLATION_SHIFT_OPENED directly. Since this happens in post of a
handler, we need to instead use the setter so that a relayout happens.
Test: Manual
Fix: 324268840
Flag: N/A
Change-Id: I089f15a8d64e0d22885ae387679214a540790ad0
The bubble bar bounds change listener is sometimes invoked before the IBubbles service has been initialized.
This change adds a null check before calling the service.
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Fixes: 332423960
Test: manual
Change-Id: Iaa048c62a60c90c5e416da05ba53467a5034d86c
This change adds a new education tooltip for pinned taskbar that teaches
users how to use Circle to Search invoked through the action key. It won't run on
transient taskbar or if the user is in 3 button mode. The disclosures at
the bottom of the tooltip link to localized legal agreements for the feature.
Fix: 330401405
Test: Pin the taskbar and observe that the next time an app is launched
the edu shows up. After dismissal it shouldn't show up again.
Additionally, click on the disclosures and ensure they launch.
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning NEXTFOOD
Change-Id: I64aea3004aca77c3ec81b81dea0cfab7a9c1e272
When launcher receives the initial bubble state update from sysui, don't animate the bubbles. The initial update is sent when bubble bar is created and not when new bubbles are created.
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605846
Test: manual
Change-Id: I74b09220be22d7382fa6d7c1351d5e60a799a054
This CL adds the ability for an app pair icon to update its title string when package changes are detected. It also reorganizes some code in the app pairs classes for readability.
Fixes: 316051810
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual
Change-Id: I833e4f9766b7da8c0a3a5fb4b9fc050d8897437e
Bug: 329012507
Flag: none
Test: trigger assistant, ensure bottom insets are removed in
gesture nav mode; also verify IME inset override correctly
applies in 3 button mode
Change-Id: I823d0d360a7e3b41cc291f6949d9371e0dc32efb
Check whether the state update indicates that the bubble bar is expanding, and pass that to the bubblebarviewcontroller so that we can suppress the new bubble animation if we're expanding from stashed.
Note that in some cases the notification service may not include the auto expand flag on the message it sends to sysui, so launcher will end up getting 2 separate messages. We may need to handle that separately.
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605846
Test: manual
- create bubble that auto expands
- observe that the bubble does not animate
- note that in some cases the notification service may not include the auto expand flag, will look into that separately.
Change-Id: Id7e2db5fd32d391413c57d83effb4b23b1085125
