Commit Graph

20901 Commits

Author SHA1 Message Date
Jagrut Desai
463c3b06b9 Merge "Don't recreate taskbar in Overview" into main 2024-12-05 19:32:07 +00:00
Tracy Zhou
d2b90982eb Merge "Restore barMode and wallpaperVisible to Taskbar NavbarButtonsViewController state" into main 2024-12-05 19:08:24 +00:00
Luca Zuccarini
7be62fbe00 Merge "Revert "Revert "Use the Coreographer's frame time for a more rel..."" into main 2024-12-05 10:23:36 +00:00
Matt Sziklay
f47c28ef95 Merge "Implement cancel transition on tapping floating view." into main 2024-12-05 03:16:51 +00:00
Treehugger Robot
db013a8e75 Merge "TaskViews indices inside RecentsView continue [2/n]" into main 2024-12-05 00:35:26 +00:00
minch
1bf7678154 TaskViews indices inside RecentsView continue [2/n]
In applyLoadPlan
- Refactored newFocusedTaskView to be based on first non-Desktop TaskView
- Set newFocusedTaskView to null when enableGridOnlyOverview() is on
- Updated target page calcuation to be based on the following priority: running task, focused task, first non-desktop task, last desktop task

Flag: EXEMPT as no functionality changes
Bug: 379942019
Test: Ensure targetPage in applyLoadPlan is correct in the following scenarios:
1. Only have desktop task
2. Desktop task and a few full screen tasks
3. Swipe up from desktop, 1st fullscreen task, and 2nd fullscreen task
4. Repeat with enableGridOnlyOverview() on, which does not have focused task

Change-Id: Iea519ad4a37c15f76557487078ac4dcf4d53480c
2024-12-04 22:21:20 +00:00
Treehugger Robot
9fdf9efdd2 Merge "multiple-desktops: Add new desktop button xml file" into main 2024-12-04 14:02:41 +00:00
Alex Chau
ba8b4d7851 Merge "Reland "Handle uiMode changes in QuickstepLauncher"" into main 2024-12-04 10:45:02 +00:00
minch
7fbc82cab1 multiple-desktops: Add new desktop button xml file
- Add the skeleton xml file for the new desktop button
- Add the icon for this button as well
- Create the kotlin file for this button

Flag: EXEMPT as added files haven't connected with the production logic
Fix: 379941322
Test: None
Change-Id: I5c7ea2c061f0f9539483221f40c892626103d11e
2024-12-04 10:26:42 +00:00
Tracy Zhou
3d31b97389 Restore barMode and wallpaperVisible to Taskbar NavbarButtonsViewController state
Fixes: 379816005
Test: manual
Flag: EXEMPT bugfix
Change-Id: I2a181c498cb674f077d1b0accfe85b62880a1cfc
2024-12-03 17:16:09 -08:00
Tony Wickham
ab8fa5e67e Merge "Factor in userId for updateHotseatItemsFromRunningTasks" into main 2024-12-04 00:31:48 +00:00
Tony Wickham
db64e1b3d1 Factor in userId for updateHotseatItemsFromRunningTasks
Test: onRecentTasksChanged_inDesktopMode_sameHotseatPackage_differentUser_isInShownTasks
Test: Pin personal Chrome, open work Chrome in desktop mode; ensure a
new work icon is created in the running apps section
Flag: com.android.window.flags.enable_desktop_windowing_taskbar_running_apps
Bug: 376818660

Change-Id: Ie5cf3ab8e839456e6bd774de8a4398835e790019
2024-12-04 00:31:36 +00:00
Saumya Prakash
1fa9b25b73 Merge "Ensure Desktop Tasks show up in Taskbar multi instance menu" into main 2024-12-03 21:14:32 +00:00
Alex Chau
007abe80e4 Reland "Handle uiMode changes in QuickstepLauncher"
- Added uiMode in handled configChanges for QuickstepLauncher, NexusLauncherActivity
- RecentsActivity will be handled separately in b/382072029
- This avoids Launcher from being recreated when swithching from an app in driving mode (e.g. Maps), which causes massive jank
- Launcher layout is unaffected when driving mode changes, so a recreation is unnecessary
- When Light/dark mode changes, BaseActivity.updateTheme will still causes activity to be recreated. Launcher will mark a boolean in saved staete so next recreate will restore previous state even if state has FLAG_DISABLE_RESTORE (e.g. Overview), similar to the existing check that force restore when UI_MODE changes

Relanded changes: /q/submissionid:27627108-b/339747262

Fix: 339747262
Test: Swtich from driving mode app to another or home in 1p and 3p laucnher
Test: Switch light/dark mode and Launcher is updated correctly and stay in previous state
Flag: EXEMPT bugfix
Change-Id: I5a62b1bcd19eed9d232f30db94aa0e032f4541bd
2024-12-03 18:20:56 +00:00
Schneider Victor-tulias
bbefa5daf7 Merge "Use the RecentsWindowTracker in FallbackRecentsTest rather than RecentsActivity's ActivityTracker when flag is enabled" into main 2024-12-03 16:06:40 +00:00
Treehugger Robot
1c9b6dd4f3 Merge "[Launcher Memory Leak] Fix leak of AbsSwipeUpHandler via Launcher#mOnDeferredActivityLaunchCallback" into main 2024-12-03 03:56:03 +00:00
Saumya Prakash
a32f7f3f4a Ensure Desktop Tasks show up in Taskbar multi instance menu
This change adds in desktop tasks to show up in the Manage Windows
Taskbar menu. Previously these were getting filtered out.

Fix: 380167542
Bug: 315989246
Test: Launch multiple tasks in desktop mode and see that they show up in
the multi instance viewer from the Taskbar menu
Flag: com.android.launcher3.enable_multi_instance_menu_taskbar

Change-Id: Ia07b3ad68f43c0f121b0608c5341d50970c8af4c
2024-12-02 23:44:59 +00:00
Tony Wickham
7614088dc5 Merge "Fix Taskbar 3 Button y position on launcher home pause/resume" into main 2024-12-02 23:33:57 +00:00
Wen-chien Wang
ef427290c9 Merge "Register back action to close the KQS view" into main 2024-12-02 22:04:11 +00:00
Schneider Victor-Tulias
1df3836591 Use the RecentsWindowTracker in FallbackRecentsTest rather than RecentsActivity's ActivityTracker when flag is enabled
Test: pre/postsubmit
Fixes: 381548102
Flag: EXEMPT checking broken tests
Change-Id: I5764c661c53c383a80fbd568e839a5f3d2633427
2024-12-02 16:40:32 -05:00
Treehugger Robot
fc6d6be050 Merge "Using inteface descriptor as the key for various interface extras" into main 2024-12-02 21:22:45 +00:00
Wen-Chien Wang
ecc50c6d7c Register back action to close the KQS view
As the KQS view is not extending the floating view, we have to
explicitly register the back action to close the KQS view.

Bug: 379778483
Test: open KQS via alt-tab/overflow button and tap the back button
Flag: com.android.launcher3.taskbar_overflow
Change-Id: I140813d1792f0c17aee5f9f8dd9fa3ed8b40ba6c
2024-12-02 21:00:35 +00:00
Liran Binyamin
35b7616cd9 Merge "Reset the bubble bar scale when the animation is interrupted" into main 2024-12-02 19:51:19 +00:00
Fengjiang Li
c83ee2aefe [Launcher Memory Leak] Fix leak of AbsSwipeUpHandler via Launcher#mOnDeferredActivityLaunchCallback
Heap dump shows that we keep AbsSwipeUpHandler in memory via Launcher#onDeferredActivityLaunchCallback after swipe up gesture or qucik switch gesture is completed.

Fix: 380860147
Flag: NONE - release code
Test: presubmit
Change-Id: I40da887aedf6ed040b4262fcd6a918f885968e1f
2024-12-02 10:25:01 -08:00
Saumya Prakash
5b878bbf1a Merge "Add animations to Manage Windows menu in Taskbar" into main 2024-12-02 17:58:32 +00:00
Liran Binyamin
3931b671b4 Reset the bubble bar scale when the animation is interrupted
Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 381283214
Test: atest BubbleBarViewAnimatorTest
Test: manual
       - have a bubble in the bubble bar
       - launch an app
       - set animator scale to 5x to slow down animation
       - send a bubble
       - when the bubble bar animates interrupt the animation by
         touching the bubble bar
       - observe the bubble bar scale is reset correctly
Change-Id: I1abd81e3df987ba749a13eb1b7506d5c1d8fdddd
2024-12-02 11:23:35 -05:00
Liran Binyamin
495fe1d255 Merge "Animate the bubble bar on dismiss" into main 2024-12-02 14:28:30 +00:00
Luca Zuccarini
1c28a44714 Revert "Revert "Use the Coreographer's frame time for a more rel..."
Revert submission 30577378-revert-30509816-raf-timing-EAFMYZVSQM

Reason for revert: this test on Cuttlefish seems to be very unstable in general. I tried to re-test on ABTD with these reverts patched in, but the test isn't being included in the suite, and I couldn't find information anywhere on whether it's supposed to be still running. Since these changes are fully flagged, I don't see how they could be the real culprit. Trying to submit again and monitoring the impact on the postsubmits.

Reverted changes: /q/submissionid:30577378-revert-30509816-raf-timing-EAFMYZVSQM

Change-Id: I4c1dc43858060716450bab20e3c56728235508c7
2024-12-02 12:49:08 +00:00
Andy Wickham
3be4c7d458 Merge "Cleanup the null checks added in ag/30408877" into main 2024-12-01 06:00:19 +00:00
Treehugger Robot
add782b869 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-11-30 21:27:38 +00:00
Treehugger Robot
16740cd22a Merge "Make TaskView not clickable when in select mode for switch access and touchscreen usage." into main 2024-11-29 21:13:31 +00:00
Uwais Ashraf
a8f01bac1d Make TaskView not clickable when in select mode for switch access and touchscreen usage.
Fix: 320228423
Flag: EXEMPT BUG_FIX
Test: Manual - steps from bug
Change-Id: Ib831ab52ce3cc3a19e73f6b255cab519074c24b6
2024-11-29 16:38:14 +00:00
Treehugger Robot
2f3d9aae18 Merge "Mock UserCache in TaskViewItemInfoTest to avoid NPE" into main 2024-11-29 14:37:53 +00:00
Johannes Gallmann
cc6e7f09c9 Merge "Fix ConcurrentModificationException in TouchInteractionService" into main 2024-11-29 13:13:39 +00:00
Alex Chau
9e52a665a6 Mock UserCache in TaskViewItemInfoTest to avoid NPE
- Also added test for runtimeStatusFlags on regular/private apps

Fix: 381295678
Test: TaskViewItemInfoTest
Flag: EXEMPT BUG_FIX
Change-Id: I928a8f128957885d33ac8001493eef0fd4b23ec7
2024-11-29 12:42:15 +00:00
Johannes Gallmann
108dc037a0 Fix ConcurrentModificationException in TouchInteractionService
Bug: 381018493
Test: Manual, i.e. verified that unregistering listener during set iteration works
Flag: EXEMPT bugfix
Change-Id: Ia4600797ce579b80621b32977fcd9712d4fc26bb
2024-11-29 11:15:40 +00:00
Treehugger Robot
b1629b250d Merge "Add missing overview state event to tests" into main 2024-11-28 22:38:13 +00:00
Treehugger Robot
9ba4899872 Merge "Wait until AllSetActivity.onResume to start the background animation" into main 2024-11-28 16:42:01 +00:00
Gustav Sennton
68648283a8 Use bugfix flags for desktop mode transitions (exit, applaunch, alttab)
The transitions changes are bug fixes / polish, so use bugfix flags
for these changes.
An existing non-bugfix flag cannot be changed into a bugfix flag, so
instead we create new flags with the bugfix type.

Bug: 380224768
Bug: 380225486
Bug: 380224832
Test: manual - disable main flags, use bugfix flags
Flag: com.android.window.flags.enable_desktop_windowing_enter_transition_bugfix
Change-Id: I1c9ea635a362db741f4a632e6360aee87c12750e
2024-11-28 12:32:34 +00:00
Mykola Podolian
6baca730ff Merge "Only adjust the hotseat if bubble bar is visible." into main 2024-11-28 04:09:00 +00:00
Bill Yi
02925dcda5 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Id3dd3f3a10edac962c71d7695073179515feceec
2024-11-27 17:34:56 -08:00
mpodolian
24521dd6f8 Only adjust the hotseat if bubble bar is visible.
The change avoids setting up the hotseat if there is no bubble bar.

Fixes: 379809704
Test: EXEMPT bugfix
Flag: com.android.wm.shell.enable_bubble_bar

Change-Id: I26820e3a13a4eaceb0897e44852c0d70aa71918b
2024-11-27 17:12:25 -08:00
Sukesh Ram
3cecfd077c Fix Taskbar 3 Button y position on launcher home pause/resume
When app launcher pauses (not on app entry, but whilst home), we want to move the taskbar buttons to 3-button mode to avoid overlap with any popup UI (usually in the form of bottom sheets). To avoid overriding existing app entry animations, this is only implemented for cases of launcher pause without a launcher stop.

Flag: EXEMPT bugfix
Bug: 373977342
Bug: 374058222
Test: Manual
Change-Id: I727173b0ae7f3f8e23b1da6755ceda6493b311cb
2024-11-28 00:27:42 +00:00
Andy Wickham
cdcfaa80b2 Cleanup the null checks added in ag/30408877
These checks should be safe, but could be hiding other issues.
They were originally added as a workaround for presubmit failures
only on mokey_go32 (32 bit Android Go).

Bug: NA
Flag: EXEMPT cleanup
Test: Manual and existing presubmit tests
Change-Id: Ifcd136f61c885dba316e492a2408b67b42dcffcf
2024-11-27 15:36:37 -08:00
Andy Wickham
28d920ef05 Merge changes from topic "rm-lph-flag" into main
* changes:
  Make ContextualSearchInvoker not a ResourceBasedOverride.
  End live tile when invoking Circle to Search over Overview.
2024-11-27 23:32:29 +00:00
Liran Binyamin
7e387fa505 Animate the bubble bar on dismiss
When the last remaining bubble is dismissed by drag or from the menu
we now fade out the bubble bar.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 347062801
Test: manual
       - create a single bubble in the bar
       - expand
       - dismiss by drag or from menu
       - observe animation
Change-Id: I86fcaf04c6f5949126744b81e0042b0e58318a13
2024-11-27 16:23:26 -05:00
Andy Wickham
2ae01adf71 Make ContextualSearchInvoker not a ResourceBasedOverride.
This was previously only used to honor the INVOKE_OMNI_LPH flag
which has been enabled for a long time. So this is part of that
cleanup.

Bug: 297561673
Test: Manual
Flag: EXEMPT deleting legacy flag
Change-Id: Ife9f14faa2099f579f631da2aadaa6a56cbba51d
2024-11-27 13:03:18 -08:00
Andy Wickham
03a96eb8f7 End live tile when invoking Circle to Search over Overview.
This fixes many animation/state issues related to switching tasks
from the live tile to AGA.

Demo before: https://drive.google.com/file/d/1aBsn_-4tRHRsfGSqsx44_1B7dgdPOq_v/view?usp=drive_link&resourcekey=0-EHyEiKRVEC2ooUo-0rcjHg
Demo after: https://drive.google.com/file/d/1Sf5cUh8hC-slUZc_efOChzxxw710pG65/view?usp=drive_link&resourcekey=0-Wr33tL3ytedMibcVNd6auw

Bug: 372592549
Bug: 297831970
Test: Manual, updated ContextualSearchInvokerTest.
Flag: EXEMPT bugfix
Change-Id: I538cb1de61e48de4cf7c6fca8710a655933d07a3
2024-11-27 13:03:08 -08:00
Mykola Podolian
400fc4ad98 Merge changes I239f9357,I57a32ac5 into main
* changes:
  Update setting taskbar window height
  Set bubble bar aligned to QSB
2024-11-27 20:44:53 +00:00
Uwais Ashraf
bfede7eb48 Merge "Exclude cleanup methods from CUJ for entering split select." into main 2024-11-27 20:28:40 +00:00