Commit Graph

5720 Commits

Author SHA1 Message Date
Abhilasha Chahal
43d68e9f6b Merge "Check if launcher has touch interaction service when registering touch events" into tm-dev 2022-05-06 21:58:36 +00:00
Alex Chau
950437ce26 Merge "Fix overview and quickswitch gesture logging" into tm-dev 2022-05-06 19:05:43 +00:00
Schneider Victor-tulias
a78e070a2e Merge changes from topic "presubmit-am-1224af9ca3f341a895e4bc19976e2bb8" into tm-dev
* changes:
  Fix recents animation flicker
  Fix janky overview animation.
2022-05-06 18:48:29 +00:00
Abhilasha Chahal
997a757661 Check if launcher has touch interaction service when registering touch events
Bug: 228014625
Test: Refactoring change

Change-Id: I3b94f4f7fabf7cb2964eefd5cf1e099d2bb80ca6
2022-05-06 16:21:48 +00:00
Becky Qiu
6183c4dd74 [Toast] Create one search tapl tests for opening qsb and calculator app.
Test design doc: https://docs.google.com/document/d/1aPtMvegzn4hdwC0CNuIkfkalqG7v0FNCfyoO7qIOfN4/edit?usp=sharing&resourcekey=0-71oNHp1KKOdDKxr7Vd4dGQ

Bug: 225935921
Bug: 225935929
Test: ran test in android studio
Change-Id: I74197a9d81fc75a44269ab3bc1bba910de5e17fe
2022-05-05 18:47:34 -07:00
Alex Chau
a717d1621d Allow BaseState.getTransitionDuration to read DeviceProfile
- Changed handheld duration to AllApps to 600

Bug: 227745955
Test: manual
Change-Id: I6f6642440dda3e39947231c2d38e8b60d152e08f
2022-05-05 14:44:00 +01:00
Alex Chau
a70e23384f Fix overview and quickswitch gesture logging
- Log Home -> Overview gesture
- Log Home -> quickswitch as LAUNCHER_QUICKSWITCH_RIGHT

Bug: 219686410
Test: Local log in StatsLogCompatManager
Change-Id: Ic88fefd5af58dc03779f77b12611843c40706b1c
2022-05-05 14:33:27 +01:00
Schneider Victor-tulias
9f922d3598 Fix recents animation flicker
The recents animation can sometimes start before launcher has started when started with 3-button mode. This causes the animation to start before the recents UI has been initialized by Launcher. Added a callback to properly synchronize launcher start and the recents animation.

Fixes: 229360539
Test: started the recents animation and checked logs (order of operations), when the recents animation or launcher started first
Change-Id: I5938bbba778a2886b4a1e4ee4844eaf28c6fac0e
2022-05-04 22:27:50 +00:00
Shan Huang
9cb46e4327 Merge "Close icon folder for predictive back to home animation." into tm-dev 2022-05-04 20:26:59 +00:00
Pat Manning
f4bd9b6304 Merge "Update workspace, cell layout, shortcut and widget, and cell size calculations." into tm-dev 2022-05-04 18:19:02 +00:00
Pat Manning
b45d6c421d Update workspace, cell layout, shortcut and widget, and cell size calculations.
Test: DeviceProfileGridDimensionsTest.kt
Fix: 230862148
Change-Id: Ib1d577bf21beb45b2f8b3d4bd57e72c188e0f71b
2022-05-04 15:39:03 +01:00
TreeHugger Robot
3fd92a955e Merge "Use isTablet instead of isPhone for check" into tm-dev 2022-05-04 11:52:53 +00:00
TreeHugger Robot
c8b095e28c Merge "Don't fade out live tile when dismissed" into tm-dev 2022-05-04 02:47:02 +00:00
Anushree Ganjam
32a05ae3f0 Use isTablet instead of isPhone for check
Bug: 228803923
Bug: 227565451

Test: Manual.
Change-Id: If7a21495b126230de8e91126ef0f3fcf54f9c900
2022-05-03 23:10:47 +00:00
Vinit Nayak
13b16060f3 Don't fade out live tile when dismissed
* Fading out exposes the wallpaper underneath
since the task is layered below launcher and
we draw a cutout in the scrim

Fixes: 230916221
Test: Swiping up on live tile task doesn't fade
Change-Id: Ie4a81aeed3de242146248ecae7734e5e02985040
2022-05-03 15:35:34 -07:00
Shan Huang
8f45458925 Close icon folder for predictive back to home animation.
Folders are typically closed in launcher#onResume. However in the
predictive back flow, launcher isn't resumed until transition fully goes
through. Therefore we need to explicitly close the folders on transition
start.

Bug: 229861300
Test: Open an opted in app from workspace folder and swipe back (with
animations enabled).

Change-Id: I4b5229cd2590c164ffba892f49eeb2e26438eadf
2022-05-03 22:35:14 +00:00
Sunny Goyal
f76524151d Merge "Replacing ItemInfoMatcher with predicate" into tm-dev 2022-05-03 20:04:55 +00:00
Vinit Nayak
38ebd4b41c Merge "Revert "Revert "Use new onStartSplitLegacy when starting split f..."" into tm-dev 2022-05-03 19:56:34 +00:00
Schneider Victor-tulias
bb44c03b1c Fix janky overview animation.
Switching to overview shortly after switching to 3-button mode caused a janky animation if the PagedView wasn't properly initialized yet. Moved the animation to a callback.

Fixes: 203632659
Fixes: 223719200
Test: manual
Change-Id: I8a345036c6b7322ae3fa50a23bcb7522f57c8a90
2022-05-03 10:38:23 -07:00
Sunny Goyal
32084d49d3 Replacing ItemInfoMatcher with predicate
This removed unnecessary componentName lookups when it
is not required. Many checks just rely on IDs and
userHandle

Bug: 231153610
Test: Presubmit
Change-Id: Ief93954abc5861062a9f55dc2ef181d3de106c62
2022-05-03 10:07:22 -07:00
Jon Miranda
e73c3075c1 Merge "Fix all app button taskbar animation in LTR and RTL." into tm-dev 2022-05-03 17:03:22 +00:00
Tracy Zhou
0c625f7472 Merge "Originate split select animation from the original icon view instead of the split menu icon" into tm-dev 2022-05-03 16:48:39 +00:00
Justin Weir
df073f0e93 Merge "Ensure log buffers are dumped to file on uncaught exceptions" into tm-dev 2022-05-03 11:38:58 +00:00
TreeHugger Robot
f1a4296cd0 Merge "Tune AllApps dismiss animation" into tm-dev 2022-05-03 11:23:46 +00:00
Jon Miranda
e7b977ddd5 Fix all app button taskbar animation in LTR and RTL.
Bug: 225154998
Test: Open app, view taskbar, go back to home
      Repeat for both RTL, LTR

Change-Id: Ifdc8074bef6e5f5a447a1f4110ccb387b18a7ea9
2022-05-02 15:31:21 -07:00
Justin Weir
811e76353a Ensure log buffers are dumped to file on uncaught exceptions
Update PluginManagerWrapper according to changes in ag/17915248

Bug: 213884413
Test: manually verified, added tests, and ran atest
Change-Id: If829fc33769819624530f766178689ecf0374926
2022-05-02 15:28:44 -04:00
Schneider Victor-tulias
9b6babf839 Translate the 3 navigation buttons to/from their in-app position when animating to/from the -1 screen, all apps and widgets.
Bug: 221455508
Test: opened all apps, widgets, -1 screen, notifications shade and keyboard in various combinations and orders; locked screen, launched app, returned home with the back/home buttons, opened overview
Change-Id: Ia0b406aacf72b34bd6b7ff1c01278ab6895a7da4
Merged-In: Ia0b406aacf72b34bd6b7ff1c01278ab6895a7da4
(cherry picked from commit 9c1a452a1d)
2022-05-02 18:45:01 +00:00
Schneider Victor-tulias
c0b30dc266 Fix taskbar 3-button truncation on rotate
- Fixed truncation issue in overview and home on rotation
- Fixed 3 buttons translating incorrectly when switching to/from overview

Fixes: 205057824
Fixes: 215482458
Test: Manual
Change-Id: I0b89010a2b6ed03a34c3443fc6e1edc81f8d9f20
Merged-In: I0b89010a2b6ed03a34c3443fc6e1edc81f8d9f20
(cherry picked from commit 8aa99c72b1)
2022-05-02 18:12:00 +00:00
TreeHugger Robot
eba6a95a29 Merge "Provide the back callback instance when unregistering it from SysUI." into tm-dev 2022-05-02 16:18:43 +00:00
Shan Huang
883e7e412b Provide the back callback instance when unregistering it from SysUI.
Bug: 228535747
Test: atest BackAnimationControllerTest
Test: Make sure back to home animation works on tablets and phones.
Change-Id: Iacbd581f382da50e96cfefbefe569800e9e1043b
2022-05-02 04:57:11 +00:00
TreeHugger Robot
002e1fcde5 Merge "Do not add HOTSEAT_ICONS to visible elements for device type "phone" in ALL_APPS State" into tm-dev 2022-04-30 17:12:35 +00:00
TreeHugger Robot
3e8f0c9bb6 Merge "Update home, back and overview gesture tutorial introductions to be clearer for blind users" into tm-dev 2022-04-30 02:13:14 +00:00
Anushree Ganjam
f6254c5947 Do not add HOTSEAT_ICONS to visible elements for device type "phone" in
ALL_APPS State

HOTSEAT_ICONS got added to visible elements for ALL_APPS State in ag/16992837.

============================================================
Phone
Before:
HotSeat present in view hierarchy - https://hsv.googleplex.com/4906040983289856?node=41
Video: https://b.corp.google.com/issues/228803923#comment9

After:
HotSeat not present in view hierarchy - https://hsv.googleplex.com/5379653922455552?node=42
Video: https://b.corp.google.com/issues/228803923#comment11
============================================================

Tablets

I couldn't test this implementation on tablet. But I have verified on a phone
locally by adding HOTSEAT_ICONS to visible elements and then verifying
"IMPORTANT_FOR_ACCESSIBILITY_NO_HIDE_DESCENDANTS" get set and hotseat icons are not focusable in all apps.
Video : https://b.corp.google.com/issues/228803923#comment14

============================================================

Bug: 228803923
Bug: 227565451

Test: Manual. See the video attached in bug.
Change-Id: I055e3bb61c8cfd240e0fe1000fe3a391a150f6d1
2022-04-29 23:33:48 +00:00
Sunny Goyal
34f51fbfc4 Merge "Removing unused SearchSessionManager" into tm-dev 2022-04-29 23:30:13 +00:00
Schneider Victor-tulias
8e0e88bb2f Update home, back and overview gesture tutorial introductions to be clearer for blind users
Added A11Y strings for the home, back and overview gesture tutorial step introductions. These strings give clearer instructions that work with talkback.

Fixes: 202492454
Test: manual
Change-Id: I1eefd6ecf3e3c576a7c1cf6dbf7b824e5be13860
2022-04-29 16:09:11 -07:00
TreeHugger Robot
47a137e05d Merge "Update TaskOverlay corner radius as fullscreen parameters are updated." into tm-dev 2022-04-29 22:34:31 +00:00
Alex Chau
f39cc126bf Tune AllApps dismiss animation
- Avoid overriding interpolator in AllAppsTransitionController.setStateWithAnimation as it's no longer needed and it'll wrongly override interpolator for ANIM_ALL_APPS_FADE
- Override ANIM_ALL_APPS_FADE to FINAL_FRAME in QuickstepAtomicAnimationFactory for tap deadzone to dismiss animation, also added EMPHASIZED_ACCELERATE for the dismiss animation
- Tuned dismiss animation across form factors to 300ms

Fix: 220336617
Test: manual
Change-Id: I4b3e827b503dcb1dd39f0bd99d4c1dd5ffdba0f3
2022-04-29 20:31:26 +01:00
Pat Manning
d9ddf6c12b Merge "Re-land "Animate overivew actions view hiding on scroll."" into tm-dev 2022-04-29 18:01:30 +00:00
Pat Manning
d44f9c9741 Merge "Finish recents animation on activity destroyed." into tm-dev 2022-04-29 17:43:21 +00:00
Zak Cohen
f2cd2f7748 Update TaskOverlay corner radius as fullscreen parameters are updated.
Bug: 230470826
Test: Build and run
Change-Id: I3b6914bf7423ec60d28d2d06ee5225de1b6862c1
2022-04-29 10:27:53 -07:00
Thales Lima
828875cd12 Fix hotseat width to span a number of columns
Bug: 227344807
Test: manual
Change-Id: Ice4e37929bcbb8c9cf3af340e67b6bec002578bd
2022-04-29 14:56:30 +00:00
Pat Manning
d08e03388f Re-land "Animate overivew actions view hiding on scroll."
Reverts commit f5f14acba3

Bug: 228137694
Bug: 221113300
Change-Id: I683092796f5de0476e09692897d80a3655ae6925
2022-04-29 13:49:09 +00:00
Pat Manning
0fd3b13d01 Finish recents animation on activity destroyed.
Do not remove acitivity lifecycle callback on reset.

Test: TaplTestsQuickstep.java testQuickSwitchFromApp
Fix: 228137694
Change-Id: I454db1d029af479624999f2e5736aea1a8a97b87
2022-04-29 11:55:40 +00:00
Sunny Goyal
a3f014d737 Removing unused SearchSessionManager
Bug: 220922858
Test: Presubmit
Change-Id: I8264a2e9b978a850aa6ce69fcb698b0a3494c6c5
2022-04-28 19:44:03 -07:00
Shan Huang
8073fc8daf Merge "Fix screen rounded corner flicker." into tm-dev 2022-04-28 19:34:37 +00:00
Mateusz Cicheński
f312acc081 Merge "Make Hotseat report shelf height on large screen devices." into tm-dev 2022-04-28 18:48:11 +00:00
Anushree Ganjam
fa693be19f Merge "Revert "Refactors Search results into separate RV for Toast."" into tm-dev 2022-04-28 04:52:01 +00:00
Anushree Ganjam
5cc7ff0990 Revert "Refactors Search results into separate RV for Toast."
This reverts commit 6729f0b950.

Reason for revert: This change caused b/230648542.

Please see https://b.corp.google.com/issues/230648542#comment5 for the video after reverting this change.

Bug: 206905515
Bug: 230648542

Change-Id: I85f063c56cad137c05b810204244bba7e8f94ee7
2022-04-28 01:37:49 +00:00
Alex Chau
2a6e364e91 Remove unnecessary updatePivots
- Follow-up of http://ag/17888303 to remove extra code that didn't get clean up

Bug: 209981696
Test: manual
Change-Id: I37f68dd52adacfd033eaeaeca52c98a4a06d556d
2022-04-27 13:57:39 +01:00
Alex Chau
a80efcee9f Merge "Update overview actions alignment" into tm-dev 2022-04-27 12:24:24 +00:00