Commit Graph

794 Commits

Author SHA1 Message Date
Sunny Goyal
4308bd232e Merge "Fixing launcher going to a different state when dragging an icon from different activity" into ub-launcher3-edmonton 2018-05-25 19:17:28 +00:00
Sunny Goyal
4dcda06542 Fixing launcher going to a different state when dragging an icon from different activity
Bug: 80191074
Change-Id: I45ea646dc2bd21627e8b724dac9c9fc23c18797d
2018-05-25 11:56:53 -07:00
Sunny Goyal
271dc919d0 Merge "Cancelling quickscrub state incease we missed quickscrub end event" into ub-launcher3-edmonton 2018-05-25 18:40:16 +00:00
Hyunyoung Song
de184a243d Add logging for selected text and split screen
Bug: 79787082

action:LONGPRESS
  Source child:TASK_PREVIEW

action:TAP
  Source child:SPLIT_SCREEN_TARGET


Change-Id: Ica5a3955f092c6678e646b6df76567cdfa3485df
2018-05-25 10:53:39 -07:00
Tony Wickham
5d6282fcf3 Merge "Use correct interpolator for recents scale when quick scrubbing" into ub-launcher3-edmonton 2018-05-25 17:11:23 +00:00
Tony Wickham
4ff7d8e7b3 Use correct interpolator for recents scale when quick scrubbing
Use same interpolator for scale and translationY so that they feel more
coordinated. (They were already the same in all cases except when
scrubbing when already in overview, which never had a scale component
before.)

Bug: 80139193
Change-Id: Id143b5cc9279d55aaa1b0444db5fe4b41ce92170
2018-05-24 22:48:46 -07:00
Winson Chung
f13015d76a Merge "Fix recents task view launch animation unclipping issue." into ub-launcher3-edmonton 2018-05-24 22:38:59 +00:00
Winson Chung
af41ea2ac5 Fix recents task view launch animation unclipping issue.
- Don't apply the scale to app window crop (which should be in app window
  space)

Bug: 79945202
Change-Id: I68862f7f7d69eab64570ab3b1e3996a2e9a9e2ba
2018-05-24 15:10:50 -07:00
TreeHugger Robot
96bc904ded Merge "Fixing keyboard navigation when Overview list is empty" into ub-launcher3-edmonton 2018-05-24 20:16:45 +00:00
Vadim Tryshev
1b0c5032d1 Fixing keyboard navigation when Overview list is empty
Bug: 80155387
Change-Id: Ife86fe4b718ef01291a04b21020155110d75fa7b
Testing: Manual
2018-05-24 13:06:18 -07:00
TreeHugger Robot
db28a992a9 Merge "Wait until the remote transtions are received before trying to quickscrub animations" into ub-launcher3-edmonton 2018-05-24 19:46:39 +00:00
Sunny Goyal
0fb1e4b5a7 Cancelling quickscrub state incease we missed quickscrub end event
> This can happen when the remote transition is cancelled while animating down
during quickscrub, cause WindowTransformSwipeHandler to get invalidated
and miss onQuickscrubEnd

Bug: 80140388
Change-Id: I0221e301d4d633bab0defaa6af76e0054776a95a
2018-05-24 12:19:50 -07:00
TreeHugger Robot
e8532d84a9 Merge "Calculate the scale up for quickscrub based on the available size of the screen" into ub-launcher3-edmonton 2018-05-24 18:33:01 +00:00
Sunny Goyal
6ec237a260 Wait until the remote transtions are received before trying to quickscrub animations
Bug: 80219743
Change-Id: Ib94568827f30b996477d82f38675e3cd55031849
2018-05-24 11:24:22 -07:00
Sunny Goyal
ccd90231e6 Calculate the scale up for quickscrub based on the available size of the screen
Bug: 80139193
Change-Id: I0492ce5bfa347bad12a09a13e404ded77e797623
2018-05-24 11:16:05 -07:00
Winson Chung
fb6721da45 Merge "Initial changes to support full-width quickscrubbing." into ub-launcher3-edmonton 2018-05-24 02:24:36 +00:00
Winson Chung
ededa9cce2 Initial changes to support full-width quickscrubbing.
Bug: 79945202
Change-Id: Ida8443432faafc74fbdc0a7dae87f0cf8c8ce648
2018-05-23 18:30:06 -07:00
Vadim Tryshev
d5ccb6978d Reverting task order reported via accessibility.
Now tasks go in the natural left-to-right direction.

Bug: 72222505
Test: Manual
Change-Id: I9e90d0eaaaa3ca0a73b2fe6d20e82689c2b2f376
2018-05-23 18:01:50 -07:00
Sunny Goyal
7f28fd55ff Increasing the overview size while in QuickScrub mode
Bug: 80139193
Change-Id: I19ea05d3cc083628364651e9d9f581fe1aaaeaaa
2018-05-23 15:55:51 -07:00
Hyunyoung Song
79141a1236 Accessibility sugar for Recents
Adding various-pitch earcorns that depend on the scroll state and
position in the list notifications. This is for Talkback.

Bug: 72222505
Test: Manual
Change-Id: I99ffe553f7a20d057940197d97506bc1a14a193e
2018-05-23 13:46:52 -07:00
TreeHugger Robot
e47fc65716 Merge "Fixing arrow navigation in task carousel" into ub-launcher3-edmonton 2018-05-23 18:44:51 +00:00
Vadim Tryshev
8fbd56e139 Fixing arrow navigation in task carousel
Bug: 80155387
Change-Id: Icbdca2e8ad2a0e7e7dfbc8493942787d9fa58a62
2018-05-23 11:14:19 -07:00
TreeHugger Robot
39ac161095 Merge "Add mStartState to determine if user swipes up from Home." into ub-launcher3-edmonton 2018-05-23 17:57:58 +00:00
Jorim Jaggi
0d25fc094d Revert "Use SyncRtSurfaceTransactionApplier for app closing/opening"
This reverts commit 4a545dd1b2.

Reason for revert: Messes up SF vsync timings.
Bug: 78611607

Change-Id: I5978eb65a7bab0d75b4150b8d394a28b38fc1da4
2018-05-23 14:07:08 +00:00
Jorim Jaggi
4a545dd1b2 Use SyncRtSurfaceTransactionApplier for app closing/opening
To ensure 100% synchronization, fixing jank.

Test: Open and close apps
Bug: 78611607
Change-Id: I5646bb259c90b65e1abe0fd67c9918f6a2b196cc
2018-05-23 14:39:13 +02:00
TreeHugger Robot
c0928c3ba0 Merge "Enable new open app transitions when in multiwindow mode." into ub-launcher3-edmonton 2018-05-23 00:35:22 +00:00
Jon Miranda
73c27ec176 Enable new open app transitions when in multiwindow mode.
Bug: 79118278
Change-Id: Iba79948256d70c913af0a9a584eb040f3a8b4151
2018-05-22 17:25:11 -07:00
Vadim Tryshev
15b82e14a8 Removing FLIP_RECENTS
Bug: 72222505
Test: Manual
Change-Id: I9c84aa3418a5551abec26f03e870da598072e82c
2018-05-22 17:07:12 -07:00
Tracy Zhou
788c051493 Add mStartState to determine if user swipes up from Home.
Bug: 80146880
Test: Manual test
Change-Id: Ia0743bff3f2a5b3998a798743138b012ec461a94
2018-05-22 16:25:37 -07:00
TreeHugger Robot
5454fa1f6e Merge "Making caret visibility part of state definition" into ub-launcher3-edmonton 2018-05-22 23:08:42 +00:00
Sunny Goyal
56e1019e95 Making caret visibility part of state definition
> Hiding the caret in fast overview state
> Hiding caret in task swipe down interaction

Bug: 79700605
Change-Id: I984d535bc75802501e8aeb13c8f37387f331e5bc
2018-05-22 15:58:20 -07:00
TreeHugger Robot
d1134a0295 Merge "Making overview panel accessible via Tab" into ub-launcher3-edmonton 2018-05-22 22:00:02 +00:00
Vadim Tryshev
f1507a6a64 Making overview panel accessible via Tab
Keyboard navigation of AllAppsContainerView is broken in TOT; disabling
focusing there is necessary for Recents.

Bug: 72222505
Test: Manual
Change-Id: I85d544f7c8dbdaf12e49de51c6626bbc3dc32917
2018-05-22 14:47:44 -07:00
TreeHugger Robot
c7ffd730a5 Merge "Tighten up loading of visible task data" into ub-launcher3-edmonton 2018-05-22 21:41:47 +00:00
Winson Chung
15067109b1 Tighten up loading of visible task data
- Certain animations can run after the launcher state has changed,
  triggering loading of task data even when the overview state is not
  visible. Only allow re/loading of this data when we are in the overview
  state.

Bug: 76162466
Change-Id: Ie1f492ef712ea4aa2db6f2e1bc7ba4390742875b
2018-05-22 14:05:22 -07:00
Tony Wickham
dcae7e2b24 Merge "Cleanup how we set back button alpha" into ub-launcher3-edmonton 2018-05-22 19:06:02 +00:00
Vadim Tryshev
783cd3cf21 Making clear-all action accessible on a fallback Overview.
Bug: 72222505
Test: Manual
Change-Id: I063081b4fa009882e50852e107490fddae0f86b7
2018-05-22 11:06:36 -07:00
Tony Wickham
4e21c1b552 Cleanup how we set back button alpha
Add BackButtonAlphaHandler to set back button alpha, instead of setting
it from multiple places.

Also force back button alpha to be 1 if swipe up is disabled (b/80091187)

Change-Id: I49b63a0e6b033a3a947a847669a398f1b9ff0564
2018-05-22 11:05:01 -07:00
Tony Wickham
8417a7b514 Bound recents content alpha to 0 and 1
Now that we use OvershootInterpolator for the atomic recents animation,
it's possible to get alpha > 1. The drawable and text paint used in the
empty recents state doesn't handle this well, causing alpha to jump to 0
in this case. Instead, we'll just force it to clamp to 1 ourselves.

Bug: 80004542
Change-Id: Id0177caf63cd349f6f27c9dfaf0e8995447e70fc
2018-05-21 17:11:24 -07:00
Vadim Tryshev
00e0b91917 Never setting accessibility focus manually
This will result in the focus going to the second from the right task
upon opening Recents. This will be mitigated by implementing in near
future announcements like Task 6 out of 7.

Besides this, due to (presumably) problems external to Launcher, the
focus may stay on Home button or completely disappear upon opening
Recents.

Bug: 72222505
Change-Id: I0e5ac62bfa0e1c0db2d17a6014e61f82cfccf252
Testing: Manual
2018-05-21 19:04:05 +00:00
Vadim Tryshev
b05b489f04 Merge "Hide clear-all button from accessibility" into ub-launcher3-edmonton 2018-05-19 01:11:00 +00:00
Vadim Tryshev
4ae69dea49 Merge "Fixing reverted order of accessibility scrolling in Recents" into ub-launcher3-edmonton 2018-05-19 00:54:37 +00:00
Vadim Tryshev
bad1c73e73 Hide clear-all button from accessibility
This solves muliple navigation problems in Overview.

Bug: 79165501
Change-Id: I2ae99fe3ad24194c9516bb2a99344289ef7408e8
Testing: Manual
2018-05-18 17:28:19 -07:00
TreeHugger Robot
3bdb81868d Merge "Making sure the task open animation runs for the correct user tile" into ub-launcher3-edmonton 2018-05-18 22:26:35 +00:00
Sunny Goyal
0751929ec2 Making sure the task open animation runs for the correct user tile
Bug: 79995913
Change-Id: I3223f25e3870bac526f8960ed3d00949650bca3b
2018-05-18 14:33:36 -07:00
TreeHugger Robot
5322e62f81 Merge "Some quick scrub fixes" into ub-launcher3-edmonton 2018-05-18 21:29:11 +00:00
Sunny Goyal
32359e6b85 Some quick scrub fixes
> Skipping quick scrub, if its already in progress, or is waiting on previous task launch
> Restoring to proper state is the task animation is cancelled before launcher gets onStop
> Crash when using quickscrub before last list has loaded

Bug: 77289180
Bug: 77856587
Bug: 79919440
Change-Id: I8db127bf9539cfc8f47c1e86c5030637845749d4
2018-05-18 14:10:41 -07:00
Winson Chung
1b74bd652c Use actual quickstep callback to track gesture start
- Better than using the threshold ourselves, we should just use the callback
  from the system.

Bug: 79970627
Change-Id: Ida15cfdaa2463f9fa15e222c55e483eb145c2716
2018-05-18 10:29:30 -07:00
Tony Wickham
f9d38098ca Merge "Fix a couple issues with swiping up from home" into ub-launcher3-edmonton 2018-05-18 16:50:47 +00:00
Winson Chung
fdf9315b8e Fix thresholds with deferred-start swipe up gestures
- We were previously using the drag threshold (10dp) for both gesture start
  and drag start, when we should be using the touch threshold (24dp) for
  the deferred gesture start to ensure it coincides with the touch threshold
  for the buttons in the nav bar.

Bug: 79970627
Test: Swipe up over the back button, ensure that we don't both start the
      animation and also trigger back press

Change-Id: Ib4b2a3e2492da144485f87be5477eabf3e96e843
2018-05-18 09:13:17 -07:00