Commit Graph

9917 Commits

Author SHA1 Message Date
Jagrut Desai
adf9c428db Merge "Adding gesture error detection to RecentsAnimationCallback" into main 2023-09-25 17:03:34 +00:00
Becky Qiu
42a06b0476 [Omnient] Creates an AOSP AssistStateManager to dump in TouchInteractionService in AOSP. am: 86b6a887d1 am: f545328f56
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24828699

Change-Id: Ic62100a1f4ca6aa2a0a0c1a1962cedff070f7e70
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-23 07:45:25 +00:00
Becky Qiu
f545328f56 [Omnient] Creates an AOSP AssistStateManager to dump in TouchInteractionService in AOSP. am: 86b6a887d1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24828699

Change-Id: Ifd35410d27765efc7896dac8e002ce3f1690a8c0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-23 06:48:19 +00:00
Becky Qiu
86b6a887d1 [Omnient] Creates an AOSP AssistStateManager to dump in TouchInteractionService in AOSP.
Bug: 300101221
Test: manually tested dump, see the NL change for samples.
Flag: INVOKE_OMNI_LPH, DISABLED; ENABLE_LONG_PRESS_NAV_HANDLE, TEAMFOOD.
Change-Id: I1fb03779775cd0c9353abd4f796e9cc7c42f0f96
2023-09-23 02:29:54 +00:00
Felix Stern
c4edad6814 Merge "Use stashedTaskbarHeight for IME insets override" into udc-qpr-dev am: 795dc83c72 am: db1028ea85
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24834321

Change-Id: I69f30281881fc6ec5631f0ec3b5495434567ed2a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-22 19:06:08 +00:00
Schneider Victor-tulias
5fc26f3861 Merge "Update KeyboardQuickSwitch for TAPL testing" into main 2023-09-22 18:26:48 +00:00
Felix Stern
db1028ea85 Merge "Use stashedTaskbarHeight for IME insets override" into udc-qpr-dev am: 795dc83c72
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24834321

Change-Id: Iec4d3327d606cf5d607b8b68d7c640e737199d72
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-22 18:07:44 +00:00
Felix Stern
795dc83c72 Merge "Use stashedTaskbarHeight for IME insets override" into udc-qpr-dev 2023-09-22 17:04:19 +00:00
Jagrut Desai
3a3bf97518 Adding gesture error detection to RecentsAnimationCallback
Bug: 289600801
Bug: 285636175
Bug: 290266108
Test: Presubmit
Flag: not needed
Change-Id: I16ec3347b273ba80eadd766dccdcf012bc0872ae
2023-09-22 10:01:13 -07:00
Brandon Dayauon
8e24505d09 Merge "Fix big icon when dragging Toast by isolating the previous QL fix display to SEARCH_RESULT_APP_ROW" into udc-qpr-dev am: 28ae77df37 am: f9a203c586
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24724750

Change-Id: I4e955f635773b5084b315282d373b16cff6988e3
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-22 16:22:21 +00:00
Brandon Dayauon
f9a203c586 Merge "Fix big icon when dragging Toast by isolating the previous QL fix display to SEARCH_RESULT_APP_ROW" into udc-qpr-dev am: 28ae77df37
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24724750

Change-Id: Ibbefedc8e85690aa7a389b0e106476d56d0d768b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-22 15:25:17 +00:00
Schneider Victor-tulias
e95326dfdd Update KeyboardQuickSwitch for TAPL testing
- Added a res id to KeyboardQuickSwitchView for TAPL testing
- Updated KeyboardQuickSwitch focus and scroll initialization
- Logging KeyEvents for TAPL testing
- Updated scrolling logic to wait for initial layout
- Fixed activity leak in KeyboardQuickSwitchViewController

Flag: ENABLE_KEYBOARD_QUICK_SWITCH
Bug: 267520665
Test: TaplTestsKeyboardQuickSwitch
Change-Id: I1d45d948c0e185504d994f7ef1d34f173c2243a9
2023-09-22 11:04:43 -04:00
Brandon Dayauon
28ae77df37 Merge "Fix big icon when dragging Toast by isolating the previous QL fix display to SEARCH_RESULT_APP_ROW" into udc-qpr-dev 2023-09-22 14:36:45 +00:00
Cosmin Băieș
df2ceac06c Use stashedTaskbarHeight for IME insets override
Previously [1] we removed the explicit insetsSizeOverride from the
Taskbar for the IME window, as we now [2] enable hiding the IME nav bar.
This would now send the normal insets the taskbar reports. When running
on pre/postsubmit, with test harness setup, the non-transient taskbar
would show, which is bigger than the IME's navigation bar height.

Due to the current logic in InsetsSource#calculateInsets, this leads to
the IME window receiving top navigation bar insets instead of bottom.
As the IME nav bar is now treated as a (fixed on bottom) caption bar,
the two would no longer overlap, and thus lead to a double insets
dispatch, and also a (temporarily) bigger IME window, for IMEs that set
their decorView height to WRAP_CONTENT (e.g. MockIME used in testing).

This instead keeps the previous insetsSizeOverride for IME, and uses the
stashedTasbarHeight when in gesture nav, which should account for both
transient and normal taskbars.

 [1]: I86079cb6670a2ae3b6fa883694f8af81df212408
 [2]: I8793db69fb846046300d5a56b3b0060138ef4cd5

Bug: 297000797
Test: atest WindowInsetsControllerTests#testDispatchApplyWindowInsetsCount_ime
Change-Id: I102a8bc1f8869ebbce9f8f1fefa651d49a9538ec
2023-09-22 14:16:03 +00:00
Jeremy Sim
dcb6f5736e Merge "Request split launches using a new enum, snapPosition, rather than a float splitRatio" into main 2023-09-21 23:50:38 +00:00
Andy Wickham
3582efc2f1 Merge "Adds SystemActionConstants" into main 2023-09-21 22:31:10 +00:00
Garfield Tan
21e8204798 Merge "Show freeform button only when dev option is on" into main 2023-09-21 21:54:15 +00:00
Jeremy Sim
da230cf526 Request split launches using a new enum, snapPosition, rather than a float splitRatio
Split ratios are now stored as an int enum rather than float values. Previously, split ratios were stored as floats, which needed to be recalculated frequently and differed depending on device screen size. Now Shell to store and launch split screen setups using an enum rather than floats.

Bug: 274835596
Bug: 182839788
Test: Existing tests still pass
Change-Id: Iebb8d3c7e8f9d597a59b677e48072300ddea458f
2023-09-21 11:34:07 -07:00
randypfohl
2cf90775d7 Setting recentsView orientation to match recents activity orientation am: 03d29305ca am: 1c76ccfd6c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24804147

Change-Id: I408f74745a6f4e5714f6ef54857982c9cfc56066
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-21 17:47:45 +00:00
randypfohl
1c76ccfd6c Setting recentsView orientation to match recents activity orientation am: 03d29305ca
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24804147

Change-Id: I12f07376447009d58ee7519b9cd7433ac544191a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-21 16:51:04 +00:00
Schneider Victor-tulias
195fc85d73 Merge "Add error detection for missing recent tasks list in SystemUiProxy" into main 2023-09-21 14:48:34 +00:00
Mady Mellor
b604e71fe8 Merge "Fix bubbles taskbar scrim showing when notification panel is shown" into main 2023-09-21 01:25:07 +00:00
Garfield Tan
d4018909e3 Show freeform button only when dev option is on
Now some Android tablets have desktop mode, which shouldn't be
entered by clicking the freeform button in Overview. Therefore still
keep it hidden when the device claims the support of freeform window
management, but the user didn't enable the freeform dev options
explicitly.

This button should also be hidden when desktop mode is enabled.

Bug: 299362754
Test: The button is hidden when the dev option is disabled.
Change-Id: Id919af4fd1a027da0bb335c4c4b7303d15d689f8
2023-09-20 18:05:20 -07:00
Randy Pfohl
bd585e4d42 Merge "Remove logs for bug investigation" into main 2023-09-20 23:14:33 +00:00
randypfohl
03d29305ca Setting recentsView orientation to match recents activity orientation
Test: can no longer repro incorrect orientation when launching apps from all apps
      added logs to verify recents activity -> view were the same while rotating
      turned off auto rotate and verified state matched

Bug: 288984663
Bug: 301024104

Change-Id: I7fc3b47bff0a99756aaf877bf634e2d162838d6f
2023-09-20 15:04:55 -07:00
Brandon Dayauon
47000ae6e6 Fix big icon when dragging Toast by isolating the previous QL fix display to SEARCH_RESULT_APP_ROW
- Create another icon, "all_apps_predicted_row_icon" that will be the mDisplay for the predicted app row
in AllAppsList

Bug:299171695
Test: video
Before: https://drive.google.com/file/d/1HxNW0015nQHCc7eQiySf-gwsHrLs_JjR/view?usp=sharing
after: https://drive.google.com/file/d/1HyEwKI-yumILTCjglKcqovhTlRVjNGxg/view?usp=sharing - making sure that QL is fine and dragging regular Toast results are normal
Flag: N/a
Change-Id: Ie002cacb168396dbea39f79679bd6a04b80e374b
2023-09-20 14:21:10 -07:00
Treehugger Robot
e745dda409 Merge "Use default taskbar stash duration when opening/closing all apps from taskbar." into main 2023-09-20 17:54:36 +00:00
Schneider Victor-tulias
c6d3ea678f Add error detection for missing recent tasks list in SystemUiProxy
There are ways for launcher to lose the recent tasks reference, in which case SystemUiProxy will quietly fail to start the recents activity.

Flag: not needed
Fixes: 301257750
Test: programmatically forced the error condition and checked the logs
Change-Id: I1cad6a3dfd2605f275672d1dcd8c83bdb965d73f
2023-09-20 15:46:00 +00:00
Andy Wickham
e257408101 Adds SystemActionConstants
This includes the previously added Taskbar System Action, as well
as a new one for Screen Search.

Bug: 299321919
Test: Manual
Change-Id: I4a8fa1dde402dc2de5f448cb2edbe712e128ff12
2023-09-19 22:12:40 +00:00
Brian Isganitis
a4497e55b2 Merge "Remove onTaskCreated for hiding Taskbar overlay." into main 2023-09-19 21:20:38 +00:00
randypfohl
dad61a0098 Remove logs for bug investigation
Test: built locally

Bug: 295069071

Change-Id: I88d41acb91ced876ab1f5a301e90ee5745119049
2023-09-19 14:13:58 -07:00
Jon Miranda
56ce010cd4 Use default taskbar stash duration when opening/closing all apps from taskbar.
Bug: 300156179
Test: from taskbar click on All Alls button
      exit All Apps
Change-Id: I54f19e6714c1da2f6caef31875769fdc312957d2
2023-09-19 19:55:20 +00:00
Sunny Goyal
a6aa1c9466 Overriding the default TextClock and AnalogClock behavior to avoid RPCs on main thread am: 5b86162853
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24795935

Change-Id: I9f4d5a9eb2590951fbe4091ff8050ad72f37bbd4
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-19 18:36:04 +00:00
Brian Isganitis
8f45ef6bdf Merge "Reapply "Have backup TouchController of Taskbar All Apps AFV."" into main 2023-09-19 18:02:42 +00:00
Pat Manning
349f101411 Merge "Migrate ENABLE_CURSOR_HOVER_STATES to aconfig" into main 2023-09-19 16:56:45 +00:00
Schneider Victor-tulias
f5099749be Merge changes I26080534,Iede0881b into main
* changes:
  Send ACTION_CANCEL motion event to TIS instead of finishing the recents animation on screen off
  Replace all uses of string concatenation with CompoundString in ActiveGestureLog
2023-09-19 12:59:35 +00:00
Sunny Goyal
5b86162853 Overriding the default TextClock and AnalogClock behavior to avoid RPCs on main thread
during onAttachToWindow

Bug: 294352799
Test: Verified on device
Flag: N/A
Change-Id: I3cce6900cd62a6e9a57c155b74c15c2340c6011b
2023-09-18 23:04:33 +00:00
Sunny Goyal
10c14c297d Merge "Overriding the default TextClock and AnalogClock behavior to avoid RPCs on main thread during onAttachToWindow" into main 2023-09-18 22:55:26 +00:00
Jagrut Desai
555d71f70f Merge "Taskbar Pinning Analytics Event" into main 2023-09-18 22:11:08 +00:00
Vinit Nayak
3a57263a7d Merge "Exit split selection state if launcher interrupted" into main 2023-09-18 21:56:07 +00:00
Schneider Victor-tulias
44de9caaeb Send ACTION_CANCEL motion event to TIS instead of finishing the recents animation on screen off
Finishing the recents animation on screen off callback did not necessarily stop touch tracking, which would allow the user to double press the power button, but create a broken experience.

Sending ACTION_DOWN instead stops touch tracking and runs the proper clean up methods.

Flag: not needed
Fixes: 299235099
Test: single-pressed and double-pressed the power button mid-gesture
Change-Id: I2608053460f43703613bd6caead91ccb4ce08ceb
2023-09-18 16:28:43 -04:00
Sunny Goyal
140883e599 Overriding the default TextClock and AnalogClock behavior to avoid RPCs on main thread
during onAttachToWindow

Bug: 294352799
Test: Verified on device
Flag: N/A
Change-Id: I3cce6900cd62a6e9a57c155b74c15c2340c6011b
2023-09-18 13:26:31 -07:00
Schneider Victor-tulias
a1a5e08713 Replace all uses of string concatenation with CompoundString in ActiveGestureLog
Flag: not needed
Fixes: 300926831
Test: ran launcher, tested gestures and checked logs
Change-Id: Iede0881be315cb1ef0a30eaf2a9e17e020828586
2023-09-18 15:51:14 -04:00
Jagrut Desai
4439af4191 Taskbar Pinning Analytics Event
Inlcuded Analytics Event
- Taskbar Divider Popup Menu Open/Close
- Taskbar was pinned
- Taskbar was unpinned

Bug: 265436916
Test: Confirm with data scientist that data is being logged.
Flag: ENABLE_TASKBAR_PINNING
Change-Id: I307d000efe9ad8a32cdbe0b8df7248b19eabb08b
2023-09-18 12:36:17 -07:00
Mady Mellor
b898a3c8d3 Fix bubbles taskbar scrim showing when notification panel is shown
TaskbarScrimViewController was previously unaware of visibility
changes that happened to taskbar outside of when the sysui state
flags changed. Additionally, isTaskbarVisibileAndNotStashing is not
a reliable signal as the visibility might be GONE even though taskbar
is about to animate to be visible (i.e. shade is showing and then
you swipe it back up -- taskbar scrim wouldn't appear because when
the sysuiStateFlags changed, taskbar visibility would still be 'gone'
at that point so the taskbar scrim wouldn't animate back when
the shade is swiped up).

To resolve this, I've added a callback to notify the scrim
controller of visibility changes and it'll update if needed.

Bug: 270634233
Test: manual - enable 3 button nav
             - have a bubble
             - go to overview
             - expand bubbles
             => observe that scrim appears over taskbar
             - swipe down shade
             => observe that scrim fades out
             - swipe shade up
             => observe that scrim fades in

Change-Id: Ibaae8efb90b4558d30795298570208a52b31efb4
2023-09-18 11:49:52 -07:00
Mady Mellor
2a76764d73 Merge "Only stash bubbles in overview when it's transient taskbar" into main 2023-09-18 18:48:58 +00:00
Tony Wickham
2b9b15325c Merge "Remove unused variables in FullscreenDrawParams and PreviewPositionHelper" into main 2023-09-18 17:41:06 +00:00
Tony Wickham
2a35b5801e Finish recents animation synchronously on cancel event am: 2316dc4750 am: e136b6a641
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24755062

Change-Id: I95fbc8c18584fe304696be81c75677d3e388ac5b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-18 17:08:27 +00:00
Schneider Victor-tulias
0afb0b740b Merge "Add overview button rate-limiter to fix recurring bug" into main 2023-09-18 16:52:19 +00:00
Tony Wickham
e136b6a641 Finish recents animation synchronously on cancel event am: 2316dc4750
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24755062

Change-Id: Ib8bd21048402db34caf681802599517b4a37cb94
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-18 16:11:14 +00:00