Commit Graph

496 Commits

Author SHA1 Message Date
Sunny Goyal
e8d901fbdb Deflaking ShortcutsChangedTaskTest by not using an active model
When using an active model, the data can change on the model thread while
the test is running on a different thread.
Instead using the model data directly without an active model running

Bug: 399155567
Flag: EXEMPT testfix
Test: Presubmit
Change-Id: I332cd7ec0f5a2fb4760ce080f016c725b2233c45
2025-03-25 12:12:20 -07:00
Charlie Anderson
ca9a920fa9 Make sure loading icons from db for archived apps only happens once after restore.
- This is to enable users to theme and shape archived apps

Bug: 402303619
Flag: com.android.launcher3.restore_archived_app_icons_from_db
Test: performing restore and toggling themed icons on/off
Change-Id: I5883f703c3b0c8df5ee303ea4d99b0c02743faa4
2025-03-21 13:29:14 -07:00
Federico Baron
c7e8c4e8e7 Add logging for which type of migration occurs.
When upgrading from non one grid to one grid, we should do the row
shift migration type, here we are logging data to make sure that is what
happens on upgrade

Flag: EXEMPT logging
Test: n/a
Bug: 393175684
Change-Id: Id09257094bc9bc44da757c73a4f63bf15987772c
2025-03-20 01:31:45 +00:00
Sebastián Franco
92330ddaf7 Merge "Removing ZipRule because it seems to break roboelectric tests" into main 2025-03-17 14:34:15 -07:00
Sebastian Franco
a67e735606 Removing ZipRule because it seems to break roboelectric tests
Fix: 402136065
Test: DeviceProfileTest
Test: DeviceProfileDumpTest
Flag: TEST_ONLY
Change-Id: I7c3777ebd725e2acb2511aef3874b031a56bcf1a
2025-03-17 14:33:28 -07:00
Sunny Goyal
66916cda10 Moving LauncherAppWidgetHolder to dagger
This would allow customizing the widget holder in LauncherPreview

Bug: 361850561
Test: Updated tests and presubmit
Flag: EXEMPT dagger
Change-Id: I32491169188992453693048986c57cb780fdf1d8
2025-03-14 14:19:29 -07:00
Sunny Goyal
370eabf534 Merge "Making ModelDbController injectable" into main 2025-03-13 23:20:17 -07:00
Sunny Goyal
25f5c7e761 Making ModelDbController injectable
Bug: 361850561
Test: Updated tests
Flag: EXEMPT dagger
Change-Id: Ie600469476ce5eb60813a3c8b57b9445fcf82c24
2025-03-13 11:23:23 -07:00
Sunny Goyal
1ac78b6ec6 Removing listeners from FolderInfo
Folder and FolderIcon are UI objects and can talk to each other directly.
FolderInfo changes are already propogated via model callbacks, and doesn't need a separate listener pattern.

Bug: 398791288
Flag: EXEMPT bugfix
Test: atest FolderTest

Change-Id: Iefd47b8ea12a8ecaf34211a3d908220a0e999187
2025-03-13 10:28:07 -07:00
Thu-Huong Vu
09846676b5 Merge "Register SimpleBroadcastReceiver permission." into main 2025-03-12 10:36:22 -07:00
Thu-Huong Vu
48dd9eee1c Register SimpleBroadcastReceiver permission.
Update SimpleBroadcastReceiver API to pass in broadcast permission and
register Growth Broadcast Receiver with permission to prevent other apps
from triggering Growth Nudge on their behalf.

Flag: EXEMPT add separately
Test: Manual
Bug: 397739323
Change-Id: I3a9d5e131ced752af0a1b35d400eed6d170fc81e
2025-03-10 23:29:33 +00:00
Sunny Goyal
42975c39db Making various model objects injectable
Bug: 361850561
Test: Updated tests
Flag: EXEMPT dagger
Change-Id: Ibb45b72c186e6aeeed7a37b0ae3f8083472019d7
2025-03-10 14:37:43 -07:00
Charlie Anderson
24645d732c Merge "Make sure profile badging matches shape" into main 2025-03-10 12:54:31 -07:00
Charlie Anderson
567097eee8 Make sure profile badging matches shape
Bug: 398875512
Test: testing different shapes on work profile
Flag: com.android.launcher3.enable_launcher_icon_shapes
Change-Id: I5cb9e629f711f2fc607ca646d82a8523c0b43d1b
2025-03-07 21:31:11 +00:00
Sebastian Franco
aeb99f8d24 Moving zip rule to Multivalent to fix roboelectric test in A-studio
This fixes roboelectric test Running in Android Studio.

Bug: 390496167
Flag: TEST_ONLY
Test: all dumpTest
Test: Running roboelectric test in Android Studio
Change-Id: I903c6cea3c981a9c38cfcd05b54e4095b6fe2a8a
2025-03-07 11:56:45 -08:00
Sebastián Franco
c55194343a Merge "Add all the dumpt test results into a zip in artifacts" into main 2025-03-05 16:08:57 -08:00
Sunny Goyal
84e0e6a188 Making ActivityContext extend SavedStateRegistryOwner
Bug: 390572144
Test: Presubmit
Flag: EXEMPT refactor

Change-Id: I8272e95a8d2da95b3c93ec616fdf877b89db5b26
2025-03-05 09:22:47 -08:00
Treehugger Robot
57cab7794a Merge "Simplifying some view iteration methods" into main 2025-03-04 18:42:06 -08:00
Sebastian Franco
c9f6668ab1 Add all the dumpt test results into a zip in artifacts
Bug: 390496167
Flag: TEST_ONLY
Test: all dumpTest
Test: dump files should now be available in test artifacts
Change-Id: Ic77b75f7792bc511e364a6af697eb1282ad49ab3
2025-03-04 13:16:47 -08:00
Sunny Goyal
476d926972 Simplifying some view iteration methods
Bug: 393703968
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: Ieffa3a66fbf8595d542995c348df578a3aec9083
2025-03-04 10:39:55 -08:00
Sunny Goyal
372c483eda Merge "Moving widgetFilter to dagger" into main 2025-03-04 09:03:10 -08:00
David Saff
e7c9940df4 Merge "Rename to uiautomatorhelpers" into main 2025-03-03 10:48:03 -08:00
Sunny Goyal
5025b9ab04 Moving widgetFilter to dagger
Moving widget filtering to UI layer as it changes with surface

Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: I9d9377540ca36873659cea4ecc91fb162d82cd44
2025-03-03 10:27:14 -08:00
Treehugger Robot
dad3394772 Merge "Fix LauncherPrefs crash by allowing sub-types of Set" into main 2025-02-28 16:49:02 -08:00
Sihua Ma
2e964781ad Merge "Enable forced theme icon in Launcher3 tests" into main 2025-02-28 16:06:04 -08:00
Charlie Anderson
4e4ad89696 Fix LauncherPrefs crash by allowing sub-types of Set
Bug: 396616795
Test: LauncherPrefsTest
Flag: EXEMPT bugfix
Change-Id: Id380a6e4bb5eb809978070ff1b523c9e98e6b869
2025-02-28 21:57:43 +00:00
Treehugger Robot
1e8125c76b Merge "Merging some notification dots implementation" into main 2025-02-27 16:08:10 -08:00
Treehugger Robot
9a5cd11da5 Merge "Move MainThreadInitializedObject to Launcher3 Go." into main 2025-02-27 13:03:12 -08:00
Charlie Anderson
f22128e5f4 Merge "Make ModelTestExtensions default to process userhandle for HSUM" into main 2025-02-27 12:59:26 -08:00
David Saff
b9fabb10dd Rename to uiautomatorhelpers
Bug: 376676853
Change-Id: I2d3f4e259da721336b0736abc45d393f0dd9145a
Test: AppWidgetsRestoredReceiverTest
Flag: TEST_ONLY
2025-02-27 11:26:52 -08:00
Sunny Goyal
39063bf167 Merging some notification dots implementation
Bug: 393703968
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: Ie02311afba85f06fbafd265a5015cd23bd356a36
2025-02-27 08:50:26 -08:00
Anushree Ganjam
e6065f5a94 Move MainThreadInitializedObject to Launcher3 Go.
Move SandboxContext to a separate class.
Remove all MainThreadInitializedObject references in Launcher3 and tests.
Remove ObjectSandbox interface and make RoboApplication extend
SandboxContext

Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger
Change-Id: I1a8af5e6ae59df44d8ad6732b4d6e949ac402d6c
2025-02-26 16:49:08 -08:00
Vadim Tryshev
684233e257 resolve merge conflicts of 6df1743d23 to main
Test: I solemnly swear I tested this conflict resolution.
Bug: None
Change-Id: I92c19785709187592c5aaa9f5ee8141d3af0e194
2025-02-26 11:08:36 -08:00
Owner Cleanup Bot
cd33516a5c [owners] Remove mateuszc@google.com from tests/multivalentTests/shared/com/android/launcher3/testing/OWNERS
This suggested change is automatically generated based on group
memberships and affiliations.

Please approve this change and vote the highest CR. This will keep the OWNERs
file tidy.  We ask that you do not ignore this change and approve it
unless you know a reason the OWNER should remain.  It can always be
reverted if needed.

If this change is in error, vote the lowest CR value (i.e. reject the CL)
and the bot will abandon it.

See the owner's recent review activity for context:
https://android-review.googlesource.com/q/mateuszc@google.com

To report an issue, file a bug in the Infra>Codereview component.

Change-Id: Ib310e8949235516783ea820d35fa113e06cd34c3
2025-02-26 09:44:59 -08:00
Charlie Anderson
87ed2ec7dd Make ModelTestExtensions default to process userhandle for HSUM
Bug: 398857280
Test: BackupAndRestoreTest
Flag: EXEMPT test fix
Change-Id: I1781ffd0a04c31ee01108fb5802278051cdff4dc
2025-02-26 11:00:18 -05:00
Charlie Anderson
dfb45d9c03 Simplify ShapesProvider and use constants
Bug: 398689048
Bug: 372884380
Test: presubmit and locally
Flag: com.android.launcher3.enable_launcher_icon_shapes

Change-Id: I102265ef4b25d84bb7a0b1f9642a9c19a7200e22
2025-02-25 20:17:54 -08:00
Owner Cleanup Bot
c383866630 Merge "[owners] Remove zakcohen@google.com from tests/multivalentTests/src/com/android/launcher3/widget/picker/OWNERS" into main am: bbda0821a6 am: c8abc144b7
Original change: https://android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/3490671

Change-Id: I9a0698da781bae7365ed46bc52fee13f46aaba2f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2025-02-25 15:37:31 -08:00
Sihua Ma
8587b2916e Enable forced theme icon in Launcher3 tests
Test: atest --start-avd Launcher3Tests:MonoIconThemeControllerTest
Bug: 398039548
Flag: com.android.launcher3.force_monochrome_app_icons
Change-Id: I629e36f77726c22b83e284beb218d8e804e0499f
2025-02-24 22:02:37 +00:00
Jagrut Desai
8b2e5eff9b Desktop Mode Taskbar Recreate Animation
This Cl includes
       - addition of entry/exit callback methods in DesktopVisibilityController.
       - taskbar manager now listens to desktop mode changes.
       - TaskbarBackrgroundRedererer can now individually animation backgrounds for transient and persistent taskbars
       - new channel for taskbar icon alpha added to TaskbarViewController
       - new animated float to handle background alpha while we are recreating taskbar with animation.

Solution:

we use the callabck we get from DekstopVisibilty for entry/exit to first change logic of when we are considered inDesktopMode. Upon entry/exit we notify display controller for info change.
we also at notify taskbar manager who is now a listener to the desktop mode change and start the recreate process. TaskbarManager first animates existing taskbar out of user view and then follows the original recreate flow.

Test: Presubmit
Bug: 343882478
Flag: com.android.window.flags.enable_desktop_windowing_mode
Change-Id: Ib827564cacd194f499e7d9b1965e2bb13e3548ab
2025-02-24 11:59:53 -08:00
Sunny Goyal
7629bc4dcd Merge "Converting LauncherAppState to Dagger" into main 2025-02-21 10:06:01 -08:00
Sunny Goyal
c9f697aeb5 Converting LauncherAppState to Dagger
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger

Change-Id: I336a233d2703c23a7e9065474bde471786886144
2025-02-20 19:13:49 -08:00
Shamali Patwa
e532fc86b4 Merge "Update widgetsModel to return pickable vs all widgets separately." into main 2025-02-20 17:42:32 -08:00
Shamali P
f6efa25a49 Update widgetsModel to return pickable vs all widgets separately.
Earlier wallpaper preview was reading widgets that were eligible for
displaying in picker, which means widgets that are marked as hidden in
picker wouldn't show up in wallpaper preview.

This fix updates widgets model to maintain map of all widgets (instead of just pickable widgets like before), so that the existing `getWidgetsByComponentKey` function used by wallpaper preview can see all widgets. And, updates picker specific methods to use separate functions (suffixed `forPicker` that filter out picker ineligible widgets when read by picker code).

Bug: 385695615
Test: WidgetsModelTest, WidgetsPredictionUpdateTaskTest and demo
Flag: EXEMPT BUGFIX
Change-Id: I59efe38be0ce1f8a956ba4be42fb6e8b48b5d323
2025-02-20 14:13:16 -08:00
Charlie Anderson
b982bfede0 Merge "Removing Sunny shape option" into main 2025-02-20 06:40:12 -08:00
Charlie Anderson
96fa7a4c79 Removing Sunny shape option
Bug: 397683324
Test: selecting shapes, and presubmit
Flag: com.android.launcher3.enable_launcher_icon_shapes
Change-Id: I3d9ea0096674c07a860ba3d7dcc8074c4342a299
2025-02-19 17:46:27 +00:00
Sebastián Franco
dbec5640de Merge "Add DeviceProfile dump files into artifacts" into main 2025-02-19 09:37:38 -08:00
Sebastian Franco
190f3263a2 Add DeviceProfile dump files into artifacts
Artifacts are collected from:

    <metrics_collector class="com.android.tradefed.device.metric.FilePullerLogCollector">
        <option name="directory-keys" value="/data/user/0/com.google.android.apps.nexuslauncher/files" />
        <option name="collect-on-run-ended-only" value="true" />
    </metrics_collector>

Defined in NexusLauncherTests.xml, by writing the files into that
directory the files should show in the artifacts section when a
test fails.

Bug: 390496167
Flag: TEST_ONLY
Test: all dumpTest
Test: dump files should now be available in test artifacts
Change-Id: I046b1482afaea647351462983c4cbab5f3bc29bc
2025-02-18 18:56:48 -08:00
Treehugger Robot
e99943f092 Merge "Moving LauncherModel initialization to a separate class" into main 2025-02-18 16:56:02 -08:00
Charlie Anderson
7a7fcf5394 Merge "Fix WorkspaceItemProcessorTest for HSUM" into main 2025-02-18 13:39:05 -08:00
Sunny Goyal
b82394758f Moving LauncherModel initialization to a separate class
Bug: 361850561
Test: Presubmit
Flag: EXEMPT dagger

Change-Id: Ie210473a9e158faa421c00f115ffcca680f84ae4
2025-02-18 13:11:50 -08:00