This CL will fix the issue when the app chip is bigger than the TaskView and doesn't respect its maxWidth value.
Also fixes the bug when the first chip expands when taps over the second app chip.
Fix: 406225230
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Change-Id: Id1c806a320522e6d5bda3d4d8712a43637c57834
These resources changes will be used in a follow up CL that implement
the nudge view.
Note that most of the values and layout are temporarily placeholder and subject
to change in follow up CL as the mock is being finalized.
Bug: 398033012
Test: Manual
Flag: com.android.launcher3.enable_growth_nudge
Change-Id: I1d88da404637200b44bd2a3a5719f52d68011fbf
The flag will be applied at the code using this use case.
Bug: 405974619
Fix: 405974619
Flag: com.android.launcher3.enable_refactor_digital_wellbeing_toast
Test: GetRemainingAppTimerDurationUseCaseTest
Change-Id: I939b3447b93e7e84eb69032aa0f67c1629f916c1
The usage of this chain will be flagged
Bug: 405359454
Fix: 405359454
Flag: com.android.launcher3.enable_refactor_digital_wellbeing_toast
Test: AppTimersRepositoryTest
Change-Id: Ife0db79175dd30982a0cb179369a3cea470ef7ba
This change will prevent the split menu and app chip translation when in Fake Landscape and Fake Seascape.
Fix: 406239562
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Test: OverviewMenuImageTest
Test: Manual. Instructions in the bug.
Change-Id: Id4aade8ce15cc51e81d5b1b7a82597924cdce7ca
- Consolidates the two TextViews (collapsed and expanded) in `IconAppChipView` into a single `appTitle` TextView.
- Updates the app name's width based on the current chip status (expanded/collapsed)
- Removes the `icon_text_collapsed` and `icon_text_expanded` from layout and uses only `icon_title`.
- Adds marquee support to handle text ellipsis in the collapsed state.
- Refactors text width calculation for collapsed state to take into account maximum available width.
- Updates text animations to use the new `appTitle`.
- Updates the maximum width to not be set to less than the min width.
Bug: 403193877
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Change-Id: Ic82790d0a79b65adb7ba14dad7848748cd568f62
- the recents view container's root view can be null, which is valid with the flag enabled
- The taskbar is now also present in 1P with flag enabled
Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/postsubmit
Change-Id: I4d822a8ea20cc7a28d7a703acbf9b589aa18593e
This prevents old scopes still being active when new TaskView state emissions are being sent to main. They were previously cancelled in time but still result in empty continuations occuring on main.
Bug: 395294954
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manual - checking perfetto traces
Change-Id: I539a6fde8c9315ceeac74c9bf622d1e2dca1403a
Surface reparenting was happening on every frame since we call
applyDepthAndBlur on each frame during animation. Instead we can do it
only when base surface is set. mBlurSurface should always be parented to
mBaseSurface so no point in calling it again and again.
Relative layer changes only when we either draw above or recents. While
drawing above recents, mBaseSurface relative layer should be used.
mBaseSurfaceOverride otherwise. No point to call this during animation.
Added perfetto traces comparison home->all apps, alongwith all other
generic overview scenarios which possibly could have caused jank is
added here:
https://drive.google.com/drive/folders/146K_4WLaOGQcZ1gsuhCFlOCzfZ-mJBw8?resourcekey=0-r1-NnNtYGH88d8DGEvnXZg&usp=sharing
Bug: 404647629
Test: Manual. Enter overview from Desktop tile / home.
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I9dae7c5ece37e51664d82c680ea247f89bb5664b
We were checking whether recents is visible or not while opening all
apps and calling RecentsView#reset. Since Recents is not visible, we
were always calling reset which was making additional blur. Adding check
here of what current state is, will reduce these calls.
Added perfetto traces comparison here
https://drive.google.com/drive/folders/146K_4WLaOGQcZ1gsuhCFlOCzfZ-mJBw8?resourcekey=0-r1-NnNtYGH88d8DGEvnXZg&usp=sharing
Bug: 404647629
Test: Manual. Launcher home -> all apps.
Flag: EXEMPT bugfix
Change-Id: If0e31638adee50d36974abd7a4c809e3747f37a0
This reverts commit adb3bf5a8d.
Reason for revert: Likely culprit for b/406159877 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.
Change-Id: I9bad89e9ffa082bc8a1505e699048a7739aaf24d
This fixes an issue with the desktop task view unexpectedly jumping
first to the right, and then back to the left. See the bug for more
information.
Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug=399822967
Change-Id: I3713b20effa2a7f25ca04ed83ed524772d23ca2f
The emissions of each TaskView on Overview open are usually:
1. task exists
2. icon loaded
3. then thumbnail loaded
If the 3 updates above come in quick succession, then ideally the first 2 will be debounced and the last one will be consumed immediately.
Debouncing only when thumbnails are not present gives the best results. This is because thumbnail loading is a decent predictor of there being no more emissions to come as they are typically the last emission for a TaskView.
Bug: 395294954
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: ABTD run of failing metric
Change-Id: Ib57d6dc7d9f58b7bb37ec1177b23d89360c24c0e
- If onPrepareGestureEndAnimation is called with null aniamtorSet, plays the dismiss animator directly with 0 duration
Fix: 405368787
Flag: EXEMPT bugfix
Test: manual, adb shell input keyevent KEYCODE_APP_SWITCH or Window + Tab with keybnoard from home
Change-Id: I16048f9454f79e2828c6a4a75b788b9838e886ab