Commit Graph

22196 Commits

Author SHA1 Message Date
Jordan Silva
41992efa95 Merge "Center Task Menu icons and text vertically" into main 2025-03-26 08:40:16 -07:00
Jordan Silva
ec18b825e4 Merge "Adjust IconAppChipView chip width based on state" into main 2025-03-26 08:36:26 -07:00
Shamali Patwa
a8455409f6 Merge changes from topic "dwb-refactor-data" into main
* changes:
  Add a useCase to get the remaining app time rounded down to minutes
  Add a repository to fetch the remaining time for DWB
2025-03-26 06:02:52 -07:00
Jordan Silva
20dd848b29 Center Task Menu icons and text vertically
Bug: 403193877
Flag: EXEMPT bug fix
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Test: OverviewMenuImageTest
Test: OverviewActionsMenuHoverImageTest
Change-Id: Idba732b64260e7e3e00d4742d2ea6ccd9228ab01
2025-03-26 05:23:31 -07:00
Treehugger Robot
dd7d89d7e1 Merge "Account for Recents Scale when computing dismiss length to take task off screen." into main 2025-03-26 05:09:07 -07:00
Treehugger Robot
8292d26063 Merge "Snap to Large tile or first grid task when they are the next page." into main 2025-03-26 05:07:40 -07:00
Jordan Silva
3451ddddd1 Adjust IconAppChipView chip width based on state
This CL will fix the issue when the app chip is bigger than the TaskView and doesn't respect its maxWidth value.
Also fixes the bug when the first chip expands when taps over the second app chip.

Fix: 406225230
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Change-Id: Id1c806a320522e6d5bda3d4d8712a43637c57834
2025-03-26 04:38:32 -07:00
Jordan Silva
f4b5725ef0 Merge "Add marquee for AppChip and simplify text view handling in IconAppChipView" into main 2025-03-26 04:28:26 -07:00
Li Lin
95dc69f7ce Merge "Growth Framework nudge resource changes." into main 2025-03-26 00:21:28 -07:00
Treehugger Robot
b4a37aed36 Merge "Remove unnecessary call to RecentsView.reset when switching from any non-overview state." into main 2025-03-26 00:12:42 -07:00
Vinay Joglekar
6b59446c58 Merge "Add logs for debugging to overview blur" into main 2025-03-25 21:58:52 -07:00
Vinay Joglekar
fe5b8108b5 Merge "Reduce calls to surface reparenting and set relative layer." into main 2025-03-25 21:58:28 -07:00
Li Lin
4a947f8209 Growth Framework nudge resource changes.
These resources changes will be used in a follow up CL that implement
the nudge view.

Note that most of the values and layout are temporarily placeholder and  subject
to change in follow up CL as the mock is being finalized.

Bug: 398033012
Test: Manual
Flag: com.android.launcher3.enable_growth_nudge
Change-Id: I1d88da404637200b44bd2a3a5719f52d68011fbf
2025-03-25 19:58:52 -07:00
Shamali P
258d1297fe Add a useCase to get the remaining app time rounded down to minutes
The flag will be applied at the code using this use case.

Bug: 405974619
Fix: 405974619
Flag: com.android.launcher3.enable_refactor_digital_wellbeing_toast
Test: GetRemainingAppTimerDurationUseCaseTest
Change-Id: I939b3447b93e7e84eb69032aa0f67c1629f916c1
2025-03-25 23:50:20 +00:00
Shamali P
24ba38b393 Add a repository to fetch the remaining time for DWB
The usage of this chain will be flagged

Bug: 405359454
Fix: 405359454
Flag: com.android.launcher3.enable_refactor_digital_wellbeing_toast
Test: AppTimersRepositoryTest
Change-Id: Ife0db79175dd30982a0cb179369a3cea470ef7ba
2025-03-25 23:41:46 +00:00
Treehugger Robot
4a22d06f6a Merge "Fix split chip wrong translation in Fake Landscape" into main 2025-03-25 15:56:55 -07:00
Treehugger Robot
2032de9d20 Merge "Fix miscellaneous TAPL testing issue" into main 2025-03-25 15:24:28 -07:00
Treehugger Robot
be8869060d Merge "Use up-to-date hover tooltip text for recents." into main 2025-03-25 14:28:16 -07:00
Priyanka Advani (xWF)
6e32188c4f Merge "Revert "Notify StateManager of workspace reveal animations."" into main 2025-03-25 13:35:54 -07:00
Jordan Silva
5c5028bf0b Fix split chip wrong translation in Fake Landscape
This change will prevent the split menu and app chip translation when in Fake Landscape and Fake Seascape.

Fix: 406239562
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Test: OverviewMenuImageTest
Test: Manual. Instructions in the bug.
Change-Id: Id4aade8ce15cc51e81d5b1b7a82597924cdce7ca
2025-03-25 13:34:41 -07:00
Jordan Silva
7e676c6a40 Add marquee for AppChip and simplify text view handling in IconAppChipView
- Consolidates the two TextViews (collapsed and expanded) in `IconAppChipView` into a single `appTitle` TextView.
- Updates the app name's width based on the current chip status (expanded/collapsed)
- Removes the `icon_text_collapsed` and `icon_text_expanded` from layout and uses only `icon_title`.
- Adds marquee support to handle text ellipsis in the collapsed state.
- Refactors text width calculation for collapsed state to take into account maximum available width.
- Updates text animations to use the new `appTitle`.
- Updates the maximum width to not be set to less than the min width.

Bug: 403193877
Flag: com.android.launcher3.enable_overview_icon_menu
Test: OverviewImageTest
Test: OverviewSplitTaskImageTest
Change-Id: Ic82790d0a79b65adb7ba14dad7848748cd568f62
2025-03-25 20:31:28 +00:00
Schneider Victor-Tulias
58b82620df Fix miscellaneous TAPL testing issue
- the recents view container's root view can be null, which is valid with the flag enabled
- The taskbar is now also present in 1P with flag enabled

Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/postsubmit
Change-Id: I4d822a8ea20cc7a28d7a703acbf9b589aa18593e
2025-03-25 12:58:29 -07:00
Brian Isganitis
409ea18bf8 Merge "Perform system actions on focused display." into main 2025-03-25 12:28:30 -07:00
Treehugger Robot
fb9548ac90 Merge "Close the Recents window onNewIntent" into main 2025-03-25 11:14:23 -07:00
Treehugger Robot
982c2abef5 Merge "Also cancel TaskView collection Jobs when Overview is not on screen." into main 2025-03-25 10:37:01 -07:00
vinayjoglekar
af83003826 Add logs for debugging to overview blur
Bug: 406197011
Test: Manual. Enter overview from Desktop tile / home.
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: Iec9def155d91025e94a6ade2dc332b4c3f3ee943
2025-03-25 10:21:22 -07:00
Daniel Andersson
1735205986 Merge "desktop-exploded-view: Avoid triggering layout when starting animation" into main 2025-03-25 09:21:05 -07:00
Schneider Victor-Tulias
848b743c20 Close the Recents window onNewIntent
Flag: com.android.launcher3.enable_launcher_overview_in_window
Bug: 377678992
Test: pre/postsubmit
Change-Id: Ied8a1ce6bb5b3a0c371ce857fe6df9d94fd04b40
2025-03-25 08:41:39 -07:00
Treehugger Robot
d4c2dedf81 Merge "Add null backup for title." into main 2025-03-25 08:36:53 -07:00
Uwais Ashraf
deefa3db71 Also cancel TaskView collection Jobs when Overview is not on screen.
This prevents old scopes still being active when new TaskView state emissions are being sent to main. They were previously cancelled in time but still result in empty continuations occuring on main.

Bug: 395294954
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: Manual - checking perfetto traces
Change-Id: I539a6fde8c9315ceeac74c9bf622d1e2dca1403a
2025-03-25 15:23:56 +00:00
Pat Manning
ac5027dbf8 Account for Recents Scale when computing dismiss length to take task off screen.
Fix: 406213321
Test: Manual.
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: If0e79fc58a1f094071b98587e3f57af4af64c524
2025-03-25 14:41:27 +00:00
vinayjoglekar
1653a5082d Reduce calls to surface reparenting and set relative layer.
Surface reparenting was happening on every frame since we call
applyDepthAndBlur on each frame during animation. Instead we can do it
only when base surface is set. mBlurSurface should always be parented to
mBaseSurface so no point in calling it again and again.

Relative layer changes only when we either draw above or recents. While
drawing above recents, mBaseSurface relative layer should be used.
mBaseSurfaceOverride otherwise. No point to call this during animation.

Added perfetto traces comparison home->all apps, alongwith all other
generic overview scenarios which possibly could have caused jank is
added here:

https://drive.google.com/drive/folders/146K_4WLaOGQcZ1gsuhCFlOCzfZ-mJBw8?resourcekey=0-r1-NnNtYGH88d8DGEvnXZg&usp=sharing

Bug: 404647629
Test: Manual. Enter overview from Desktop tile / home.
Flag: com.android.launcher3.enable_overview_background_wallpaper_blur
Change-Id: I9dae7c5ece37e51664d82c680ea247f89bb5664b
2025-03-25 07:02:46 -07:00
Shamali Patwa
15fa804ddf Merge "Add ViewStubs for DWB layouts to avoid duplicate views in refactor" into main 2025-03-25 06:38:42 -07:00
Uwais Ashraf
e54f38f7c7 Add null backup for title.
Fix: 403146003
Flag: EXEMPT - test bugfix
Test: Postsubmit runs
Change-Id: Icd94a207ba6e35b92c72e407db4ebc1ba0178723
2025-03-25 13:20:25 +00:00
Pat Manning
b147f6f4b7 Snap to Large tile or first grid task when they are the next page.
Fix: 398232493
Fix: 399622012
Test: Manual
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I10cbd303b3e36059a41cb4ff7fdb4b4af7f93f23
2025-03-25 12:44:35 +00:00
Alex Chau
f5956e01b2 Merge "Still play home task dismiss animation when aniamtorSet is null" into main 2025-03-25 05:03:06 -07:00
Treehugger Robot
5ff3717c6f Merge "Add debounce to TaskView emissions" into main 2025-03-25 03:58:44 -07:00
vinayjoglekar
162a85e777 Remove unnecessary call to RecentsView.reset when switching from any non-overview state.
We were checking whether recents is visible or not while opening all
apps and calling RecentsView#reset. Since Recents is not visible, we
were always calling reset which was making additional blur. Adding check
here of what current state is, will reduce these calls.

Added perfetto traces comparison here

https://drive.google.com/drive/folders/146K_4WLaOGQcZ1gsuhCFlOCzfZ-mJBw8?resourcekey=0-r1-NnNtYGH88d8DGEvnXZg&usp=sharing

Bug: 404647629
Test: Manual. Launcher home -> all apps.
Flag: EXEMPT bugfix
Change-Id: If0e31638adee50d36974abd7a4c809e3747f37a0
2025-03-25 03:40:18 -07:00
Chaitanya Cheemala (xWF)
62ad6217ac Revert "Notify StateManager of workspace reveal animations."
This reverts commit adb3bf5a8d.

Reason for revert: Likely culprit for b/406159877 - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.

Change-Id: I9bad89e9ffa082bc8a1505e699048a7739aaf24d
2025-03-25 03:18:33 -07:00
Treehugger Robot
0a3f31940d Merge "Notify StateManager of workspace reveal animations." into main 2025-03-24 23:34:33 -07:00
Treehugger Robot
373bb0d190 Merge "Fix broken quick switch from home gesture with recents-in-window enabled" into main 2025-03-24 21:41:08 -07:00
Daniel Andersson
07c09556f0 desktop-exploded-view: Avoid triggering layout when starting animation
This fixes an issue with the desktop task view unexpectedly jumping
first to the right, and then back to the left. See the bug for more
information.

Flag: com.android.launcher3.enable_desktop_exploded_view
Test: Manual
Bug=399822967

Change-Id: I3713b20effa2a7f25ca04ed83ed524772d23ca2f
2025-03-24 15:04:27 -07:00
Treehugger Robot
44552dc98f Merge "Stay in the current task when a new desk is created" into main 2025-03-24 13:23:22 -07:00
Uwais Ashraf
2f193110b7 Add debounce to TaskView emissions
The emissions of each TaskView on Overview open are usually:
1. task exists
2. icon loaded
3. then thumbnail loaded

If the 3 updates above come in quick succession, then ideally the first 2 will be debounced and the last one will be consumed immediately.

Debouncing only when thumbnails are not present gives the best results. This is because thumbnail loading is a decent predictor of there being no more emissions to come as they are typically the last emission for a TaskView.

Bug: 395294954
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Test: ABTD run of failing metric
Change-Id: Ib57d6dc7d9f58b7bb37ec1177b23d89360c24c0e
2025-03-24 20:17:35 +00:00
Vinit Nayak
16210fa129 Merge changes I48079ecb,Ifda20367 into main
* changes:
  Revert "Re-use existing method to get split root"
  Revert "Reset leashes before starting taskbar app pair launch animation"
2025-03-24 13:14:22 -07:00
Min Chen
d5aa8031b1 Merge "Pass displayId to CachedTaskInfo when needed" into main 2025-03-24 13:10:29 -07:00
Shamali Patwa
bb04b1135f Merge "Revert "Improve reliability of cleanup done in onDestroy."" into main 2025-03-24 13:06:27 -07:00
Min Chen
0599eaa522 Merge "Make sure the correct input consumer is created" into main 2025-03-24 12:34:44 -07:00
Alex Chau
09a3453052 Still play home task dismiss animation when aniamtorSet is null
- If onPrepareGestureEndAnimation is called with null aniamtorSet, plays the dismiss animator directly with 0 duration

Fix: 405368787
Flag: EXEMPT bugfix
Test: manual, adb shell input keyevent KEYCODE_APP_SWITCH or Window + Tab with keybnoard from home
Change-Id: I16048f9454f79e2828c6a4a75b788b9838e886ab
2025-03-24 18:51:26 +00:00
Treehugger Robot
69998a8c77 Merge "Using Choreographer for getting refreshrate instead of display manager" into main 2025-03-24 11:10:42 -07:00