Starting from target SDK U, we will block creation of mutable
PendingIntents with implicit Intents because attackers can mutate the
Intent object within and launch altered behavior on behalf of victim
apps. For more details on the vulnerability, see go/pendingintent-rca.
From a quick analysis, we concluded that the PendingIntent here was only
destined to the test app/to the app, so it was made explicit. Reviewers,
please call out if this is not the case.
Bug: 236704164
Test: atest NexusLauncherTests:com.android.quickstep.DigitalWellBeingToastTest
Test: atest RequestPinItemTest
Change-Id: I81311b0588b7b712c97de6cb016a62bb91c7a77c
This uses ktfmt on the PREUPLOAD hook to check file formatting.
Bug: 264851618
Test: manual
Change-Id: I8bdeabd9c1ed571a464707e6912419ad3190a169
Merged-In: I8bdeabd9c1ed571a464707e6912419ad3190a169
QuickSwitch can resume Launcher activity due to transient launch when
shell transition is enabled, waiting for the Launcher leave resume
stage to make the test stable.
Bug: 263907455
Test: atest TaplTestsQuickstep#testQuickSwitchToPreviousAppForTablet
Change-Id: I2e6e0511cba51f4634ccf3da454e4be1dd93ffd1
* New signals coming in from Sysui reflect the toggle
in Settings for long pressing on home button to
invoke assistant.
Fixes: 255909545
Test: Manual + added unit test for TaskbarNavButtonController
Change-Id: Ic65a80b0b9697990931b7e89756773fb086cc3bd
Change margin spaces and logic of how many items the hotseat and taskbar should show.
Fix: 246424857
Test: DeviceProfileDumpTest
Test: HotseatWidthCalculationTest
Change-Id: I8ec71c56a0aa362483c43d6400c762d12cf45f5b
- Cells should get extra space by reducing borderSpace. If that's still not enough, use 0 borderSpace and distribute the space
Fix: 256976071
Fix: 248348171
Test: manual
Change-Id: I067c1aaa553d7a84caeeb9ce21e80cfaf86a3bed
* Updated code, wrote new test for new code
but forgot to update old test.
Fixes: 261110474
Test: FullscreenDrawParamsTest passes
Change-Id: I39a9029b69774f0ea7064da295c516f547bcbef2
* Strangely if you swipe up with a split pair
and then tap on the live tile to go back to
fullscreen this animates fairly correctly.
However, if you drag the focused pair back to fullscreen
the bottom app does not unclip as expected
Bug: 219411750
Test: Swipe up w/ stashed taskbar in portrait.
Thumbnail cutout doesn't appear when dragging to
fullscreen
Change-Id: Ia6e7aae10389d9fefa4adbfce540171bbe0a9180
* Takes into account taskbar insets, not sure what
expected val should be so copied the same logic from code
Bug: 219411750
Test: Ran test, passes
Change-Id: I6230a3d043e41446c35c9b393abf4a2e0ea891af
* More work still needs to be done for portrait
split apps with stashed taskbar
Bug: 258714015
Test: Existing tests pass, visually saw slight
improvement in stashed portrait gesture clipping.
Change-Id: Id1b9bb28a1a2676a5da1b5e5824e0835290cb616
This reverts commit e7011d2b87.
Reason for revert: attempt to fix test issues
- Instead of using SharedPrefs which can be flaky anyways,
we pass along a boolean to test transient taskbar when
we are in the test harness
Bug: 257549303
Test: TaplTestsTaskbar
Change-Id: I7c15a97363adc377f29853c1fe60b1960c77bfc3
This reverts commit d5a6b5f688.
Reason for revert: Breaks tests due to "SharedPreferences in credential encrypted storage are not available until after user is unlocked"
Bug: 258256906
Change-Id: I1de69249685f9d2e71183357cf3eda8d443c7d97
* Crop out taskbar from bottom thumbnail for vertical split
* TODO: Need to re-calculate thumbnail sizes if taskbar
is stashed. There's also a very slight rounding error
somewhere even in the unstashed case that needs to be
revisited
Bug: 219411750
Test: Start gesture animation in split in potrait
Change-Id: I35f2415e13af7467e0735ac8865cee0e3e3d27f8
- Lays the foundation for transient taskbar tests.
- Does not add flags that would add ACTION_OUTSIDE in tests.
We can address testing this functionality in a separate CL
Bug: 257549303
Test: TaplTestsTaskbar
Change-Id: I44acc5e589b959e6d4bc93fdc369e503c54e7d87
When handling widget prediction, first match the full provider names
Only if no widgets are found, match any widget in the package
Bug: 256202399
Test: atest WidgetsPredicationUpdateTaskTest
Change-Id: I5337618d935f8b926803aeefede46059545de72d
The request setOrientationLeft() is async that puts the target
rotation to setting. So the actual display rotation change may
happen when executing goHome(). Then the swipe gesture may be
interrupted that causes the test to fail.
Add a condition to wait for leaving natural orientation change
before calling goHome(). Also reorder and simplify the way to
start test activity to reduce execution time.
Bug: 253290379
Test: TaplTestsQuickstep#testDisableRotationCheckForPhone
Change-Id: I881d6f666c98fd3fe601b874adb0d14122bff2b7
