Problem: upon exiting the deesktop mode we were getting change in recents tasks which we were commiting to ui and that resulted in hotseat flashing.
Solution: since layout transition is only in use while we are in desktop windowing mode, we will only need to change icon layout bound while we are in desktop mode and not when we are exiting.
Test: Manual, Presubmit
Bug: 417696108
Bug: 415700104
Flag: EXEMPT bugfix
Change-Id: Ibcf65df49e7b48312a27d2750d3d0c6c5d392006
Problem:
The framework prevents a key gesture handler from being re-registered by the same process ID. In `TaskbarAutohideSuspendControllerTest`, we observed two calls to `QuickstepKeyGestureEventsManager#registerAllAppsKeyGestureEvent`. The first call originated from TouchInteractionService (as expected). The second, however, came from a new TaskbarManager instance created within `TaskbarbarUnitTestRule`. This occurs because `TaskManager#recreateTaskbarForDisplay` triggers `AllAppsActionManager#isTaskbarPresent`, which ultimately leads to the duplicate call to `QuickstepKeyGestureEventsManager#registerAllAppsKeyGestureEvent`.
Solution:
Since this problem only occurs in tests and not in practice, we can mock out `QuickstepKeyGestureEventsManager`'s [un]registration calls to do nothing within `TaskbarbarUnitTestRule` to prevent duplicated re-registration.
Flag: com.android.window.flags.grant_manage_key_gestures_to_recents
Test: atest NexusLauncherTests:TaskbarAutohideSuspendControllerTest
Test: atest NexusLauncherTests:TaskbarEduTooltipControllerTest
Fix: 421853013
Change-Id: Ic87bd8d36ce018935002b8698b1d53e30b2fca6d
Bug: 402365283
Flag: com.android.launcher3.enable_overview_on_connected_displays
Test: unit tests + local test on tablet + foldable
Change-Id: I379547e41029baedb95c67b4440f23adfb29b1ba
* changes:
Add dagger2-compiler to some of picker module targets.
Add no-op widget picker module to some test modules / graphs.
Wire the compose based widget picker in widget picker activity
Repository and datasource implementations backing the widget picker.
Add widget picker module dependency to launcher when compose is enabled
Open widget picker activity instead of full sheet when refactor flag is on
- Use both infoModifier and infoModifierForDisplay to support overview
on CD changes in DisplayController.
Test: TaskbarModeRuleTest TaskbarInsetsControllerTes
Bug: 363251602
Flag: EXEMPT test only change
Change-Id: I18f2dd7f6c486a269769d93f5ad7623bcba5fe3c
Added logic to notify the BubbleBarLocationListener implementors on
bubble bar location updated.
Bug: 411506181
Test: DragToBubbleControllerTest
Flag: com.android.wm.shell.enable_create_any_bubble
Change-Id: I51290bb6c2b35ff913a43c04db35be65b377ea03
Updates KQS view not to show fullscreen tasks, and not to cap off number
of items in the view if shown for taskbar overflow.
Bug:419279335
Test: TaskbarOverflowTest
Flag: com.android.window.flags.enable_taskbar_overflow
Change-Id: I771cabc51ffa527b7db83cf12747cf8c4793670d
When the task is not found in top or bottom set, return current page. This fixes rotation in overview while split select is already active.
Fix: 420546041
Test: TaskGridNavHelperTest
Flag: com.android.launcher3.enable_expressive_dismiss_task_motion
Change-Id: I4f654b017a0c051bd373e78ebd3d3f02f7bdf3cf
This is make it easier to create factory classes for individual when adding more injected parameters
Bug: 361850561
Test: Presumit
Flag: EXEMPT refactor
Change-Id: Ie68e9e24aae801b7fed14d1b03df760e5b67c183
- Unregister the init listener on launcher destroy to unblock the home button
- This also exposes a crash in AbsSwipeUpHandler.onRecentsAnimation start since the home bounds aren't available. So, also adding handling to reload the launcher on night mode change
Flag: EXEMPT bug fix
Fixes: 384423890
Fixes: 416536400
Test: changed dark theme then swiped/pressed home and overview buttons.
Change-Id: Ic26192e8d0e4e6b226fb9af6dba596aa78a09e96
For the apps in All apps view, if the app is already pinned in the
taskbar, we should show the unpin option for users to unpin it
instead of a pin option that is no-op.
Bug: 375648361
Bug: 418058610
Test: manual + TaskbarPopupControllerTest
Flag: com.android.window.flags.enable_pinning_app_with_context_menu
Change-Id: I770afcf3abd6cb08c574230d27c4cbcbb83b29a6
To match with the UX spec, this CL updates the insets based on the
number of tasks within a tile. It also sets a maximum height to the
task window when multiple apps are available.
Flag: com.android.launcher3.enable_desktop_exploded_view
Test: OrganizeDesktopTasksUseCaseTest
Bug: 414614454
Change-Id: Icfecc1e41dfd0b95bae10b495adae95fe10dfef2
Revert submission 33672643-DataDeviceProfile1
Reason for revert: Droidmonitor created revert due to b/419867875. Will be verifying through ABTD before submission.
Fix: 419867875
Reverted changes: /q/submissionid:33672643-DataDeviceProfile1
Change-Id: Icb66aefbbcee24e05806b2139923e1f2ea1c65e3
This change addresses the desire to lower the footer for SUW content if
the expressive theme is enabled in SUW. This would remove the extra gap
at the bottom of the screen.
Fix: 409897759
Test: Enable expressive theme and relaunch SUW. Check that the bottom
buttons are closer to the bottom edge of the screen.
Flag: EXEMPT bugfix
Change-Id: I7a4961549ec888e57c89a564028843f1e8c0000b
Adds `maxLineCount` attribute to CellSpec. The attribute indicates the max
number of lines of text the cell was speced to support. It's used to:
* enable two-line labels in `BubbleTextViews` for workspace (including
folder children) items
* Update cell dimension calculation to inform cell vertical padding
When calculating cell content size the icon text size will be included
`maxLineCount` times, so the cell content gets centered as if it
contains `maxLineCount` lines of text. That way the icon position will
be consistent between cells with text that fits into one line, and cells
that contain two lines of text.
Adds `maxLineCountMatchesWorkspace` attribute to specify that the cell
should inherit `maxLineCount` from workspace cell spec.
Bug: 30153091
Flag: com.android.launcher3.enable_scalability_for_desktop_experience
Test: Manual
Change-Id: I150a62f427a0ad755a4746a736d9846d3bea4d2e
In cases where a recents aniamtion transition was successfully requested but failed to start, we should clean up the gesture state to recover.
Flag: EXEMPT bug fix
Fixes: 415930274
Test: TaskAnimationManagerTest.testRecentsAnimationStartTimeout_cleansUpRecentsAnimation
Change-Id: If1a24d6c7baac7338c49056531bc01665f082ddf
Bug: 397902030
Flag: NONE test fix, not actual code editing
Test: atest NexusLauncherTests:DesktopVisibilityControllerTest
Change-Id: Ie6ae4abb2a894d4f7403e77cf797cdce924fd9e3
It enables support for assigning SplitRemoteTargetHandles to multiple tasks within a split-screen.
The changes include:
- Retrieving the list of split-screen tasks directly from `SplitBounds`.
- Iterating through the task list and setting the remoteTargetHandle for each individual task.
- General code refactoring to set the remoteTargetHandle.
Bug: 346295292
Bug: 360782849
Flag: com.android.wm.shell.enable_flexible_two_app_split
Test: manual test.
Video: Before: http://recall/-/gvQq7Z7JECwxnxKrBmr3wt/fnHVbaVwMWfvrOaez5eO6L
Video: After: http://recall/-/gvQq7Z7JECwxnxKrBmr3wt/dzv6tZMlAYG1bBBtYdsWxF
Change-Id: I1e8c8316947b0d4fd72c9cf36dff8ecd99d2f170
