Commit Graph

5942 Commits

Author SHA1 Message Date
TreeHugger Robot
3e366d6529 Merge "Fix foreground position during widget home animation" into sc-dev 2021-06-15 17:59:48 +00:00
Jonathan Miranda
bea8267854 Merge "Address LAUNCHER_APP_LAUNCH_FROM_ICON jank." into sc-dev 2021-06-15 00:32:40 +00:00
Jon Miranda
0750f03c96 Address LAUNCHER_APP_LAUNCH_FROM_ICON jank.
- Delay app launch animations by a frame, and skip logic to skip the first frame.
- Note the icon pressed state animation still occurs, so there is still some
  visual feedback for the user that something is happening.

Bug: 181901105
Test: ensure animation still looks smooth (using window animation scale & record in slow mo)
Change-Id: Ia904b8b96301042c900e0589f33fc625c1c1148b
Merged-In: Ia904b8b96301042c900e0589f33fc625c1c1148b
2021-06-14 23:29:29 +00:00
Hongwei Wang
5a2a6e7325 Merge "Calculate the position from start bounds for auto-enter PiP" into sc-dev 2021-06-14 22:21:19 +00:00
Jon Spivack
3e48c63180 Merge "Send NIU Actions Intents to default Assistant" into sc-dev 2021-06-14 18:13:34 +00:00
Winson Chung
9f5ba22d74 Merge "Skip entering PIP when dismissing auto-enter pip task" into sc-dev 2021-06-14 16:39:19 +00:00
Winson Chung
c5d50f710a Skip entering PIP when dismissing auto-enter pip task
- Revert some changes from ag/14827090, we don't actually need to
  screenshot when dismissing, but we do need to prevent pip

Fixes: 190751761
Test: Swiping up from YT -> PIP
      Swiping up from YT to Overview to home -> PIP
      Swiping up from YT to Overview
Change-Id: I2057467d5146be6edc382d3745a1e5269cd76a6b
Merged-In: I2057467d5146be6edc382d3745a1e5269cd76a6b
2021-06-14 16:39:11 +00:00
Winson Chung
a50c38c457 Merge "Ignore source hint rect if it is too small" into sc-dev 2021-06-13 22:55:48 +00:00
Winson Chung
b009faca5e Merge changes Ib7d3a07e,Ic22ccf17 into sc-dev
* changes:
  Disallow auto-enter PIP when there is an existing PIP
  Don't use icon home animator when entering PIP
2021-06-13 20:50:51 +00:00
Winson Chung
be2a0989ce Merge "Ensure we pass the pointer id to the velocity tracker and not the index" into sc-dev 2021-06-13 20:49:58 +00:00
TreeHugger Robot
cfa0baeca6 Merge "Polish the gesture navigation tutorial sandbox" into sc-dev 2021-06-13 01:25:56 +00:00
Winson Chung
62b5692736 Ignore source hint rect if it is too small
- When the source hint rect is too small, we can't do a nice transition
  when going home (it would require scaling the surface up to fit the
  rect, which conflicts spatially with the crop down to launcher
  icon/pip), so in this case, just fallback to the overlay

Bug: 190464560
Test: Enter YT Pip, play video, swipe it down to miniplayer then
      enter pip
Change-Id: I44b253ca440f6d2ca0eb20eef3454c5d4e3ae3e9
2021-06-12 13:58:32 -07:00
Winson Chung
954681d837 Disallow auto-enter PIP when there is an existing PIP
- Remove some deprecated calls when registering task stack listeners

Bug: 190464560
Test: Enter YT Pip, try to enter another auto-enter PIP app
Change-Id: Ib7d3a07effadb7b13f7c37f938741e27cf0e254e
2021-06-12 13:58:32 -07:00
Winson Chung
5300fce94f Don't use icon home animator when entering PIP
- If the app supports pip, can just do the fallback workspace
  home animation since the app will not be going to the icon

Bug: 190464560
Test: Open YT, swipe up, ensure it goes to the icon,
      Reopen YT video, swipe up, ensure it goes into PIP without
      icon animation
Change-Id: Ic22ccf17c664b9941ed944c0e39dc1f8d4efa84a
2021-06-12 13:58:17 -07:00
Cyrus Boadway
3616f29f83 Merge "Use the splash screen background color as the fallback background color" into sc-dev 2021-06-12 17:14:49 +00:00
Cyrus Boadway
5fcc3a90b0 Fix foreground position during widget home animation
The home return animation applies a position animation to all views in
the workspace. Since the widget uses a GhostView of the original widget
to represent the foreground of the animation, that animation was
reflected in the foreground's positioning.

The CL creates an ignore list of workspace views to which an animator
should not be applied.

Bug: 190488979
Test: manual
Change-Id: I5a86165e945336693eedd253a02bda1e1eb6662d
2021-06-11 22:00:53 +00:00
Jon Spivack
77edb686d7 Send NIU Actions Intents to default Assistant
This changes the recipient for NIU Actions from a package hard-coded in a config file to the currently selected default Assistant. The user can change this under Settings -> Default apps.

ImageActionUtils has also been updated to handle the case where its
Intents cannot be resolved, preventing a crash if the user sets the
default Assistant to something that cannot receive NIU Actions.

Bug: 186655099
Test: Manual (Pixel 3A, set default Assistant to Google Go and None)
Test: m -j RunLauncherGoGoogleRoboTests
Change-Id: I03b93597092575902d507615f32b63f4050c4c69
2021-06-11 13:58:57 -07:00
Schneider Victor-tulias
7fec8fc10c Polish the gesture navigation tutorial sandbox
- Updated in-memory tutorial steps to a array so we can better track the tutorial progress after changing the theme.
- Added a 1.5 second delay for the gesture video when the user first starts a step, and when the app resumes.
- Updated the tutorial step indicator color: previous color was invisible against the background.

Bug: 188972959
Test: manual
Change-Id: Ia1a67f7cd9e7ed9802dbc0d88d1e3b432acfa127
2021-06-11 12:16:28 -07:00
Hongwei Wang
cb5c35e5d1 Calculate the position from start bounds for auto-enter PiP
Video: http://recall/-/aaaaaabFQoRHlzixHdtY/eUpkH2il1vYBVBPt1Vks2u
Bug: 190748719
Test: manual, see video
Change-Id: I053bd5607200ad6341d04c9bcfec5222f101cf65
2021-06-10 17:59:00 -07:00
Winson Chung
e46c7613a3 Ensure we pass the pointer id to the velocity tracker and not the index
Bug: 189259717
Test: Swipe up with two fingers using accessibility + gesture nav
Change-Id: Icef48276c6da824d43dea0f7d567691af9cdedaf
2021-06-10 14:50:17 -07:00
Cyrus Boadway
9f06168692 Use the splash screen background color as the fallback background color
For the widget transition animation fallback background color, use either
the splash screen background color if a task is starting or the task
description-attached background color.

With a background in place, allow the window to fully fade out before
fading in the widget, by moving the window alpha math into an animation
factory-specific implementation.

Bug: 187706750
Test: Manual
Change-Id: I2b5a7783b0585d447ad60534bc48d2e2176877ed
2021-06-10 21:03:24 +00:00
Zak Cohen
20832e64a4 Merge "Suppress failing view inflation tests until investigation" into sc-dev 2021-06-10 20:06:17 +00:00
zakcohen
139a54f20e Suppress failing view inflation tests until investigation
Widget parts of ViewInflationDuringSwipeUp are failing on some devices,
looks like a test architecture problem, not a code failing problem.


Bug: 190729479
Test: Ran remaining tests
Change-Id: I7598f381053f7136b2fcd861ec73d2fda239bb8d
2021-06-10 10:39:32 -07:00
Pat Manning
206db75b87 [DO NOT MERGE] Animate live tile translation and update live tile page scroll on dismissal of non-live tile tasks.
Test: manual
Fix: 188453992
Bug: 188453992
Change-Id: I661c7a2900118ea02e4947feed99308d1a3a5619
2021-06-09 16:17:29 +00:00
Lucas Dupin
14e1f2a6bb Merge "Update blur radius" into sc-dev 2021-06-09 15:32:35 +00:00
Lucas Dupin
76877fda73 Update blur radius
Bug: 189976220
Test: manual
Change-Id: If5e6d6be7314dacfad8c501a5ae2da6556ca3cea
2021-06-08 21:51:47 -07:00
Shawn Lin
f0ebf00394 Merge "Play the nav bar animation for app launch from recent in live tile" into sc-dev 2021-06-09 01:39:49 +00:00
zakcohen
284eef2bf9 Re-enable swipe up view inflation test.
Disable chips by default as they are not plan of record for launch.

Bug: 141579810
Test: Local and ran test
Change-Id: Iae270c6ac4bbec4f7c29b1137cf926383443e85e
2021-06-08 14:24:20 -07:00
Wei Sheng Shih
c3db44bbce Merge "Pre-set splash screen as icon-style when launch activity from Launcher." into sc-dev 2021-06-08 12:16:24 +00:00
zakcohen
1fb6718c85 DO NOT MERGE
Use focused task id for getting task size

When getting the selected task size, look at the focused task id, not
the running task id.
I believe this was a typo from the original change.

Bug: 190399315
Test: Local build and flash and run
Change-Id: Ice92e0562765f4f0142e27da0c38140df4c11425
2021-06-07 23:29:11 +00:00
shawnlin
60b97de72b Play the nav bar animation for app launch from recent in live tile
Bug: 189278432
Test: manual - launch an app from recent in live tile mode
Change-Id: I9a39cdbbe0b8b9ee6d11a3ee53936d2fea699dd8
2021-06-07 16:46:44 +08:00
wilsonshih
0fe2342445 Pre-set splash screen as icon-style when launch activity from Launcher.
Specify icon style splash screen when launch activity from Launcher.

Bug: 188023621
Bug: 189293785
Test: Start application from Launcher/Recents.
Change-Id: I13b7cd67576cf8822e86ff90971d6bb1a24d1a91
2021-06-07 11:58:45 +08:00
Winson Chung
4f3c749ffc Workaround for apps to stop before removing the task
- With live tile enabled, the race between destroying the task and
  killing the process is more evident since the app may not get
  stopped at all.  For now, when dismissing, defer removing the
  task until we've finished the recents animation to allow the
  app to be stopped accordingly

Bug: 184899234
Test: Dismiss the task from overview, check that the app gets
      lifecycle events
Change-Id: Ib3ea479643d65859fe4cd580b4c347b87130a69d
Merged-In: Ib3ea479643d65859fe4cd580b4c347b87130a69d
2021-06-04 22:00:30 +00:00
Lucas Dupin
997ac6cddc Merge "Remove blur from launcher when in overview" into sc-dev 2021-06-04 19:51:46 +00:00
Lucas Dupin
258e4526b7 Remove blur from launcher when in overview
The App window will be under Launcher, so we can't actually blur
launcher at that time, otherwise the live window will also be blurred.

Test: manual
Bug: 189207458
Change-Id: Ie07449d29d3b0dc60d3787b6d32aa9e46e0bb613
2021-06-04 11:05:37 -07:00
Vadim Tryshev
a5a61dddfd Merge "Postponing CUJ_QUICK_SWITCH and CUJ_APP_CLOSE_TO_HOME" into sc-dev 2021-06-04 17:57:00 +00:00
Yogisha Dixit
4ff5ee3a8f Add new log events for widgets.
Design doc: go/widgets-logging

Bug: 185778648
Test: manual
Change-Id: Ia3c6edb87766a33e77865e9461e7101a1df864c1
2021-06-04 14:52:37 +01:00
TreeHugger Robot
04eff2698c Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-dev 2021-06-04 00:23:55 +00:00
Bill Yi
5821abb3e5 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I463274ac8154729157b0fd623b966dba8ce36711
2021-06-03 19:00:20 +00:00
Bill Lin
a1221bcd53 2/ Notify adjust touch slop when one handed mode activated
When one handed mode activated, user swipe-up to exit usually
cross over the NavBar region, and then invoke TouchController
intercept touch event to trigger All Apps drawer on Home.

To enhanced the UX of gesture conflict of exit OHM & All Apps,
notify TouchController throught LauncherActivityInterface,
and Launcher dispatch onOneHandedModeStateChanged() event to
all mTouchControllers in DragLayer that touchController can
adjust the touch slop by it's SingleAxisSwipeDetector.

Test: manual trigger One handed mode and swipe-up to exit
Test: monitor minDisplacement of SingleAxisSwipeDetector
      OHM activated : touchSlop x multiplier
      OHM deactivated : touchSlop x 1
Test: check All Apps doesn't mis-trigger when exit one handed mode
Bug: 186235522
Change-Id: I7b9e6e7fa898231697d1866186a5f9b1717a9aa3
2021-06-04 01:44:51 +08:00
Bill Lin
945bb34b5e 1/ Provides feasibility to adjust touch slop in TouchController
There is a case when one handed mode triggered(Activated), all apps
drawer is very easy to trigger while user swipe up around NavBar
region to exit one handed mode. Since System Gesture monitor regsion
is small on screen bottom, swipe-up gesture usually cross over NavBar
monitor region and invoke launcher touch controller intercept touch
event and introduce unexpectedly trigger all apps drawer.

Adding onOneHandedModeStateChanged(boolean activated) for controller
be able to adjust the touch slop by multiplier, we can set a larger
multiplier when the visible window size translate become smaller
and make swipe gesture not too sensitive.

Test: manual swipe up to swich "home <-> all apps" and monitor
      minDisplacement of SingleAxisSwipeDetector
Test: Trigger one handed mode and swipe up to exit one handed mode
      check the minDisplacement of SingleAxisSwipeDetector
Bug: 186235522
Change-Id: I9729cd408d85b2b22582bf800e28d1471fc06980
2021-06-04 01:44:50 +08:00
Zak Cohen
d7129fc919 Merge "RecentsView - reduce work in color tint animator" into sc-dev 2021-06-03 17:09:45 +00:00
Shawn Lin
cd0fe7b057 Merge "Detach the nav once the endTarget is determined as HOME" into sc-dev 2021-06-03 11:47:50 +00:00
shawnlin
2b006fb27b Detach the nav once the endTarget is determined as HOME
Bug: 189900722
Test: manual - swipe up to home from an app and observe the nav
Change-Id: I421de17fe4d8413deaf9ebd63166a6d2d00d096e
2021-06-03 13:06:42 +08:00
zakcohen
da08cb2639 RecentsView - reduce work in color tint animator
Don't allocate animators when there is no animation to do. The work was
not required.

Bug: 189492167
Test: Local build, run and trace analysis
Change-Id: I111768b055ed636aa92d5d9d6b799f316a568380
2021-06-02 15:46:46 -07:00
vadimt
09f1d8f9b7 Postponing CUJ_QUICK_SWITCH and CUJ_APP_CLOSE_TO_HOME
Now starting at the first drawn frame.

Test: perfetto
Bug: 188645726
Change-Id: I035f225f5afe64cf6eafa9ba40cffffce0a9d8cc
2021-06-02 14:09:08 -07:00
TreeHugger Robot
8c46bba98e Merge "AssistContentRequester move binder call to background thread." into sc-dev 2021-06-02 20:31:53 +00:00
zakcohen
243fbd3e5d AssistContentRequester move binder call to background thread.
The call into system server is synchronous, so make the call off the main
thread to avoid jank.

Bug: 189251291
Test: Local with flag enabled
Change-Id: I1787a0ad68488755bf19e813ecfe9fc079cfaed8
2021-06-02 10:33:31 -07:00
Pat Manning
49cb49b1f5 End drag touch event when crossing task drag threshold, and only when task is going up (drag to dismiss)
Test: manual
Fix: 188618115
Bug: 188618115
Change-Id: I51d157e224eaeee34ed131e4945bb92d6baf18cd
2021-06-02 16:28:25 +00:00
Wei Sheng Shih
630efccd7a Merge "Read the starting surface icon size from framework" into sc-dev 2021-06-02 10:00:22 +00:00