Commit Graph

3297 Commits

Author SHA1 Message Date
Lucas Dupin
6d7a006302 Constrain scroll amount
Test: scroll vertically and horizontally
Fixes: 196309367
Change-Id: Ibf16fb72cf95e29ed820d5f511e764a388c93bb0
Merged-In: Ibf16fb72cf95e29ed820d5f511e764a388c93bb0
(cherry picked from commit b259a896f5)
2021-08-25 16:45:20 +00:00
Alex Chau
d688120ee1 Merge "Fix animation problem when swipeing up app to screen edge and release" into sc-qpr1-dev 2021-08-25 09:08:03 +00:00
Lucas Dupin
e3cf162169 Synchronize surface transaction am: 0a2076e8d3
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15669618

Change-Id: I494543d4183689bfcec9ed4e384be4ad3e660707
2021-08-25 03:35:43 +00:00
Lucas Dupin
0a2076e8d3 Synchronize surface transaction
Until now the SurfaceControl transaction was being applied
asynchronously, which could lead to it being executed out of sync with
launcher drawing.
This became an issue at higher refresh rates, where frames are produced
at a much faster pace.

In order to fix this issue, we can use BLAST transactions, which are
annotated with a frame number.

Test: record video, go through it manually
Fixes: 194320152
Change-Id: I1636a1ded4f9dd84c54ba12239e3549b92ed7567
Merged-In: I1636a1ded4f9dd84c54ba12239e3549b92ed7567
2021-08-24 21:28:50 +00:00
Alex Chau
df2b9e14d6 Fix animation problem when swipeing up app to screen edge and release
- Consider scroll diff between currentPage and primary scroll when calculating adjacent page offset
- Removed setEnableFreeScroll call in onPrepareGestureAnimation that calls setCurrentPage and causes jumping

Fixes: 197012570
Fixes: 195740577
Test: Swipe up from app to end of screen, adjacent task should come from screen edge, and app should snap smoothly to position
Test: Swipe up from app, scroll immediately, free scroll should be enabled
Test: Swipe up immediately after quick switch, task thumbnails are loaded
Change-Id: Id88266634183dfcb18d5ba8a803883b7d6f50ab4
Merged-In: I1964b8c3bd82b22396340d2352833b2aee73a6fc
(cherry picked from commit 8ebd11af14)
2021-08-24 10:11:41 +00:00
Lucas Dupin
f52fb6f632 Act on scrim visibility am: a8382dc052
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15655786

Change-Id: I40626071bdaadd997cc1479118224847b78229d3
2021-08-23 21:34:23 +00:00
Lucas Dupin
a8382dc052 Act on scrim visibility
The scrim visibility drives whether the launcher window is opaque or
not. We should track it and apply the flag instead of trying to catch it
through other Launcher life cycles.

Fixes: 195365607
Bug: 196403152
Test: tap on home button while launching app from overview
Change-Id: I2a00b86b602b5dd12c901433b92adcf0170be15e
(cherry picked from commit e4a9469156)
2021-08-23 19:22:02 +00:00
TreeHugger Robot
686d42a1d4 Merge "New app animation specs." into sc-qpr1-dev 2021-08-19 00:45:05 +00:00
Jon Miranda
bda98de9f8 New app animation specs.
- New values and interpolators.

Bug: 173107751
Test: open apps from different parts of the home screen
Change-Id: I81bec0221aec9c04dac0bb3e926c879999699e57
2021-08-18 18:26:46 +00:00
Lucas Dupin
482f983a7b Add depth to -1 screen
Wallpaper will zoom out as you drag the overlay

Test: manually pull overlay
Fixes: 192502999
Change-Id: I9067b70d10497d4e16a5ef601161fbedfa9307e1
Merged-In: I9067b70d10497d4e16a5ef601161fbedfa9307e1
(cherry picked from commit 87d752062e)
2021-08-18 15:34:45 +00:00
TreeHugger Robot
3be0173b14 Merge "Adjust all apps zoom level" into sc-dev am: 6b10f4649c
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/15530106

Change-Id: Id2a24af3aed6fa4819a2fc46c8a305b06ff31d84
2021-08-12 00:31:19 +00:00
Lucas Dupin
3f6a4e6bf5 Adjust all apps zoom level
The All Apps scrim fades in early, covering part of the zoom animation.
We need to adjust the max zoom in order to make All Apps consistent with
Overview, -1, and Shade.

Test: pull up the all apps drawer
Fixes: 195992422
Change-Id: Ia7bbe17fe7f227dd0a16ba7d21b402cff57176f0
(cherry picked from commit f168bb7aaf)
2021-08-11 15:55:04 +00:00
Thales Lima
931bc2a38e navigation: don't run gesture animation if gestures are not enabled
Makes the animation when using 3 button navigation be closer to what we
have in non fallback mode, also fixing the problem when fallback recents
just started and don't have any views.

Fix 194487871
Test: manual with gestures, 2 button and 3 button nav

Change-Id: If3925d6bef1d14f51b86169d06607786972f5f1f
(cherry picked from commit 8d49c4bb29)
2021-08-11 10:26:22 +00:00
Tony Wickham
0b3b2921c3 Don't recreate touch controllers when ending gesture
Test: swipe up to overview from an app and swipe up to dismiss it during the transition
Bug: 189700453
Change-Id: I303696f90dbb236ea93e06d94a3c92d783850fa4
(cherry picked from commit 0e9ecaeea8)
2021-08-10 23:26:33 +00:00
Tracy Zhou
145bd74749 [DO NOT MERGE] Disable live tile in split mode for S
Recall link: https://recall.googleplex.com/projects/debb8388-5e38-42c5-99ab-20bdfb92d25e/sessions/655af962-b4bd-4dc4-93aa-178852c0d701

Bug: 193991436
Test: enter split screen and swipe up
Change-Id: I7adffcdefb12d225db207542716a436f29df0377
2021-08-03 20:50:27 +00:00
Alex Chau
fb5ae9060d Always treat FallbackRecentsView as visible if isInLiveTileMode is true
- activity.hasBeenResumed is no longer an accurate indicator after live tile has been introduced, indeed it's always false
- Return recentsView regardless if there is a runningTask as well

Bug: 194286330
Test: In fallback Recents with 3 button, tap overview button from home screen, then tap overview button again. Try combination with back and home button
Change-Id: Ib2775a11f5466abc433763f24192e7bfdcf191a2
(cherry picked from commit 455718e842)
2021-07-30 08:22:03 +00:00
Tracy Zhou
6842315605 Clear command queue of OverviewCommandHelper on home tap
Fixes: 194934483
Test: manual
Change-Id: Id83b341245793c38c305e6ada5581ac4e49527a7
Merged-In: Id83b341245793c38c305e6ada5581ac4e49527a7
2021-07-29 19:09:53 +00:00
Tracy Zhou
024749a1e0 Merge "Reset current task and dequeue overview commands when recents animation is cancelled" into sc-dev 2021-07-26 21:17:38 +00:00
Tracy Zhou
94e798bac1 Reset current task and dequeue overview commands when recents animation is cancelled
Fixes: 193925362
Test: manual
Change-Id: I792be003e5aabf34324075829d5381cba591892b
2021-07-26 12:17:01 -07:00
Sunny Goyal
58e81e5da1 Fixing touch events ignored in some cases
Bug: 160218103
Test: Manual
Change-Id: Ifa71e742451acecd8979a6833a202c6189b4df52
2021-07-22 15:27:43 -07:00
Jason Chang
1b3f5d3883 Merge "Fix unable to swipe up to exit one-handed mode under 2 button navigation" into sc-dev 2021-07-22 09:43:13 +00:00
Brian Isganitis
ec4a56a311 Support overriding All Apps EDU animation on drag
Test: Dragging during All Apps EDU animation overrides the animation.
Bug: 160218103
Change-Id: I1c0a2d047bcb43ea7ce30cf87182b392dac313e4
2021-07-21 17:39:00 +00:00
Jason Chang
edc7917521 Fix unable to swipe up to exit one-handed mode under
2 button navigation

Remove redundant condition checking when consuming One-handed mode
gesture events.

Bug: 193761450

Test: manual
Test: atest WMShellUnitTests
Change-Id: Id4687cb579c17d7de1a08b32c003e656cbbce820
2021-07-21 11:54:52 +08:00
Lucas Dupin
ee9099af7f Revert "Apply depth even when surface is null"
This reverts commit a6c38be150.

Fixes: 193333562
Test: manual
Change-Id: I4fae079e0cd056fc800e5a15389f4795c77e17fb
2021-07-20 14:14:50 -07:00
Sunny Goyal
c3f56d7628 Merge "Fixing quickswitch window not properly aligned in split-screen" into sc-dev 2021-07-20 07:03:51 +00:00
Sunny Goyal
a1bed5428d Fixing quickswitch window not properly aligned in split-screen
Bug: 193992000
Test: Manual
Change-Id: Ic37cbc561a0299be1a1c05dfb17bd826c173100e
2021-07-19 17:10:12 -07:00
Jonathan Miranda
8e095ccb05 Merge "Fix notification dot not always being up to date." into sc-dev 2021-07-19 17:45:26 +00:00
Jon Miranda
f8441cc276 Fix notification dot not always being up to date.
- Prediction row views were never updated when notification changes.
- FloatingIconView set the BubbleTextView to force hide dot, but never restored it.
  BubbleTextView is instanceof IconLabelDotView, so its already handled in the end runnable

Bug: 183360736
Test: 1. swipe up to go home such that the closing app has a notification,
         note that the notification dot is properly updated
      2. have all apps open
         make notification update for a predicted app
         ensure dot is properly updated

Change-Id: I35dacf9b71a3d8b8a857be450690d65ea9199bf6
2021-07-16 17:50:56 -07:00
TreeHugger Robot
f054bf5681 Merge "Fixing regression from animation not starting while in overview" into sc-dev 2021-07-16 01:27:02 +00:00
Winson Chung
558b18eb12 Fixing regression from animation not starting while in overview
Bug: 193830420
Test: Open an app in overview, tap on a notification
Change-Id: Ifd9797dc40d9fffbf9603bca98fcb4a4119e0444
2021-07-15 16:17:51 -07:00
Cyrus Boadway
66f1b57815 Merge "Keep transparent drawable for clipping outline during launch animation" into sc-dev 2021-07-15 18:28:29 +00:00
Hongwei Wang
a35d7ec90e Merge "Use display cutout info in auto-enter-pip transition" into sc-dev 2021-07-14 23:52:42 +00:00
Cyrus Boadway
1cf5527ae8 Keep transparent drawable for clipping outline during launch animation
During the widget-activity transition, the widget foreground loses its
clipping radius, if the clipping is determined by a drawable. We remove
the drawable through the animation.

For widgets where there is content being clipped by the background's
corener radius, this results in the widget window appearing square
through the entire animation, then snapping in rounded corners on
animation-complete.

To solve this, we leave a transparent clone of the drawable in the
original drawable's place, for the balance of the animation, providing
the outline for clipping.

Manual testing against 20 Google widgets showed no regression in
behaviour in other cases.

Bug: 193665108
Test: manual

Change-Id: I3db31e4634c8dd6b22a513a976386d396445ebc2
2021-07-14 19:21:16 +00:00
Schneider Victor-tulias
ae2e5d9231 Merge "Update Gesture navigation tutorial to match new specs" into sc-dev 2021-07-13 23:27:45 +00:00
Hongwei Wang
854fbf8d23 Use display cutout info in auto-enter-pip transition
Video: http://recall/-/aaaaaabFQoRHlzixHdtY/bpKcGg1eoOo5Jz5U6IwBYK
Bug: 191310680
Test: manual, auto-enter-pip from landscape with source rect hint being
      turned on, see the video
Change-Id: Ic191fc73597132a5119522dda477a4319e35d1c8
Merged-In: Ic191fc73597132a5119522dda477a4319e35d1c8
2021-07-13 13:24:57 -07:00
Schneider Victor-tulias
bfe33b057a Update Gesture navigation tutorial to match new specs
- Updated strings
- Updated removed 'next' button when there are followign steps
- Added timeout to automatically continue the tutorial
- Combined back left and right into one step

Bug: 192009114
Bug: 177005427
Test: manual
Change-Id: I58b9017c4d69b5d097326c7d5be156a63951fb1a
2021-07-09 19:38:16 +00:00
Winson Chung
d489a4b6e9 Merge "Fix crash when handling recents animation canceled" into sc-dev 2021-07-08 21:21:37 +00:00
Winson Chung
255fe1ea45 Fix crash when handling recents animation canceled
- If Launcher finishes the animation, that also cleans up the screenshot
    on the server side, so we can skip calling it

Fixes: 192684578
Test: N/a, adding a null check
Change-Id: I8bf1ad5089762469697d14842cc14c184055e925
2021-07-08 10:12:34 -07:00
kumarashishg
88be649d21 NIU Actions: Add NIU Actions tooltip
These tooltips are added to educate the user about NIU buttons actions. We have added tooltips for Translate and Listen NIU actions buttons.

Bug: 186006700
Test: Manual
Change-Id: Ib076c2a44055b62f2daf06bddf45aca220a28756
2021-07-08 00:48:22 +00:00
Vinit Nayak
7d0826f3d1 Merge "Set correct divider dimension for task menu options" into sc-dev 2021-07-07 19:56:56 +00:00
Winson Chung
da587fb7a6 Merge "Remove unused logs" into sc-dev 2021-07-07 18:02:53 +00:00
Lucas Dupin
e55878cedf Merge "Use launcher surface when removing launch target" into sc-dev 2021-07-03 17:14:32 +00:00
Winson Chung
a82403ab09 Merge "Fix crash when handling recents animation canceled" into sc-dev 2021-07-03 03:26:26 +00:00
Winson Chung
553d978012 Fix crash when handling recents animation canceled
- If Launcher finishes the animation, that also cleans up the screenshot
  on the server side, so we can skip calling it

Fixes: 192684578
Test: N/a, adding a null check
Change-Id: Ia6b99b4262e72f925e7d622ea8833d3c88252633
2021-07-03 03:26:16 +00:00
Lucas Dupin
20a13047ae Use launcher surface when removing launch target
Otherwise events won't be dispatched properly and window opacity will be
wrong.

Test: manual
Fixes: 191149025
Change-Id: Ice7ea86252282c7dc1cb5925dd1bdb8cade89c08
2021-07-02 17:39:10 -07:00
Tracy Zhou
ee5dc1149e Merge "[DO NOT MERGE] Make the cutout slightly smaller" into sc-dev 2021-07-02 21:41:28 +00:00
Tracy Zhou
26f47c711a [DO NOT MERGE] Make the cutout slightly smaller
Temporary fix for S. Leaving the bug open for a proper fix in T.

Bug: 189265196
Test: https://screenshot.googleplex.com/75fgCva736rqwg5
Change-Id: Ice3b189a41f759e090334e360e44543eabc4836d
2021-07-02 13:35:50 -07:00
Sunny Goyal
6348858734 Merge "Fix some touch issues during gesture nav transition" into sc-dev 2021-07-02 18:33:34 +00:00
Tracy Zhou
fa72529b05 Merge "Check if live tile targetSet is null in launchSideTaskInLiveTileModeForRestartedApp" into sc-dev 2021-07-02 18:18:23 +00:00
Tracy Zhou
d2039614e0 Check if live tile targetSet is null in launchSideTaskInLiveTileModeForRestartedApp
Fixes: 192458435
Test: N/A
Change-Id: I3f0b828bf9fa9645bbd253612aa073f37b21e4b2
2021-07-01 23:52:34 -07:00