Commit Graph

11152 Commits

Author SHA1 Message Date
Alex Chau
34bfc7a80b Add debug log for TaskView.onClick
Bug: 310064698
Test: manual
Flag: None
Change-Id: Ib772dd8995442d3b1af84aec0668b11828ab62e6
2024-04-09 17:45:30 +01:00
Sunny Goyal
8ecbaa422f Merge "Moving various nav-bar configs out of feature flags" into main 2024-04-09 05:45:21 +00:00
Jeremy Sim
fa3eae99a5 Merge "Fix bug where app pair title was not updating with language" into main 2024-04-09 00:22:19 +00:00
Sunny Goyal
89931316a2 Moving various nav-bar configs out of feature flags
Bug: 332588958
Test: Presubmit
Flag: None
Change-Id: Ia4dc5b69bcf4d461e3444b9e37bb7334bb74aae4
2024-04-08 16:54:04 -07:00
Federico Baron
9462c3b604 Merge "Fix null pointer in FloatingWidgetView" into main 2024-04-08 18:52:43 +00:00
Treehugger Robot
8687018b09 Merge "Disable app chip menu height limit for bottom row" into main 2024-04-08 18:22:08 +00:00
Treehugger Robot
18694cc977 Merge "Add max height logic and avoidance of taskbar into task menu" into main 2024-04-08 18:22:08 +00:00
Liran Binyamin
9a9ef494ae Merge changes I74b09220,Id7e2db5f into main
* changes:
  Don't animate bubbles in the initial state update
  Suppress animation for bubbles that auto expand
2024-04-08 16:30:30 +00:00
Uwais Ashraf
d9de4b0558 Add max height logic and avoidance of taskbar into task menu
Fix: 329842207
Test: Manually tested, see video in bug
Flag: NA
Change-Id: I08079f14cee63fe7973ba751529109ca66423bb6
2024-04-08 16:23:59 +00:00
Alex Chau
293d2cb867 Disable app chip menu height limit for bottom row
Bug: 326952853
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD
Test: manual
Change-Id: I104296979803eb8967b07793f4f2590e592f9df7
2024-04-08 16:24:45 +01:00
Saumya Prakash
83646f9b82 Merge "Add Taskbar education for Circle to Search for pinned taskbar" into main 2024-04-06 05:39:28 +00:00
Saumya Prakash
5453c053b9 Add Taskbar education for Circle to Search for pinned taskbar
This change adds a new education tooltip for pinned taskbar that teaches
users how to use Circle to Search invoked through the action key. It won't run on
transient taskbar or if the user is in 3 button mode. The disclosures at
the bottom of the tooltip link to localized legal agreements for the feature.

Fix: 330401405
Test: Pin the taskbar and observe that the next time an app is launched
the edu shows up. After dismissal it shouldn't show up again.
Additionally, click on the disclosures and ensure they launch.
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning NEXTFOOD

Change-Id: I64aea3004aca77c3ec81b81dea0cfab7a9c1e272
2024-04-06 01:52:49 +00:00
Liran Binyamin
0701ab166d Don't animate bubbles in the initial state update
When launcher receives the initial bubble state update from sysui, don't animate the bubbles. The initial update is sent when bubble bar is created and not when new bubbles are created.

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605846
Test: manual
Change-Id: I74b09220be22d7382fa6d7c1351d5e60a799a054
2024-04-05 20:15:52 -04:00
Sunny Goyal
8e1f37181d Merge "Allowing base class for ResourceBasedOverride to have Context based constructors" into main 2024-04-05 23:20:38 +00:00
Tony Wickham
a6dcb11094 Merge "Apply insets to top-level providers, not just paramsForRotation" into main 2024-04-05 22:01:29 +00:00
Jeremy Sim
24284467b5 Fix bug where app pair title was not updating with language
This CL adds the ability for an app pair icon to update its title string when package changes are detected. It also reorganizes some code in the app pairs classes for readability.

Fixes: 316051810
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual
Change-Id: I833e4f9766b7da8c0a3a5fb4b9fc050d8897437e
2024-04-05 21:35:58 +00:00
Sunny Goyal
9d28eee769 Allowing base class for ResourceBasedOverride to have Context based constructors
Bug: 330920490
Flag: None
Test: Presubmit
Change-Id: Ib4d1ef80133596a114a4fb32ea8ae918852a77f5
2024-04-05 12:56:36 -07:00
Anushree Ganjam
16a0f61078 Merge "Add dump for PredictionRowView." into main 2024-04-05 19:41:31 +00:00
Tony Wickham
f95a6b73e5 Apply insets to top-level providers, not just paramsForRotation
Bug: 329012507
Flag: none
Test: trigger assistant, ensure bottom insets are removed in
gesture nav mode; also verify IME inset override correctly
applies in 3 button mode

Change-Id: I823d0d360a7e3b41cc291f6949d9371e0dc32efb
2024-04-05 19:40:06 +00:00
Liran Binyamin
c21852a186 Suppress animation for bubbles that auto expand
Check whether the state update indicates that the bubble bar is expanding, and pass that to the bubblebarviewcontroller so that we can suppress the new bubble animation if we're expanding from stashed.
Note that in some cases the notification service may not include the auto expand flag on the message it sends to sysui, so launcher will end up getting 2 separate messages. We may need to handle that separately.

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605846
Test: manual
       - create bubble that auto expands
       - observe that the bubble does not animate
       - note that in some cases the notification service may not include the auto expand flag, will look into that separately.
Change-Id: Id7e2db5fd32d391413c57d83effb4b23b1085125
2024-04-05 14:09:32 -04:00
Anushree Ganjam
1115b416bb Add dump for PredictionRowView.
adb shell dumpsys activity NexusLauncherActivity : https://paste.googleplex.com/4907497231482880

When AllApps prediction is off : https://paste.googleplex.com/5930628737925120

Bug: 332171918
Test: Manual
Flag: NA
Change-Id: I753ff876aab162026d99fd1b35f63edf2e712f70
2024-04-05 10:57:44 -07:00
Schneider Victor-tulias
09268637b4 Merge "Add debug logs to TaskView" into main 2024-04-05 16:46:55 +00:00
Tony Wickham
fefe8a441b Merge "Unstash taskbar due to IME immediately when system gesture starts" into main 2024-04-05 15:49:36 +00:00
Schneider Victor-tulias
148cbffdbf Add debug logs to TaskView
Investigating b/332386996

Flag: N/A
Bug: 332386996
Test: TaplTestsQuickstep#testQuickSwitchFromApp
Change-Id: I633a1a67cadc8f1f85fbdeb3a0913623ae817bf1
2024-04-05 10:31:21 -04:00
Treehugger Robot
6539e29882 Merge "Launch AppPair live tile when not visible" into main 2024-04-05 02:08:17 +00:00
Liran Binyamin
98bbc2b46d Merge "Animate the stash handle for new bubbles" into main 2024-04-05 00:49:39 +00:00
Vinit Nayak
8c14bef1f2 Merge "Explicitly set animation and timings for split cancel button" into main 2024-04-05 00:07:13 +00:00
Vinit Nayak
637274ebc9 Launch AppPair live tile when not visible
* End the recents animation and then relaunch as if
from scratch
* We explicitly ignore the anim for end of recents animation
since that will cause the taskbar to quickly show and stash
again, and we know in this case that we'll quickly be launching
right back into an app

Test: Tested w/ live tile + non live,
fullscreen + app pairs
Bug: 316485863

Change-Id: I6ae8cccc01401935bf96fba8a154216e6b1ad701
2024-04-04 15:58:17 -07:00
Tony Wickham
a6b29968a4 Unstash taskbar due to IME immediately when system gesture starts
This is reversing a previous change from a few years ago
(ag/16325264) because we now clip the recent apps on the bottom
during gesture nav, whereas before we left them unclipped until
you swiped up.

Flag: none
Fixes: 305977350
Test: verified visuals manually in persistent, transient, and 3
button nav; also tested interactions with All Apps

Change-Id: Ib3823a9bd9aebf923ad481c010c7e8544bcb6a4d
2024-04-04 22:07:43 +00:00
Vinit Nayak
aeb9595b37 Explicitly set animation and timings for split cancel button
* Mismatched animation durations were causing recents task
thumbnails to flash in at the end.
* Following a similar pattern started at ag/26378432, except
here we manually call all the steps to create launcherState
animation

Fixes: 321863575
Test: Repro steps from bug no longer occur.
Tested on phone and large screen, workspace, overview and all apps

Change-Id: I02696c0470bf4cfe6a278f0a2bc0786367a9fe37
2024-04-04 14:20:18 -07:00
Jagrut Desai
e6f349b3dd Adjusting Taskbar Icons for larger display size
Bug: 323948193
Test: Manual
Flag: NONE

Change-Id: I0bdfcaebf3de050ac850fe42c061c82ffebdb7c2
2024-04-04 14:01:57 -07:00
Ats Jenk
9f0042b2c8 Merge "Update spring stiffness for bubble bar drag animation" into main 2024-04-04 18:56:27 +00:00
Ats Jenk
d961c3d31d Merge "Update bubble bar bounds in shell" into main 2024-04-04 18:55:36 +00:00
Liran Binyamin
597ced3033 Animate the stash handle for new bubbles
The stash handle now animates out before the new bubble animates in, and animates back in after the new bubble is hidden.
There's still some additional polish needed :)

Demo: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/z30Ob1rcDUkNEphLAQsgV

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605846
Test: atest BubbleBarViewAnimatorTest
Change-Id: I03449286b01ec96de9834e24a707652ddbe49fb0
2024-04-04 14:26:08 -04:00
Treehugger Robot
c9d07b0639 Merge "Align widget picker bottom swipe transition with predictive back." into main 2024-04-04 18:07:32 +00:00
Vinit Nayak
247c6ac8ec Merge "Allow app pairs in folders" into main 2024-04-04 17:55:34 +00:00
Holly Jiuyu Sun
568b84ffcc Merge "[omni] Read long press duration from AppSearch and override server configured value." into main 2024-04-04 16:09:44 +00:00
Treehugger Robot
5c8241b421 Merge "Update the WidgetPickerActivity to display recommendations for hub host" into main 2024-04-04 14:36:56 +00:00
Alex Chau
2bf1143079 Merge "Clean-up unnecessary desktop windowing flag usage" into main 2024-04-04 14:04:49 +00:00
Johannes Gallmann
ed184acb3a Merge "Use custom interpolator for predictive back system animations" into main 2024-04-04 13:19:31 +00:00
Alex Chau
312dd2f5bb Merge "Reland "Update Split button visibility based on DeviceProfile change"" into main 2024-04-04 12:17:38 +00:00
Alex Chau
13b7ceeff0 Clean-up unnecessary desktop windowing flag usage
- mDesktopVisibilityController will now be null if desktop windowing flag is disabled
- As a result, all code that uses mDesktopVisibilityController no longer need to check desktop windowing flag
- DesktopTaskView/DesktopTask only populates when flag is enabled, so we don't need to check flag if we already check DesktopTaskView/DesktopTask
- Removed the flag check in SplitToWorkspaceController, as we shouldn't enable split from workspace base on desktop windowing, contextual split already have its own flag
- Also avoid creating GroupTask or DesktopTask for freeform tasks when flag is off, to avoid a crash in RecentsView

Bug: 332655617
Test: manual with desktop windowing flag on/off
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Change-Id: I0e45f73ad2b0d99dfb4ec3215f973679ca93957c
2024-04-04 12:21:43 +01:00
Johannes Gallmann
d989d0ec02 Merge "Add vsync id to predictive back transactions" into main 2024-04-04 11:20:43 +00:00
Alex Chau
7d0edb46ac Reland "Update Split button visibility based on DeviceProfile change"
This reverts commit 38bc885de9.

- Always request layout of action_buttons after changing visibility of its children
- Update Split button visibility based on DeviceProfile change in updateDimension() only
- Update Split button visibility based on 3P launcher in initialization only
- Also simplified action_buttons to wrap_content and layout in middle of parent
- Also removed the space between buttons and use marginStart
- Fixed TAPL to not expect save app pair button on phone. Before this CL actions_buttons are still on view hierarchy despite they're not visible on screen.

Fix: 321291049
Fix: 329255757
Test: Clear all tasks, fold, launch app, swipe up to Overivew; repeat in RTL
Test: OverviewImageTest
Flag: None
Change-Id: I9ecf872279f6f07d2d9bc33fb09031568023cb77
2024-04-04 11:58:35 +01:00
Treehugger Robot
d477acedfb Merge "Add LAUNCHER_ALL_APPS_SEARCH_BACK jank instrumentation" into main 2024-04-04 07:20:45 +00:00
Jeremy Sim
a596f589c4 Allow app pairs in folders
This CL substantially refactors folders to be able to take contents of type AppPairInfo. App pairs can now be moved in and out of folders, and launch from folders.

This CL contains only logic and model changes; animation and style changes (for dropping items into folders, color changes to app pair surfaces, etc.) will be in a following CL. Another CL (hopefully) will contain tests. I'm planning to submit them together, but this patch should also be able to stand alone with no issues (except janky transitions).

Bug: 315731527
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual, more to follow in another CL.
Change-Id: I73732fcaefbdc61bf6e02a5be365962b8bbc3e41
2024-04-03 16:47:42 -07:00
Ats Jenk
3a60cee509 Update spring stiffness for bubble bar drag animation
Use MEDIUM_LOW spring stiffness for bubble bar translation spring.

Bug: 330585397
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: manual, drag and release bubble bar
Change-Id: Id27a5c5a7a77ae1fee988816271adb810635d84b
2024-04-03 15:26:45 -07:00
Eghosa Ewansiha-Vlachavas
43b731801b Fix launcher activity leaking when desktop windowing enabled
When desktop windowing is enabled we initiate the
`SplitFromDesktopController` within the `SplitSelectStateController`
which registers a `SplitSelectListener` on the launcher instance.
However when we destroy the `SplitSelectStateController` the
`SplitFromDesktopController` is not destroyed an thus any listeners are
not unregisterd. Instead we should explicitly destroy the
`SplitFromDesktopController` by unregistering listener.

Flag: NONE
Fixes: 332667403
Bug: 331774319
Test: atest -c NexusLauncherTests:com.android.quickstep.TaplStartLauncherViaGestureTests
atest -c NexusLauncherTests:com.android.quickstep.util.SplitSelectStateControllerTest

Change-Id: I68ffcc4114644e75f751632eca8bc73e406139a8
2024-04-03 22:04:06 +00:00
Zak Cohen
4d341404c6 Align widget picker bottom swipe transition with predictive back.
Bug: 325930715
Test: widget picker tests
Flag: NA
Change-Id: I15319f0a264503ff34dd4cc0dc36a40531379e2b
2024-04-03 12:46:33 -07:00
Sunny Goyal
54e9c6c81c Merge "Using IHomeTransitionListener for listening for Launcher state when taskbar recreates" into main 2024-04-03 16:35:05 +00:00