Commit Graph

19573 Commits

Author SHA1 Message Date
Cosmin Băieș
33f8bfbadf Add IME switch button long click support
This adds support for handling long clicking on the IME switch button.
Initially it will behave exactly like short clicking, i.e. show the IME
switcher menu.

Flag: android.view.inputmethod.ime_switcher_revamp
Test: atest
  TaskbarNavButtonControllerTest#testPressImeSwitcher
  TaskbarNavButtonControllerTest#testLongPressImeSwitcher
Bug: 311791923
Change-Id: Ibd0d6bce2bab11511bc082f46731ec86038c8cf8
2024-07-11 11:42:16 +02:00
Mykola Podolian
103191c589 Merge "Shadow for bubble icons fixed." into main 2024-07-10 19:38:23 +00:00
Alex Chau
33da74f8c2 Merge "focusTransitionScaleAndDimOut should always go from 1f to 0f" into main 2024-07-10 16:41:03 +00:00
mpodolian
a3921ddb67 Shadow for bubble icons fixed.
The bubble's outline was hardcoded with a fixed size. This caused a
shadow to be drawn using the hardcoded outline size, regardless of the
actual bubble view size. The BubbleView logic has been updated to use
the actual bubble size for the outline. The guarding flag has been
removed.

Bug: 340445019
Flag: com.android.wm.shell.enable_bubble_bar
Test: http://recall/-/gx8ASgewUeUS3QYohfrd1J/hqFtAZJnX0tCRONoFpSK3i
Change-Id: Iaa2c2d0bfeee2af9840acbcf11daaf8be2e0b7af
2024-07-10 16:36:22 +00:00
Liran Binyamin
e29e31922f Merge "Fix squished hotseat due to bubbles" into main 2024-07-10 16:10:41 +00:00
Liran Binyamin
4cebffa209 Merge "Fix missing bubble update dot" into main 2024-07-10 14:23:16 +00:00
Liran Binyamin
c79119e911 Merge "Fix bubble update animation" into main 2024-07-10 14:23:04 +00:00
Alex Chau
c378e64b75 focusTransitionScaleAndDimOut should always go from 1f to 0f
- Also updated AnimatedFloat to accept a Consumer<Float>, so a lambda can be used as updateCallback with refernce to udpated value
- Also updated PendingAnimation to accept Animator with TimedInterpolator without specifying SpringProperty

Fix: 352195519
Test: manual
Flag: EXEMPT bugfix
Change-Id: Ifb78c1bcd3ca215a5d214f986a107d0988bff13b
2024-07-10 13:40:22 +01:00
Alex Chau
0ac34a3388 Add use case for split animation to retrieve thumbnail
Fix: 349120849
Test: TaskSplitAnimationHelperTest
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Change-Id: I7d4bcbdbeacd56356c71eb18c73ceef8446011d1
2024-07-10 09:37:33 +00:00
Liana Kazanova
5de87a8908 Merge "Revert "Add CUJ instrumentation for KQS"" into main 2024-07-09 22:10:40 +00:00
Treehugger Robot
8bfaf55814 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-07-09 22:10:14 +00:00
Priyanka Advani
0947d9f618 Revert "Add CUJ instrumentation for KQS"
Revert submission 28049476-kqs-cuj-instrumentation

Reason for revert: Droidmonitor created revert due to b/352144322. Will be verifying through ABTD before submission.

Reverted changes: /q/submissionid:28049476-kqs-cuj-instrumentation

Change-Id: I8bfe7bfe4ce1bd816f138dbd4d5915f837ab97a0
2024-07-09 22:04:38 +00:00
Liran Binyamin
e3eaacdcb2 Fix missing bubble update dot
Don't update the dot scale if the bubble bar is not collapsing or
expanding.

Flag: com.android.wm.shell.enable_bubble_bar
Bug: 351904597
Test: manual
       - Create 2 bubbles in the bubble bar
       - Select both bubbles to clear the dot
       - Launch an app to stash the bar
       - Send updates to both bubbles
       - Observe dot appears during each animation
       - Swipe up on the bubble bar
       - Observe dot disappears for the selected bubble but remains
         for the unselected bubble
Change-Id: I2cb6dd7ded261686ae73e497bd5d4841ebde35ef
2024-07-09 17:58:41 -04:00
Liran Binyamin
e1d5ce2fda Merge "Dump some bubble data to dumpsys" into main 2024-07-09 21:41:46 +00:00
Liran Binyamin
fef9d249bd Fix bubble update animation
Fix bubble update animation when the updated bubble is the only
bubble in the bar.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 352119655
Test: Manual:
       - Create 1 bubble in the bubble bar
       - Send an update for that bubble
       - Observe bubble bar is animated correctly
Change-Id: If569810dacf0ef77147a822c53ddebd09e35fe15
2024-07-09 16:47:36 -04:00
Liran Binyamin
a7a5617466 Merge "Fix bubble translation x when bar is collapsed" into main 2024-07-09 19:54:05 +00:00
Treehugger Robot
6f7be465c0 Merge "Taskbar running apps: show one icon per task + tap opens that task" into main 2024-07-09 19:01:02 +00:00
Winson Chung
b5522f0564 Merge "Workaround for crash with null icon drawable" into main 2024-07-09 17:42:28 +00:00
Liran Binyamin
0f08377436 Fix bubble translation x when bar is collapsed
Previously the translation x value for bubbles when the bar is
collapsed and on the right was 0 for the first bubble and some
fixed value for the rest of the bubbles. But if only 1 bubble
is visible when the bar is collapsed, as in the case when there
is only 1 bubble and the overflow, this ends up pushing the
overflow too far to the right.

This change updates the translation x value for bubbles when the
bar is collapsed and on the right, so that if only 1 bubble is
visible when collapsed, all bubbles have tx 0, otherwise if 2
bubbles are visible, the first has tx 0 and the rest have the same
tx value.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 350962159
Test: manual
       - Add 1 bubble to the bubble bar
       - Make sure bubble bar is on the right
       - Expand and collapse the bar
       - Observe the overflow tx value is correct during the animation
Change-Id: I8401d70fa6f374ace58d9cdbe3302e39e7aedc70
2024-07-09 13:10:12 -04:00
Schneider Victor-tulias
d0811445d4 Merge "Add CUJ instrumentation for KQS" into main 2024-07-09 17:07:42 +00:00
Gustav Sennton
f3108c59ed Taskbar running apps: show one icon per task + tap opens that task
Before this CL we would show only one Taskbar icon per app, making it
impossible (through the taskbar) to switch between several windows of
the same app.
With this CL we add one icon per task instead, making it possible to
bring each task to the front individually.

Flag: com.android.window.flags.enable_desktop_windowing_taskbar_running_apps
Bug: 351118893
Bug: 349790805
Bug: 351156858
Test: Started several Chrome windows -> taskbar has one icon per window

Change-Id: Ia692977effceb9ce339906bf6ca24d73e19d8769
2024-07-09 14:48:04 +00:00
Schneider Victor-tulias
c957e68e17 Merge "Add fallback handling for gesture nav mode switch and launcher destroyed mid-gesture" into main 2024-07-09 14:37:02 +00:00
Liran Binyamin
fad57132d3 Dump some bubble data to dumpsys
Flag: NONE added dump logs
Bug: 350753857
Test: manual
       - adb shell dumpsys activity service com.android.quickstep
Change-Id: I19d328f99e5ba887aa508ea9ab16e9778f13698b
2024-07-09 10:34:19 -04:00
Treehugger Robot
bb2e973297 Merge "Add NaN handling to SpringAnimationRunner" into main 2024-07-09 04:42:44 +00:00
Vinit Nayak
71c9a887c9 Merge "Add divider bg placeholder to app pair icon launch" into main 2024-07-09 04:18:56 +00:00
Winson Chung
510a00958c Workaround for crash with null icon drawable
- Fallback to using a transparent drawable for the split select icon
  if one can't be resolved

Flag: EXEMPT bugfix
Bug: 342465270
Test: Instructions from the bug
Change-Id: I5e4366b08bf438df96669ad3742bc9fb998bf0b3
2024-07-09 04:14:52 +00:00
Shamali Patwa
a84049f4fe Merge "Update the title and description provided by intent params." into main 2024-07-09 02:01:40 +00:00
Shamali P
012ad2fc07 Align the launch location passed to prediction session
Matches the prediction helper (the prediction service ignores added
widgets if launch location doesn't match the pattern. The size / pos
details however aren't used, so we pass defaults.

With this, prediction service may be able to predict widgets that
aren't already added, hence providing more suggestions.

Bug: N/A
Test: Unit test
Flag: EXEMPT BUGFIX
Change-Id: Ieaba4c9a8354dc96ea2bc70cafa106978037c572
2024-07-08 19:56:47 +00:00
Schneider Victor-tulias
00df2a9d6a Add NaN handling to SpringAnimationRunner
Also Added some debug logs

Flag: com.android.launcher3.enable_additional_home_animations
Fixes: 340426016
Test: Forced NaN and checked logs
Change-Id: Iee3536e764752a79f97e77c2ccaa8fdaa81a6eef
2024-07-08 19:07:50 +00:00
Schneider Victor-tulias
0b15d98271 Add fallback handling for gesture nav mode switch and launcher destroyed mid-gesture
If the gesture nav mode switches to button nav mode mid gesture, specifically while a recents animation start is pending, then we never invalidate AbsSwipeUpHandler. This leaves the LauncherInitListener registered in the ActivityTracker until the AbsSwipeUpHandler is invalidated by something like a quick switch. Since the AbsSwipeUpHandler is not invalidated by pressing the home button, this leaves the home button seeming unresponsive.

Also added some clean up logic and debug logging to AbsSwipeUpHandler.onTasksAppeared since this path was confusing this investigation.

Flag: NONE code clean up, debug logs and bug fix
Fixes: 340748907
Test: adb shell cmd overlay enable-exclusive --category com.android.internal.systemui.navbar.threebutton && adb shell am start -n <component> while mid-gesture
Change-Id: I72f0656a2a2b92006d2d13ba5868062f2f0aec33
2024-07-08 18:47:01 +00:00
Tracy Zhou
810cab2e9c Merge "Get rid of multiple haptic feedbacks when long pressing on nav buttons" into main 2024-07-08 17:48:07 +00:00
Liran Binyamin
a7821390e2 Fix squished hotseat due to bubbles
Hotseat supports adjusting its layout to make room for bubbles when
needed. There are 2 events that trigger this:
  1. When Hotseat's layout is reset, it checks for whether bubbles
     are showing.
  2. When Bubble Bar visibility changes it notifies hotseat so that
     it can update itself.

Folding the device is recreated triggers both hotseat layout reset
and recreation of taskbar, but the order in which these happen is not
guaranteed. Sometimes hotseat checks for the status of bubble bar
which may be visible if taskbar hasn't been recreated yet.

This change makes sure that hotseat updates itself after taskbar is
recreated and the ui controller is set, so that it cleans up any
adjustments it may have if bubbles are not visible.

Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 349430356
Test: manual
       - unfold the device
       - create bubbles
       - observe hotseat adjusts itself for the bubble bar
       - fold the device
       - observe bubble bar is gone and hotseat shows correctly
Change-Id: I58d925c178b02c22583488ae081d478bbbbccc8c
2024-07-08 09:59:26 -04:00
Bill Yi
6e36413d55 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I609e3d36ba2dfad376a840746ac68c4fbd7c53ba
2024-07-08 05:41:37 -07:00
Treehugger Robot
892d358394 Merge "Make DeskopTaskView use latest TTV" into main 2024-07-08 12:05:53 +00:00
Alina Zaidi
f9fc3cf180 Merge "[Dev option] Move DesktopModesStatus to wm/shell/shared/desktopmode from wm/shell/shared/" into main 2024-07-08 09:49:20 +00:00
Tracy Zhou
d289ca471b Get rid of multiple haptic feedbacks when long pressing on nav buttons
When returning false in a onLongClickListener, the touch event gets dispatched to onClickListener at release.

Fixes: 351457303
Test: long press and short press both result in one haptic feedback
Flag: EXEMPT bugfix
Change-Id: Id173a2d1fcf2f61c3289c653809207425b468a82
2024-07-05 23:26:45 -07:00
Alex Chau
3fde467b41 Make DeskopTaskView use latest TTV
- Made TaskThumbnailViewDeprecated nullable in TaskContainer, with non-null getter that requires feature flag to be on/off
- Removed TaskThumbnailViewDeprecated.setTaskOverlay, as it'll now be null with feature flag on
- Removed TaskThumbnailViewDeprecated from DesktopTaskView xml
- Simplifed DesktopTaskView binding logic, to always get thumbnailViews from viewPool, removeView and recycle all thumbnailViews in onRecycle
- Didn't implement view pooling of TaskThumbnailView due to difficulty with TaskContainer not being recycled togetehr with TaskThumbnailView

Bug: 338360089
Test: TaskThumbnailViewModelTest
Test: manual testing for DesktopTaskView for both enable_refactor_task_thumbnail on and off
Flag: com.android.launcher3.enable_refactor_task_thumbnail
Flag: com.android.window.flags.enable_desktop_windowing_mode
Change-Id: I38a6dfc6bc561689578d1660794f91d30bad4a68
2024-07-05 18:39:56 +01:00
Alina Zaidi
05cc31a613 [Dev option] Move DesktopModesStatus to wm/shell/shared/desktopmode from
wm/shell/shared/

Test: not needed, just refactoring. mp droid builds
Bug: 348193756
Flag: EXEMPT just refactoring
Change-Id: I6dd19f4203a2336f50bc26ac5b292057bb79ce37
2024-07-05 11:12:35 +00:00
Treehugger Robot
a00c81c173 Merge "Change thumbnail/icon to get the image rather than updating it" into main 2024-07-04 17:13:37 +00:00
Schneider Victor-tulias
acddb58539 Add CUJ instrumentation for KQS
Flag: NONE LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Bug: 339585624
Test: manually checked that CUJ calls were reached
Change-Id: Ifd2b92451c5ed2ebc35834c1d2f495275db3d49a
2024-07-04 10:44:26 -04:00
Uwais Ashraf
551927c6d3 Change thumbnail/icon to get the image rather than updating it
Flag: EXEMPT no-op refactor
Bug: 334826842
Test: existing screenshot tests
Test: Manual - checked icon loading
Change-Id: Ie1da708f911ba569d6464f338dc4efac92420268
2024-07-04 12:18:56 +00:00
Treehugger Robot
9ec1bc48d0 Merge "Remove deprecated initOverlay interface used by TaskOverlayFactoryGo" into main 2024-07-04 08:50:28 +00:00
Brian Isganitis
f7ca8d60be Merge changes I6e7c349d,If6c74b3b,Ib276e9dc,Ida0f7cc0 into main
* changes:
  Override DisplayController on main thread.
  Add annotations for manipulating secure settings.
  Don't use UiThreadTest for Taskbar Unit tests.
  Suspend Launcher taskbar while removed for tests.
2024-07-04 02:26:46 +00:00
Treehugger Robot
12e13d89e1 Merge "Initialize SplitSelectStateController for 3P before setting content view" into main 2024-07-04 00:00:32 +00:00
Treehugger Robot
564209829d Merge "Prevent taskbar icon tooltip from showing on hotseat transition." into main 2024-07-03 23:06:44 +00:00
Vinit Nayak
4276ee4897 Initialize SplitSelectStateController for 3P before setting content view
* RecentsView#onAttachedToWindow relies on splitSelectStateController
being initialized, so we now do it before RecentsActivity calls
setContentView()

Bug: 332643607
Test: Couldn't repro before or after :(
Flag: EXEMPT bugfix
Change-Id: Ic26460e08ca74adcf6dcf31abc956ad57f4061c2
2024-07-03 22:18:05 +00:00
Vinit Nayak
afdd0d3b31 Add divider bg placeholder to app pair icon launch
* Extract out both the top level split root leash
as well as the left and right split root leashes
* Set windowCorner radius on the left/right roots

Test: No more flicker near divider when launching app
pair (see comment for video in CL)
Flag: EXEMPT bugfix
Bug: 349387413

Change-Id: I6fce290d1e7766e55c2f11cc8c365f0c29087c0f
2024-07-03 11:27:41 -07:00
Alex Chau
cd894eeae2 Merge "Make sure thumbnailViewDeprecated is only accessed when refactor flag is off" into main 2024-07-03 15:54:09 +00:00
Shamali P
96ebf67b9f Update the title and description provided by intent params.
Bug: 347288851
Flag: EXEMPT flagged in sys ui
Test: Manual (automated covered in b/339716822)
Change-Id: I71f21bc48fd03dbbe2b3804b7fcade5940606917
2024-07-03 15:49:32 +00:00
Olivier St-Onge
25eaff395e Merge "Stash taskbar when a SysUI dialog appears." into main 2024-07-03 15:20:17 +00:00