Commit Graph

9805 Commits

Author SHA1 Message Date
Jagrut Desai
311d519292 Fix TaplTestsNexus#testSearchForApp
This cl is 1/2 part change

We are currently getting StaleObjectException when running this test.
We want to implment a synchoronized event beetween test and launcher,
so we know that search result adapter is done updating and page will
get no more updates of search results.

Test: Presubmit
Bug: 232008758
Flag: not needed
Change-Id: I40cf9b83d231a2487220aabc8f8e8c3ca71f255c
2023-09-13 11:09:05 -07:00
Ivan Tkachenko
068d1ea839 Merge "Bubble bar user education" into main 2023-09-11 17:59:08 +00:00
Brian Isganitis
cbaf0a7f70 Merge "Close overlay onTaskStackChanged when All Apps is visible." into main 2023-09-11 17:46:16 +00:00
Jagrut Desai
2a0d7b5a11 Merge "Add haptic feeback for Transient Taskbar" into main 2023-09-09 02:54:02 +00:00
Andy Wickham
43da2dc409 Merge "Add tests for LPH override for 3 button mode Taskbar." into udc-qpr-dev am: 3289e4fa35 am: 294a40b1be
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24607784

Change-Id: Id8ba2e642aad256612f21e6026adbf5c2e756123
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-08 23:49:12 +00:00
Brian Isganitis
648d917a29 Merge "Add All Apps search icon variant behind flag." into main 2023-09-08 23:39:23 +00:00
Jagrut Desai
54677143b1 Add haptic feeback for Transient Taskbar
Bug: 264851582
Test: Manual
Flag: Not needed
Change-Id: Id5f0e386968291f4c4a897bebf40c59aba33c3d4
2023-09-08 15:39:12 -07:00
Brian Isganitis
8215d8be32 Close overlay onTaskStackChanged when All Apps is visible.
We have too many cases where All Apps can relaunch the current task
behind it to the point where it will not be sustainable to manually
close AFVs in all of these cases.

Test: Manual
Fix: 299169192
Fix: 299169075
Fix: 299169073
Flag: No
Change-Id: If3d9aa756ff5e5d6fbaf5f91d2ccc0c5c11a5c23
2023-09-08 20:51:58 +00:00
Andy Wickham
294a40b1be Merge "Add tests for LPH override for 3 button mode Taskbar." into udc-qpr-dev am: 3289e4fa35
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24607784

Change-Id: I87cd79905c5febcd0391d75b9756522ad3d1ba34
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-08 16:44:53 +00:00
Brian Isganitis
46cabfebdc Register OnAttachStateChangeListener before attaching to container. am: 503f04f86d am: a62d85752e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24681979

Change-Id: I18e1ee9b5c46affdf90f3fbbb9327db4bbe178e2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-07 23:44:35 +00:00
Andy Wickham
3289e4fa35 Merge "Add tests for LPH override for 3 button mode Taskbar." into udc-qpr-dev 2023-09-07 23:43:42 +00:00
Brian Isganitis
a62d85752e Register OnAttachStateChangeListener before attaching to container. am: 503f04f86d
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24681979

Change-Id: Iae9abea705e1f379cb605ed286de6ee4e6df8168
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-07 22:54:25 +00:00
Brian Isganitis
503f04f86d Register OnAttachStateChangeListener before attaching to container.
If we do the reverse, there is a change onAttach will occur before the
callback is registered and invokable (e.g. overlay window already exists
for EDU).

Test: Manual
Fix: 299335210
Flag: None
Change-Id: Ic4befe900c9582e1b01c2bc4699b431f95efa617
2023-09-07 19:15:10 +00:00
Brian Isganitis
0b9c0589b7 Add All Apps search icon variant behind flag.
Bug: 265170176
Test: https://b.corp.google.com/issues/265170176#comment15
Flag: ENABLE_ALL_APPS_SEARCH_IN_TASKBAR
Change-Id: I0f5fa4fbbab687d92435d299656b9c27d93525b4
2023-09-07 18:29:46 +00:00
Vinit Nayak
e6747e4caa Merge "Revert "Revert "Revert "Hold WeakReference to split callback"""" into main 2023-09-07 18:29:40 +00:00
Vinit Nayak
8248585a0c Revert "Revert "Revert "Hold WeakReference to split callback"""
This reverts commit bb9fe16254.

Reason for revert: b/299403672

Change-Id: I8107bc69c033cb70333d5920cfee0700fe1f63a6
2023-09-07 18:15:17 +00:00
Brian Isganitis
c9420c3561 Merge "Close IME on Taskbar drag." into main 2023-09-07 17:41:51 +00:00
Schneider Victor-tulias
f573abadb7 Merge "Add error handling to prevent IllegalArgumentException" into main 2023-09-07 16:03:17 +00:00
Vinit Nayak
6fe9c3e555 Merge "Revert "Revert "Hold WeakReference to split callback""" into main 2023-09-07 04:55:33 +00:00
Brian Isganitis
1219d69625 Close IME on Taskbar drag.
Matches LauncherDragController#startDrag impl.

Test: Manual
Fix: 299167809
Flag: No
Change-Id: If6552b0c9cf7bfcdd01f1802eaf895bde4f357d8
2023-09-06 22:06:54 +00:00
Jagrut Desai
cd667ed4ad Clear TaskbarDividerPopupView callback upon closing
- Breakout CL part 4
- This is a breakout cl from ag/24272821 to make it more readable and atomic.
- This cl consist of clearing callbacks after calling close once, so that we don't run into scenario where user is able to close popup multiple times leading to crash.

Test: Manual, Visual
Bug: 265170176
Flag: ENABLE_TASKBAR_PINNING
Change-Id: Ie4cd95c69a559a17b7c19a64a71ccf6ac20542d7
2023-09-06 17:53:34 +00:00
Ivan Tkachenko
72597e32cb Bubble bar user education
Launcher support for the user education logic described in ag/24587530.

Bug: 275077944
Test: TBD
Flag: WM_BUBBLE_BAR
Change-Id: I2b9a6ecde332de6305ad574c41d8322d8bb5d7ad
2023-09-06 14:19:31 +00:00
Brandon Dayauon
cc9a529293 Merge "Add nullable annotation" into udc-qpr-dev am: 31679166a7 am: b33d906d87
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24544468

Change-Id: I21f2072984d2620a0012180ea8ef0ffc1f78c110
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-05 18:59:17 +00:00
Brandon Dayauon
b33d906d87 Merge "Add nullable annotation" into udc-qpr-dev am: 31679166a7
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24544468

Change-Id: Ifd6ac159f610f6a9a3a0f409778a6084f411949f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-05 18:09:33 +00:00
Brandon Dayauon
31679166a7 Merge "Add nullable annotation" into udc-qpr-dev 2023-09-05 16:50:38 +00:00
Schneider Victor-tulias
0fb4b268e5 Add error handling to prevent IllegalArgumentException
ActivityLaunchAnimator.Controller.fromView requires an instance of LaunchableView, however findViewWithBackground had no checks to return one. updated the check to make the exception less likely.

Flag: not needed
Fixes: 297564681
Test: ran launcher and launched apps
Change-Id: Iddbe55c1ff66b067f8456d058cbc60a2a698c4ae
2023-09-05 13:57:11 +00:00
Saumya Prakash
53b19f1b6a Merge "Ensure Gesture Nav Edu animation scales to fit different screen sizes" into udc-qpr-dev am: 15b0c9ea54 am: a2c965726e
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24623620

Change-Id: Ice6431407e0a6cf6f69eb9440f79c38badbcaa81
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-02 01:44:51 +00:00
Sunny Goyal
175ad05a06 Merge "Fixes broken callbacks in RecentsAnimationCallbacks" into udc-qpr-dev am: a6f089c5fc am: aee84be4b6
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24589979

Change-Id: I7139b62fe6985e407880966c434d621da3af508c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-02 01:43:11 +00:00
Saumya Prakash
a2c965726e Merge "Ensure Gesture Nav Edu animation scales to fit different screen sizes" into udc-qpr-dev am: 15b0c9ea54
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24623620

Change-Id: I76dcb5ab590f458fdebb2b171e3faf58d7d919f7
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-02 00:48:43 +00:00
Sunny Goyal
aee84be4b6 Merge "Fixes broken callbacks in RecentsAnimationCallbacks" into udc-qpr-dev am: a6f089c5fc
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24589979

Change-Id: I790f16e73181bd299e9e229401015784588bd245
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-02 00:48:15 +00:00
Tony Wickham
7bbc5a3c01 Merge "Update TaskView corner radius dynamically" into udc-qpr-dev am: 2677e04510 am: 0eb2b24d68
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24627246

Change-Id: Ib3fb4c43fd651a017746e2ff8cff17dec3eab057
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-02 00:04:10 +00:00
Saumya Prakash
15b0c9ea54 Merge "Ensure Gesture Nav Edu animation scales to fit different screen sizes" into udc-qpr-dev 2023-09-01 23:49:30 +00:00
Sunny Goyal
a6f089c5fc Merge "Fixes broken callbacks in RecentsAnimationCallbacks" into udc-qpr-dev 2023-09-01 23:46:02 +00:00
Tony Wickham
0eb2b24d68 Merge "Update TaskView corner radius dynamically" into udc-qpr-dev am: 2677e04510
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24627246

Change-Id: I59ba22e210e592dff73e0a1ac73b6fba4762e610
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-09-01 23:05:41 +00:00
Ats Jenk
6ea1072a15 Merge "Update scale logic for desktop tasks in recents animation" into main 2023-09-01 22:50:16 +00:00
Tony Wickham
2677e04510 Merge "Update TaskView corner radius dynamically" into udc-qpr-dev 2023-09-01 22:41:18 +00:00
Saumya Prakash
3ca10a1325 Ensure Gesture Nav Edu animation scales to fit different screen sizes
The lottie animation in the gesture nav tutorial wasn't scaling correctly for certain devices
leading to gaps around the animation. This change uses animation's scale transformation to ensure it fits the
dimensions of the device.

Flag: ENABLE_NEW_GESTURE_NAV_TUTORIAL
Fix: 295809541
Test: Went through the tutorial on different types of devices and ensure
the animation takes up the entire screen.

Change-Id: Iadee0d0389a11aa38c9e947b4b40466acd8f4422
2023-08-31 23:08:54 +00:00
Tony Wickham
5d20ad6500 Update TaskView corner radius dynamically
Previously we set the corner radius just once when TaskView is
constructed, but this doesn't work when reusing the TaskView on a
different display that has a different corner radius.

Flag: none
Test: FullScreenDrawParamsTest
Test: kill launcher, open Overview on one display, then switch to
another display with different corner radii and ensure task radii
have updated while quick switching
Fixes: 293224095

Change-Id: I5f0697a4697400ec0e003c116774d74a945ee59e
2023-08-31 22:41:53 +00:00
Brandon Dayauon
75d8994e6f Add nullable annotation
It looks like from the stack trace that there is an NPE during the setApps() call. So adding nullable and null checking
to make sure mApps is not null.

bug: 296920692
test: presubmit
flag: n/a
Change-Id: If402c0b68db159f7a698e8e2e139d9bd5041b1c1
2023-08-31 13:59:13 -07:00
Alex Chau
d9e3b8e254 Merge "Revert "Add detailed exception for snappedIndex == -1 when dismissing tasks"" into main 2023-08-31 16:50:34 +00:00
Fengjiang Li
f096f3ebe3 Merge "Fix memory leak of Launcher activityfrom QuickstepTransitionManager and LauncherBackAnimationController" into main 2023-08-31 16:11:39 +00:00
Charlie Anderson
d48f89be9d Merge "Remove ENABLE_MATERIAL_U_POPUP flag and cleanup dead code" into main 2023-08-31 15:09:25 +00:00
Fengjiang Li
e180de6b20 Fix memory leak of Launcher activityfrom QuickstepTransitionManager and LauncherBackAnimationController
We should also avoid using non-static inner class that extends IOnBackInvokedCallback.Stub and IRemoteAnimationRunner.Stub inside LauncherBackAnimationController, which references the entire LauncherBackAnimationController object.

1. When launcher is created, a Runnable is posted to ShellExecutor to call BackAnimationController#registerAnimation
2. When launcher is later destroyed, another Runnable is posted to same ShellExecturo to call BackAnimationController#unregisterAnimation
3. If the execturo queued the 1st runnable, then we have leaked LauncherBackAnimationController object, including Launcher activity.

This CL fixes the leak by making the Stub static inner classes, and use weak reference hold reference to launcher activity.

Bug: 297806573
Test: Grab a heap dump and this reference no longer exist
Flag: N/A
Change-Id: I78853e900a98399b02682ba2d9179e544a4030d5
2023-08-30 23:43:20 -07:00
Saumya Prakash
a698652981 Merge "Remove extraneous transition from Overview to Home screen" into udc-qpr-dev am: dbd47e9f75 am: e5b09cd7f1
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24587641

Change-Id: I6c3c15584cf07e88748e020356bcf1fed30c9314
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-30 23:27:26 +00:00
Saumya Prakash
e5b09cd7f1 Merge "Remove extraneous transition from Overview to Home screen" into udc-qpr-dev am: dbd47e9f75
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24587641

Change-Id: I350f08b5d09a9f7c17a93529b0a9bfd033e2a04c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-30 23:27:09 +00:00
Saumya Prakash
dbd47e9f75 Merge "Remove extraneous transition from Overview to Home screen" into udc-qpr-dev 2023-08-30 23:06:15 +00:00
Ats Jenk
cb12f2445e Update scale logic for desktop tasks in recents animation
When swiping up to overview, we need to calculate a target position for
the desktop tasks. They need to be scaled down and positioned within the
desktop tile.
After recents animation finishes, the tasks will be replaced by
screenshots. To make the replace less flickery, the position of the
tasks should match the position of the screenshots.

TODO: there is a flicker when the task is replaced with recents entry.
      Task is hidden and then, half a second later, the recents tile is
      shown. Enabling live tiles should help with this.

Bug: 298252273
Test: swipe up to recents from desktop
Change-Id: I0c7fba40dc2511c17d0011d0516456de07cfa004
2023-08-30 14:46:02 -07:00
Andy Wickham
976876ec5b Add tests for LPH override for 3 button mode Taskbar.
Override == Launcher handles via AssistUtils instead of SysUI.

Bug: 297561673
Test: TaskbarNavButtonControllerTest + bug bash session
Change-Id: I079d4b9045d6f7d94d74e91bcabbbc182de6e17d
2023-08-30 14:45:18 -07:00
Saumya Prakash
c4cc4b13b1 Remove extraneous transition from Overview to Home screen
Previously, users used to be able to swipe down near the
bottom of the screen to leave overview. This was causing the taskbar to
animate to home while still in overview (and causing jank). Since this isn't expected behavior for
how to leave overview, this change removes that method.

Flag: N/A
Fix: 284416178
Test: Completed multiple transitions (ex. Overview to home) with 3
button nav and gesture nav. Ensured swiping down from below the recents
task does not go to the home screen while not affecting other
transitions.

Change-Id: I8cdfde71117dd947174d9c3c3a7f834fbeaddcca
2023-08-30 21:24:45 +00:00
Andreas Agvard
c41b4e4744 Merge "Fixes search feature invocation issue" into udc-qpr-dev am: 7d793ecdda am: 0c93438614
Original change: https://googleplex-android-review.googlesource.com/c/platform/packages/apps/Launcher3/+/24586848

Change-Id: Id0b016b3ac7ea7d5d99df9f526496b6843d50a56
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2023-08-30 21:00:08 +00:00