Commit Graph

10539 Commits

Author SHA1 Message Date
Tony Wickham
480448b059 Merge "Temporary workaround for taskbar hiding in Desktop" into main 2024-01-11 23:21:42 +00:00
Riddle Hsu
1438af66f8 Merge "Fix leakage of GestureExclusionListener" into main 2024-01-11 05:54:05 +00:00
Tony Wickham
4e7411c54c Temporary workaround for taskbar hiding in Desktop
Taskbar still hides during the transition, but then reappears
after settling.

Flag: LEGACY ENABLE_HOME_TRANSITION_LISTENER enabled
Bug: 314207404
Test: manual
Change-Id: Ie3d29b3d40e513f39cb34176baa781c9f2853e57
2024-01-10 19:59:25 +00:00
Tracy Zhou
e19c572ac2 Merge "Hook up luma sampling state change from CommandQueue" into main 2024-01-10 19:33:24 +00:00
Helen Cheuk
78745df2b4 Merge "Fix wrong translation for swiping up split task" into main 2024-01-10 13:11:05 +00:00
helencheuk
06ddebb34f Fix wrong translation for swiping up split task
The wrong calculation is caused by using half size mTaskRect in Split task to calculate the translation X to middle
It should use the fullTaskSize instead of half size. This change refactors the code to store the full size so it does not need to re-calculate many times

Bug: 312371505
Test: Manual, swiping up split task diagonally from right side many times, test the case when mSplitBounds is not null in addAppToOverviewAnim
Test: Tested swipe up to overview for split task/single task in Phone, Tablet and Unfolded phone, with the flag on and off
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Change-Id: Id2b008a7d9597271e077a125f3195b27196797d7
2024-01-10 11:40:58 +00:00
Riddle Hsu
96d7f9c2d7 Fix leakage of GestureExclusionListener
So the unregister/register are paired when launcher activity
is relaunched:

Launcher#onDestroy
 > mSplitWithKeyboardShortcutController.onDestroy()
+ > RecentsAnimationDeviceState#destroy
+  > unregisterExclusionListener

Launcher#onCreate
 > setupViews
  > new SplitWithKeyboardShortcutController
   > new RecentsAnimationDeviceState
    > onDisplayInfoChanged
     > registerExclusionListener

Bug: 319133753
Test: Toggle screen resolution many times and check the amount
      of DisplayContent#mSystemGestureExclusionListeners.
Change-Id: I2fb84415db71aaa14e653fea2592d6b9b5adad59
2024-01-10 17:59:28 +08:00
Tracy Zhou
cf5407dfc6 Hook up luma sampling state change from CommandQueue
Currently when swiping up from some apps (maps), the stashed task bar color changes. Instead, sampling should be disabled during the transition (with a signal from the frameworks).

Bug: 230395757
Test: Swipe up from maps. Make sure the bar color doesn't change during transition
 to overview
Change-Id: Ifc30f4067a0e4d134b422d152f5b5caee0a77a33
2024-01-09 21:56:58 -08:00
Fengjiang Li
ad3915e7dd Merge "Adding support for skipping animation cancel on reapply" into main 2024-01-10 02:28:19 +00:00
Sunny Goyal
40e7937af8 Merge "Simplifying pending widget inflation path" into main 2024-01-09 23:11:08 +00:00
Sunny Goyal
98b5e1f077 Adding support for skipping animation cancel on reapply
Bug: 314279319
Test: Verified on device
Flag: None
Change-Id: I0a6e9eef77a1d917c0fce7d4bddd079ceeb10c99
2024-01-09 10:35:43 -08:00
Orhan Uysal
9606989404 Merge "Fix z order of tasks in overview." into main 2024-01-09 17:46:49 +00:00
Schneider Victor-tulias
818b3ba092 Merge "Update KQS task launch animation" into main 2024-01-09 15:04:20 +00:00
Orhan Uysal
80484e6da0 Fix z order of tasks in overview.
The recent tasks list provided to launcher is ordered from most recent
to least recent. As a result, we need to add snapshot views always to
the start of the view list.

Test: Manual
Bug: 269664273
Bug: 317486696
Flag: None
Change-Id: I4efb3b3dbb21171cbbb52783e88e86d1b1778ec3
2024-01-09 14:35:47 +00:00
Johannes Gallmann
dacd86e053 Merge "Fix TaplTestsQuickstep.testPressback failure" into main 2024-01-09 08:13:39 +00:00
Ikram Gabiyev
bb68dfec10 Merge "Send app bounds to Shell via stopSwipePipToHome" into main 2024-01-09 06:34:29 +00:00
Tracy Zhou
bcdde0d1a6 Merge "Use KeyButtonRipple for button nav" into main 2024-01-09 02:42:08 +00:00
Sunny Goyal
fdeb19e02c Simplifying pending widget inflation path
Instead of adding a PendingView in appWidgetHost, attaching a
listener in PendingView for widget-updates.

This moves the view inflation as the last stage of widget
binding. Eventually we can separate the model update and view
inflation to different threads

Bug: 318539160
Test: atest TaplBinderTests
Flag: None
Change-Id: I124edaa9622fa367302b80969036d128a978396e
2024-01-08 15:52:50 -08:00
Schneider Victor-tulias
5bc6a0aa1f Update KQS task launch animation
Updated the KQS app launch animation to match the spec: translate the launching app from the left (right in RTL) and translate the closing app to the right (left in RTL)

Flag: LEGACY ENABLE_KEYBOARD_QUICK_SWITCH ENABLED
Fixes: 313606549
Fixes: 313607264
Test: launched tasks from KQS from home and launched app
Change-Id: I0e903c741e4f930b377607b7eaf42a87177c3eb6
2024-01-08 16:19:17 -05:00
Tracy Zhou
f46729fd23 Use KeyButtonRipple for button nav
- Matched ripple style
- Matched ripple bounds

Bug: 230395757
Test: Ripple looks the same as the one using navigation bar
Change-Id: I58c773b1f767fb8b0f2570bc4603ea953d589560
2024-01-08 11:54:48 -08:00
Tony Wickham
a3daee40f3 Merge "Update kotlin formatting for TaskbarInsetsController" into main 2024-01-08 19:10:24 +00:00
Brandon Dayauon
4f673d2517 Merge "Increase predicted app row by 4dp to be same as SEARCH_RESULT_APP_ROW" into main 2024-01-08 18:00:05 +00:00
Sam Cackett
ad51bc1df2 Merge "Reset AppChip chevron when closed" into main 2024-01-08 14:40:05 +00:00
samcackett
191b13e8d0 Reset AppChip chevron when closed
This CL fixes two issues:
1. It resets the chevron AnimatedVectorDrawable back to the start when
the TaskMenuView has finished closing. This stops it being re-opened in
any previously animated state and starts fresh each time.
2. The original position of the TaskMenuView is put back in its original
position when finished closing. If animations are disabled, the
TaskMenuView is never put back in its original position.

Video after this commit is applied: http://shortn/_gfy0pN6sKX

Fixes: 316998167
Fixes: 316996167
Test: Manual
  Open several apps. Open Overview. Expand a TaskMenuView. Swipe up to
  home. Open Overview again. TaskMenuView chevron should be facing down.
Flag: ACONFIG com.android.launcher3.enable_grid_only_overview TEAMFOOD
Flag: ACONFIG com.android.launcher3.enable_overview_icon_menu TEAMFOOD

Change-Id: I7d9e60b5c0a56cf809e9870573c3b51af5ded8c3
2024-01-08 13:44:51 +00:00
Riddle Hsu
d4d4eaaf31 Merge "Perform TaskView animation when reopening the current task" into main 2024-01-08 13:25:13 +00:00
Johannes Gallmann
48a425df95 Fix TaplTestsQuickstep.testPressback failure
In the predictive back to home case, no WALLPAPER_OPEN_ANIMATION_FINISHED_MESSAGE event was sent to AccessibilityManagerCompat, which caused TaplTestsQuickstep.testPressback to fail.

Bug: 318675970
Flag: ACONFIG com.android.systemui.predictive_back_qs_dialog_anim DEVELOPMENT
Test: TaplTestsQuickstep
Change-Id: I326577575d9e51e0f9ae879bca76e9c254f4ea34
2024-01-08 13:31:51 +01:00
Jagrut Desai
7a9686b49d Merge "Fixing com.android.quickstep.TaplTestsTransientTaskbar#testSwipeToStashAndUnstash" into main 2024-01-06 19:11:01 +00:00
Brandon Dayauon
3dd0f12cad Increase predicted app row by 4dp to be same as SEARCH_RESULT_APP_ROW
Verified that there should be no jumping going on in the top app row between A-Z list and Toast.

bug: 312781931
Test: manual -video:
https://drive.google.com/file/d/11GX-5mVr5BoZY29IyX5FvrIA_yT57MOJ/view?usp=sharing
Flag: None

Change-Id: I5c35c04eb500f52780b0b77c542e0a861346a3fd
2024-01-05 17:09:23 -08:00
Jagrut Desai
4f56608aec Fixing com.android.quickstep.TaplTestsTransientTaskbar#testSwipeToStashAndUnstash
Test: Presubmit
Bug: 317798731
Flag: NONE
Change-Id: I05d430a4d8a306b672e89bb3033dfb41bbb9d000
2024-01-05 17:00:53 -08:00
Tony Wickham
79f5536524 Update kotlin formatting for TaskbarInsetsController
Flag: none
Test: none
Bug: none
Change-Id: I2f83ce8bbbe89ac3fcee6f6b3c1100f387ddf76e
2024-01-06 00:42:08 +00:00
Jagrut Desai
21f3d770a0 Merge "Taskbar Pinning Animation Improvements" into main 2024-01-05 23:21:57 +00:00
Tony Wickham
8424eed91a Merge "Fix onIsStashedChanged() not called in 3 button mode" into main 2024-01-05 22:18:18 +00:00
Liran Binyamin
fdc5c72aa1 Merge "Add a test for stashed bubble bar" into main 2024-01-05 21:19:19 +00:00
Jagrut Desai
a3d3c06967 Taskbar Pinning Animation Improvements
Test: Manual
Bug: 312178646
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning DISABLED

Change-Id: I708127be8301a61994168f780474c75be726815d
2024-01-05 12:12:12 -08:00
Tony Wickham
438e6c90af Fix onIsStashedChanged() not called in 3 button mode
Calling this ensures we update touchableRegion accordingly.

Since this will also start the stashed handle region sampling,
which we don't need for 3 button mode, also adjust logic to
check that the StashedHandleView is actually visible.

Flag: None
Test: Lock screen, run `adb shell cmd uimode night yes`, unlock
Test: Lock screen, rotate, unlock
  In both cases, verify touchableRegion is accurate
Fixes: 315393203
Change-Id: I951af6b97cad0ee0f362dc22f3996cfd9286a21e
2024-01-05 19:19:57 +00:00
Jagrut Desai
ad88561612 Merge "Migrating Tapl Overview test to platform scenario project" into main 2024-01-05 18:53:24 +00:00
Liran Binyamin
40c1b93aee Add a test for stashed bubble bar
This change introduces a new test protocol event for unstashing the bubble bar.

It's not possible to do this via a UI event because the stashed handle is only visible when an app is in the foreground, but in that state none of the elements in TaskbarDragLayer are visible to accessbility.

Flag: LEGACY persist.wm.debug.bubble_bar DISABLED
Bug: 273994695
Test: atest PlatformScenarioTests:android.platform.test.scenario.sysui.bubble.BubbleBarTest
Change-Id: I4581bf95b07691429966ecbd573232047f820b69
2024-01-05 08:49:27 -05:00
Sergey Pinkevich
0f8d28024e Merge "Java crash on RecentsView.isTaskViewVisible method" into main 2024-01-05 11:34:55 +00:00
Charlie Anderson
6c4dde2c4d Merge "Adds a legacy flag to enable Launcher BR metrics." into main 2024-01-05 01:32:11 +00:00
Jagrut Desai
71e8dcca46 Migrating Tapl Overview test to platform scenario project
- Removes tapl overview test form platinum test suite
 - adds individual overview test to platform scenario test.

Test: Presubmit, Manual
Bug: 303256981
Flag: NONE
Change-Id: I7d04dc5dc63ba3a5e63ad03d98760dbd24c974f8
2024-01-04 16:25:17 -08:00
Sunny Goyal
1a8f804195 Merge "Removing ENABLE_CACHED_WIDGET since we now have always listenign widget" into main 2024-01-05 00:02:54 +00:00
Charlie Anderson
a4240c72c0 Adds a legacy flag to enable Launcher BR metrics.
This is necessary because the aconfig flag requires reboot to enable, however backup/restore happens on the first load so the flag will not be ready.

Flag: LEGACY ENABLE_LAUNCHER_BR_METRICS TEAMFOOD
Test: compilation / presubmit
Bug: 305984208
Change-Id: Ida90b1bd485fb037ebf3dde7ad17bf4e462661e6
2024-01-04 17:40:51 -05:00
Johannes Gallmann
852a70f994 Merge "Hide app icon during predictive back to home" into main 2024-01-04 19:39:05 +00:00
Tony Wickham
97e6c9c214 Merge "Fix KI in test and re-enable for postsubmit." into main 2024-01-04 17:50:35 +00:00
Sunny Goyal
4df719a1e6 Removing ENABLE_CACHED_WIDGET since we now have always listenign widget
> Also using PendingWidgetView for deferred widget view

Bug: 270395008
Flag: LEGACY ENABLE_CACHED_WIDGET enabled
Test: Exising widgets tests pass.
      Verified UI by forcefully rendering deferred widget

Change-Id: Id34f89d778f9f993c1b7ad13f66e57fda9843417
2024-01-04 09:26:10 -08:00
Jordan Silva
873d49937c Merge "Add ESCAPE key to dismiss Overview" into main 2024-01-04 14:12:28 +00:00
Riddle Hsu
51ceb99715 Perform TaskView animation when reopening the current task
When using gesture navigation to switch task, if the next started
task moves the previous task in live tile to top, the appeared
task will be the previous animating task rather than the task
started by recents.

Previously, none of condition handles the case, which causes a
splash screen task view to stay on screen and the transition keeps
in running state.

By running the side task launch animation, it can indicate that
there is an additional task switch visually, and the recents
transition can be finished when the animation is finished.

Bug: 317160303
Test: Activity A's onResume always starts activity B (declares
      different taskAffinity) with FLAG_ACTIVITY_NEW_TASK.
      Use gesture to swipe from B to A. B should be visible
      instead of staying at recents with a splash screen view.

Change-Id: Id1a441561ac9958f71efe2440e4fb467bedc6947
2024-01-04 21:28:05 +08:00
Jordan Silva
9878a7206e Add ESCAPE key to dismiss Overview
This CL adds the functionality of escape key to Overview. It dismisses Overview when the esc key is pressed.
When Overview is showing a Modal Task, it will return to Overview state instead of the Normal state.

Fix: 315283507
Flag: N/A
Test: TaplTestsQuickstep
Change-Id: I02e02f623d9a4aad1c2d6188fdea4e3fc4f96d64
2024-01-04 09:08:44 -03:00
Vinit Nayak
e4b5ab6523 Merge "Null out launcher reference to prevent leak" into main 2024-01-04 00:59:28 +00:00
Tony Wickham
c5d4e4dcf5 Fix KI in test and re-enable for postsubmit.
- The taskbar stashing logic with hardware keyboards was different
  between tests and user experience; aligned the test to be the
  same.
- There is still a previous test failure that only occurred in
  post submit, so also add ScreenRecord to diagnose it
- Once that is resolved, can promote the test to PRESUBMIT.

Test: testQuickSwitchToPreviousAppForTablet
Flag: NA
Fixes: 318544733
Bug: 314873201
Change-Id: Ia813eb0294d759c40d90cec7a8e9a7e0aea2d917
2024-01-03 23:27:18 +00:00