Commit Graph

18918 Commits

Author SHA1 Message Date
Alex Chau
2daa3eba99 Merge "Refactor TaskView.getTaskIds and its attribute container to support any number of tasks" into main 2024-05-01 13:49:02 +00:00
Gustav Sennton
19f8002e30 Merge "Pass OverviewComponentObserver as a parameter." into main 2024-05-01 07:06:40 +00:00
Tracy Zhou
d0d94922fe Merge "Do not hide nav bar on the homescreen from setup" into main 2024-05-01 00:08:35 +00:00
Ats Jenk
af0ba3e8cf Merge "Implement API to animate bubble bar position" into main 2024-04-30 22:20:05 +00:00
Tracy Zhou
ee67a48d60 Do not hide nav bar on the homescreen from setup
FLAG_STASHED_SMALL_SCREEN is not updated after setup UI finishes.

Fixes: 337738795
Test: Finish setup, swipe home in folded, and observe home handle is visible.
Change-Id: I297e3b44f49f94ab5a1b9fe5ff16ff64c6cf2c0a
2024-04-30 15:01:38 -07:00
Ats Jenk
d7fe32ab8e Implement API to animate bubble bar position
Create a new API to animate bubble bar position.
Animating it will not update its laid out location.
To update bubble bar laid out location, BubbleBarUpdate can be used.
Applying a location change from BubbleBarUpdate no longer animates the
change.

Bug: 330585402
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: long press bubble bar and drag it to left and right
Change-Id: I2572da4c063fc8e07cf07c4303778d343baa4ec4
2024-04-30 13:12:56 -07:00
Treehugger Robot
7f26505f04 Merge "Re-fetch DesktopVisibilityController when needed instead of just once" into main 2024-04-30 17:50:17 +00:00
Gustav Sennton
f74d8b7264 Re-fetch DesktopVisibilityController when needed instead of just once
When creating DesktopTaskbarRunningAppsController the Quickstep Launcher
might not be available, meaning we pass a null
DesktopVisibilityController to DesktopTaskbarRunningAppsController.
With this CL we refetch DesktopVisibilityController whenever needed.

Bug: 338035946
Test: manual, and DesktopTaskbarRunningAppsControllerTest
Flag: ACONFIG com.android.window.flags.Flags.enableDesktopWindowingTaskbarRunningApps DEVELOPMENT
Change-Id: I8b806e2d0addbf8fb5ab6a3d419a4691c445f223
2024-04-30 16:07:13 +00:00
Treehugger Robot
5a8e719b4c Merge "Remove references to FEATURE_PC and related Desktop classes in Launcher" into main 2024-04-30 15:33:30 +00:00
Liran Binyamin
85c50adb91 Merge "Animate the bubble bar to show new bubble" into main 2024-04-30 14:01:09 +00:00
Gustav Sennton
0eaf9ebdaa Remove references to FEATURE_PC and related Desktop classes in Launcher
Also clean up TaskbarRecentAppsController APIs

Flag: NA
Test: DesktopTaskbarRunningAppsControllerTest
Bug: 330551930
Change-Id: Ibd9c3d6aa1d5423b51a48ed0a972196752d5199a
2024-04-30 13:15:28 +00:00
Orhan Uysal
6d54305170 Pass OverviewComponentObserver as a parameter.
Instead of instantiating a new OVerviewComponentObserver, instantiate
one in QuickstepLauncher and pass it down to relevant classes.

Test: Manual
Bug: 336155199
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Change-Id: Ifcc40c63f0649544a92e7f6d4a00d9edcd9f7fe1
2024-04-30 09:29:38 +00:00
Treehugger Robot
43f65905ab Merge "Replace Contextual Rotation Button with Floating Action Button" into main 2024-04-30 05:34:35 +00:00
Ats Jenk
45a4f6426f Merge "Update bubble bar pin controller after parent class refactor" into main 2024-04-30 01:36:14 +00:00
Sukesh Ram
1187fd817e Replace Contextual Rotation Button with Floating Action Button
When foldable is in 3 button, the rotation button is covered by the device’s camera cutout upon rotation.

This CL replaces Contextual Rotation Button with Floating Action Button for taskbar and navbar.

Flag: NONE
Test: Manually tested on Felix & panther.
Bug: 324070001
Change-Id: I8bd9acdeec8ade4c8183c42056bf67b1c825906c
2024-04-29 22:44:00 +00:00
Ats Jenk
79a5acf475 Update bubble bar pin controller after parent class refactor
Some of the common logic related to exclusion zone calculation moved to
parent class. Update the bubble bar controller based on the refactor.

Bug: 330585402
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Test: run shell unit tests, manual test
Change-Id: I5910f76f26aaf6d15a5f6f7c1399b36b80296aeb
2024-04-29 15:16:14 -07:00
Vadim Tryshev
edfa8480a9 Merge "Saving test artifacts in TAPL when the failure is diagnosed" into main 2024-04-29 20:49:15 +00:00
Federico Baron
f22abdb2ec Merge "Revert "Add screenrecord to test with "Only System UI views are visible" message"" into main 2024-04-29 19:50:14 +00:00
Bill Yi
18a4a3407d Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-04-29 18:54:39 +00:00
Vadim Tryshev
7a4d696bbb Saving test artifacts in TAPL when the failure is diagnosed
Not waiting for FailureWatcher to catch the exception and save
artifacts. This will help to save test artifacts before potential
deinitialization in the test which may change the screen contents.

Bug: 187761685
Test: presubmit
Flag: N/A
Change-Id: I7aa95028acfae3fe0895fc5df4ea6f6912fcda52
2024-04-29 11:53:08 -07:00
Alex Chau
15e2c7734b Refactor TaskView.getTaskIds and its attribute container to support any number of tasks
- getTaskIds and getTaskIdAttributeContainers will now return an array with any sizes:
  - Not bound -> empty array
  - Single task -> 1 element array
  - Split task -> 2 elements array
  - Desktop task -> N elements array
- Updates TaskView.containsTaskId/containsMultipleTasks accordingly
- Removed unnecessary overrides in GroupedTaskView and DesktopTaskView
- Updates RecentsView.hasAllValidTaskIds accordingly
- Reviewed all direct and indirect usage of getTaskIds, to make sure caller don't access the array without length checking; migrate usage to stream if applicable
- Simplfied RecentsView.shouldAddStubTaskView to use getTaskViewByTaskIds to find TaksView with exact match of taskIds
- Simplfied RecentsView.setContentAlpha to match TaskView ref instead of doing taskId matching

Bug: 249371338
Test: With single, split, desktop task in Overview, try different CUJs like launch, menu, dismiss, scroll, swipe up etc.
Flag: NONE
Change-Id: I39a5a36c85ce8b366fe25132a349b08244fb1217
2024-04-29 19:27:11 +01:00
Federico Baron
d77a57178e Revert "Add screenrecord to test with "Only System UI views are visible" message"
This reverts commit 3f58b471af.

Reason for revert: issue resolved

Change-Id: Ifa8806b6460f4243c9e38e2e6c63ec22dcc7d8f6
2024-04-29 16:47:38 +00:00
Gustav Sennton
56f9df0620 Merge "[Desktop Mode] Show indicators under Taskbar app icons for running apps" into main 2024-04-29 08:28:28 +00:00
Bill Yi
bcf9cd332c Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ic11465c775fc2f56129fc14c1737e4d496357ba1
2024-04-28 18:38:37 -07:00
Treehugger Robot
1b21277b1d Merge "Add TAPL tests for PredictionRow." into main 2024-04-27 01:13:02 +00:00
Liran Binyamin
29a3e5d676 Animate the bubble bar to show new bubble
This change updates that animation that plays when a new bubble notification is received. We now animate the entire bubble bar rather than the individual bubble.

Demo: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/dwbsZJZlqLwJ2IG7RfJZ7c

Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Bug: 280605846
Test: atest BubbleBarViewAnimatorTest
Change-Id: I2dc58ad61b880d76c9eefa462c3aee4e8bbb3584
2024-04-26 20:50:43 -04:00
Bill Yi
db8d2dc357 Merge "Import translations. DO NOT MERGE ANYWHERE" into main 2024-04-26 23:46:21 +00:00
Anushree Ganjam
5a2b0ff434 Add TAPL tests for PredictionRow.
This will help us catch and debug following issues
* Prediction row view is missing
* Prediction row view doesn't contain enough apps

Bug: 332171918
Test: Manual
Flag: NA

Change-Id: I11035997afb26799a2c3b69d5139b4f3c28fc405
2024-04-26 16:27:41 -07:00
Evan Rosky
1754a6a2b2 Merge "Phase-out shell-transit flag" into main 2024-04-26 22:24:35 +00:00
Brian Isganitis
4fcf4016a0 Merge "Make IME force stash the Taskbar." into main 2024-04-26 21:37:23 +00:00
Saumya Prakash
473de42d70 Merge "Change colors shown in Gesture Nav Tutorial for light mode" into main 2024-04-26 20:32:44 +00:00
Gustav Sennton
52a8b7e24b [Desktop Mode] Show indicators under Taskbar app icons for running apps
In Desktop Mode we show running Desktop apps in the Taskbar. With this
change we also show an indicator under the app icon for each such
running app.

Bug: 332504528
Test: manual
Test: DesktopTaskbarRunningAppsControllerTest
Flag: ACONFIG com.android.window.flags.Flags.enableDesktopWindowingTaskbarRunningApps DEVELOPMENT
Change-Id: If0906dab8ad0bd8a78d93a4e99db47550e763bed
2024-04-26 15:29:00 +00:00
Jordan Silva
4e741082dc Merge "Make TaskMenuViewWithArrow width wrap content with a minimum width" into main 2024-04-26 15:14:46 +00:00
Sam Cackett
dcfe4ef27d Merge "Make DesktopTaskView's icon handling more similar to standard TaskView" into main 2024-04-26 14:53:40 +00:00
Mykola Podolian
6e43b862ce Merge "Fixed issue with shadow for overflow icon" into main 2024-04-26 12:14:39 +00:00
Alex Chau
02ec92b229 Make DesktopTaskView's icon handling more similar to standard TaskView
- Add back touch handling on icon to make task menu work again
- Add back a couple of UI state handling for icon
- Fixed pivot of TaskView to use overviewTaskThumbnailTopMarginPx for calculations
- No longer require `taskView.getTask().icon` to populate TaskMenuView as it's no longer used in the menu; for TaskMenuViewWithArrow, check iconView.drawable instead which will get copied into DragLayer
- Added menu item handling for DesktopTaskView, and aligned GroupedTaksView handling to same mechanism
- Refactored Screenshot and Modal shortcut availability check into TaskShortFactory for consistency with other shortcuts

Bug: 249371338
Test: manual
Flag: ACONFIG com.android.window.flags.enable_desktop_windowing_mode DEVELOPMENT
Change-Id: I22ee6a5ca3c16a1bd510b0910211823e8c0be71b
2024-04-26 12:32:26 +01:00
Anushree Ganjam
1c7ca89191 Merge "Add Uninstall App test for private space apps." into main 2024-04-26 02:54:33 +00:00
Anushree Ganjam
7690f8744e Add Uninstall App test for private space apps.
Doc: go/private-space-tapl

Bug: 322882655
Test: Manual, TAPL
Flag: NA

Change-Id: I96598ad2d78e68ea0ac3bd7872243c231810023b
2024-04-25 16:28:19 -07:00
Saumya Prakash
58aacfad2b Change colors shown in Gesture Nav Tutorial for light mode
We use a second set of colors to ensure that the text is more visible in light mode for the gesture navigation tutorial.

Fix: 318471359
Test: Run the gesture navigation tutorial in light mode and dark mode
Flag: LEGACY ENABLE_NEW_GESTURE_NAV_TUTORIAL ENABLED
Change-Id: Ib83fdcce1d2bd057ca4bf3258cc81fda704bf149
2024-04-25 23:00:29 +00:00
Liran Binyamin
9af43dfdf8 Merge "Don't animate new bubble when already expanded" into main 2024-04-25 22:56:57 +00:00
Liran Binyamin
b8cf10a409 Merge "Handle taps on the animating bubble" into main 2024-04-25 22:56:32 +00:00
Bill Yi
aef6b6e097 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Ic518fc1f87cc443384d927ac56bc4fa8cba70c81
2024-04-25 15:55:08 -07:00
Brandon Dayauon
46776af42d Merge "Make all apps text focusable by accessibility." into main 2024-04-25 22:34:34 +00:00
Brian Isganitis
b3a3ffa8bb Merge "Remove nav button controller dependency on TIS." into main 2024-04-25 20:51:49 +00:00
Shan Huang
da82c82a2b Merge "Generate progress events from app process for app animations." into main 2024-04-25 19:48:53 +00:00
mpodolian
0786deaedc Fixed issue with shadow for overflow icon
Made icons elevation animates to flat state while bubble bar is being
expanded and animate to full elevation while bubble bar is being
collapsed.

Test: Visual
Fixes: 295027436
Flag: ACONFIG com.android.wm.shell.enable_bubble_bar DEVELOPMENT
Change-Id: I8286cd79904367654e319d6a84a307bd64c28d93
2024-04-25 20:16:55 +01:00
Daniel Akinola
e91b4b52ee Merge "Revert "Force calculator to launch in fullscreen for taskbar tests"" into main 2024-04-25 17:56:47 +00:00
Daniel Akinola
2a19774bbe Merge "Revert "Force calculator to launch in fullscreen for quickswitch tests"" into main 2024-04-25 17:56:47 +00:00
Mykola Podolian
cbc77c9818 Merge "Removed arrow animation on selected bubble closing." into main 2024-04-25 17:31:34 +00:00
Evan Rosky
fa1b1332b6 Phase-out shell-transit flag
Shell-transit has been in production for a whole release
now, so disable the flag.

Bug: 294268547
Test: N/A - unused
Flag: NA
Change-Id: Idbc8ffc007b4d0aa01ecdfe47c846c05a937de70
2024-04-25 10:31:24 -07:00