Commit Graph

1410 Commits

Author SHA1 Message Date
Andy Wickham
90c16ace8a Reduces padding of the Overview shelf in no button mode.
Before: https://screenshot.googleplex.com/iw6baTCfoy2.png
After: https://screenshot.googleplex.com/8CcsQvLhYDo.png
Desired: https://b.corp.google.com/action/issues/139551306/attachments/26925873?download=false

Test: Examined before and after padding and verified 3-button is unaffected.
Fixes: 139551306

Change-Id: Ia416399cf25e7c6c2fb8aa84ad20e7ad74dcd31b
(cherry picked from commit ddc9622e92)
2019-09-03 22:05:20 +00:00
Becky Qiu
f0a014d7ff Move swipe actions on container logging to west world.
Test: manual
Bug: 137777105

Log result for swiping in and out of -1 screen.
  data {
    elapsed_timestamp_nanos: 597609736235111
    atom {
      launcher_event {
        action: SWIPE_LEFT
        src_state: HOME
        dst_state: HOME
        is_swipe_up_enabled: true
      }
    }
  }

  data {
    elapsed_timestamp_nanos: 597610569783111
    atom {
      launcher_event {
        action: SWIPE_RIGHT
        src_state: HOME
        dst_state: HOME
        is_swipe_up_enabled: true
      }
    }
  }


Change-Id: Ic84d3c32d1c9f780f13ec5cd6320e9f1d610f018
2019-08-22 16:27:49 -07:00
Hyunyoung Song
96eba3aea6 Merge "Make TogglableFlag backed by DeviceConfig for e2e testing" into ub-launcher3-qt-qpr1-dev 2019-08-15 22:25:33 +00:00
Hyunyoung Song
d4204437de Make TogglableFlag backed by DeviceConfig for e2e testing
Bug: 138964490

TL;DR;; need this to be part of QQ1 or QD1 to verify if DeviceConfig
can be supported for launcher toggleableFlags.

Not handled in this CL:
- When flag is locally modified, that will override the flag value
How that scenario is handled should be discussed separately and is not
within scope of this CL.

Change-Id: I2e6694a40bee9202ed0b0d559e3b5607634071bf
2019-08-15 14:02:28 -07:00
Sunny Goyal
934ebd087b Adding support for storing keywords in iconCache
Change-Id: I1183e63a6556ebfb3eee5df23d149e09728193a9
Merged-In: I1183e63a6556ebfb3eee5df23d149e09728193a9
(cherry picked from commit e529a86fbd)
2019-08-14 22:12:49 +00:00
Becky Qiu
90ea00b399 Log the event for swiping up to dismiss a task in Overview.
Test: manual
Bug: 137777105

Demo logging for dismissing a task:
  data {
    elapsed_timestamp_nanos: 70772067228810
    atom {
      launcher_event {
        action: DISMISS_TASK
        src_state: OVERVIEW
        dst_state: BACKGROUND
        is_swipe_up_enabled: true
      }
    }
  }

Change-Id: I5569b80e2e1f35661bc5e9e343c6c298791a1ec1
2019-08-09 10:57:05 -07:00
Pinyao Ting
e4061fc931 show dot in deep shortcuts when notification contains exactly identical
set of person

Bug: 132336512
Change-Id: I975524e28168c10a186cdc24b188c161faf433cf
Merged-In: I975524e28168c10a186cdc24b188c161faf433cf
2019-08-05 23:31:35 -07:00
Becky Qiu
84fa94e2fc Fill the log container as hotseat or workspace based on position.
Test: manual
Bug: 137953006

Swipe from workspace:
07-30 15:15:44.031  9779  9779 D UserEvent: action:FLING direction=UP direction=UP
07-30 15:15:44.031  9779  9779 D UserEvent:  Source child:WORKSPACE id=0 span(951,1313)	parent:WORKSPACE id=0
07-30 15:15:44.031  9779  9779 D UserEvent:  Destination child:ALLAPPS
07-30 15:15:44.031  9779  9779 D UserEvent:  Elapsed container 826 ms, session 9361 ms, action 0 ms

Swipe from hotseat:
07-30 15:15:46.010  9779  9779 D UserEvent: action:FLING direction=UP direction=UP
07-30 15:15:46.010  9779  9779 D UserEvent:  Source child:HOTSEAT id=0 span(786,1908)	parent:WORKSPACE id=0
07-30 15:15:46.010  9779  9779 D UserEvent:  Destination child:ALLAPPS
07-30 15:15:46.010  9779  9779 D UserEvent:  Elapsed container 1139 ms, session 11339 ms, action 0 ms

Change-Id: I959528889fda778efc569bb59e7f44d3bd5b81bc
2019-08-01 22:24:44 +00:00
Jon Miranda
f20a7d252c Merge "Fix bug where rounded corners were being set despite being disabled." into ub-launcher3-qt-dev
am: 9da9a2bd21

Change-Id: Icae4fd3fef3ad221d45e8d9ecdcc018813d560f3
2019-08-01 15:05:00 -07:00
Tony Wickham
35a4e0eec9 Tie prediction text to all apps interpolator
Now floating headers get 2 interpolators: one for the header content
itselt, and one for the all apps content that follows. That way, they
can choose to intperolate part of their content as if it were part of
all apps instead of the header. Currently, we do this to animate
predicted icons quickly, followed by the all apps icons, predictions
text, all apps scrollbar, and all apps divider as you continue swiping.

Bug: 132455160
Change-Id: Ib3e373c291e174e1306a53854d0ad4dc29eb4b76
2019-07-31 14:45:18 -07:00
Tony Wickham
c088051c29 Add OverviewScrim to show below overview but above workspace
- Refactor some basic scrim logic to Scrim class and have
  WorkspaceAndHotseatScrim and OverviewScrim extend it
- Draw OverviewScrim under recents unless predictions are disabled, in
  which case draw it under hotseat (since that is in recents)
- Remove sysui scrim (behind status bar and nav bar) when overview is
  peeking

Bug: 132455160
Change-Id: Ia5d6f54582a4c5a70e3b2d4a98281567edd68519
2019-07-31 14:44:28 -07:00
TreeHugger Robot
2cccb134a4 Merge "Add several missing swipe logging Enable swipe down to open noti shade from landscape" into ub-launcher3-qt-r1-dev 2019-07-25 21:55:16 +00:00
James O'Leary
93dceb8a48 Merge "Fix QSB becoming invisible" into ub-launcher3-qt-r1-dev 2019-07-25 20:41:34 +00:00
Hyunyoung Song
e299a45944 Add several missing swipe logging
Enable swipe down to open noti shade from landscape

Bug: 137137090
Bug: 137954767
Bug: 134181439

Change-Id: I47b4d17c9ae0586565fce101eb478e33ed8f7e3d
2019-07-25 13:18:48 -07:00
James O'Leary
74ece6b021 Fix QSB becoming invisible
This could not be reproduced until I removed a line that wouldn't call
onAssistantVisiblityChanged if the argument was the same value as the
argument as the previous call.

After that, the bug became readily reproducible. I traced through
Launcher till I found that FallbackActivityControllerHelper
.onAssistantVisibilityChanged was being called while the screen was
locked, proving that onAssistantVisiblityChanged was _not_ reaching
launcher.

Test: Verify bug no longer reproduces.
Bug: 134981174
Bug: 135247753
Bug: 135572849
Bug: 135733393
Bug: 136386749
Bug: 136776987
Bug: 137534772
Bug: 137764419

Change-Id: Ib5e8df3b5030a77c5df351a1fcd993db6bd602fc
2019-07-25 10:22:02 -04:00
Tony Wickham
cfbdb91a7f Merge "Distinguish mDragHandleProgress from mMidProgress" into ub-launcher3-qt-r1-dev 2019-07-24 19:39:48 +00:00
Sunny Goyal
4e6c45bcd3 Using the first frame delay based on the display refresh rate instead of
hardcoding it to 16ms

> Creating a utility class for caching display property changes

Bug: 128940249
Change-Id: I6f9a214548de65bd1c8530508d665ee88312da4a
2019-07-24 10:12:37 -07:00
Tony Wickham
fbd77c48cc Distinguish mDragHandleProgress from mMidProgress
mMidProgress is intended to be the point at which we reach Overview when
swiping up and thus start scrimming it as All Apps shows above it. For
that reason, mMidProgress needs to match OverviewState's progress. In
contrast, the drag handle (accessibility arrow) can move up sooner to
avoid overlapping with the QSB; for this, we added mDragHandleProgress.

Bug: 136800511
Change-Id: I2825ff798707530420855257350e492b4b9b77dc
2019-07-23 16:58:45 -07:00
Jon Miranda
9566a04400 Fix bug where rounded corners were being set despite being disabled.
Bug: 138117089
Change-Id: Icb852e2e07d80c45ad3406ef432b89720887fccf
2019-07-23 22:24:35 +00:00
Tony Wickham
b6841ac630 Revert the changes that prevented touch on RecentsView during animation
The original bug that was solving seems to be fixed by other changes,
and this allows users to scroll, dismiss, etc on recent tasks before
fully reaching overview from an app.

Bug: 137487381
Change-Id: I28a708811bba3ce739ce261f19eb29558d8f0e7d
2019-07-22 12:39:59 -07:00
Tony Wickham
6670435c14 Merge "Allow TouchControllers to override shouldDisableGestures" into ub-launcher3-qt-r1-dev 2019-07-18 22:27:54 +00:00
Tony Wickham
f33b6d4378 Allow TouchControllers to override shouldDisableGestures
Currently only StatusBarTouchController overrides this to always return
false, so that you can swipe down for notifications during transition to
home screen from an app (in gesture nav).

Bug: 137161198
Change-Id: I803c37937d5294810cbe0c1bbffcd5dddcc5ca3b
2019-07-18 15:10:21 -07:00
TreeHugger Robot
aaf6c7ce56 Merge "Using correct gesture margins in overview" into ub-launcher3-qt-r1-dev 2019-07-17 23:02:50 +00:00
vadimt
2f7d1fa4a8 Using correct gesture margins in overview
Change-Id: I0108858279559e10633825f7de22211515f0e9b7
2019-07-17 15:18:21 -07:00
Sunny Goyal
e88d8acd85 Adding spring animation when swiping up to home in 3P Launcher
Bug: 137197916
Change-Id: Ic9808a30e8cd4e0b2a221c4b03bc29489038e092
2019-07-17 11:39:25 -07:00
Vinit Nayak
10d278f3d5 Merge "Reload task list when task is removed" into ub-launcher3-qt-r1-dev 2019-07-17 00:49:52 +00:00
vadimt
6a75e52f85 Getting starting point of swipe from overview to all apps via protocol
Change-Id: Idf04579b67011dac45b081a81367cde2d1274117
2019-07-16 16:46:53 -07:00
Vinit Nayak
2c7917d100 Reload task list when task is removed
Instead of individually removing tasks,
ask for all tasks to get accurate list.
This method is invoked whenever user presses
back on a root activity, which causes the task to
be killed from perspective of the activity.

Test: Visually inspected, recent task no longer
disappears.
Open any app, hit back, and then go to overview quickly.
App should remain in recents list.

Fixes: 135687618
Change-Id: I1c135673ae987016db5df0b83f5ea8e345d3c7c1
(cherry picked from commit 8651219f7e)
2019-07-16 23:24:36 +00:00
Sunny Goyal
365f29e577 Adding support for swipe operation when on home screen
Bug: 137197916
Change-Id: Ic85bf9767d4a9a77dafc1c60c02555f3d2a5d8a2
2019-07-16 10:51:13 -07:00
vadimt
853852351f Correctly restarting Launcher from OOP tests
Waiting for touch interaction service; waiting for package-restart
events.

Bug: 136215685
Change-Id: I0c31c09fe3a58b898168dfdb4e4d23757b94a47c
2019-07-11 14:17:06 -07:00
Sunny Goyal
f11dd8e107 Using a higher priority executor than BackgroundExecutor for various recents tasks
BackgroundExecutor is also using thread pool executor where the order is perserved

Change-Id: Ieef8825599f35fe22da3e9adb1270c5525449d62
2019-07-11 09:38:54 -07:00
Winson Chung
98de773474 Revert "Trigger heap dump when heap exceeds a limit"
This reverts commit e069291ecd.

Reason for revert: Blocked on FW change

Change-Id: Iabf6dee687e499544be5bf895563e57157b0f9e1
2019-07-08 20:32:35 +00:00
Riddle Hsu
70697e48a8 Preload overview activity in background
To reduce the jank when swiping-up the overview which is not
ready yet, we restart the overview activity if the process
was died and update its configuration if there is change.

Bug: 127350205
Test: manual - Enable 2-button or gesture navigation.
      Swipe-up overview after:
      Case 1: Other app is in foreground and kill the process
              of launcher.
      Case 2: Change configuration, e.g. font size, language.

Change-Id: Ia6e365cc0faf3765781484d040bdddd4e10a2650
2019-07-01 13:29:34 +08:00
Winson Chung
f5e81122a0 Revert "Revert "Enable FLAG_SLIPPERY window flag when swipe down on workspace""
This reverts commit c4c8b3c695.

Reason for revert: Re-enabling for R1

Change-Id: Id6706c548dcc9debbfaf2069164636bc22aa9b5e
2019-06-29 00:28:55 +00:00
TreeHugger Robot
66b1cc9675 Merge "Revert "Enable FLAG_SLIPPERY window flag when swipe down on workspace"" into ub-launcher3-qt-dev 2019-06-28 23:28:44 +00:00
Winson Chung
c4c8b3c695 Revert "Enable FLAG_SLIPPERY window flag when swipe down on workspace"
This reverts commit 35062f8ed3.

Reason for revert: Moving to R1

Change-Id: Ifd19d78015a66c9fbe9a67845232d13e011943d3
2019-06-28 23:17:18 +00:00
TreeHugger Robot
ed9127a732 Merge "Resetting UI state when the last has launched" into ub-launcher3-qt-dev 2019-06-28 21:59:23 +00:00
Sunny Goyal
4f2d926d42 Resetting UI state when the last has launched
Bug: 135038270
Change-Id: Ie0af9c7d47f69b32caedd72f98ed1706bdbef5fa
2019-06-28 14:50:24 -07:00
Sunny Goyal
1dae67b49d Fixing accessibility arrow
> Hiding arrow in background state and during quick switch
> Preventing arrow overlapping with search box in overview state

Bug: 135885458
Change-Id: Iadefba044717351d69480cde7d784cd04289d086
2019-06-27 23:18:46 -07:00
Winson Chung
937688bff4 Merge "Enable FLAG_SLIPPERY window flag when swipe down on workspace" into ub-launcher3-qt-dev 2019-06-26 21:48:56 +00:00
Hyunyoung Song
35062f8ed3 Enable FLAG_SLIPPERY window flag when swipe down on workspace
Bug: 131356741
Test: manual

Change-Id: Ibe0e3a03e7406d5d882a1c63265d6e4e0253983e
2019-06-26 21:48:29 +00:00
Winson Chung
0b70cd4ca4 Finish recents animation when starting a new activity
- Defer starting the activity when an activity is paused, and finish
  the current animation to trigger launcher to be resumed

Bug: 132811175
Test: Swipe up and launch a new app
Change-Id: I78b76800052512eb93f69ccf0523f4d752a82ece
2019-06-26 14:01:56 -07:00
Winson Chung
fad3823420 Merge "Clean up some more refs to thumbnail data" into ub-launcher3-qt-dev 2019-06-26 18:25:58 +00:00
Winson Chung
df9fc63e8c Clean up some more refs to thumbnail data
- Always return a copy of the task list to ensure that the model doesn't
  hold refs to the thumbnail data if it was loaded into the same task
- Always clear the task thumbnail data ref once the visibility of the
  task view changes to be invisible

Bug: 132309376
Test: Enter overview scroll to the end of the list, relaunch app and take
      heap dump

Change-Id: I4437fd30172a5fe2a78c111f780163a1e6bbbb54
2019-06-25 14:44:05 -07:00
Sunny Goyal
700dc99d9b Enabling simple gesture navigation for 3P launcher
In case of 3P launcher, swipe-up will go to Launcher and there will be
no way to reach overview.

Bug: 135769778
Change-Id: Ib2c6bb1b13e6055d30b7360ec077b0a2fece66ff
2019-06-25 13:25:30 -07:00
Winson Chung
73769f0a88 Fixing rounding error when computing bottom clip
- In TaskThumbnailView.updateThumbnailMatrix() we compare the rounded
  scaled bitmap height with the height of the task/thumbnail view.
  Since the position is also non-integer, the rounding of the sum
  is not equivalent to the rounding of the individual components, which
  causes the check to fail.

Bug: 135150767
Test: Quickswitch on sargo
Change-Id: I849b4732569e5b8699f00f5ff210f41fb505f1e7
2019-06-20 20:06:24 +00:00
Sunny Goyal
676a795ebd Merge "Some improvements to home to overview transition for 0 button mode" into ub-launcher3-qt-dev 2019-06-19 22:20:05 +00:00
Tony Wickham
59c6901823 Some improvements to home to overview transition for 0 button mode
- Peek in overview further, and with more overshoot
- Fade out and scale down workspace faster while swiping up
- Scale and translate workspace slower when letting go to enter
  overview (so it doesn't zoom out at warp speed)
- Fade in all apps shelf sooner

Bug: 132455160
Change-Id: Ieafad0ccf9bb587889bc35d536627661db10e358
2019-06-19 14:48:57 -07:00
Winson Chung
e069291ecd Trigger heap dump when heap exceeds a limit
Bug: 135150619
Change-Id: I2b207bed1f66407f573abeae879aae34e98741bd
2019-06-19 11:58:30 -07:00
Rajeev Kumar
873759a316 Merge "Add QuickstepProcessInitializer back to common src" into ub-launcher3-qt-dev 2019-06-18 12:09:55 +00:00