Commit Graph

37 Commits

Author SHA1 Message Date
Alex Chau
0686931b68 Use DeviceProfile.isTwoPanels for two panels expectation in tests
Fix: 193810767
Test: TaplTestsLauncher3.testWorkspace
Change-Id: Ifec5506415b79f3effa84fe0163eb1bb2bc7cc8d
2021-07-16 15:14:34 +00:00
Vinit Nayak
b974a86c8f Add IDs to buttons in 3 button nav for Taskbar
Bug: 191449914
Test: testSwitchToOverview passes
See bug for more details

Change-Id: I108bbe7607181680bca7cb5fad5e7289191edde6
2021-06-18 18:20:44 -07:00
Steven Ng
2f5648a911 Refactoring before adding a new view type in the WidgetsListAdapter
Changes made:
1. Model: added an abstract class for storing common information for
   entries shown in the full page widgets picker.
2. Introduced a ViewHolderBinder interface to split the logic of binding
   data to ViewHolder into separate classes.
3. Move the view holder binding of WidgetsListRow from WidgetListAdapter
   to its new class.
4. Move some widgets picker classes into a new picker package.

Test: Auto: Run WidgetsListAdapterTest, WidgetsListRowEntryTest and
      WidgetsListRowViewHolderBinderTest.
      Manual: open the all apps widgets tray and navigate the list.

Bug: 179797520
Change-Id: Iab29557842bb79156cad84d00a4c5d0db0c5aa06
2021-02-10 21:23:40 +00:00
vadimt
fb099c7fe1 Improving diagnostics when can't find a widget
Instead of "exceeded number of attempts" now printing that can't scroll
to widget.

Change-Id: Ia6f582e038d68fc35f152d94e592f60ef0bc2cf4
2020-06-24 21:54:16 +00:00
vadimt
45564c831b Removing debug requests from non-debug test info handlers
Bug: 152629799
Bug: 153670015
Change-Id: I02776be811d1d3325b35880d19d25a6638f904ef
2020-06-10 18:48:37 -07:00
Vinit Nayak
6b7cc3fdc2 Re-enable orientation sensor for Overview animation
Slight revert of ag/10668129 with adjustment
of disabling it for tests.

Fixes: 151456795
Test: Ran the labtest command for OOP
tests for crosshatch (where this issue
was first detected)

Change-Id: I315d138c2e4a6d4068304e9b5fb2e1b7feb34e63
2020-04-02 11:07:10 -07:00
vadimt
2e1e0d6bff Removing tracing for "Launcher didn't initialize" flake
The flake had disappeared, perhaps because of this logging, or,
hopefully, for some other reason.

Bug: 148313079
Change-Id: I636783d5fc71474dd443c143289c3ff74651835e
2020-02-10 12:47:42 -08:00
Sunny Goyal
5fffa47cac Fixing race condition on test information provider
Activity tracker is accessed on a non-UI thread, which can cause a non-initialized
Launcher to be treated as initialized

Bug: 149022794
Change-Id: I6634a6aff891592369c16469bbe95a9ea611819c
2020-02-07 12:37:44 -08:00
vadimt
c8b09709ff Tracing for another "Launcher didn't initialize" failure
This simply restored logging used for one of earlier investigations

Bug: 148313079
Change-Id: Idafed13208dc5610d577986fc487d1d44bc0ef5e
2020-01-27 17:48:49 -08:00
vadimt
9675452c2f Better diags and a small correction for scrolling in AllApps
Change-Id: I48dbba26139f42350831fb707bea847b7c76129f
2020-01-14 19:39:35 -08:00
Pinyao Ting
654adf657e integration test for open settings menu from workspace.
compare pid of launcher process after test execution to verify launcher isn't crashed when running in oop test.

Bug: 147235759
Change-Id: Id13c47f5c4e388cc8e95b19d099e94a2e540bf3f
Test: fun flake locally
2020-01-08 17:01:39 -08:00
vadimt
480083490f Tapl: AllApps: ensuring a minimal vertical size of an icon
Clicking an icon within its padding area is ignored by Launcher. Hence,
ensuring that the whole icon is visible.

Bug: 141770616
Change-Id: I19e3ba7cfa25de75a47202845d0838bea46af92c
2019-11-13 20:20:57 +00:00
vadimt
56b800bfea Reducing chances for the object with finalizer to be reffed by register
As suggested in b/143155020#comment27

Bug: 143155020
Change-Id: I4ed87a003fcd7afde213014fc1ba8b004500e71a
2019-10-25 18:12:25 -07:00
vadimt
23c8341096 Removing tracing and @Stability for a fixed bug
Bug: 142514365
Change-Id: I147850db274c465fb964eca30b97b3ebaaa2ccf6
2019-10-25 11:21:33 -07:00
vadimt
ce25a2bf68 Adding tracing for a lab-only flake
Bug: 142514365
Change-Id: I9c93ecabbcbad6d4683d595587831d8465e62ee8
2019-10-14 11:34:38 -07:00
Winson Chung
c062580b5a Wait for the task to be in recents before validation
- There are two issues:
  1) Currently the system does not add the task to the task list until
     the activity starting the task has been resumed (to be fixed in a
     follow up platform CL). When the three activities are started in
     sequence, it's possible for one of the activities to not reach the
     resumed state leading to an unexpected number of recent tasks the
     next time it's fetched.
  2) When swiping up, it may take time for getTasks to return and call
     applyLoadPlan, so try and wait until the task views have had a
     chance to be applied before continuing.
  3) Use the launcher activity tracker instead of activity rule since it
     will return the same activity even after the activity is destroyed
- Move the margin handling to the caller instead of the scroll method

Bug: 141580748
Change-Id: I2b7634f5ac6869ba4b369b3bd60e0f63747c0f0b
2019-10-11 17:10:38 -07:00
vadimt
4b5c1ef71b Adding support for intentionally leaking views.
Bug: 139137636
Change-Id: I923d1781daee9ae47eb306ee8fa3c44790c6993f
2019-10-08 17:04:26 +00:00
TreeHugger Robot
86017c9611 Merge "Removing access to LauncherModel.getCallbacks" into ub-launcher3-master 2019-10-08 16:26:12 +00:00
vadimt
1b92f6d964 Reduce risk of flakes in memory leak detection tests.
Now performing jreck@-style garbage collection prior to getting Launcher
PSS. The reduces PSS noise from ~700KB to ~250KB (std dev).

The tests (MemoryTests) run outside of Launcher process and
communicate with Launcher via RPC.

The change is in the RPC handler that lives in Launcher and returns
Launcher PSS to the test.

Bug: 139137636
Change-Id: I457e590b005dac53345f4223d972c7961754938c
2019-10-08 01:05:41 +00:00
Sunny Goyal
b0adac23e0 Removing access to LauncherModel.getCallbacks
Bug: 137568159
Change-Id: Ic074dec6a8981a4b9aabf028cf3b878b532abb11
2019-10-02 14:27:40 -07:00
Sunny Goyal
e84c5b82be Unifying activity tracker callback
> Using a common class for both Launcher and RecentsActivity
> Removing static refenrece to LauncherModel and using a common pattern for
  tracking activities

Bug: 141376165
Bug: 137568159
Change-Id: Ic1897abe6913ec78e25725118eedf5b468d5ec70
2019-10-01 13:54:26 -07:00
Vadim Tryshev
f7a2971530 Merge "Waiting for Launcher model load in out-of-proc tests." into ub-launcher3-master 2019-10-01 18:43:24 +00:00
vadimt
542b7df7fd Waiting for Launcher model load in out-of-proc tests.
Not doing this seems to have caused flakes.

Bug: 141770616
Change-Id: Ia9caf20e4a2d93298adf4249ca815ad79bced802
2019-10-01 17:46:35 +00:00
Pinyao Ting
d843673434 Merge "removed extra test protocol for unit test" into ub-launcher3-qt-future-dev
am: d8aef47393

Change-Id: I0d69c2ec0e3d693d4556314fd1b74dabd0a8cbd2
2019-09-30 13:54:36 -07:00
Pinyao Ting
ea38c25854 removed extra test protocol for unit test
Bug: 140406263
Test: run TaplTestsLauncher3
Change-Id: I73b3098bd3aa92fed41d22a94cb58fd07263d26a
2019-09-30 18:34:49 +00:00
Pinyao Ting
30414c5699 Merge changes from topic "a11y-minus-one" into ub-launcher3-qt-future-dev
am: ff4977d42d

Change-Id: I5c565a2d67274240dcd06e41ad03564526d486ce
2019-09-24 14:58:53 -07:00
Pinyao Ting
7752023c08 fix test for a11y change in supporting -1 page
Bug: 140406263
Change-Id: I0a39db135a5e5b0fe570ace55a368a7f4b6cb453
Test: run TaplTestLauncher3 locally
2019-09-23 13:06:36 -07:00
Sunny Goyal
3d56046ff8 Fixing some tests for 2-button mode
Bug: 141315387
Change-Id: I66db3e790f5fbe6bc30999ed599cce03874509be
2019-09-20 10:40:14 -07:00
vadimt
c708384087 resolve merge conflicts of a24ed7267c to ub-launcher3-qt-future-dev
Bug: None
Test: I solemnly swear I tested this conflict resolution.
Change-Id: I89f3bcf309b10a359b12167474fcb3f93640787f
2019-09-17 13:03:18 -07:00
vadimt
8c2ae545cf Support for tests that a leak is detected
Bug: 139137636
Change-Id: Ib4f02d6b3798e3fdf3d8e5758c09d2b642404af5
Merged-in: Ib4f02d6b3798e3fdf3d8e5758c09d2b642404af5
2019-09-17 18:49:42 +00:00
vadimt
a6650287b7 Merge "Support for getting Launcher Pss by tests" into ub-launcher3-qt-qpr1-dev
am: 01f8fb9132

Change-Id: I36a1309b24a94dafe5203287e07595d60622c158
2019-09-09 14:18:14 -07:00
vadimt
2bad570b40 Support for getting Launcher Pss by tests
Bug: 139137636
Change-Id: I8cad7dec07ce400cf927e3fc2ba9904fef942d9a
2019-09-06 16:50:51 -07:00
Sunny Goyal
6fe3eec95c Moving various common executors to a single location
Change-Id: I44bca49b8adb6fa22c3b48d10f674e42c28d792c
2019-08-20 14:36:17 -07:00
vadimt
c1a2764a6e Support for memory tests
Change-Id: I867a232a293f7bddbc630f563f18c0db94ac4b6e
2019-08-08 12:03:09 -07:00
vadimt
853852351f Correctly restarting Launcher from OOP tests
Waiting for touch interaction service; waiting for package-restart
events.

Bug: 136215685
Change-Id: I0c31c09fe3a58b898168dfdb4e4d23757b94a47c
2019-07-11 14:17:06 -07:00
vadimt
d4c90e12e9 Freezing all apps updates during certain tests
This CL adds a very low risk because most (but not all) changes affect
only Launcher behavior during the test.

This should fix a lab-only flake when all apps keeps changing while
the test is working with it.

Example: test figures out which icon to click, by the moment it clicks
there, there is another icon there, or the icon is under the search box,
and clicking opens IME.

Switching test devices to airplane mode didn't help. The earlier change
that prevents popup menu cancellation is not general enough.

Now the tests are given an API to explicitly freeze and unfreeze
all-apps, which should be a final solution.

Bug: 132900132
Bug: 133765434
Change-Id: I8b81cc9be004482beb6cdcdd05406e2d9b4c7629
2019-06-06 11:10:56 -07:00
Sunny Goyal
ab3963ddcf Moving TestInformationProvider to Launcher3 so that it can be used for
testing Launcher3 without quickstep

Also keeping the provider as disabled until needed

Change-Id: Ib5f459e02ae551724b390f3b74f43d601568d749
2019-05-23 14:02:33 -07:00