Apparently InputManager.getInputDevice can return null when a device is added
Fixes: 344902395
Test: N/A
Change-Id: I79c3dd3431b1d4b079b8a6863688a13ea2741602
This CL adds a TouchDelegate to the "Cancel" button on SplitInstructionsView so that it is always at least 48dp by 48dp. I.e. if the touch target is smaller than 48dp, it expands the TouchDelegate to be at least that size.
Fixes: 323108127
Test: Manually verified that the touch target is larger
Flag: EXEMPT bugfix
Change-Id: Id14bc39660ee7767991a3b5613f1282945a2ef96
- Merged DesktopTaskbarRunningAppsController up into
TaskbarRecentAppsController, which is now initialized directly
- The old TaskbarRecentAppsController was effectively a no-op
that was always overridden, so merging the one subclass up makes
things simpler (especially for the follow up CLs which will add
support for switching between Running and Recent tasks using
the same underlying data).
Flag: com.android.launcher3.enable_recents_in_taskbar
Test: TaskbarRecentAppsControllerTest
Bug: 315354060
Change-Id: I8411fb832e5dd3d76201d2694dec0b11bd70bbf9
Attempts to fix a flaky test by ensuring that recents is always cleared before creating a split pair (so the split pair under test is always the same).
Bug: 340935208
Test: testSaveAppPairMenuItemOrActionExistsOnSplitPair(), testSplitTaskTapBothIconMenus()
Flag: TEST_ONLY
Change-Id: Ibc81b90fac531f0e78e93a494ff59073ab5e52cf
When a new bubble is added when the bubble bar is expanded,
we now scale in the new bubble.
This change only handles the case where we're not at the limit.
Demo: http://recall/-/bJtug1HhvXkkeA4MQvIaiP/hW4pwqpAttscedRMxnu5BN
Flag: com.android.wm.shell.enable_bubble_bar
Bug: 345795791
Test: manual
- Expand bubble bar
- Push a new bubble and verify it scales in
Change-Id: Iafae1d0c8feb8e5a8853d54e7299db261df4ebf4
After dragging a bubble in the bubble bar to dismiss it,
we remove it from the view and update the width of the bubble bar.
The issue here is that the drag state only gets cleared in
BubbleBarView after the dismiss animation is complete, so when
the width is updated, we don't reposition all the bubbles according
to the new width, and end up in a weird state.
The fix is to clear the drag state in onDragDismiss.
Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 345482103
Test: manual
- Add multiple bubbles to the bubble bar
- Drag a bubble to dismiss it
- Observe bubble bar updates correctly
- Repeat with other bubbles
Change-Id: Ie94f8ace0f5660466686a261174b42c8d71b3e30
- animateClose uses ObjectAnimator which is able to skip animation automatically
Fix: 332685379
Test: OverviewMenuImageTest
Test: Remove animations in Settings, open and close the menu in handheld
Flag: EXEMPT bugfix
Change-Id: I5bfe835cffc77ff7f835ff3c41bbd64fc7121ed2
- In BaseContainerInterface.calculateTaskSize, combine both portrait and landscape/seascape insets to leave space for status bar/nav bar in either orientations.
- Rotate the paddings to portrait before applying
- Don't use getOverviewActionsClaimedSpace() in fake landscape/seascape
Bug: 344727200
Test: We can't currnetly autotest fake orientaiton
Test: With gesture/3-button, rotate Overview to portriat/landscape/seascape/fake-landscape/fake-seascape, launch task and enter overview
Flag: EXEMPT bugfix
Change-Id: Icda0f483781921cae78f1ea3ef003562b60ad75a
* on rotation taskbar re-inflates it's hotseat views.
If we're already in split, then FloatingTaskView tries to do calculations
on the view's position in the window, but has a reference to the
old, pre-rotated view which is no longer in any window.
* This sets startingPosition to be an empty rect, which is used to
set LayoutParam values, which are used downstream in update() to calculate
scale, and thus we end up dividing by 0.
* TODO(b/345556328) figure out a better solution than checking for an
empty rect
Fixes: 342606096
Test: Repro steps don't cause crash
Flag: EXEMPT bugfix
Change-Id: Icb546a05d383d1997a92471fc1de3ffc37d06eca
Additionally, let only prediction system provide suggestions, since the
UI surface has been there for a while, adding locally filtered widgets
from app package isn't required.
Bug: 345520128
Test: Unit tests
Flag: EXEMPT bugfix
Change-Id: Ia97f0743fefeae750e07a694bb19d24a5cc11ffe
When the bubble bar collapses, explicitly set the alpha to 1
for bubbles that should not be hidden.
Flag: com.android.wm.shell.enable_bubble_bar
Fixes: 345283193
Test: manual
- create 3 bubbles in the bar
- tap to expand
- select the last bubble
- tap it again to collapse
- observe it is visible
Change-Id: I1aed310b66433b88b08ccaf760fc8e82923b1b64
Updated logic for taskbar scrim view alpha calculation, setting it to 0
when bubble manage menu is shown.
Fixes: 337169457
Flag: NONE
Test: Visual.
For gesture navigation:
1) On foldable phone while device is being folded expand any
bubble, click mange button, then unfold. Observe no scrim view is
visible.
2) Enable persistent taskbar, pull down the notification shade then
swipe it back up while bubbles are open.
3) Enable persistent taskbar, pull down the notification shade then
swipe it back up while bubbles and mange menu is open.
4) Enable persistent taskbar. Fold device. Open bubble and click manage
button. Unfold device. Observe no scrim view is visible.
For 3 button navigation
1) Unfold the device, press the home key, pull down the notification
shade then swipe it back up while bubbles are open.
2) Unfold the device, press the home key, pull down the notification
shade then swipe it back up while bubbles and mange menu is open.
3) Fold device, open bubble and click manage button. Unfold device.
Observe no scrim view is visible.
Change-Id: Ic011ae9bd11801a479062cc51c60377823a926fb
Set content description on the bubble bar when it is collapsed. Only
allow focus on the bar itself. In collapsed mode, bubbles in the bar
can't be focused.
Content description for the bar matches what we have in floating mode.
We include the text for the first bubble and then how many bubbles are
there more.
Set content description on bubbles in bubble bar. When bubble bar is
expanded, only the bubbles are focusable.
Bubble content description matches the floating bubbles content
description. Includes the notification title and app name.
Bug: 344670947
Flag: com.android.wm.shell.enable_bubble_bar
Test: enable talkback, focus on bubble bar when it is collapsed, check
that only bubble bar receives focus
Test: enable talkback and expand bubble bar, check that only the bubbles
receive focus
Change-Id: Id931f0360b9ebadd01dd16b05b75546fcc4df803
- This was a coding error introduced in ag/27382735
- getThumbnailBounds is supposed to union all individual thumbnailBounds per TaskContainer, rather than overriding bounds over and over per TaskContainer
Bug: 339787250
Test: Swipe up to home from split apps
Flag: EXEMPT bugfix
Change-Id: I7a697620f4b4507df8f1860b4c2f9889e4be006b
1. Update the starting window velocity when coming from 3-button nav or
predictive back
Before we used an arbitrary fixed velocity which goes down to basically
0 with the old implementation, but caused a noticeable jump up in the
new one when using predictive back. Now we just pass 0, since the
predictive back framework doesn't give us the actual velocity.
2. Add the scaling home reveal to the targetless (not going back to a
specific app icon or widget) animation and 3-button nav
Bug: 298089923
Fix: 343143876
Flag: com.android.launcher3.enable_scaling_reveal_home_animation
Test: manually tested with flag on and off
Change-Id: Ied3630a51862731fad044b68f76a45dc87f2e17b
- icon and DWB toast now transition in with animation when swipe up from apps to Overview
- Refacotred focusTransition into MultiProperty, with separate control from fullScreenProgress and scaleAndDim, and get rid of "invert" parameter and iconScaleAnimStartProgress variable which is very confusing
- Added a SCALE_AND_DIM_OUT property for use with PendingAnmation during dismiss, as PendingAnimation does not support per animator interpolator
- Use height from resource in DWB toast when calcualting translation, so translation can be properly set before view is measured
- Always set bannerOffsetPercentage regardless if banner is added
Fix: 344786723
Fix: 315972057
Fix: 313644427
Flag: EXEMPT bugfix
Test: Quick switch from home, icon and DWB toast don't transition in until gesture release
Test: Quick switch from app, icon and DWB toast don't transition in until gesture release to Overview
Test: Dismiss focus task, icon and DWB toast transition in after transition settle
Test: Swipe down task, icon and DWB toast transition out with finger
Test: Launcher central task, icon and DWB toast transition out
Change-Id: Ie16a2ceff10967de38b5f66c52f4be00d0051c5f
This CL replaces the live tile with the snapshot after rotating in fake orientation. The animateRotation function was created to extract the rotation logic to guarantee that switchToScreenshot call will only happen when there is a running task.
Fix: 326410493
Flag: EXEMPT bug fix
Test: Manual. Instructions in the bug description.
Change-Id: I9d5e1b5ca803f8f8072702b37206a73b8d8a10ed
from AppIcon press in overview
Test: Updated unit tests
Flag: EXEMPT not a major feature/ user visible change
Bug: b/326231756
Change-Id: I9e53cd3ec41dd2475ba90ea8fab2fb7a90f5e158
