The order of initialization for IconShape is closely tied to ThemeManager
which makes it difficult for change listeners to work. Merging these keeps
all the theming information at one place
Bug: 381897614
Test: Updated tests
Flag: EXEMPT refactor
Change-Id: Ie29efa20c3308a24be3e284c1c93ed7444b68d58
- when done with breaking changes will update tests as part of b/396211437
Bug: 395952745
Bug: 396211437
Flag: com.android.launcher3.enable_launcher_icon_shapes
Test: Presubmit
Change-Id: I461f6834932a710efa439a112bce23359aee13de
Unless explicitly annotated, parameters in java are by
default nullable. There are a few cases where a null context
may be passed to the unregisterReceiverSafely function
of SimpleBroadcastReceiver.
To mitigate misuses or incorrect contexts being passed for
register vs unregister, keep the context as a strong reference
in the constructor.
Also added NonNull annotations for any public callsites to
enforce behavior.
Bug: 395019017, 395966395
Flag: NONE - bug fixed
Test: manual - presubmit
Change-Id: Ie371fa45cadceaf51cf184b446df9123ef27c337
This CL does the following:
- Adds new methods `isInDesktopMode()` and
`isInDesktopModeAndNotInOverview()` to `DesktopVisibilityController`.
- These two methods rely on the new multi-desks impl when the flags are
enabled.
- Makes the existing `areDesktopTasksVisible()` and
`areDesktopTasksVisibleAndNotInOverview()` private, and migrates all
the usages to the new methods.
- The new methods uses the old methods if the flags are disabled.
A companion NexusLauncher CL is at ag/31601363.
Bug: 394182435
Test: m
Flag: com.android.window.flags.enable_multiple_desktops_frontend
Flag: com.android.window.flags.enable_multiple_desktops_backend
Change-Id: I29ff38f984bfe2f68a120f84e1a75fa36b739258
The TODO was added by an external contributor from the test org. The contributor is not available for the proper fix, so leaving the workaround as is.
Bug: 225505986
Change-Id: I4d94214f36a4d927546d87f01c924db82fbbe898
Test: presubmit
Flag: NA test code
The reason the test fails is that since the tap targets are smaller, the
drag is too fast and the hover over icon to create folder time doesn't
elapse
Bug: 383917141
Test: TaplDragTest#testDragToFolder
Flag: TEST_ONLY
Change-Id: Iadf0587c3c1c9b5aa50b508a35321bb398d36e5c
This reverts commit abbb991d8f.
Reason for revert: DroidMonitor: Potential culprit for Bug X - verifying through ABTD before revert submission. This is part of the standard investigation process, and does not mean your CL will be reverted.
Change-Id: Ifa241a631a1a4361623cfe0e81e31ca6b44e9d73
Bug: 390665752
Flag: com.android.window.flags.enable_desktop_taskbar_on_freeform_displays
Test: manual on desktop device. verify correct taskbar is shown
on home screen, in overview, in desktop mode, with fullscreen
app shown. Verify opening/launching apps from taskbar works
as expected.
Change-Id: I5c1e21799609c28ec44cc190bfc681934907199f
> Merging come methods to BaseActivtiy
> Separating wallpaper theme implementation to an independent class
Bug: 393703968
Flag: EXEMPT refactor
Test: Presubmit
Change-Id: I8cdb6d1520beff3f8226b62c5b7eafd48b2c674f
it looks like the issue is that the layout has a widget on the second
page leading the page count to be different than expected
Bug: 381918059
Test: TaplWorkspaceTest#testAddAndDeletePageAndFling
Flag: TEST_ONLY
Change-Id: I19e475450494a5580e8fd04d02692624c086807c
- includes loading icons for AllApps as archived apps show there as well
Bug: 391913214
Flag: com.android.launcher3.restore_archived_app_icons_from_db
Test: LoaderTaskTest, LoaderCursorTest and manually doing backup + restore
Change-Id: Icc9dc292551d4a3c6ac23de89aea4cb14856744c
Change I59b886bfb632f0f26ee58c40f82f447f5ea59b41 caused a number of
launcher and WM tests to fail because the TAPL code was producing motion
events with invalid button states, or just not sending BUTTON_PRESS and
BUTTON_RELEASE events at all. While this change does not address all
possible uses of LauncherInstrumentation#sendPointer (for example,
sending a MOVE during which a button should be held down), it fixes
consistency issues in all cases currently used by tests. A more
comprehensive fix is not worthwhile since this kind of input event
injection is deprecated and should be replaced with usage of uinput or
virtual devices anyway.
Test: $ atest \
NexusLauncherOutOfProcTests:com.android.launcher3.appiconmenu.TaplAppIconMenuTest \
NexusLauncherOutOfProcTests:com.android.launcher3.dragging.TaplDragTest \
NexusLauncherOutOfProcTests:com.android.launcher3.dragging.TaplUninstallRemoveTest \
NexusLauncherTests:com.android.quickstep.TaplTestsTransientTaskbar \
'NexusLauncherTests:com.android.quickstep.TaplTestsTaskbar#testOpenMenuViaRightClick' \
'WMShellFlickerServicePlatinumTests:com.android.wm.shell.EnterSplitScreenByDragFromShortcutGesturalNavLandscape#enterSplitScreenByDragFromShortcut'
Bug: 372571823
Bug: 392150793
Flag: TEST_ONLY
Change-Id: I5c259c13d433d3010d2cf9c6fe01e08ba5990ef7
Revert submission 31445615-model-callbacks
Reason for revert: <Droidmonitor crested revert due to b/393222548. Will be verified through ABTD for stanadard investigation.>
Reverted changes: /q/submissionid:31445615-model-callbacks
Change-Id: If6893a125756e5abfbb215af377576429bb1c91b
> Using ShapeDelegate for icon clipping
> Creating ShapeDelegate based on the current icon shape
> Defining different shape delegates for icon and folder
> Updating preview rendering to use dagger graph
> Adding tests for all icon shapes
Bug: 392145015
Test: atest IconShapesProviderTest
Flag: com.android.launcher3.enable_launcher_icon_shapes
Change-Id: Ic9f287e2a6fef2aad18ba224404de58a64da0bb3
Making the BubbleTextView.applyItem stateless so that it does not depend on the order of events
Bug: 390572144
Flag: EXEMPT refactor
Test: atest LauncherBindableItemsContainerTest
atest BubbleTextViewTest
Change-Id: Ib9c0ac6c330d6f4e08c3db5772d35787fa056b65
If a TAPL test fails after injecting a ACTION_DOWN event, but before it had a chance to send the associated ACTION_UP event, every following test that attempts to send a ACTION_DOWN will then fail. Adding a check and clean up for this.
Flag: EXEMPT adding test failure cleanup
Fixes: 392660264
Test: TAPL tests
Change-Id: If7c21ab58a75fbcec55437ca32b7c9cd0aa8d961
