Commit Graph

1737 Commits

Author SHA1 Message Date
vadimt
091794671d Adding tracing for non-detection of Pause
Bug: 156044202
Change-Id: I16f196db6266a0c3a84b59b7cdeb29863a37ff0f
2020-05-07 20:06:58 -07:00
TreeHugger Robot
e4d1a71413 Merge "Disabling OverviewActionsView buttons while scrolling or clear all shown." into ub-launcher3-rvc-dev 2020-05-08 00:02:54 +00:00
James O'Leary
ac327df55c Merge "Revert "Compose gesture integrated fully into Launcher"" into ub-launcher3-rvc-dev 2020-05-07 01:14:44 +00:00
TreeHugger Robot
d13dd3bc44 Merge "Skip setting the controller if the animation is already finished" into ub-launcher3-rvc-dev 2020-05-07 00:14:15 +00:00
James O'Leary
2610bfde05 Revert "Compose gesture integrated fully into Launcher"
Revert "Compose gesture integrated fully into Nexus Launcher"

Revert submission 11035205-compose_gesture_fully_integrated_launcher

Reason for revert: Broke Launcher Android Studio build, quick switch, and home gesture doesn't work if Compose is open.
Reverted Changes:
I2d97b22d5:OverscrollPlugin refactored to use onTouchEvent
Ia19a55f65:Compose gesture integrated fully into Nexus Launch...
I65aa07ac1:Compose gesture integrated fully into Launcher

Change-Id: Ic05c47eb686b3942ba519e76db32977fc568844b
2020-05-07 00:13:47 +00:00
Sreyas
78f53856a9 Disabling OverviewActionsView buttons while scrolling or clear all shown.
Bug: 153469850, 153387526
Video: https://drive.google.com/a/google.com/file/d/1mOc8yubux92iKtXRtSOKTcnjWWzvDgC7/view?usp=sharing

Change-Id: Id507d3a050e67057fc34a30771c9566ddfcf94ca
2020-05-06 16:36:24 -07:00
James O'Leary
d9c86d4b3b Compose gesture integrated fully into Launcher
- Support dismissing Compose via the reverse gesture from the appear
gesture
- Use Tony Wickham's ag/10204761 with some glue code to enable the
app below Compose panning in the same direction as the gesture as
Compose peeks in
- Add feature flag to use Compose hosted in a window (permits underlying
app panning)
- Use InterpolatingVelocityTracker to fix OtherActivityInputConsumer
processing swipes in the wrong direction ~20% of the time due to a bug
in VelocityTracker (see go/quirky-bubbles)

Change-Id: I65aa07ac112db8bd89cec9acfa0ce2b6ebacd43f
2020-05-06 13:40:47 -04:00
TreeHugger Robot
18f367a5f7 Merge "Bias rotation to remain in existing rotation" into ub-launcher3-rvc-dev 2020-05-06 17:30:40 +00:00
TreeHugger Robot
164d0c6509 Merge "Fix AlwaysOnTop stack may covered by RemoteAnimation" into ub-launcher3-rvc-dev 2020-05-06 16:23:32 +00:00
Sunny Goyal
d67569eac8 Fix AlwaysOnTop stack may covered by RemoteAnimation
Merging changes from Change-Id: I8028cd50d66f7d77e5d1ec6514e953c8be9935d6
in TaskViewSimulator

Bug: 151024899
Change-Id: Id41e5af227be2557032387bdaa61cac3458baf32
2020-05-06 02:41:15 -07:00
Winson Chung
7ad937c78d Merge "Account for various launcher states when setting back button alpha" into ub-launcher3-rvc-dev 2020-05-05 04:37:38 +00:00
Sunny Goyal
29e7a58f1a Fixing max-zoom-scale not taking into account the the fullScreen scale
Also fixing the issue where display info is is not correctly initialized

Bug: 155257023
Bug: 155682580
Change-Id: Ib2cc981c1900f3d14f158f4dbb60ae77311f339b
2020-05-04 18:11:15 -07:00
Winson Chung
a4b11dd984 Skip setting the controller if the animation is already finished
Bug: 154568748
Change-Id: I999c0cc3a4d9661bcf6dcd1e804746a3a0959a83
2020-05-01 16:25:04 +00:00
TreeHugger Robot
7a87f953a8 Merge changes from topic "widget-logging" into ub-launcher3-rvc-dev
* changes:
  Fixes missing components info when logging Widget item.
  Implement LAUNCHER_ITEM_DRAG_STARTED event.
2020-05-01 07:54:03 +00:00
Winson Chung
2a00f81327 Account for various launcher states when setting back button alpha
- Previously we only check for the flag which is always true in the
  normal launcher state, so if the animation starts, we could end up
  writing the back alpha value without accounting for window focus or
  any other states that launcher is in that affects back button
  visibility

Bug: 155129739
Test: Open -1 article and hit back
Change-Id: I42d27a192b23f394f8565a6893ce092603e31654
2020-04-30 23:03:52 -07:00
Winson Chung
7f534cf2a8 Merge "Fix issue with quickswitch not updating system bar flags" into ub-launcher3-rvc-dev 2020-04-30 22:48:43 +00:00
thiruram
f81e8b002a Implement LAUNCHER_ITEM_DRAG_STARTED event.
* Fixes null component issue when ItemInfo object copiedFrom.
* Fixes missing container when item is dragged from hybrid hotseat.

Sample Logs:
2020-04-30 14:09:45.499 30472-30472/com.google.android.apps.nexuslauncher D/StatsLogManager: LAUNCHER_ITEM_DRAG_STARTED
    # com.android.launcher3.logger.LauncherAtom$ItemInfo@260f31f8
    application {
      component_name: "com.android.chrome/com.google.android.apps.chrome.Main"
      package_name: "com.android.chrome"
    }
    container_info {
      workspace {
        grid_x: 2
        grid_y: 2
        page_index: 2
      }
    }
    is_work: false

2020-04-30 14:23:15.230 31320-31320/com.google.android.apps.nexuslauncher D/StatsLogManager: LAUNCHER_ITEM_DRAG_STARTED
    # com.android.launcher3.logger.LauncherAtom$ItemInfo@608f101
    application {
      component_name: "com.google.android.gm/.ConversationListActivityGmail"
      package_name: "com.google.android.gm"
    }
    container_info {
      hotseat {
        index: 1
      }
    }
    is_work: false

Bug: 152978018

Change-Id: I3d3ce213fd2fc6eb5ffb239e048ceb7c0fa88b53
2020-04-30 15:03:43 -07:00
Winson Chung
a7ac7192c3 Fix issue with quickswitch not updating system bar flags
- Separate the calls to minimize split and to update the flags (we only
  want to minimize in split when swiping up, but we want to update the
  flags when quickswitching as well)

Bug: 155410195
Change-Id: I56308cc0fbaa8a855383012738f129671d72feff
2020-04-30 13:58:22 -07:00
Zak Cohen
7f48b0aa34 Overview - position the modal task in the correct place.
video of new behavoir
https://drive.google.com/a/google.com/file/d/1vFTtjjpwamj5H7dhmB1-5JSFS6fv6vMw/view?usp=sharing


Test: local
Bug: 155205932
Change-Id: I7fe79c848af92013587de32a777645cc472ae910
2020-04-30 18:34:46 +00:00
Lucas Dupin
20051e22e5 Merge "Do not blur if all apps is fully visible" into ub-launcher3-rvc-dev 2020-04-30 17:11:53 +00:00
Sunny Goyal
8f96546e79 Generalizing LauncherState definition so that it can be used in RecentsActivity
> Removing 'Launcher' as parameter from state methods called by StateManager
> Converting state properties to methods for easier abstraction
> Moving state handling drom state definition to activity class

Change-Id: I997627df606a7e0bb3bf32688d045a942a47fc94
2020-04-30 01:01:51 -07:00
TreeHugger Robot
2d60935e1c Merge "Various multi-window fixes" into ub-launcher3-rvc-dev 2020-04-29 23:43:57 +00:00
TreeHugger Robot
875f381dbb Merge "Dump RecentsOrientationState for bug reports" into ub-launcher3-rvc-dev 2020-04-29 19:56:54 +00:00
Vinit Nayak
a5877307d1 Dump RecentsOrientationState for bug reports
Bug: 154951045
Test: New output shows up when running
"adb shell dumpsys activity
com.google.android.apps.nexuslauncher.NexusLauncherActivity
[--all]"

Change-Id: I5e9ace7d370eb0e9d278d7d9f7f9156674ca1a50
2020-04-29 12:19:49 -07:00
Sunny Goyal
0addbf0512 Various multi-window fixes
> Fixing scale up calculator for swipe-down
> Offsetting pivot so that the preview is aligned to bottom-right
> Allowing insets to be available in multi-window mode as well
> Offsetting taskViewSimulator appropriately in multi-window mode

Change-Id: I7da4c145efca72ef219a5ffcaf23d726812df270
2020-04-29 11:50:33 -07:00
Lucas Dupin
264cb2ff68 Do not blur if all apps is fully visible
Fixes: 155093795
Fixes: 155203546
Test: manual
Change-Id: I30f4c027e5107a199791e908acbb7ffed94e6a77
2020-04-29 17:49:02 +00:00
Jon Miranda
f6225830d5 Fix floating icon view positioning when in multiwindow mode.
The rect we passed in was in screen space to match the window, but needs to be
be local to launcher.

Also updated code/comments to make it more readable.

Note that the bounds of the targets being off is a separate issue b/153581126

Bug: 135195169
Change-Id: I4a8c0aa2f504bdf69342a927725cd440fb324a36
2020-04-28 21:29:51 -07:00
Vinit Nayak
e8269b3944 Merge "Enable edge back gesture on app launch" into ub-launcher3-rvc-dev 2020-04-29 00:18:22 +00:00
Vinit Nayak
3f3cc3e96e Enable edge back gesture on app launch
We don't clear state on EdgeBackGestureHandler
when we go to Recents or Home.
A more robust solution is in the works with
WM team and will probably be built on top of this.
Needs ag/11273364 to work.

Bug: 154580671
Test: Launch app directly in landscape,
should be able to swipe home on first try.

Change-Id: Ia4c685e16645d0237f278a611f6c61f252f3b79c
2020-04-28 13:51:43 -07:00
Vinit Nayak
72c9da7647 Bias rotation to remain in existing rotation
Change-Id: I3457dc7946838eb7e0e68a879091941ce4674a7a
2020-04-28 12:53:07 -07:00
Zak Cohen
a39544d562 OverviewActions - Use launcher state to track modal state.
Test:local

Change-Id: I44e25b95095b9a7aac4b4172c9c91fbfbf4d9ec7
2020-04-27 16:29:44 -07:00
Vinit Nayak
b219eeab48 Merge "Revert "Hide shelf in 2-Button Landscape"" into ub-launcher3-rvc-dev 2020-04-27 21:24:53 +00:00
Vinit Nayak
48b28027c0 Revert "Hide shelf in 2-Button Landscape"
This reverts commit 9b5795a579.

Reason for revert: b/155090034

Change-Id: If7decd54965a680d50e4474fb279ebe0002441bb
2020-04-27 20:48:49 +00:00
TreeHugger Robot
1016bf410d Merge "Don't scale workspace when going to all apps if ENABLE_OVERVIEW_ACTIONS" into ub-launcher3-rvc-dev 2020-04-25 06:21:30 +00:00
Tony Wickham
00dc219309 Merge "Use OverviewWithoutFocusInputConsumer for sharesheets over home" into ub-launcher3-rvc-dev 2020-04-25 06:00:01 +00:00
TreeHugger Robot
ea0c4f57be Merge "Hide shelf in 2-Button Landscape" into ub-launcher3-rvc-dev 2020-04-25 01:14:10 +00:00
TreeHugger Robot
c6800e40e2 Merge "Creating default implementation for state lisnter method" into ub-launcher3-rvc-dev 2020-04-24 23:49:33 +00:00
Vinit Nayak
9b5795a579 Hide shelf in 2-Button Landscape
Disable overview rotation in 2-Button
until we can figure out the correct
transition/animation.
TODO: b/154665738

Fixes: 154181816
Test: Tested no button and 2 button,
overview actions worked as before.

Change-Id: Ib67906b11e24def870a39f57b5156e29db258fd7
2020-04-24 16:43:37 -07:00
TreeHugger Robot
2450f524c6 Merge "Clear swipe region cache on nav mode switch" into ub-launcher3-rvc-dev 2020-04-24 23:31:04 +00:00
Sunny Goyal
aeec80ddbb Creating default implementation for state lisnter method
> The transition start is used rarely

Change-Id: I0d33f0f6372eb4ef89bfbb66968612693b7c6033
2020-04-24 15:41:29 -07:00
Vinit Nayak
dcec265f0d Clear swipe region cache on nav mode switch
Fixes: 154955192, 150958400
Test: Switched from gesture nav to 3 button,
was no longer able to swipe up

Change-Id: Icc7b27eb7bd1eb5ddf25d7e7c3464a77a3a88f24
2020-04-24 15:05:17 -07:00
Tony Wickham
bf2f066fff Use OverviewWithoutFocusInputConsumer for sharesheets over home
Test:
- start sharesheet from overview action, swipe up
- start sharesheet after taking screenshot on home, swipe up
- start sharesheet from an app, e.g. Chrome
The first two use OWFIC, last one uses OtherActivityInputConsumer
as normal.

Bug: 153673244
Change-Id: I7d7887e1f6818346ada75776ec63b43aaf3708f1
2020-04-24 15:01:32 -05:00
TreeHugger Robot
a29a69943a Merge changes I38874b8b,I627ed7c6 into ub-launcher3-rvc-dev
* changes:
  Adds ripple effect for successful Back gestures in tutorial.
  Adds feedback to Home and Back tutorials.
2020-04-24 19:58:48 +00:00
TreeHugger Robot
acafb3a287 Merge "Detects nav bar gestures to progress through Home tutorial." into ub-launcher3-rvc-dev 2020-04-24 18:58:30 +00:00
Andy Wickham
e992fab187 Adds ripple effect for successful Back gestures in tutorial.
Emanates from where the gesture was started.

Demo: https://drive.google.com/open?id=1oaXOSUiZP6Hi7J6W4H2NIFVVu0tQfKWm
Bug: 148542211
Change-Id: I38874b8b731864cbfdf963a5e44a59c8c3d30c51
2020-04-24 18:16:43 +00:00
Andy Wickham
64a91132c5 Adds feedback to Home and Back tutorials.
Back feedback:
 - Too far from edge of screen
 - Cancelled (reversed gesture, swiped upwards, etc.)
 - Inside nav bar region
 - Demo: https://drive.google.com/open?id=1pc_hr7i-iZmgF37CN8oijPjhOvvsJoEG

Home feedback:
 - Too far from edge of screen
 - Paused too long (Overview detected)
 - Swiped sideways instead of up
 - Demo: https://drive.google.com/open?id=1NGYAlqV2wJtM2DOJ1pZM-r8N1SYVtMos

Bug: 148542211
Test: Manual
Change-Id: I627ed7c6e9b005d35794e4ae568529b5613cbf70
2020-04-24 18:15:23 +00:00
Andy Wickham
6b6287f414 Detects nav bar gestures to progress through Home tutorial.
Home gesture also exits Back and Home tutorials on the
completion screens (as does back gesture).

Test: Manually verified Back and Home tutorial flows.
Bug: 148542211
Change-Id: I8026745e875e9ccb8cfd60bc438213b2d896254d
2020-04-24 18:13:05 +00:00
Ming-Shin Lu
4f07525417 Fix AlwaysOnTop stack may covered by RemoteAnimation
Now with hierarachical animation, the layer of
RecentsAnimation / RemoteAnimation are controlled by system.

Now Launcher side don't need to have other way to set layer for ZBoost
case, so remove setLayer & withLayer related logics for cleaning up.

Fix: 151024899
Test: manual, launch google map app -> enter PiP mode,
      swipe up to overview screen or launch activity from shortcut,
      make sure the PiP window is not covered by other apps.

Change-Id: I8028cd50d66f7d77e5d1ec6514e953c8be9935d6
(cherry picked from commit 99f7da7dd2)
2020-04-24 02:18:16 +00:00
TreeHugger Robot
1bb37acb5d Merge "Don't allow swiping from overview to all apps in 3 button mode" into ub-launcher3-rvc-dev 2020-04-23 00:04:35 +00:00
TreeHugger Robot
2309597c9a Merge "[Overview Actions] Update the navigation mode immediately when switch." into ub-launcher3-rvc-dev 2020-04-22 23:34:00 +00:00