Commit Graph

10885 Commits

Author SHA1 Message Date
Jeremy Sim
742f710168 Merge "Fix bug with TalkBack not reading out SplitInstructionsView" into main 2024-03-03 00:18:47 +00:00
Jagrut Desai
02c56e8258 Merge "Fixing taskbar being unstashed after opening to unfolded mode" into main 2024-03-01 21:43:24 +00:00
PODISHETTY KUMAR
b588e4618b Merge "Revert "Implements the "Save App Pair" button in Overview Actions"" into main 2024-03-01 09:27:08 +00:00
Jeremy Sim
d2c28c7ee3 Fix bug with TalkBack not reading out SplitInstructionsView
This CL sets an accessibility title so that TalkBack and other tools will properly read out the instructions on SplitInstructionsView.

Fixes: 323461342
Flag: ACONFIG com.android.wm.shell.enable_split_contextual TRUNKFOOD
Test: TalkBack announces the instructions immediately when the view appears, and is not interrupted.
Change-Id: I1666f0c374d40b31d732d3cca529f03a7f2f7f28
2024-02-29 21:35:20 -08:00
Jeremy Sim
c8c4fd8aeb Merge "Fix disabled state for non-resizeable app pairs" into main 2024-03-01 05:14:48 +00:00
Vinit Nayak
5c8978c4db Revert "Implements the "Save App Pair" button in Overview Actions"
Revert submission 26391074-save-app-pair-button

Reason for revert: breaks image comparison tests b/327665771
Reverted changes: /q/submissionid:26391074-save-app-pair-button

Change-Id: Ic4580fc39d8394771551f100932157e6ef35c4b7
2024-03-01 01:02:35 +00:00
Jagrut Desai
3c3bef333a Fixing taskbar being unstashed after opening to unfolded mode
Test: Manual,
Bug: 312723553
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning TRUNKFOOD
Change-Id: I91aa947a707e3fc918e617f207e823b2f1460466
2024-02-29 16:17:24 -08:00
Jeremy Sim
31b934f28f Fix disabled state for non-resizeable app pairs
This CL makes it so that app pair creation includes updating some flags on the newly created WorkspaceItemInfos -- specifically the FLAG_NON_RESIZEABLE flag. Previously, flag updating only happened upon launcher restart or package change, which meant that newly created app pairs were missing some flags.

This caused App+Camera pairs to not have the FLAG_NON_RESIZEABLE flag immediately on app pair creation, which affected the disabled state.

Fixes: 323088270
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Test: Manual
Change-Id: I96c6ec3723bec2ddaa0af625890b983faf2fe2c7
2024-02-29 13:42:43 -08:00
Saumya Prakash
3fb35d3fb8 Merge "Remove the tint from taskbar themed icons for dark mode." into main 2024-02-29 20:05:15 +00:00
Jeremy Sim
8c383aceda Merge "Implements the "Save App Pair" button in Overview Actions" into main 2024-02-29 19:47:20 +00:00
Tony Wickham
47a85e4607 Merge "Call showCurrentTask again if applyLoadPlan doesn't include running task" into main 2024-02-29 17:19:11 +00:00
Jeremy Sim
41d8ae8a7a Implements the "Save App Pair" button in Overview Actions
Second attempt at enabling this feature. See ag/25143701, linked bugs, and revert history for details. This patch is tested with mokey devices and does not crash!

This patch includes:
- Ability to "save app pair" from Overview Actions.
- Internally the actions bar is not longer hidden for GroupedTasks; instead the individual buttons for "Select", "Screenshot", and "Split screen" are toggled off and "Save app pair" is toggled on.
- "Save app pair" option does not appear in icon menu when it is visible in the Actions Bar.
- Addition to go/quickstep/res/layout/overview_actions_container.xml to support addition of the new button.

Note: This patch introduces a slight regression where users are now able to long-press to select text on task 1 of a paired GroupedTaskView (previously we did not let them select text on either task for consistency.) Will follow up with a fix -- see bug for details.

Flag: ACONFIG com.android.wm.shell.enable_app_pairs TRUNKFOOD
Fixes: 315545418
Fixes: 315292030
Test: Manual, all action buttons still work and "Save app pair" appears and disappears correctly
Change-Id: I4b4ac525cfd5eb9cfcd757d0bffc7215b04f9a3d
2024-02-28 19:39:04 -08:00
Vinit Nayak
2b4e99344d Merge "Remove A11y node info for SplitInstructionsView" into main 2024-02-29 03:16:28 +00:00
Tony Wickham
bf885ceb5f Call showCurrentTask again if applyLoadPlan doesn't include running task
Test: swipe up from an app that has excludeFromRecents=true, e.g.
Volume Dialog, Home quick settings tile, and Routines widget; ensure
the gesture works as expected (e.g. can quick switch, go home, or to
overview with all tasks visible).
Flag: none
Fixes: 324495241

Change-Id: If3b61f7d1725ee573fad38140bfeb77f3a6cea1e
2024-02-29 00:36:16 +00:00
Saumya Prakash
ba04c0c1dc Remove the tint from taskbar themed icons for dark mode.
We remove the added tint to taskbar themed icons to match how they look
in the hotseat on launcher home screen specifically for dark mode.

Fix: 323952706
Test: Turn on themed icons and dark mode. Compare app icons in taskbar
and in hotseat
Flag: N/A

Change-Id: I4dfe352ca17ef5537e48fcc3cff66ba4fd4f603a
2024-02-28 23:07:07 +00:00
Jagrut Desai
07959348e6 Merge "Fixing taskbar unstashing after unfolding" into main 2024-02-28 15:21:40 +00:00
Eghosa Ewansiha-Vlachavas
7cc75c6a43 Merge changes from topics "removeDesktopMode2", "replaceDesktopWindowingFlag" into main
* changes:
  [2/n] Remove use of `persist.wm.debug.desktop_mode_2`
  [2/n] Replace read-only desktop windowing flag with runtime flag
2024-02-28 14:24:09 +00:00
Vinit Nayak
0edcfa4979 Merge "Update animation timing for split dismiss animation" into main 2024-02-28 04:14:28 +00:00
Sukesh Ram
1909570ed3 Debugging Logs for TaplOverviewIconTest#testOverviewActionsMenu
Add logging for TaplOverviewIconTest#testOverviewActionsMenu.

Flag: NONE
Test: Manually tested in pixel 7.
Bug: 326073471
Change-Id: I5f08192bb1143c1d23f8884bb207ce69c5830a41
2024-02-28 01:06:14 +00:00
Vinit Nayak
dfbf253f90 Remove A11y node info for SplitInstructionsView
* Individual text view and cancel button still
have their own a11y actions, but top level
view doesn't need one

Test: Tested w/ switches to ensure parent view
doesn't get selected. Tested w/ Talkback to
ensure we can still cancel through talkback
Fixes: 323462927

Change-Id: I60d21f6e768c59f29f51007f56ff784821487895
2024-02-27 16:54:02 -08:00
Jagrut Desai
e424570af1 Fixing taskbar unstashing after unfolding
Test: Manual,
Bug: 312723553
Flag: ACONFIG com.android.launcher3.enable_taskbar_pinning TRUNKFOOD
Change-Id: Iddd10df6e40ee2de4ef08eb18df88d48b7468035
2024-02-27 14:44:26 -08:00
Vinit Nayak
9c29c1e1c4 Update animation timing for split dismiss animation
* We weren't specifying an animation duration for the
dismiss placeholder animation, and it wasn't inheriting
from the animatorSet since that didn't have any duration
set on it.
* Now we explicitly set a duration (usually matching that of
the current launcher state config) to the timings line up
well

Test: Repro steps don't show bug. Also tested on large screen dismissing
contextual split from overview and home, seems fine
Fixes: 314860754

Change-Id: I701e4f88c1ddd92561da4fb76715a859f587c91e
2024-02-27 12:10:44 -08:00
Schneider Victor-tulias
7e0703eca0 Merge "Fix blocked gesture handling on failed startRecentsActivity calls" into main 2024-02-27 18:53:13 +00:00
Sam Cackett
fe2ff288de Merge "Set max height on TaskMenuView and scroll if too many elements" into main 2024-02-27 17:02:51 +00:00
Treehugger Robot
287e981ce9 Merge "Fix bouncing of task view when dragged past dismiss threshold." into main 2024-02-27 16:41:59 +00:00
Uwais Ashraf
dddafae44e Fix bouncing of task view when dragged past dismiss threshold.
Before: https://screenshot.googleplex.com/56AHSMFkNwC76BV
After: https://screenshot.googleplex.com/AjuWqZaSNxmNYn8

Other cases after:
https://screenshot.googleplex.com/oaNotdg79v7LGUA
https://screenshot.googleplex.com/8SVtzpokbvmAzpv
https://screenshot.googleplex.com/87uRqmEAasBMQz2

Fix: 319577620
Flag: NA
Test: Manual (animation), analyse setPlayFraction log - see screenshots
Change-Id: Ib1f24182b8fc0f6ea1ff07125f25dbfc206ae5c2
2024-02-27 14:15:48 +00:00
Luca Zuccarini
0547036143 Merge "Move remote animation utils to the Animation lib." into main 2024-02-27 13:53:59 +00:00
samcackett
6c93e88faf Set max height on TaskMenuView and scroll if too many elements
Video of functionality: http://shortn/_pz6qhz5yxM

Fixes: 210466650
Test: Manual
Flag: NONE
Change-Id: I8b7873cf03857ee3be047ab30388e679f7a95bfd
2024-02-27 12:45:53 +00:00
Helen Cheuk
96fd73ed84 Merge "Stash taskbar when software keyboard is docked" into main 2024-02-27 10:40:07 +00:00
Jeremy Sim
70b3131393 Merge "Improve app pairs disabled state" into main 2024-02-27 06:49:52 +00:00
Jeremy Sim
3c1ee0dad4 Improve app pairs disabled state
This CL fixes 2 issues with app pairs:
- When an app pair is incompatible with the screen size due to a non-resizeable app (e.g. Camera), the app pair will now be properly disabled and display an error message. If the user is on a foldable, it will prompt the user to unfold their phone.
- The app pair icon will now properly redraw with lower opacity when it is disabled.

Fixes: 323088270
Test: Manually paused and unpaused apps, created Camera app pairs and tested with foldable
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I66514c96bc19f480c9788661e4dffaa5b1cdc2ca
2024-02-26 14:29:57 -08:00
Jeremy Sim
dab12bc67c Fix embarrassing typo with saving app pairs
When saving app pairs, we should grab attributes[0] and attributes[1] instead of attributes[0] and attributes[0].

Fixes: 326854996
Test: App pairs saves the correct two apps
Flag: ACONFIG com.android.wm.shell.enable_app_pairs TEAMFOOD
Change-Id: I8d2fc4597cf1f1bd36bc0b910cc022c79a48f067
2024-02-26 09:03:52 -08:00
Schneider Victor-tulias
5040a837d0 Fix blocked gesture handling on failed startRecentsActivity calls
Flag: N/A
Fixes: 324228222
Test: forcicly set SystemUiProxy.mRecentTasks to null. multiple startRecentsActivity call attempts were made rather than just one
Change-Id: I2e5f8cc0cf47a143dcd7985b31292bb4d8cbbcad
2024-02-26 11:12:34 -05:00
Orhan Uysal
410b2d7497 Merge "Make taskbar visibilty change only in desktop." into main 2024-02-26 10:47:00 +00:00
Fengjiang Li
e98d88ef2f Merge "Opt-in predicitive back before register the back button" into main 2024-02-24 04:40:57 +00:00
Saumya Prakash
4314d726c0 Merge "Fix jump in app launch when quick switching from Home" into main 2024-02-24 00:06:43 +00:00
William Leshner
0c2b98e876 Merge "Tweak WidgetPickerActivity size filtering." into main 2024-02-23 23:22:16 +00:00
Saumya Prakash
b3b4cc6edb Merge "Ensure taskbar insets for camera cutout only apply on the needed sides" into main 2024-02-23 22:59:57 +00:00
Fengjiang Li
e52fee8b8f Opt-in predicitive back before register the back button
The predictive back infra checks the opt-in status when a callback is registered, and drops the registration if the Application / Activity is not opted-in

Fix: 326627953
Test: manual
Flag: ACONFIG launcher.enable_predictive_back_gesture DISABLED
Change-Id: I8f2e2378d0bf966b3784cf08c12045509b6d5682
2024-02-23 14:58:55 -08:00
Jeremy Sim
4e22c4463d Merge "Fix app pair launches with certain apps" into main 2024-02-23 21:56:05 +00:00
Johannes Gallmann
7f1df14cf3 Merge "Use STANDARD_DECELERATE interpolator for predictive back to home" into main 2024-02-23 21:41:54 +00:00
Johannes Gallmann
1a9cff800f Merge "Transfer coordinate into new Rect instead of in-place" into main 2024-02-23 21:20:24 +00:00
Saumya Prakash
5983ac77d8 Fix jump in app launch when quick switching from Home
This change addresses a recent regression that caused quick switch to not scale up to full screen during the launch animation.

Fix: 326625526
Test: Launch quick switch from home and ensure it is a smooth transition
Flag: N/A
Change-Id: Id94d5d3eae0625225f880897e1e5f3cf9e4fea6c
2024-02-23 20:13:18 +00:00
Schneider Victor-tulias
bdc846448c Merge "Update KQS launch task callbacks" into main 2024-02-23 19:54:44 +00:00
Saumya Prakash
40fc6eb323 Ensure taskbar insets for camera cutout only apply on the needed sides
For devices with a camera cutout, we only need the increased inset to
accomodate a camera cutout on the sides/orientations where the cutout
interrupts the taskbar. This change ensures that the insets are only
added when necessary.

Fix: 325508089
Test: Open an app and ensure the insets remain unchanged for 0 and 90
degree rotations. Ensure the insets for 180 and 270 degrees are still
covering the camera cutout.
Flag: N/A

Change-Id: I3ee14ffc84d72512acdb750d0f614acacefc7639
2024-02-23 19:15:44 +00:00
Treehugger Robot
45181a668b Merge "Focus a task by default when using keyboard to go to overview." into main 2024-02-23 19:08:01 +00:00
Priyanka Advani
d0a1c2c023 Merge "Revert "Remove Unused parts of LauncherPrefs causing cyclical dependency."" into main 2024-02-23 18:11:50 +00:00
Priyanka Advani
a80997d9eb Revert "Remove Unused parts of LauncherPrefs causing cyclical dependency."
This reverts commit 21ab3b979b.

Reason for revert: Culprit for b/326611479. Will be verifying through ABTD for confirmation and before submitting the revert.

Change-Id: Ib71791d159b3ac65ca332f58500341a1a0fe36e1
2024-02-23 18:05:39 +00:00
Eghosa Ewansiha-Vlachavas
957bbcd97f [2/n] Remove use of persist.wm.debug.desktop_mode_2
`persist.wm.debug.desktop_mode_2` is no longer needed as desktop
windowing now uses a runtime flag which can be modified using the command: `adb shell device_config put lse_desktop_experience
com.android.window.flags.enable_desktop_windowing_mode (true/false)`.

Flag: NONE
Fixes: 326060855
Bug: 304778354
Test: build & `adb shell device_config put lse_desktop_experience
com.android.window.flags.enable_desktop_windowing_mode true && adb
reboot` desktop windowing mode should be enabled.

Change-Id: I25d509c0912ab3266a32ad992333460332b8b0a2
2024-02-23 17:42:04 +00:00
Johannes Gallmann
f3fe3b47a4 Merge "Fix flickers when invoking overview transition during predictive back-to-home" into main 2024-02-23 17:15:46 +00:00