Merge "Fix HOME/RECENTS/BACK duplicated, missing logging" into ub-launcher3-qt-dev

This commit is contained in:
Hyunyoung Song
2019-06-14 22:08:48 +00:00
committed by Android (Google) Code Review
2 changed files with 7 additions and 15 deletions

View File

@@ -1353,19 +1353,6 @@ public class Launcher extends BaseDraggingActivity implements LauncherExterns,
if (isActionMain) {
if (!internalStateHandled) {
// Note: There should be at most one log per method call. This is enforced
// implicitly by using if-else statements.
UserEventDispatcher ued = getUserEventDispatcher();
AbstractFloatingView topOpenView = AbstractFloatingView.getTopOpenView(this);
if (topOpenView != null) {
topOpenView.logActionCommand(Action.Command.HOME_INTENT);
} else if (alreadyOnHome) {
Target target = newContainerTarget(mStateManager.getState().containerType);
target.pageIndex = mWorkspace.getCurrentPage();
ued.logActionCommand(Action.Command.HOME_INTENT, target,
newContainerTarget(ContainerType.WORKSPACE));
}
// In all these cases, only animate if we're already on home
AbstractFloatingView.closeAllOpenViews(this, isStarted());
@@ -1385,6 +1372,13 @@ public class Launcher extends BaseDraggingActivity implements LauncherExterns,
}
}
// Handle HOME_INTENT
UserEventDispatcher ued = getUserEventDispatcher();
Target target = newContainerTarget(mStateManager.getState().containerType);
target.pageIndex = mWorkspace.getCurrentPage();
ued.logActionCommand(Action.Command.HOME_INTENT, target,
newContainerTarget(ContainerType.WORKSPACE));
final View v = getWindow().peekDecorView();
if (v != null && v.getWindowToken() != null) {
UiThreadHelper.hideKeyboardAsync(this, v.getWindowToken());

View File

@@ -268,8 +268,6 @@ public class LauncherState {
if (this != NORMAL) {
LauncherStateManager lsm = launcher.getStateManager();
LauncherState lastState = lsm.getLastState();
launcher.getUserEventDispatcher().logActionCommand(Action.Command.BACK,
containerType, lastState.containerType);
lsm.goToState(lastState);
}
}