From 1e8961c3f8edcc04d014962ed61e9c82afc8e6ec Mon Sep 17 00:00:00 2001 From: Saumya Prakash Date: Mon, 4 Mar 2024 23:38:17 +0000 Subject: [PATCH] Increase the delay in between gesture tutorials The time in between each gesture's finish page and the start of the next gesture tutorial was too short. We increased the time we spend on the finish page by 1000 ms based on this feedback. Fix: 293967263 Test: Run through the gesture tutorial and note the longer pause in between each gesture Flag: LEGACY ENABLE_NEW_GESTURE_NAV_TUTORIAL ENABLED (cherry picked from https://googleplex-android-review.googlesource.com/q/commit:959dff122049349e25cfec82e78c6ae6db9fa7d6) Merged-In: I2c22e19dff91ac720877e596df90efe7f3cfcd80 Change-Id: I2c22e19dff91ac720877e596df90efe7f3cfcd80 --- .../quickstep/interaction/TutorialController.java | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/quickstep/src/com/android/quickstep/interaction/TutorialController.java b/quickstep/src/com/android/quickstep/interaction/TutorialController.java index 545a94d641..f89888a113 100644 --- a/quickstep/src/com/android/quickstep/interaction/TutorialController.java +++ b/quickstep/src/com/android/quickstep/interaction/TutorialController.java @@ -41,6 +41,7 @@ import android.view.View; import android.view.ViewGroup; import android.view.ViewOutlineProvider; import android.view.accessibility.AccessibilityEvent; +import android.view.accessibility.AccessibilityManager; import android.widget.Button; import android.widget.FrameLayout; import android.widget.ImageView; @@ -87,7 +88,7 @@ abstract class TutorialController implements BackGestureAttemptCallback, private static final int FEEDBACK_ANIMATION_MS = 133; private static final int RIPPLE_VISIBLE_MS = 300; private static final int GESTURE_ANIMATION_DELAY_MS = 1500; - private static final int ADVANCE_TUTORIAL_TIMEOUT_MS = 2000; + private static final int ADVANCE_TUTORIAL_TIMEOUT_MS = 3000; private static final long GESTURE_ANIMATION_PAUSE_DURATION_MILLIS = 1000; protected float mExitingAppEndingCornerRadius; protected float mExitingAppStartingCornerRadius; @@ -209,8 +210,12 @@ abstract class TutorialController implements BackGestureAttemptCallback, mFeedbackView.removeCallbacks(mFeedbackViewCallback); } mFeedbackViewCallback = mTutorialFragment::continueTutorial; - mFeedbackView.postDelayed(mFeedbackViewCallback, - ADVANCE_TUTORIAL_TIMEOUT_MS); + mFeedbackView.postDelayed( + mFeedbackViewCallback, + AccessibilityManager.getInstance(mContext) + .getRecommendedTimeoutMillis( + ADVANCE_TUTORIAL_TIMEOUT_MS, + AccessibilityManager.FLAG_CONTENT_TEXT)); } }) .start();