From 4df46b1da21ffa548dc6c11604e39ba54293626c Mon Sep 17 00:00:00 2001 From: Thiru Ramasamy Date: Tue, 24 Aug 2021 13:21:47 -0700 Subject: [PATCH] Add RESERVE_NEW_UI_EVENT_ID field to EventEnum interface. Bug: 193797130 Test: NA Change-Id: I786ff0222f2fd4c5cbc2598fe4b3e22733233f8b --- .../launcher3/logging/StatsLogManager.java | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/src/com/android/launcher3/logging/StatsLogManager.java b/src/com/android/launcher3/logging/StatsLogManager.java index d959ee288b..5ed651f5a9 100644 --- a/src/com/android/launcher3/logging/StatsLogManager.java +++ b/src/com/android/launcher3/logging/StatsLogManager.java @@ -76,6 +76,22 @@ public class StatsLogManager implements ResourceBasedOverride { } public interface EventEnum { + + /** + * Tag used to request new UI Event IDs via presubmit analysis. + * + *

Use RESERVE_NEW_UI_EVENT_ID as the constructor parameter for a new {@link EventEnum} + * to signal the presubmit analyzer to reserve a new ID for the event. The new ID will be + * returned as a Gerrit presubmit finding. Do not submit {@code RESERVE_NEW_UI_EVENT_ID} as + * the constructor parameter for any event. + * + * 

+         * @UiEvent(doc = "Briefly describe the interaction when this event will be logged")
+         * UNIQUE_EVENT_NAME(RESERVE_NEW_UI_EVENT_ID);
+         *
+ */ + int RESERVE_NEW_UI_EVENT_ID = Integer.MIN_VALUE; // Negative IDs are ignored by the logger. + int getId(); } @@ -489,8 +505,7 @@ public class StatsLogManager implements ResourceBasedOverride { LAUNCHER_TURN_OFF_WORK_APPS_TAP(839), @UiEvent(doc = "Launcher item drop failed since there was not enough room on the screen.") - LAUNCHER_ITEM_DROP_FAILED_INSUFFICIENT_SPACE(872) - ; + LAUNCHER_ITEM_DROP_FAILED_INSUFFICIENT_SPACE(872); // ADD MORE