From ff3721fe963af8ebc01bfe92e2c1c768f608ad31 Mon Sep 17 00:00:00 2001 From: Andy Wickham Date: Wed, 25 May 2022 14:55:39 -0700 Subject: [PATCH] Allows work apps to be dragged down while work edu is showing. Also fixes jumpiness of the personal/work tabs while scrolling with this card showing. Cause: AllAppsRecyclerView#getCurrentScrollY() calculates the current scroll based on the top of the first item in the view. This is used to determine if pulling down should move the container (if you are scrolled to the top), and it is also used to align the personal/work tabs as you scroll down (they stop moving when the top item reaches their bottom). Fix: The top of the Work Edu card was lower than the top of the recycler view because it was offset by a top margin. Switching this to padding in the card's container fixes the associated calculations while keeping the visual positioning from before. Fix: 233836148 Test: Manually tried dragging down and scrolling. Tried it with and without my refactor. Change-Id: Idaf4b3801174c1dfeceda5c0f112e405908e856d --- res/layout/work_apps_edu.xml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/res/layout/work_apps_edu.xml b/res/layout/work_apps_edu.xml index f3b3053e13..c8e3f81b59 100644 --- a/res/layout/work_apps_edu.xml +++ b/res/layout/work_apps_edu.xml @@ -16,8 +16,8 @@