diff --git a/quickstep/res/values-sw720dp/dimens.xml b/quickstep/res/values-sw720dp/dimens.xml index 585f01e46a..28f7c5d0de 100644 --- a/quickstep/res/values-sw720dp/dimens.xml +++ b/quickstep/res/values-sw720dp/dimens.xml @@ -37,4 +37,7 @@ 42sp 16sp + + + 76dp diff --git a/quickstep/res/values/dimens.xml b/quickstep/res/values/dimens.xml index 7a3c35f439..ad77768263 100644 --- a/quickstep/res/values/dimens.xml +++ b/quickstep/res/values/dimens.xml @@ -281,8 +281,7 @@ 32dp - 76dp - 72dp + 72dp 24dp 40dp 10dp diff --git a/quickstep/src/com/android/launcher3/taskbar/TaskbarActivityContext.java b/quickstep/src/com/android/launcher3/taskbar/TaskbarActivityContext.java index 6d745268cc..731eea78e9 100644 --- a/quickstep/src/com/android/launcher3/taskbar/TaskbarActivityContext.java +++ b/quickstep/src/com/android/launcher3/taskbar/TaskbarActivityContext.java @@ -284,9 +284,7 @@ public class TaskbarActivityContext extends BaseTaskbarContext { private void updateIconSize(Resources resources) { mDeviceProfile.iconSizePx = resources.getDimensionPixelSize( DisplayController.isTransientTaskbar(this) - ? mDeviceProfile.isTwoPanels - ? R.dimen.transient_taskbar_two_panels_icon_size - : R.dimen.transient_taskbar_icon_size + ? R.dimen.transient_taskbar_icon_size : R.dimen.taskbar_icon_size); mDeviceProfile.updateIconSize(1f, resources); } @@ -694,9 +692,7 @@ public class TaskbarActivityContext extends BaseTaskbarContext { } if (DisplayController.isTransientTaskbar(this)) { - int taskbarSize = resources.getDimensionPixelSize(mDeviceProfile.isTwoPanels - ? R.dimen.transient_taskbar_two_panels_size - : R.dimen.transient_taskbar_size); + int taskbarSize = resources.getDimensionPixelSize(R.dimen.transient_taskbar_size); return taskbarSize + (2 * resources.getDimensionPixelSize(R.dimen.transient_taskbar_margin)) + resources.getDimensionPixelSize(R.dimen.transient_taskbar_shadow_blur); diff --git a/quickstep/src/com/android/launcher3/taskbar/TaskbarStashController.java b/quickstep/src/com/android/launcher3/taskbar/TaskbarStashController.java index 29b8ee3b5d..c269648f7d 100644 --- a/quickstep/src/com/android/launcher3/taskbar/TaskbarStashController.java +++ b/quickstep/src/com/android/launcher3/taskbar/TaskbarStashController.java @@ -202,9 +202,7 @@ public class TaskbarStashController implements TaskbarControllers.LoggableTaskba Resources resources = mActivity.getResources(); boolean isTransientTaskbar = DisplayController.isTransientTaskbar(mActivity); mUnstashedHeight = resources.getDimensionPixelSize(isTransientTaskbar - ? (mActivity.getDeviceProfile().isTwoPanels - ? R.dimen.transient_taskbar_two_panels_size - : R.dimen.transient_taskbar_size) + ? R.dimen.transient_taskbar_size : R.dimen.taskbar_size); mStashedHeight = resources.getDimensionPixelSize(isTransientTaskbar ? R.dimen.transient_taskbar_stashed_size diff --git a/res/values-sw720dp/dimens.xml b/res/values-sw720dp/dimens.xml index 09b2d6f83f..40e49f1545 100644 --- a/res/values-sw720dp/dimens.xml +++ b/res/values-sw720dp/dimens.xml @@ -46,4 +46,7 @@ 24dp + + + 57dp diff --git a/res/values/dimens.xml b/res/values/dimens.xml index 664c2f3d5f..d66c82496e 100644 --- a/res/values/dimens.xml +++ b/res/values/dimens.xml @@ -364,11 +364,9 @@ 50dp 0dp 44dp - 57dp - 50dp + 50dp 0dp - 0dp 0dp 0dp 0dp diff --git a/src/com/android/launcher3/DeviceProfile.java b/src/com/android/launcher3/DeviceProfile.java index b95b0af5b0..4a22f73bfe 100644 --- a/src/com/android/launcher3/DeviceProfile.java +++ b/src/com/android/launcher3/DeviceProfile.java @@ -325,9 +325,7 @@ public class DeviceProfile { if (isTaskbarPresent) { if (DisplayController.isTransientTaskbar(context)) { - taskbarSize = res.getDimensionPixelSize(isTwoPanels - ? R.dimen.transient_taskbar_two_panels_size - : R.dimen.transient_taskbar_size); + taskbarSize = res.getDimensionPixelSize(R.dimen.transient_taskbar_size); stashedTaskbarSize = res.getDimensionPixelSize(R.dimen.transient_taskbar_stashed_size); transientTaskbarMargin = @@ -1376,7 +1374,7 @@ public class DeviceProfile { public int getOverviewActionsClaimedSpaceBelow() { if (isTaskbarPresent) { if (FeatureFlags.ENABLE_TASKBAR_IN_OVERVIEW.get()) { - return taskbarSize + transientTaskbarMargin; + return taskbarSize + transientTaskbarMargin * 2; } return isGestureMode @@ -1647,6 +1645,8 @@ public class DeviceProfile { overviewActionsTopMarginPx)); writer.println(prefix + pxToDpStr("overviewActionsHeight", overviewActionsHeight)); + writer.println(prefix + pxToDpStr("overviewActionsClaimedSpaceBelow", + getOverviewActionsClaimedSpaceBelow())); writer.println(prefix + pxToDpStr("overviewActionsButtonSpacing", overviewActionsButtonSpacing)); writer.println(prefix + pxToDpStr("overviewPageSpacing", overviewPageSpacing)); diff --git a/src/com/android/launcher3/util/DisplayController.java b/src/com/android/launcher3/util/DisplayController.java index 8e3daf33a4..c52890fd18 100644 --- a/src/com/android/launcher3/util/DisplayController.java +++ b/src/com/android/launcher3/util/DisplayController.java @@ -131,13 +131,20 @@ public class DisplayController implements ComponentCallbacks, SafeCloseable { * Returns whether taskbar is transient. */ public static boolean isTransientTaskbar(Context context) { + return INSTANCE.get(context).isTransientTaskbar(); + } + + /** + * Returns whether taskbar is transient. + */ + public boolean isTransientTaskbar() { // TODO(b/258604917): When running in test harness, use !sTransientTaskbarStatusForTests // once tests are updated to expect new persistent behavior such as not allowing long press // to stash. if (!Utilities.IS_RUNNING_IN_TEST_HARNESS && FORCE_PERSISTENT_TASKBAR.get()) { return false; } - return getNavigationMode(context) == NavigationMode.NO_BUTTON + return getInfo().navigationMode == NavigationMode.NO_BUTTON && (Utilities.IS_RUNNING_IN_TEST_HARNESS ? sTransientTaskbarStatusForTests : ENABLE_TRANSIENT_TASKBAR.get());