From bfc74bdb024ff339483c56df13b540c6ccf506ac Mon Sep 17 00:00:00 2001 From: Sebastian Franco Date: Wed, 6 Sep 2023 16:19:32 -0700 Subject: [PATCH] Adding logs to test uninstallWorkspaceIcon to find flake reason Also, removing old logs. Bug: 288944469 Test: atest uninstallWorkspaceIcon Change-Id: Ifad3c5e6486346a363dba98180839f4e08ed2078 --- tests/src/com/android/launcher3/ui/TaplTestsLauncher3.java | 4 ---- tests/tapl/com/android/launcher3/tapl/Workspace.java | 5 +++++ 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/src/com/android/launcher3/ui/TaplTestsLauncher3.java b/tests/src/com/android/launcher3/ui/TaplTestsLauncher3.java index c462f59180..07d298a63f 100644 --- a/tests/src/com/android/launcher3/ui/TaplTestsLauncher3.java +++ b/tests/src/com/android/launcher3/ui/TaplTestsLauncher3.java @@ -645,10 +645,6 @@ public class TaplTestsLauncher3 extends AbstractLauncherUiTest { mLauncher.getWorkspace().verifyWorkspaceAppIconIsGone( DUMMY_APP_NAME + " was expected to disappear after uninstall.", DUMMY_APP_NAME); - // Debug for b/288944469 I want to test if we are not waiting enough after removing - // the icon to request the list of icons again, since the items are not removed - // immediately. This should reduce the flake rate - SystemClock.sleep(500); Map finalPositions = mLauncher.getWorkspace().getWorkspaceIconsPositions(); assertThat(finalPositions).doesNotContainKey(DUMMY_APP_NAME); diff --git a/tests/tapl/com/android/launcher3/tapl/Workspace.java b/tests/tapl/com/android/launcher3/tapl/Workspace.java index 860498817a..a5e706bab3 100644 --- a/tests/tapl/com/android/launcher3/tapl/Workspace.java +++ b/tests/tapl/com/android/launcher3/tapl/Workspace.java @@ -27,6 +27,7 @@ import static junit.framework.TestCase.assertTrue; import android.graphics.Point; import android.graphics.Rect; import android.os.SystemClock; +import android.util.Log; import android.view.KeyEvent; import android.view.MotionEvent; @@ -285,6 +286,10 @@ public final class Workspace extends Home { final UiObject2 workspace = verifyActiveContainer(); List workspaceIcons = mLauncher.waitForObjectsInContainer(workspace, AppIcon.getAnyAppIconSelector()); + Log.d("b/288944469", "List size = " + workspaceIcons.size()); + for (int i = 0; i < workspaceIcons.size(); i++) { + Log.d("b/288944469", "index = " + i + " tesxt = " + workspaceIcons.get(i).getText()); + } return workspaceIcons.stream() .collect( Collectors.toMap(