From c65f37e7c6b7cb7df8911f6c97dcd68cef98513e Mon Sep 17 00:00:00 2001 From: Saumya Prakash Date: Wed, 8 Feb 2023 00:18:13 +0000 Subject: [PATCH] Migrate from using CardViews to Views in gesture nav tutorial layouts. Use Views in layouts for the gesture navigation tutorial instead of CardViews. We only migrate the classes that will end up being used in the redesigned gesture tutorial. Fix: 268259319 Test: Manual Change-Id: I510c8b3f840d0267dd6dfca573cc69c4996d525c --- quickstep/res/drawable/hotseat_icon.xml | 21 +++++++++ quickstep/res/drawable/hotseat_icon_home.xml | 21 +++++++++ quickstep/res/drawable/hotseat_search_bar.xml | 21 +++++++++ quickstep/res/drawable/top_task_view.xml | 21 +++++++++ .../gesture_tutorial_mock_hotseat.xml | 28 ++++++------ .../gesture_tutorial_tablet_mock_hotseat.xml | 43 ++++++++----------- .../res/layout/gesture_tutorial_fragment.xml | 23 +++++----- .../layout/gesture_tutorial_mock_hotseat.xml | 35 +++++++-------- .../gesture_tutorial_tablet_mock_hotseat.xml | 42 ++++++++---------- .../redesigned_gesture_tutorial_fragment.xml | 26 +++++------ ...designed_gesture_tutorial_mock_hotseat.xml | 38 +++++++--------- .../interaction/AnimatedTaskView.java | 7 +-- .../HomeGestureTutorialController.java | 8 ++-- .../interaction/TutorialController.java | 1 - 14 files changed, 194 insertions(+), 141 deletions(-) create mode 100644 quickstep/res/drawable/hotseat_icon.xml create mode 100644 quickstep/res/drawable/hotseat_icon_home.xml create mode 100644 quickstep/res/drawable/hotseat_search_bar.xml create mode 100644 quickstep/res/drawable/top_task_view.xml diff --git a/quickstep/res/drawable/hotseat_icon.xml b/quickstep/res/drawable/hotseat_icon.xml new file mode 100644 index 0000000000..b849fe90ce --- /dev/null +++ b/quickstep/res/drawable/hotseat_icon.xml @@ -0,0 +1,21 @@ + + + + + + \ No newline at end of file diff --git a/quickstep/res/drawable/hotseat_icon_home.xml b/quickstep/res/drawable/hotseat_icon_home.xml new file mode 100644 index 0000000000..d59dd4a88e --- /dev/null +++ b/quickstep/res/drawable/hotseat_icon_home.xml @@ -0,0 +1,21 @@ + + + + + + \ No newline at end of file diff --git a/quickstep/res/drawable/hotseat_search_bar.xml b/quickstep/res/drawable/hotseat_search_bar.xml new file mode 100644 index 0000000000..ea332e9462 --- /dev/null +++ b/quickstep/res/drawable/hotseat_search_bar.xml @@ -0,0 +1,21 @@ + + + + + + \ No newline at end of file diff --git a/quickstep/res/drawable/top_task_view.xml b/quickstep/res/drawable/top_task_view.xml new file mode 100644 index 0000000000..d2176c3cb4 --- /dev/null +++ b/quickstep/res/drawable/top_task_view.xml @@ -0,0 +1,21 @@ + + + + + + \ No newline at end of file diff --git a/quickstep/res/layout-land/gesture_tutorial_mock_hotseat.xml b/quickstep/res/layout-land/gesture_tutorial_mock_hotseat.xml index 1e2e014111..c7e176ac2e 100644 --- a/quickstep/res/layout-land/gesture_tutorial_mock_hotseat.xml +++ b/quickstep/res/layout-land/gesture_tutorial_mock_hotseat.xml @@ -24,54 +24,50 @@ android:paddingStart="56dp" android:paddingEnd="56dp"> - - - - - - - - - - - + app:layout_constraintTop_toTopOf="@id/full_task_view" /> - + app:layout_constraintTop_toBottomOf="@id/top_task_view" /> diff --git a/quickstep/res/layout/gesture_tutorial_mock_hotseat.xml b/quickstep/res/layout/gesture_tutorial_mock_hotseat.xml index 8513dcf3d7..8ee0339e9c 100644 --- a/quickstep/res/layout/gesture_tutorial_mock_hotseat.xml +++ b/quickstep/res/layout/gesture_tutorial_mock_hotseat.xml @@ -8,67 +8,62 @@ android:paddingStart="26dp" android:paddingEnd="26dp"> - - - - - diff --git a/quickstep/res/layout/gesture_tutorial_tablet_mock_hotseat.xml b/quickstep/res/layout/gesture_tutorial_tablet_mock_hotseat.xml index 363f14e481..63c51e8040 100644 --- a/quickstep/res/layout/gesture_tutorial_tablet_mock_hotseat.xml +++ b/quickstep/res/layout/gesture_tutorial_tablet_mock_hotseat.xml @@ -22,84 +22,78 @@ android:paddingStart="@dimen/gesture_tutorial_hotseat_padding_start_end" android:paddingEnd="@dimen/gesture_tutorial_hotseat_padding_start_end"> - - - - - - - + app:layout_constraintTop_toTopOf="@id/full_task_view" /> - + android:layout_centerHorizontal="true" + android:layout_marginBottom="@dimen/gesture_tutorial_taskbar_margin_bottom" /> + android:paddingEnd="26dp"> - - - - - diff --git a/quickstep/src/com/android/quickstep/interaction/AnimatedTaskView.java b/quickstep/src/com/android/quickstep/interaction/AnimatedTaskView.java index 53ad138b6a..3ccd683eba 100644 --- a/quickstep/src/com/android/quickstep/interaction/AnimatedTaskView.java +++ b/quickstep/src/com/android/quickstep/interaction/AnimatedTaskView.java @@ -30,7 +30,6 @@ import android.view.ViewOutlineProvider; import androidx.annotation.NonNull; import androidx.annotation.Nullable; -import androidx.cardview.widget.CardView; import androidx.constraintlayout.widget.ConstraintLayout; import com.android.launcher3.R; @@ -46,8 +45,8 @@ import java.util.ArrayList; public class AnimatedTaskView extends ConstraintLayout { private View mFullTaskView; - private CardView mTopTaskView; - private CardView mBottomTaskView; + private View mTopTaskView; + private View mBottomTaskView; private ViewOutlineProvider mTaskViewOutlineProvider = null; private final Rect mTaskViewAnimatedRect = new Rect(); @@ -185,8 +184,6 @@ public class AnimatedTaskView extends ConstraintLayout { void setFakeTaskViewFillColor(@ColorInt int colorResId) { mFullTaskView.setBackgroundColor(colorResId); - mTopTaskView.setCardBackgroundColor(colorResId); - mBottomTaskView.setCardBackgroundColor(colorResId); } @Override diff --git a/quickstep/src/com/android/quickstep/interaction/HomeGestureTutorialController.java b/quickstep/src/com/android/quickstep/interaction/HomeGestureTutorialController.java index c89d4b61a8..bce639b200 100644 --- a/quickstep/src/com/android/quickstep/interaction/HomeGestureTutorialController.java +++ b/quickstep/src/com/android/quickstep/interaction/HomeGestureTutorialController.java @@ -61,10 +61,10 @@ final class HomeGestureTutorialController extends SwipeUpGestureTutorialControll @Override protected int getMockAppTaskLayoutResId() { - return mTutorialFragment.isLargeScreen() - ? R.layout.gesture_tutorial_tablet_mock_webpage - : ENABLE_NEW_GESTURE_NAV_TUTORIAL.get() - ? R.layout.swipe_up_gesture_tutorial_shape + return ENABLE_NEW_GESTURE_NAV_TUTORIAL.get() + ? R.layout.swipe_up_gesture_tutorial_shape + : mTutorialFragment.isLargeScreen() + ? R.layout.gesture_tutorial_tablet_mock_webpage : R.layout.gesture_tutorial_mock_webpage; } diff --git a/quickstep/src/com/android/quickstep/interaction/TutorialController.java b/quickstep/src/com/android/quickstep/interaction/TutorialController.java index ccdb2660bd..6fcb840349 100644 --- a/quickstep/src/com/android/quickstep/interaction/TutorialController.java +++ b/quickstep/src/com/android/quickstep/interaction/TutorialController.java @@ -154,7 +154,6 @@ abstract class TutorialController implements BackGestureAttemptCallback, mFeedbackTitleView.setText(getIntroductionTitle()); mFeedbackSubtitleView.setText(getIntroductionSubtitle()); - mSkipButton.setVisibility(GONE); } mTitleViewCallback = () -> mFeedbackTitleView.sendAccessibilityEvent(