From af95ddbadc2e4eae5438ea76de78a1175f6256c0 Mon Sep 17 00:00:00 2001 From: Sunny Goyal Date: Wed, 27 Jul 2022 16:38:27 -0700 Subject: [PATCH] Fixing search behavior in Launcher3 > Showing no-result found only when there are no results > Removing unnecessary view inflation in RecyclerViewPool for various search vide types > Removing unused market-search link and no-empty-result illustration Bug: 240343082 Bug: 207573083 Test: Verified Launcher3 Change-Id: Ia44799cd2385ea5dc837ef25732ca237975abde7 --- res/drawable/ic_all_apps_bg_hand.xml | 100 --------- res/drawable/ic_all_apps_bg_icon_1.xml | 31 --- res/drawable/ic_all_apps_bg_icon_2.xml | 33 --- res/drawable/ic_all_apps_bg_icon_3.xml | 36 --- res/drawable/ic_all_apps_bg_icon_4.xml | 34 --- res/layout/all_apps_search_market.xml | 30 --- res/values/dimens.xml | 3 - res/values/strings.xml | 2 - res/values/styles.xml | 11 - .../allapps/ActivityAllAppsContainerView.java | 9 - .../allapps/AllAppsBackgroundDrawable.java | 206 ------------------ .../allapps/AllAppsRecyclerView.java | 62 ------ .../allapps/AlphabeticalAppsList.java | 21 -- .../launcher3/allapps/BaseAllAppsAdapter.java | 57 ++--- .../search/AppsSearchContainerLayout.java | 2 +- .../search/DefaultAppSearchAlgorithm.java | 19 ++ 16 files changed, 33 insertions(+), 623 deletions(-) delete mode 100644 res/drawable/ic_all_apps_bg_hand.xml delete mode 100644 res/drawable/ic_all_apps_bg_icon_1.xml delete mode 100644 res/drawable/ic_all_apps_bg_icon_2.xml delete mode 100644 res/drawable/ic_all_apps_bg_icon_3.xml delete mode 100644 res/drawable/ic_all_apps_bg_icon_4.xml delete mode 100644 res/layout/all_apps_search_market.xml delete mode 100644 src/com/android/launcher3/allapps/AllAppsBackgroundDrawable.java diff --git a/res/drawable/ic_all_apps_bg_hand.xml b/res/drawable/ic_all_apps_bg_hand.xml deleted file mode 100644 index 7f3fe14fb1..0000000000 --- a/res/drawable/ic_all_apps_bg_hand.xml +++ /dev/null @@ -1,100 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - \ No newline at end of file diff --git a/res/drawable/ic_all_apps_bg_icon_1.xml b/res/drawable/ic_all_apps_bg_icon_1.xml deleted file mode 100644 index d226ac6000..0000000000 --- a/res/drawable/ic_all_apps_bg_icon_1.xml +++ /dev/null @@ -1,31 +0,0 @@ - - - - - - - - \ No newline at end of file diff --git a/res/drawable/ic_all_apps_bg_icon_2.xml b/res/drawable/ic_all_apps_bg_icon_2.xml deleted file mode 100644 index 5966d9969f..0000000000 --- a/res/drawable/ic_all_apps_bg_icon_2.xml +++ /dev/null @@ -1,33 +0,0 @@ - - - - - - - - \ No newline at end of file diff --git a/res/drawable/ic_all_apps_bg_icon_3.xml b/res/drawable/ic_all_apps_bg_icon_3.xml deleted file mode 100644 index b18f8bc473..0000000000 --- a/res/drawable/ic_all_apps_bg_icon_3.xml +++ /dev/null @@ -1,36 +0,0 @@ - - - - - - - - - diff --git a/res/drawable/ic_all_apps_bg_icon_4.xml b/res/drawable/ic_all_apps_bg_icon_4.xml deleted file mode 100644 index 8eb4d90126..0000000000 --- a/res/drawable/ic_all_apps_bg_icon_4.xml +++ /dev/null @@ -1,34 +0,0 @@ - - - - - - - - - \ No newline at end of file diff --git a/res/layout/all_apps_search_market.xml b/res/layout/all_apps_search_market.xml deleted file mode 100644 index 6f2dd3d21e..0000000000 --- a/res/layout/all_apps_search_market.xml +++ /dev/null @@ -1,30 +0,0 @@ - - - diff --git a/res/values/dimens.xml b/res/values/dimens.xml index b19e73920b..5bb753e694 100644 --- a/res/values/dimens.xml +++ b/res/values/dimens.xml @@ -108,9 +108,6 @@ 24dp 30dp 40dp - 144dp - 700dp - 475dp 48dp 12dp 48dp diff --git a/res/values/strings.xml b/res/values/strings.xml index 2addf5034e..3eb08bada1 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -128,8 +128,6 @@ Loading apps… No apps found matching \"%1$s\" - - Search for more apps App diff --git a/res/values/styles.xml b/res/values/styles.xml index a8cbf08ca1..90553a160e 100644 --- a/res/values/styles.xml +++ b/res/values/styles.xml @@ -292,17 +292,6 @@ - -